[GitHub] [hudi] yihua commented on a diff in pull request #8557: [HUDI-5895] Remove bootstrap key generator configs

2023-05-06 Thread via GitHub
yihua commented on code in PR #8557: URL: https://github.com/apache/hudi/pull/8557#discussion_r1186784885 ## hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/DataSourceOptions.scala: ## @@ -411,6 +411,11 @@ object DataSourceWriteOptions { .markAdvanced

[GitHub] [hudi] yihua commented on a diff in pull request #8557: [HUDI-5895] Remove bootstrap key generator configs

2023-05-06 Thread via GitHub
yihua commented on code in PR #8557: URL: https://github.com/apache/hudi/pull/8557#discussion_r1186771703 ## hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/DataSourceOptions.scala: ## @@ -411,6 +411,11 @@ object DataSourceWriteOptions { .markAdvanced

[GitHub] [hudi] yihua commented on a diff in pull request #8557: [HUDI-5895] Remove bootstrap key generator configs

2023-05-06 Thread via GitHub
yihua commented on code in PR #8557: URL: https://github.com/apache/hudi/pull/8557#discussion_r1186752187 ## hudi-spark-datasource/hudi-spark/src/main/java/org/apache/hudi/cli/BootstrapExecutorUtils.java: ## @@ -263,10 +262,9 @@ private void initializeTable() throws IOException

[GitHub] [hudi] yihua commented on a diff in pull request #8557: [HUDI-5895] Remove bootstrap key generator configs

2023-05-06 Thread via GitHub
yihua commented on code in PR #8557: URL: https://github.com/apache/hudi/pull/8557#discussion_r1186752072 ## hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/TestHoodieSparkSqlWriter.scala: ## @@ -591,8 +591,7 @@ class TestHoodieSparkSqlWriter { HoodieBoo

[GitHub] [hudi] yihua commented on a diff in pull request #8557: [HUDI-5895] Remove bootstrap key generator configs

2023-05-06 Thread via GitHub
yihua commented on code in PR #8557: URL: https://github.com/apache/hudi/pull/8557#discussion_r1186752046 ## hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/TestHoodieSparkSqlWriter.scala: ## @@ -591,8 +591,7 @@ class TestHoodieSparkSqlWriter { HoodieBoo

[GitHub] [hudi] yihua commented on a diff in pull request #8557: [HUDI-5895] Remove bootstrap key generator configs

2023-05-06 Thread via GitHub
yihua commented on code in PR #8557: URL: https://github.com/apache/hudi/pull/8557#discussion_r1186751959 ## hudi-examples/hudi-examples-spark/src/main/java/org/apache/hudi/examples/spark/HoodieSparkBootstrapExample.java: ## @@ -64,7 +64,6 @@ public static void main(String[] arg