[GitHub] [hudi] yihua commented on a diff in pull request #8771: [HUDI-6245] Automatically downgrade table version of metadata table

2023-05-22 Thread via GitHub
yihua commented on code in PR #8771: URL: https://github.com/apache/hudi/pull/8771#discussion_r1201046443 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieMetadataWriteUtils.java: ## @@ -0,0 +1,175 @@ +/* + * Licensed to the Apache Software Foundati

[GitHub] [hudi] yihua commented on a diff in pull request #8771: [HUDI-6245] Automatically downgrade table version of metadata table

2023-05-20 Thread via GitHub
yihua commented on code in PR #8771: URL: https://github.com/apache/hudi/pull/8771#discussion_r1199677002 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/upgrade/UpgradeDowngrade.java: ## @@ -105,6 +108,25 @@ public boolean needsUpgradeOrDowngrade(HoodieTab

[GitHub] [hudi] yihua commented on a diff in pull request #8771: [HUDI-6245] Automatically downgrade table version of metadata table

2023-05-20 Thread via GitHub
yihua commented on code in PR #8771: URL: https://github.com/apache/hudi/pull/8771#discussion_r1199676834 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/upgrade/UpgradeDowngrade.java: ## @@ -105,6 +108,25 @@ public boolean needsUpgradeOrDowngrade(HoodieTab

[GitHub] [hudi] yihua commented on a diff in pull request #8771: [HUDI-6245] Automatically downgrade table version of metadata table

2023-05-20 Thread via GitHub
yihua commented on code in PR #8771: URL: https://github.com/apache/hudi/pull/8771#discussion_r1199676750 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java: ## @@ -252,8 +253,9 @@ private void enablePartition(final Meta