[GitHub] [hudi] yihua commented on a diff in pull request #8885: [HUDI-6198] Support Hudi on Spark 3.4.0

2023-06-09 Thread via GitHub
yihua commented on code in PR #8885: URL: https://github.com/apache/hudi/pull/8885#discussion_r1225129097 ## hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/HoodieParquetFileFormat.scala: ## @@ -34,6 +34,15 @@ class Hoodi

[GitHub] [hudi] yihua commented on a diff in pull request #8885: [HUDI-6198] Support Hudi on Spark 3.4.0

2023-06-09 Thread via GitHub
yihua commented on code in PR #8885: URL: https://github.com/apache/hudi/pull/8885#discussion_r1225128128 ## hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/BaseFileOnlyRelation.scala: ## @@ -66,17 +66,21 @@ case class BaseFileOnlyRelation(override val sql

[GitHub] [hudi] yihua commented on a diff in pull request #8885: [HUDI-6198] Support Hudi on Spark 3.4.0

2023-06-09 Thread via GitHub
yihua commented on code in PR #8885: URL: https://github.com/apache/hudi/pull/8885#discussion_r1225127785 ## hudi-client/hudi-spark-client/src/main/scala/org/apache/spark/sql/execution/datasources/HoodieSparkPartitionedFileUtils.scala: ## @@ -0,0 +1,77 @@ +/* + * Licensed to the

[GitHub] [hudi] yihua commented on a diff in pull request #8885: [HUDI-6198] Support Hudi on Spark 3.4.0

2023-06-09 Thread via GitHub
yihua commented on code in PR #8885: URL: https://github.com/apache/hudi/pull/8885#discussion_r1224877296 ## hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/command/AlterHoodieTableAddColumnsCommand.scala: ## @@ -17,31 +17,30 @@ package org.ap

[GitHub] [hudi] yihua commented on a diff in pull request #8885: [HUDI-6198] Support Hudi on Spark 3.4.0

2023-06-09 Thread via GitHub
yihua commented on code in PR #8885: URL: https://github.com/apache/hudi/pull/8885#discussion_r1224780310 ## hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/BaseFileOnlyRelation.scala: ## @@ -66,17 +66,21 @@ case class BaseFileOnlyRelation(override val sql

[GitHub] [hudi] yihua commented on a diff in pull request #8885: [HUDI-6198] Support Hudi on Spark 3.4.0

2023-06-09 Thread via GitHub
yihua commented on code in PR #8885: URL: https://github.com/apache/hudi/pull/8885#discussion_r1224771994 ## hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/HoodieParquetFileFormat.scala: ## @@ -34,6 +34,15 @@ class Hoodi

[GitHub] [hudi] yihua commented on a diff in pull request #8885: [HUDI-6198] Support Hudi on Spark 3.4.0

2023-06-09 Thread via GitHub
yihua commented on code in PR #8885: URL: https://github.com/apache/hudi/pull/8885#discussion_r1224726026 ## hudi-spark-datasource/hudi-spark3.3.x/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/Spark33HoodieParquetFileFormat.scala: ## @@ -0,0 +1,518 @@ +/* + *

[GitHub] [hudi] yihua commented on a diff in pull request #8885: [HUDI-6198] Support Hudi on Spark 3.4.0

2023-06-09 Thread via GitHub
yihua commented on code in PR #8885: URL: https://github.com/apache/hudi/pull/8885#discussion_r1224724972 ## hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/command/AlterHoodieTableAddColumnsCommand.scala: ## @@ -92,15 +91,16 @@ case class AlterH

[GitHub] [hudi] yihua commented on a diff in pull request #8885: [HUDI-6198] Support Hudi on Spark 3.4.0

2023-06-09 Thread via GitHub
yihua commented on code in PR #8885: URL: https://github.com/apache/hudi/pull/8885#discussion_r1224724397 ## hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/HoodieParquetFileFormat.scala: ## @@ -34,6 +34,15 @@ class Hoodi

[GitHub] [hudi] yihua commented on a diff in pull request #8885: [HUDI-6198] Support Hudi on Spark 3.4.0

2023-06-09 Thread via GitHub
yihua commented on code in PR #8885: URL: https://github.com/apache/hudi/pull/8885#discussion_r1224612364 ## hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/BaseFileOnlyRelation.scala: ## @@ -66,17 +66,21 @@ case class BaseFileOnlyRelation(override val sql

[GitHub] [hudi] yihua commented on a diff in pull request #8885: [HUDI-6198] Support Hudi on Spark 3.4.0

2023-06-09 Thread via GitHub
yihua commented on code in PR #8885: URL: https://github.com/apache/hudi/pull/8885#discussion_r1224611690 ## hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/BaseFileOnlyRelation.scala: ## @@ -66,17 +66,21 @@ case class BaseFileOnlyRelation(override val sql

[GitHub] [hudi] yihua commented on a diff in pull request #8885: [HUDI-6198] Support Hudi on Spark 3.4.0

2023-06-09 Thread via GitHub
yihua commented on code in PR #8885: URL: https://github.com/apache/hudi/pull/8885#discussion_r1224610497 ## hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/BaseFileOnlyRelation.scala: ## @@ -66,17 +66,21 @@ case class BaseFileOnlyRelation(override val sql

[GitHub] [hudi] yihua commented on a diff in pull request #8885: [HUDI-6198] Support Hudi on Spark 3.4.0

2023-06-09 Thread via GitHub
yihua commented on code in PR #8885: URL: https://github.com/apache/hudi/pull/8885#discussion_r1224609909 ## hudi-client/hudi-spark-client/src/main/scala/org/apache/spark/sql/HoodieCatalystPlansUtils.scala: ## @@ -52,6 +52,31 @@ trait HoodieCatalystPlansUtils { */ def cre

[GitHub] [hudi] yihua commented on a diff in pull request #8885: [HUDI-6198] Support Hudi on Spark 3.4.0

2023-06-09 Thread via GitHub
yihua commented on code in PR #8885: URL: https://github.com/apache/hudi/pull/8885#discussion_r1224607155 ## hudi-client/hudi-spark-client/src/main/scala/org/apache/hudi/SparkJdbcUtils.scala: ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [hudi] yihua commented on a diff in pull request #8885: [HUDI-6198] Support Hudi on Spark 3.4.0

2023-06-08 Thread via GitHub
yihua commented on code in PR #8885: URL: https://github.com/apache/hudi/pull/8885#discussion_r1223853653 ## hudi-spark-datasource/hudi-spark3.4.x/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/Spark34HoodieParquetFileFormat.scala: ## @@ -0,0 +1,532 @@ +/* + *

[GitHub] [hudi] yihua commented on a diff in pull request #8885: [HUDI-6198] Support Hudi on Spark 3.4.0

2023-06-08 Thread via GitHub
yihua commented on code in PR #8885: URL: https://github.com/apache/hudi/pull/8885#discussion_r1223791778 ## hudi-common/src/main/java/org/apache/hudi/common/util/JsonUtils.java: ## @@ -35,6 +36,8 @@ public class JsonUtils { private static final ObjectMapper MAPPER = new Obje

[GitHub] [hudi] yihua commented on a diff in pull request #8885: [HUDI-6198] Support Hudi on Spark 3.4.0

2023-06-08 Thread via GitHub
yihua commented on code in PR #8885: URL: https://github.com/apache/hudi/pull/8885#discussion_r1223651454 ## hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/command/index/TestIndexSyntax.scala: ## @@ -56,30 +58,37 @@ class TestIndexSyntax extends Hoodie

[GitHub] [hudi] yihua commented on a diff in pull request #8885: [HUDI-6198] Support Hudi on Spark 3.4.0

2023-06-08 Thread via GitHub
yihua commented on code in PR #8885: URL: https://github.com/apache/hudi/pull/8885#discussion_r1223580325 ## hudi-spark-datasource/hudi-spark3.2.x/src/main/scala/org/apache/spark/sql/HoodieSpark32CatalystPlanUtils.scala: ## @@ -38,6 +36,14 @@ object HoodieSpark32CatalystPlanUtil

[GitHub] [hudi] yihua commented on a diff in pull request #8885: [HUDI-6198] Support Hudi on Spark 3.4.0

2023-06-08 Thread via GitHub
yihua commented on code in PR #8885: URL: https://github.com/apache/hudi/pull/8885#discussion_r1223579632 ## hudi-common/src/main/java/org/apache/hudi/common/util/JsonUtils.java: ## @@ -35,6 +36,8 @@ public class JsonUtils { private static final ObjectMapper MAPPER = new Obje