[GitHub] [hudi] yihua commented on a diff in pull request #9083: [HUDI-6464] Spark SQL Merge Into for pkless tables

yihua commented on code in PR #9083: URL: https://github.com/apache/hudi/pull/9083#discussion_r1254962228 ## hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/analysis/HoodieAnalysis.scala: ## @@ -43,23 +43,29 @@ object HoodieAnalysis extends SparkAdapter

[GitHub] [hudi] yihua commented on a diff in pull request #9083: [HUDI-6464] Spark SQL Merge Into for pkless tables

yihua commented on code in PR #9083: URL: https://github.com/apache/hudi/pull/9083#discussion_r1251329643 ## hudi-spark-datasource/hudi-spark3.0.x/src/main/scala/org/apache/spark/sql/catalyst/analysis/HoodieSpark30Analysis.scala: ## @@ -0,0 +1,223 @@ +/* + * Licensed to the Apac

[GitHub] [hudi] yihua commented on a diff in pull request #9083: [HUDI-6464] Spark SQL Merge Into for pkless tables

yihua commented on code in PR #9083: URL: https://github.com/apache/hudi/pull/9083#discussion_r1251327647 ## hudi-spark-datasource/hudi-spark3.2plus-common/src/main/scala/org/apache/spark/sql/hudi/analysis/HoodieSpark32PlusAnalysis.scala: ## @@ -128,9 +131,135 @@ case class Hood

[GitHub] [hudi] yihua commented on a diff in pull request #9083: [HUDI-6464] Spark SQL Merge Into for pkless tables

yihua commented on code in PR #9083: URL: https://github.com/apache/hudi/pull/9083#discussion_r1251313925 ## hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/MergeIntoHoodieTableCommand.scala: ## @@ -298,26 +333,34 @@ case class MergeIntoHoodieTa

[GitHub] [hudi] yihua commented on a diff in pull request #9083: [HUDI-6464] Spark SQL Merge Into for pkless tables

yihua commented on code in PR #9083: URL: https://github.com/apache/hudi/pull/9083#discussion_r1251290919 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/index/HoodieInternalProxyIndex.java: ## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Software Foundation (

[GitHub] [hudi] yihua commented on a diff in pull request #9083: [HUDI-6464] Spark SQL Merge Into for pkless tables

yihua commented on code in PR #9083: URL: https://github.com/apache/hudi/pull/9083#discussion_r1251283969 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/index/HoodieInternalProxyIndex.java: ## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Software Foundation (