[GitHub] [hudi] yihua commented on pull request #8238: [HUDI-5954] Infer cleaning policy based on clean configs

2023-04-01 Thread via GitHub
yihua commented on PR #8238: URL: https://github.com/apache/hudi/pull/8238#issuecomment-1492861245 CI is green. https://user-images.githubusercontent.com/2497195/229271805-6db678af-348c-48c9-8862-de80acbe56ae.png;> -- This is an automated message from the Apache Git Service. To

[GitHub] [hudi] yihua commented on pull request #8238: [HUDI-5954] Infer cleaning policy based on clean configs

2023-03-31 Thread via GitHub
yihua commented on PR #8238: URL: https://github.com/apache/hudi/pull/8238#issuecomment-1492829259 > > > I'm so confused by these options, does the option hoodie.cleaner.policy make any sense here? If all the specific cleaning param: hoodie.cleaner.commits.retained,

[GitHub] [hudi] yihua commented on pull request #8238: [HUDI-5954] Infer cleaning policy based on clean configs

2023-03-31 Thread via GitHub
yihua commented on PR #8238: URL: https://github.com/apache/hudi/pull/8238#issuecomment-1491404273 > I'm so confused by these options, does the option hoodie.cleaner.policy make any sense here? If all the specific cleaning param: hoodie.cleaner.commits.retained,