[GitHub] [hudi] zherenyu831 commented on a change in pull request #2784: [HUDI-1740] Fix insert-overwrite API archival

2021-04-11 Thread GitBox
zherenyu831 commented on a change in pull request #2784: URL: https://github.com/apache/hudi/pull/2784#discussion_r611273466 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/utils/MetadataConversionUtils.java ## @@ -76,15 +76,16 @@ public stati

[GitHub] [hudi] zherenyu831 commented on a change in pull request #2784: [HUDI-1740] Fix insert-overwrite API archival

2021-04-08 Thread GitBox
zherenyu831 commented on a change in pull request #2784: URL: https://github.com/apache/hudi/pull/2784#discussion_r610237185 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/utils/MetadataConversionUtils.java ## @@ -72,9 +76,14 @@ public static

[GitHub] [hudi] zherenyu831 commented on a change in pull request #2784: [HUDI-1740] Fix insert-overwrite API archival

2021-04-08 Thread GitBox
zherenyu831 commented on a change in pull request #2784: URL: https://github.com/apache/hudi/pull/2784#discussion_r610237185 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/utils/MetadataConversionUtils.java ## @@ -72,9 +76,14 @@ public static

[GitHub] [hudi] zherenyu831 commented on a change in pull request #2784: [HUDI-1740] Fix insert-overwrite API archival

2021-04-07 Thread GitBox
zherenyu831 commented on a change in pull request #2784: URL: https://github.com/apache/hudi/pull/2784#discussion_r609200500 ## File path: hudi-common/src/main/java/org/apache/hudi/common/table/view/AbstractTableFileSystemView.java ## @@ -245,7 +245,7 @@ public final void rese

[GitHub] [hudi] zherenyu831 commented on a change in pull request #2784: [HUDI-1740] Fix insert-overwrite API archival

2021-04-07 Thread GitBox
zherenyu831 commented on a change in pull request #2784: URL: https://github.com/apache/hudi/pull/2784#discussion_r609192912 ## File path: hudi-common/src/main/java/org/apache/hudi/common/table/view/AbstractTableFileSystemView.java ## @@ -245,7 +245,7 @@ public final void rese

[GitHub] [hudi] zherenyu831 commented on a change in pull request #2784: [HUDI-1740] Fix insert-overwrite API archival

2021-04-07 Thread GitBox
zherenyu831 commented on a change in pull request #2784: URL: https://github.com/apache/hudi/pull/2784#discussion_r609186934 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/utils/MetadataConversionUtils.java ## @@ -105,14 +114,15 @@ public sta