[GitHub] [hudi] zhuanshenbsj1 commented on a diff in pull request #9038: [HUDI-6423] Incremental cleaning should consider inflight compaction instant

zhuanshenbsj1 commented on code in PR #9038: URL: https://github.com/apache/hudi/pull/9038#discussion_r1252072216 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/clean/CleanPlanActionExecutor.java: ## @@ -111,14 +111,15 @@ HoodieCleanerPlan requestCl

[GitHub] [hudi] zhuanshenbsj1 commented on a diff in pull request #9038: [HUDI-6423] Incremental cleaning should consider inflight compaction instant

zhuanshenbsj1 commented on code in PR #9038: URL: https://github.com/apache/hudi/pull/9038#discussion_r1252072216 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/clean/CleanPlanActionExecutor.java: ## @@ -111,14 +111,15 @@ HoodieCleanerPlan requestCl

[GitHub] [hudi] zhuanshenbsj1 commented on a diff in pull request #9038: [HUDI-6423] Incremental cleaning should consider inflight compaction instant

zhuanshenbsj1 commented on code in PR #9038: URL: https://github.com/apache/hudi/pull/9038#discussion_r1252054975 ## hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/table/TestCleaner.java: ## @@ -1004,23 +1098,24 @@ private void testPendingCompactions(HoodieWriteConf

[GitHub] [hudi] zhuanshenbsj1 commented on a diff in pull request #9038: [HUDI-6423] Incremental cleaning should consider inflight compaction instant

zhuanshenbsj1 commented on code in PR #9038: URL: https://github.com/apache/hudi/pull/9038#discussion_r1252054975 ## hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/table/TestCleaner.java: ## @@ -1004,23 +1098,24 @@ private void testPendingCompactions(HoodieWriteConf

[GitHub] [hudi] zhuanshenbsj1 commented on a diff in pull request #9038: [HUDI-6423] Incremental cleaning should consider inflight compaction instant

zhuanshenbsj1 commented on code in PR #9038: URL: https://github.com/apache/hudi/pull/9038#discussion_r1245807664 ## hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieDefaultTimeline.java: ## @@ -267,6 +267,13 @@ public HoodieTimeline getCommitsTimeline() {

[GitHub] [hudi] zhuanshenbsj1 commented on a diff in pull request #9038: [HUDI-6423] Incremental cleaning should consider inflight compaction instant

zhuanshenbsj1 commented on code in PR #9038: URL: https://github.com/apache/hudi/pull/9038#discussion_r1238713840 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/clean/CleanPlanner.java: ## @@ -509,7 +509,7 @@ public Pair> getDeletePaths(String part