[GitHub] [incubator-hudi] lamber-ken commented on issue #1290: [HUDI-584] Relocate spark-avro dependency by maven-shade-plugin

2020-03-01 Thread GitBox
lamber-ken commented on issue #1290: [HUDI-584] Relocate spark-avro dependency by maven-shade-plugin URL: https://github.com/apache/incubator-hudi/pull/1290#issuecomment-593252380 hi @bhasudha, addressed and add `--packages` to READ.ME doc ``` export SPARK_HOME=/work/BigData/install/s

[GitHub] [incubator-hudi] lamber-ken commented on issue #1290: [HUDI-584] Relocate spark-avro dependency by maven-shade-plugin

2020-03-01 Thread GitBox
lamber-ken commented on issue #1290: [HUDI-584] Relocate spark-avro dependency by maven-shade-plugin URL: https://github.com/apache/incubator-hudi/pull/1290#issuecomment-593237472 hi @bhasudha, all review comments are addressed and fixed. Thanks ![image](https://user-images.githubus

[GitHub] [incubator-hudi] lamber-ken commented on issue #1290: [HUDI-584] Relocate spark-avro dependency by maven-shade-plugin

2020-02-05 Thread GitBox
lamber-ken commented on issue #1290: [HUDI-584] Relocate spark-avro dependency by maven-shade-plugin URL: https://github.com/apache/incubator-hudi/pull/1290#issuecomment-582669261 Hi @vinothchandar, I didn't know you and @umehrot2 had talked about this 😭 https://github.com/apache/incub

[GitHub] [incubator-hudi] lamber-ken commented on issue #1290: [HUDI-584] Relocate spark-avro dependency by maven-shade-plugin

2020-02-05 Thread GitBox
lamber-ken commented on issue #1290: [HUDI-584] Relocate spark-avro dependency by maven-shade-plugin URL: https://github.com/apache/incubator-hudi/pull/1290#issuecomment-582663093 Hi @vinothchandar @bhasudha @umehrot2, thanks you all talk about this here, I thinks it's a meaningful discuss

[GitHub] [incubator-hudi] lamber-ken commented on issue #1290: [HUDI-584] Relocate spark-avro dependency by maven-shade-plugin

2020-02-05 Thread GitBox
lamber-ken commented on issue #1290: [HUDI-584] Relocate spark-avro dependency by maven-shade-plugin URL: https://github.com/apache/incubator-hudi/pull/1290#issuecomment-582661108 hi @bhasudha, `Spark 3.0.0-preview2` is pre-built with Scala 2.12, user need to build hudi with scala-2.12 fir

[GitHub] [incubator-hudi] lamber-ken commented on issue #1290: [HUDI-584] Relocate spark-avro dependency by maven-shade-plugin

2020-02-05 Thread GitBox
lamber-ken commented on issue #1290: [HUDI-584] Relocate spark-avro dependency by maven-shade-plugin URL: https://github.com/apache/incubator-hudi/pull/1290#issuecomment-582628959 > > If the user wants some changes in spark-avro:3.0-preview2, the right way is modify spark-version to 3.0-pr

[GitHub] [incubator-hudi] lamber-ken commented on issue #1290: [HUDI-584] Relocate spark-avro dependency by maven-shade-plugin

2020-02-04 Thread GitBox
lamber-ken commented on issue #1290: [HUDI-584] Relocate spark-avro dependency by maven-shade-plugin URL: https://github.com/apache/incubator-hudi/pull/1290#issuecomment-582248349 Thanks for review this pr @vinothchandar, this pr does not lock the user into `spark-avro:2.4.4`. If t

[GitHub] [incubator-hudi] lamber-ken commented on issue #1290: [HUDI-584] Relocate spark-avro dependency by maven-shade-plugin

2020-01-30 Thread GitBox
lamber-ken commented on issue #1290: [HUDI-584] Relocate spark-avro dependency by maven-shade-plugin URL: https://github.com/apache/incubator-hudi/pull/1290#issuecomment-580144740 hi @bhasudha, you're welcome. This works well with ` spark-3.0-preview2 and scala 2.12`. ``` wget h