Re: [PR] [HUDI-6860] Move createNewInstantTime out of HoodieActiveTimeline [hudi]

2024-03-01 Thread via GitHub
danny0405 commented on PR #10714: URL: https://github.com/apache/hudi/pull/10714#issuecomment-1972769406 Closed, @wombatu-kun Thanks for the contribution anyway! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [HUDI-6860] Move createNewInstantTime out of HoodieActiveTimeline [hudi]

2024-03-01 Thread via GitHub
danny0405 closed pull request #10714: [HUDI-6860] Move createNewInstantTime out of HoodieActiveTimeline URL: https://github.com/apache/hudi/pull/10714 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [HUDI-6860] Move createNewInstantTime out of HoodieActiveTimeline [hudi]

2024-02-29 Thread via GitHub
yihua commented on PR #10714: URL: https://github.com/apache/hudi/pull/10714#issuecomment-1972597039 @boneanxs @wombatu-kun should we close this PR if no longer needed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] [HUDI-6860] Move createNewInstantTime out of HoodieActiveTimeline [hudi]

2024-02-22 Thread via GitHub
boneanxs commented on PR #10714: URL: https://github.com/apache/hudi/pull/10714#issuecomment-1960641014 > @boneanxs Can you help for the review and clarify the initiative aim of the task? Hey @danny0405 @wombatu-kun, sorry for misunderstanding. The intention of this issue is to movin

Re: [PR] [HUDI-6860] Move createNewInstantTime out of HoodieActiveTimeline [hudi]

2024-02-21 Thread via GitHub
danny0405 commented on PR #10714: URL: https://github.com/apache/hudi/pull/10714#issuecomment-1958568370 @boneanxs Can you help for the review and clarify the initiative aim of the task? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] [HUDI-6860] Move createNewInstantTime out of HoodieActiveTimeline [hudi]

2024-02-20 Thread via GitHub
wombatu-kun commented on PR #10714: URL: https://github.com/apache/hudi/pull/10714#issuecomment-1955917467 I don't know exactly, I'm not the reporter of this improvement in ASF (it is Hui An). I suppose his purpose was to extract such a common utility code from HoodieActiveTimeline class to

Re: [PR] [HUDI-6860] Move createNewInstantTime out of HoodieActiveTimeline [hudi]

2024-02-20 Thread via GitHub
hudi-bot commented on PR #10714: URL: https://github.com/apache/hudi/pull/10714#issuecomment-1955911711 ## CI report: * 237c5cdda3c87fec59247bb403c202d39bc5cdca Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22

Re: [PR] [HUDI-6860] Move createNewInstantTime out of HoodieActiveTimeline [hudi]

2024-02-20 Thread via GitHub
danny0405 commented on PR #10714: URL: https://github.com/apache/hudi/pull/10714#issuecomment-1955860732 Can you elaborate what is the purpose of this change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] [HUDI-6860] Move createNewInstantTime out of HoodieActiveTimeline [hudi]

2024-02-20 Thread via GitHub
hudi-bot commented on PR #10714: URL: https://github.com/apache/hudi/pull/10714#issuecomment-1955757868 ## CI report: * 8acd57d8a2270eda79fb69b3219d2861e1b96f30 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22

Re: [PR] [HUDI-6860] Move createNewInstantTime out of HoodieActiveTimeline [hudi]

2024-02-20 Thread via GitHub
hudi-bot commented on PR #10714: URL: https://github.com/apache/hudi/pull/10714#issuecomment-1955751508 ## CI report: * 8acd57d8a2270eda79fb69b3219d2861e1b96f30 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22

Re: [PR] [HUDI-6860] Move createNewInstantTime out of HoodieActiveTimeline [hudi]

2024-02-20 Thread via GitHub
hudi-bot commented on PR #10714: URL: https://github.com/apache/hudi/pull/10714#issuecomment-1954014906 ## CI report: * 8acd57d8a2270eda79fb69b3219d2861e1b96f30 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22

Re: [PR] [HUDI-6860] Move createNewInstantTime out of HoodieActiveTimeline [hudi]

2024-02-20 Thread via GitHub
hudi-bot commented on PR #10714: URL: https://github.com/apache/hudi/pull/10714#issuecomment-1953803850 ## CI report: * 8acd57d8a2270eda79fb69b3219d2861e1b96f30 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22

Re: [PR] [HUDI-6860] Move createNewInstantTime out of HoodieActiveTimeline [hudi]

2024-02-20 Thread via GitHub
hudi-bot commented on PR #10714: URL: https://github.com/apache/hudi/pull/10714#issuecomment-1953788895 ## CI report: * 8acd57d8a2270eda79fb69b3219d2861e1b96f30 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run th

[PR] [HUDI-6860] Move createNewInstantTime out of HoodieActiveTimeline [hudi]

2024-02-20 Thread via GitHub
wombatu-kun opened a new pull request, #10714: URL: https://github.com/apache/hudi/pull/10714 ### Change Logs Moved createNewInstantTime out of HoodieActiveTimeline (to HoodieTimeline) ### Impact none ### Risk level (write none, low medium or high below) non