Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-09 Thread via GitHub
yihua commented on code in PR #11131: URL: https://github.com/apache/hudi/pull/11131#discussion_r1595870231 ## hudi-common/src/main/java/org/apache/hudi/common/fs/FSUtils.java: ## @@ -635,16 +603,7 @@ public static Long getSizeInMB(long sizeInBytes) { } public static

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-09 Thread via GitHub
yihua commented on code in PR #11131: URL: https://github.com/apache/hudi/pull/11131#discussion_r1595862165 ## hudi-common/src/main/java/org/apache/hudi/storage/HoodieStorageUtils.java: ## @@ -19,37 +19,63 @@ package org.apache.hudi.storage; -import

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-09 Thread via GitHub
jonvex commented on code in PR #11131: URL: https://github.com/apache/hudi/pull/11131#discussion_r1595861415 ## hudi-common/src/main/java/org/apache/hudi/common/fs/FSUtils.java: ## @@ -209,21 +193,7 @@ public static List getAllPartitionFoldersThreeLevelsDown(HoodieStorage s

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-09 Thread via GitHub
yihua commented on code in PR #11131: URL: https://github.com/apache/hudi/pull/11131#discussion_r1595849923 ## hudi-common/src/main/java/org/apache/hudi/common/config/PropertiesConfig.java: ## @@ -0,0 +1,33 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-09 Thread via GitHub
yihua commented on code in PR #11131: URL: https://github.com/apache/hudi/pull/11131#discussion_r1595827566 ## hudi-common/src/main/java/org/apache/hudi/metrics/Metrics.java: ## @@ -99,8 +97,7 @@ public static synchronized void shutdownAllMetrics() { private List

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-09 Thread via GitHub
yihua commented on code in PR #11131: URL: https://github.com/apache/hudi/pull/11131#discussion_r1595818567 ## hudi-common/src/main/java/org/apache/hudi/common/fs/FSUtils.java: ## @@ -96,20 +90,6 @@ public class FSUtils { private static final StoragePathFilter

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-09 Thread via GitHub
yihua commented on code in PR #11131: URL: https://github.com/apache/hudi/pull/11131#discussion_r1595815715 ## hudi-client/hudi-java-client/pom.xml: ## @@ -42,6 +42,11 @@ hudi-client-common ${project.parent.version} + +

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-09 Thread via GitHub
yihua commented on code in PR #11131: URL: https://github.com/apache/hudi/pull/11131#discussion_r1595814771 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieAppendHandle.java: ## @@ -674,14 +674,15 @@ private static HoodieLogBlock

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-09 Thread via GitHub
yihua commented on code in PR #11131: URL: https://github.com/apache/hudi/pull/11131#discussion_r1595813106 ## hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/testutils/HoodieClientTestUtils.java: ## @@ -322,7 +322,7 @@ public static HoodieTableMetaClient

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-09 Thread via GitHub
yihua commented on code in PR #11131: URL: https://github.com/apache/hudi/pull/11131#discussion_r1595811789 ## hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/testutils/HoodieClientTestUtils.java: ## @@ -313,7 +313,7 @@ public static Option

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-09 Thread via GitHub
yihua commented on code in PR #11131: URL: https://github.com/apache/hudi/pull/11131#discussion_r1595806678 ## hudi-hadoop-common/src/main/java/org/apache/hudi/hadoop/fs/HadoopFSUtils.java: ## @@ -109,25 +105,6 @@ public static FileSystem getFs(String pathStr, Configuration

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-09 Thread via GitHub
hudi-bot commented on PR #11131: URL: https://github.com/apache/hudi/pull/11131#issuecomment-2102997699 ## CI report: * 94063d1bd8234c38e9ffb1befaf8760ae664621f UNKNOWN * bf97332bd42d5005f6299c94b44aba122c4919b2 UNKNOWN * 1219237f59281728a3c6c0286a131264d68121ed Azure:

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-09 Thread via GitHub
hudi-bot commented on PR #11131: URL: https://github.com/apache/hudi/pull/11131#issuecomment-2102800416 ## CI report: * 94063d1bd8234c38e9ffb1befaf8760ae664621f UNKNOWN * bf97332bd42d5005f6299c94b44aba122c4919b2 UNKNOWN * 532c386fec8fdc1ba587da04b3b50092440e4097 Azure:

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-09 Thread via GitHub
hudi-bot commented on PR #11131: URL: https://github.com/apache/hudi/pull/11131#issuecomment-2102785956 ## CI report: * 94063d1bd8234c38e9ffb1befaf8760ae664621f UNKNOWN * bf97332bd42d5005f6299c94b44aba122c4919b2 UNKNOWN * 532c386fec8fdc1ba587da04b3b50092440e4097 Azure:

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-08 Thread via GitHub
hudi-bot commented on PR #11131: URL: https://github.com/apache/hudi/pull/11131#issuecomment-2101814289 ## CI report: * 94063d1bd8234c38e9ffb1befaf8760ae664621f UNKNOWN * bf97332bd42d5005f6299c94b44aba122c4919b2 UNKNOWN * 532c386fec8fdc1ba587da04b3b50092440e4097 Azure:

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-08 Thread via GitHub
hudi-bot commented on PR #11131: URL: https://github.com/apache/hudi/pull/11131#issuecomment-2101774189 ## CI report: * 94063d1bd8234c38e9ffb1befaf8760ae664621f UNKNOWN * bf97332bd42d5005f6299c94b44aba122c4919b2 UNKNOWN * a24b9db69ad0993d5ff649e222525238274481a5 Azure:

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-08 Thread via GitHub
hudi-bot commented on PR #11131: URL: https://github.com/apache/hudi/pull/11131#issuecomment-2101721636 ## CI report: * 94063d1bd8234c38e9ffb1befaf8760ae664621f UNKNOWN * bf97332bd42d5005f6299c94b44aba122c4919b2 UNKNOWN * ea50694f9547bff4b01b9b39a6cb400f411b0168 Azure:

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-08 Thread via GitHub
hudi-bot commented on PR #11131: URL: https://github.com/apache/hudi/pull/11131#issuecomment-2101715271 ## CI report: * 94063d1bd8234c38e9ffb1befaf8760ae664621f UNKNOWN * bf97332bd42d5005f6299c94b44aba122c4919b2 UNKNOWN * ea50694f9547bff4b01b9b39a6cb400f411b0168 Azure:

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-08 Thread via GitHub
hudi-bot commented on PR #11131: URL: https://github.com/apache/hudi/pull/11131#issuecomment-2101708907 ## CI report: * 94063d1bd8234c38e9ffb1befaf8760ae664621f UNKNOWN * bf97332bd42d5005f6299c94b44aba122c4919b2 UNKNOWN * ea50694f9547bff4b01b9b39a6cb400f411b0168 Azure:

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-08 Thread via GitHub
hudi-bot commented on PR #11131: URL: https://github.com/apache/hudi/pull/11131#issuecomment-2101668214 ## CI report: * 94063d1bd8234c38e9ffb1befaf8760ae664621f UNKNOWN * 3d33de31b2a4b0a4f252a0e96cef728af83ddc16 Azure:

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-08 Thread via GitHub
hudi-bot commented on PR #11131: URL: https://github.com/apache/hudi/pull/11131#issuecomment-2101662372 ## CI report: * 94063d1bd8234c38e9ffb1befaf8760ae664621f UNKNOWN * 3d33de31b2a4b0a4f252a0e96cef728af83ddc16 Azure:

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-08 Thread via GitHub
jonvex commented on code in PR #11131: URL: https://github.com/apache/hudi/pull/11131#discussion_r1594778367 ## hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/HoodieFileGroupReaderBasedParquetFileFormat.scala: ## @@

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-08 Thread via GitHub
jonvex commented on code in PR #11131: URL: https://github.com/apache/hudi/pull/11131#discussion_r1594772203 ## hudi-hadoop-common/src/test/java/org/apache/hudi/common/table/TestHoodieTableConfig.java: ## @@ -63,7 +61,7 @@ public class TestHoodieTableConfig extends

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-08 Thread via GitHub
jonvex commented on code in PR #11131: URL: https://github.com/apache/hudi/pull/11131#discussion_r1594771064 ## hudi-hadoop-common/src/main/java/org/apache/hudi/storage/hadoop/HadoopStorageConfiguration.java: ## @@ -38,7 +38,11 @@ public class HadoopStorageConfiguration extends

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-08 Thread via GitHub
jonvex commented on code in PR #11131: URL: https://github.com/apache/hudi/pull/11131#discussion_r1594767682 ## hudi-common/src/main/java/org/apache/hudi/metrics/Metrics.java: ## @@ -99,8 +97,7 @@ public static synchronized void shutdownAllMetrics() { private List

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-08 Thread via GitHub
yihua commented on code in PR #11131: URL: https://github.com/apache/hudi/pull/11131#discussion_r1594754496 ## hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestMORDataSourceStorage.scala: ## @@ -25,10 +25,10 @@ import

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-08 Thread via GitHub
jonvex commented on code in PR #11131: URL: https://github.com/apache/hudi/pull/11131#discussion_r1594753453 ## hudi-common/src/main/java/org/apache/hudi/io/storage/HoodieNativeAvroHFileReader.java: ## @@ -265,7 +263,7 @@ private HFileReader newHFileReader() throws IOException

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-08 Thread via GitHub
yihua commented on code in PR #11131: URL: https://github.com/apache/hudi/pull/11131#discussion_r1594752319 ## hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/HoodieFileGroupReaderBasedParquetFileFormat.scala: ## @@

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-08 Thread via GitHub
jonvex commented on code in PR #11131: URL: https://github.com/apache/hudi/pull/11131#discussion_r1594751287 ## hudi-common/src/main/java/org/apache/hudi/common/util/ParquetUtils.java: ## @@ -100,7 +100,8 @@ public static ParquetMetadata readMetadata(StorageConfiguration conf,

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-08 Thread via GitHub
jonvex commented on code in PR #11131: URL: https://github.com/apache/hudi/pull/11131#discussion_r1594597401 ## hudi-hadoop-common/src/test/java/org/apache/hudi/common/testutils/FileSystemTestUtils.java: ## @@ -79,34 +68,4 @@ public static void deleteFile(File fileToDelete)

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-08 Thread via GitHub
jonvex commented on code in PR #11131: URL: https://github.com/apache/hudi/pull/11131#discussion_r1594592122 ## hudi-common/src/main/java/org/apache/hudi/storage/HoodieStorageUtils.java: ## @@ -34,22 +32,35 @@ public static HoodieStorage getStorage(StorageConfiguration conf) {

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-08 Thread via GitHub
jonvex commented on code in PR #11131: URL: https://github.com/apache/hudi/pull/11131#discussion_r1594591453 ## hudi-hadoop-common/src/test/java/org/apache/hudi/common/functional/TestHoodieLogFormat.java: ## @@ -459,7 +457,7 @@ public void testHugeLogFileWrite() throws

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-08 Thread via GitHub
jonvex commented on code in PR #11131: URL: https://github.com/apache/hudi/pull/11131#discussion_r1594589135 ## hudi-hadoop-common/src/main/java/org/apache/hudi/storage/hadoop/HoodieHadoopStorage.java: ## @@ -213,6 +267,16 @@ public Configuration unwrapConf() { return

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-08 Thread via GitHub
jonvex commented on code in PR #11131: URL: https://github.com/apache/hudi/pull/11131#discussion_r1594587944 ## hudi-hadoop-common/src/main/java/org/apache/hudi/storage/hadoop/HadoopStorageConfiguration.java: ## @@ -38,7 +38,11 @@ public class HadoopStorageConfiguration extends

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-08 Thread via GitHub
jonvex commented on code in PR #11131: URL: https://github.com/apache/hudi/pull/11131#discussion_r1594586377 ## hudi-hadoop-common/src/main/java/org/apache/hudi/hadoop/fs/HadoopFSUtils.java: ## @@ -109,25 +105,6 @@ public static FileSystem getFs(String pathStr, Configuration

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-08 Thread via GitHub
hudi-bot commented on PR #11131: URL: https://github.com/apache/hudi/pull/11131#issuecomment-2101365987 ## CI report: * 94063d1bd8234c38e9ffb1befaf8760ae664621f UNKNOWN * 3d33de31b2a4b0a4f252a0e96cef728af83ddc16 Azure:

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-08 Thread via GitHub
jonvex commented on code in PR #11131: URL: https://github.com/apache/hudi/pull/11131#discussion_r1594581863 ## hudi-common/src/main/java/org/apache/hudi/metrics/Metrics.java: ## @@ -99,8 +97,7 @@ public static synchronized void shutdownAllMetrics() { private List

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-08 Thread via GitHub
jonvex commented on code in PR #11131: URL: https://github.com/apache/hudi/pull/11131#discussion_r1594577738 ## hudi-common/src/main/java/org/apache/hudi/io/storage/HoodieNativeAvroHFileReader.java: ## @@ -265,7 +263,7 @@ private HFileReader newHFileReader() throws IOException

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-08 Thread via GitHub
jonvex commented on code in PR #11131: URL: https://github.com/apache/hudi/pull/11131#discussion_r1594570213 ## hudi-common/src/main/java/org/apache/hudi/common/util/ParquetUtils.java: ## @@ -100,7 +100,8 @@ public static ParquetMetadata readMetadata(StorageConfiguration conf,

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-08 Thread via GitHub
jonvex commented on code in PR #11131: URL: https://github.com/apache/hudi/pull/11131#discussion_r1594560411 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieAppendHandle.java: ## @@ -674,14 +674,15 @@ private static HoodieLogBlock

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-08 Thread via GitHub
hudi-bot commented on PR #11131: URL: https://github.com/apache/hudi/pull/11131#issuecomment-2101275676 ## CI report: * 2bde7d57048e342132d0b70b524317e1bcbdb96b Azure:

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-08 Thread via GitHub
hudi-bot commented on PR #11131: URL: https://github.com/apache/hudi/pull/11131#issuecomment-2101206487 ## CI report: * 2bde7d57048e342132d0b70b524317e1bcbdb96b Azure:

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-08 Thread via GitHub
hudi-bot commented on PR #11131: URL: https://github.com/apache/hudi/pull/11131#issuecomment-2101189533 ## CI report: * 2bde7d57048e342132d0b70b524317e1bcbdb96b Azure:

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-08 Thread via GitHub
jonvex commented on code in PR #11131: URL: https://github.com/apache/hudi/pull/11131#discussion_r1594410585 ## hudi-hadoop-mr/pom.xml: ## @@ -108,6 +114,22 @@ test-jar test + + org.apache.hudi + hudi-hadoop-common + ${project.version} +

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-08 Thread via GitHub
jonvex commented on code in PR #11131: URL: https://github.com/apache/hudi/pull/11131#discussion_r1594408581 ## hudi-hadoop-common/src/test/java/org/apache/hudi/common/testutils/FileSystemTestUtils.java: ## @@ -79,34 +68,4 @@ public static void deleteFile(File fileToDelete)

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-08 Thread via GitHub
jonvex commented on code in PR #11131: URL: https://github.com/apache/hudi/pull/11131#discussion_r1594399186 ## hudi-hadoop-common/src/test/java/org/apache/hudi/common/table/timeline/TestWaitBasedTimeGenerator.java: ## @@ -75,7 +75,7 @@ public boolean tryLock(long time,

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-08 Thread via GitHub
jonvex commented on code in PR #11131: URL: https://github.com/apache/hudi/pull/11131#discussion_r1594398612 ## hudi-hadoop-common/src/test/java/org/apache/hudi/common/table/TestHoodieTableConfig.java: ## @@ -63,7 +61,7 @@ public class TestHoodieTableConfig extends

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-08 Thread via GitHub
jonvex commented on code in PR #11131: URL: https://github.com/apache/hudi/pull/11131#discussion_r1594396489 ## hudi-common/src/main/java/org/apache/hudi/storage/HoodieStorageUtils.java: ## @@ -34,22 +32,35 @@ public static HoodieStorage getStorage(StorageConfiguration conf) {

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-08 Thread via GitHub
jonvex commented on code in PR #11131: URL: https://github.com/apache/hudi/pull/11131#discussion_r1594395638 ## hudi-hadoop-common/src/test/java/org/apache/hudi/common/functional/TestHoodieLogFormat.java: ## @@ -459,7 +457,7 @@ public void testHugeLogFileWrite() throws

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-08 Thread via GitHub
jonvex commented on code in PR #11131: URL: https://github.com/apache/hudi/pull/11131#discussion_r1594392368 ## hudi-hadoop-common/src/main/java/org/apache/hudi/storage/hadoop/HadoopStorageConfiguration.java: ## @@ -38,7 +38,11 @@ public class HadoopStorageConfiguration extends

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-08 Thread via GitHub
jonvex commented on code in PR #11131: URL: https://github.com/apache/hudi/pull/11131#discussion_r1594382795 ## hudi-hadoop-common/src/main/java/org/apache/hudi/storage/hadoop/HoodieHadoopStorage.java: ## @@ -43,16 +47,66 @@ import java.util.List; import

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-08 Thread via GitHub
jonvex commented on code in PR #11131: URL: https://github.com/apache/hudi/pull/11131#discussion_r1594377249 ## hudi-hadoop-common/src/main/java/org/apache/hudi/storage/hadoop/HadoopStorageConfiguration.java: ## @@ -38,7 +38,11 @@ public class HadoopStorageConfiguration extends

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-08 Thread via GitHub
jonvex commented on code in PR #11131: URL: https://github.com/apache/hudi/pull/11131#discussion_r1594370366 ## hudi-hadoop-common/src/main/java/org/apache/hudi/hadoop/fs/HoodieHadoopUtils.java: ## @@ -0,0 +1,35 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-08 Thread via GitHub
jonvex commented on code in PR #11131: URL: https://github.com/apache/hudi/pull/11131#discussion_r1594367946 ## hudi-hadoop-common/src/main/java/org/apache/hudi/hadoop/fs/HadoopFSUtils.java: ## @@ -109,25 +105,6 @@ public static FileSystem getFs(String pathStr, Configuration

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-08 Thread via GitHub
jonvex commented on code in PR #11131: URL: https://github.com/apache/hudi/pull/11131#discussion_r1594361490 ## hudi-hadoop-common/src/main/java/org/apache/hudi/common/config/DFSPropertiesConfiguration.java: ## @@ -202,6 +202,11 @@ public void addPropsFromStream(BufferedReader

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-08 Thread via GitHub
jonvex commented on code in PR #11131: URL: https://github.com/apache/hudi/pull/11131#discussion_r1594360124 ## hudi-common/src/test/java/org/apache/hudi/common/testutils/HoodieTestUtils.java: ## @@ -198,24 +199,25 @@ public static HoodieTableMetaClient init(String basePath,

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-08 Thread via GitHub
jonvex commented on code in PR #11131: URL: https://github.com/apache/hudi/pull/11131#discussion_r1594352910 ## hudi-common/src/test/java/org/apache/hudi/common/testutils/HoodieTestDataGenerator.java: ## @@ -578,8 +576,8 @@ private static void createMetadataFile(String f,

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-08 Thread via GitHub
jonvex commented on code in PR #11131: URL: https://github.com/apache/hudi/pull/11131#discussion_r1594350164 ## hudi-common/src/main/java/org/apache/hudi/metrics/Metrics.java: ## @@ -99,8 +97,7 @@ public static synchronized void shutdownAllMetrics() { private List

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-08 Thread via GitHub
jonvex commented on code in PR #11131: URL: https://github.com/apache/hudi/pull/11131#discussion_r1594348426 ## hudi-common/src/main/java/org/apache/hudi/io/storage/HoodieNativeAvroHFileReader.java: ## @@ -265,7 +263,7 @@ private HFileReader newHFileReader() throws IOException

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-08 Thread via GitHub
jonvex commented on code in PR #11131: URL: https://github.com/apache/hudi/pull/11131#discussion_r1594338645 ## hudi-common/src/main/java/org/apache/hudi/common/util/ParquetUtils.java: ## @@ -100,7 +100,8 @@ public static ParquetMetadata readMetadata(StorageConfiguration conf,

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-08 Thread via GitHub
jonvex commented on code in PR #11131: URL: https://github.com/apache/hudi/pull/11131#discussion_r1594313548 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieAppendHandle.java: ## @@ -674,14 +674,15 @@ private static HoodieLogBlock

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-08 Thread via GitHub
jonvex commented on code in PR #11131: URL: https://github.com/apache/hudi/pull/11131#discussion_r1594288001 ## hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/testutils/HoodieClientTestUtils.java: ## @@ -322,7 +322,7 @@ public static HoodieTableMetaClient

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-08 Thread via GitHub
jonvex commented on code in PR #11131: URL: https://github.com/apache/hudi/pull/11131#discussion_r1594285849 ## hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/testutils/HoodieClientTestUtils.java: ## @@ -313,7 +313,7 @@ public static Option

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-08 Thread via GitHub
jonvex commented on code in PR #11131: URL: https://github.com/apache/hudi/pull/11131#discussion_r1594281556 ## hudi-client/hudi-java-client/pom.xml: ## @@ -42,6 +42,11 @@ hudi-client-common ${project.parent.version} + +

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-08 Thread via GitHub
jonvex commented on code in PR #11131: URL: https://github.com/apache/hudi/pull/11131#discussion_r1594272278 ## hudi-client/hudi-client-common/pom.xml: ## @@ -43,6 +43,16 @@ hudi-common ${project.version} + + org.apache.hudi + hudi-io +

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-08 Thread via GitHub
yihua commented on code in PR #11131: URL: https://github.com/apache/hudi/pull/11131#discussion_r1593573466 ## hudi-hadoop-common/src/test/java/org/apache/hudi/common/testutils/FileSystemTestUtils.java: ## @@ -79,34 +68,4 @@ public static void deleteFile(File fileToDelete)

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-08 Thread via GitHub
yihua commented on code in PR #11131: URL: https://github.com/apache/hudi/pull/11131#discussion_r1593562711 ## hudi-hadoop-common/src/test/java/org/apache/hudi/common/functional/TestHoodieLogFormat.java: ## @@ -459,7 +457,7 @@ public void testHugeLogFileWrite() throws

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-08 Thread via GitHub
yihua commented on code in PR #11131: URL: https://github.com/apache/hudi/pull/11131#discussion_r1593538784 ## hudi-hadoop-common/src/main/java/org/apache/hudi/common/config/DFSPropertiesConfiguration.java: ## @@ -202,6 +202,11 @@ public void addPropsFromStream(BufferedReader

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-08 Thread via GitHub
yihua commented on code in PR #11131: URL: https://github.com/apache/hudi/pull/11131#discussion_r1593527111 ## hudi-common/src/main/java/org/apache/hudi/storage/HoodieStorageUtils.java: ## @@ -34,22 +32,35 @@ public static HoodieStorage getStorage(StorageConfiguration conf) {

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-08 Thread via GitHub
yihua commented on code in PR #11131: URL: https://github.com/apache/hudi/pull/11131#discussion_r1593525459 ## hudi-common/src/main/java/org/apache/hudi/metrics/Metrics.java: ## @@ -99,8 +97,7 @@ public static synchronized void shutdownAllMetrics() { private List

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-08 Thread via GitHub
yihua commented on code in PR #11131: URL: https://github.com/apache/hudi/pull/11131#discussion_r1593522855 ## hudi-common/src/main/java/org/apache/hudi/io/storage/HoodieNativeAvroHFileReader.java: ## @@ -265,7 +263,7 @@ private HFileReader newHFileReader() throws IOException {

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-08 Thread via GitHub
yihua commented on code in PR #11131: URL: https://github.com/apache/hudi/pull/11131#discussion_r1593483883 ## hudi-common/src/main/java/org/apache/hudi/common/table/log/block/HoodieHFileDataBlock.java: ## @@ -189,9 +193,7 @@ protected byte[] serializeRecords(List records)

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-08 Thread via GitHub
yihua commented on code in PR #11131: URL: https://github.com/apache/hudi/pull/11131#discussion_r1593442058 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieAppendHandle.java: ## @@ -674,14 +674,15 @@ private static HoodieLogBlock

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-07 Thread via GitHub
yihua commented on code in PR #11131: URL: https://github.com/apache/hudi/pull/11131#discussion_r1593272677 ## hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/testutils/HoodieClientTestUtils.java: ## @@ -313,7 +313,7 @@ public static Option

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-07 Thread via GitHub
hudi-bot commented on PR #11131: URL: https://github.com/apache/hudi/pull/11131#issuecomment-2098943852 ## CI report: * 2bde7d57048e342132d0b70b524317e1bcbdb96b Azure:

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-07 Thread via GitHub
hudi-bot commented on PR #11131: URL: https://github.com/apache/hudi/pull/11131#issuecomment-2098748252 ## CI report: * 7c72471a1b9b5ad43ca63ab60da0f3d260f67cea Azure:

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-07 Thread via GitHub
hudi-bot commented on PR #11131: URL: https://github.com/apache/hudi/pull/11131#issuecomment-2098720660 ## CI report: * 7c72471a1b9b5ad43ca63ab60da0f3d260f67cea Azure:

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-06 Thread via GitHub
hudi-bot commented on PR #11131: URL: https://github.com/apache/hudi/pull/11131#issuecomment-2097467747 ## CI report: * 7c72471a1b9b5ad43ca63ab60da0f3d260f67cea Azure:

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-06 Thread via GitHub
hudi-bot commented on PR #11131: URL: https://github.com/apache/hudi/pull/11131#issuecomment-2097379202 ## CI report: * 1a5e0d9b0b3bd73b7034ef290fbeaf6aa7a66441 Azure:

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-06 Thread via GitHub
hudi-bot commented on PR #11131: URL: https://github.com/apache/hudi/pull/11131#issuecomment-2097373459 ## CI report: * 1a5e0d9b0b3bd73b7034ef290fbeaf6aa7a66441 Azure:

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-06 Thread via GitHub
hudi-bot commented on PR #11131: URL: https://github.com/apache/hudi/pull/11131#issuecomment-2096530418 ## CI report: * 1a5e0d9b0b3bd73b7034ef290fbeaf6aa7a66441 Azure:

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-06 Thread via GitHub
hudi-bot commented on PR #11131: URL: https://github.com/apache/hudi/pull/11131#issuecomment-2096434273 ## CI report: * 1a5e0d9b0b3bd73b7034ef290fbeaf6aa7a66441 Azure:

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-06 Thread via GitHub
hudi-bot commented on PR #11131: URL: https://github.com/apache/hudi/pull/11131#issuecomment-2096420931 ## CI report: * 1a5e0d9b0b3bd73b7034ef290fbeaf6aa7a66441 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-06 Thread via GitHub
hudi-bot commented on PR #11131: URL: https://github.com/apache/hudi/pull/11131#issuecomment-2096181036 ## CI report: * 1a5e0d9b0b3bd73b7034ef290fbeaf6aa7a66441 Azure:

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-06 Thread via GitHub
hudi-bot commented on PR #11131: URL: https://github.com/apache/hudi/pull/11131#issuecomment-2096163440 ## CI report: * 834aad2a8b073a221e68fb3c960200f684b84dfd Azure:

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-02 Thread via GitHub
hudi-bot commented on PR #11131: URL: https://github.com/apache/hudi/pull/11131#issuecomment-2091884462 ## CI report: * 834aad2a8b073a221e68fb3c960200f684b84dfd Azure:

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-02 Thread via GitHub
hudi-bot commented on PR #11131: URL: https://github.com/apache/hudi/pull/11131#issuecomment-2091820661 ## CI report: * c0a81f2890f9b066738fdf74cad9edf79cae0fda Azure:

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-02 Thread via GitHub
hudi-bot commented on PR #11131: URL: https://github.com/apache/hudi/pull/11131#issuecomment-2091675567 ## CI report: * c0a81f2890f9b066738fdf74cad9edf79cae0fda Azure:

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-02 Thread via GitHub
hudi-bot commented on PR #11131: URL: https://github.com/apache/hudi/pull/11131#issuecomment-2091556390 ## CI report: * c0a81f2890f9b066738fdf74cad9edf79cae0fda Azure:

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-02 Thread via GitHub
hudi-bot commented on PR #11131: URL: https://github.com/apache/hudi/pull/11131#issuecomment-2091448728 ## CI report: * b88fa88e1a946edf8da8f0686345fe06fd0f55ce Azure:

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-02 Thread via GitHub
hudi-bot commented on PR #11131: URL: https://github.com/apache/hudi/pull/11131#issuecomment-2091343002 ## CI report: * b88fa88e1a946edf8da8f0686345fe06fd0f55ce Azure:

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-02 Thread via GitHub
jonvex commented on code in PR #11131: URL: https://github.com/apache/hudi/pull/11131#discussion_r1588149891 ## hudi-common/src/test/java/org/apache/hudi/common/testutils/HoodieTestUtils.java: ## @@ -68,7 +68,8 @@ public class HoodieTestUtils { public static final String[]

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-02 Thread via GitHub
hudi-bot commented on PR #11131: URL: https://github.com/apache/hudi/pull/11131#issuecomment-2091284841 ## CI report: * b88fa88e1a946edf8da8f0686345fe06fd0f55ce Azure:

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-02 Thread via GitHub
jonvex commented on code in PR #11131: URL: https://github.com/apache/hudi/pull/11131#discussion_r1588149891 ## hudi-common/src/test/java/org/apache/hudi/common/testutils/HoodieTestUtils.java: ## @@ -68,7 +68,8 @@ public class HoodieTestUtils { public static final String[]

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-02 Thread via GitHub
hudi-bot commented on PR #11131: URL: https://github.com/apache/hudi/pull/11131#issuecomment-2091205515 ## CI report: * 4e4a01a12bc7022fee11414a3b6be9e72e4a18dc Azure:

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-02 Thread via GitHub
hudi-bot commented on PR #11131: URL: https://github.com/apache/hudi/pull/11131#issuecomment-2091191554 ## CI report: * 4e4a01a12bc7022fee11414a3b6be9e72e4a18dc Azure:

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-02 Thread via GitHub
hudi-bot commented on PR #11131: URL: https://github.com/apache/hudi/pull/11131#issuecomment-2091177439 ## CI report: * 4e4a01a12bc7022fee11414a3b6be9e72e4a18dc UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-02 Thread via GitHub
hudi-bot commented on PR #11131: URL: https://github.com/apache/hudi/pull/11131#issuecomment-2091097360 ## CI report: * d1de8c5240cf8f3695303a6e118538a87dea82a8 UNKNOWN * 4e4a01a12bc7022fee11414a3b6be9e72e4a18dc Azure:

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-02 Thread via GitHub
hudi-bot commented on PR #11131: URL: https://github.com/apache/hudi/pull/11131#issuecomment-2091083909 ## CI report: * d1de8c5240cf8f3695303a6e118538a87dea82a8 UNKNOWN * 50b743df39f533e7824741d997f0981cb2f8b32c Azure:

Re: [PR] [HUDI-7587] Make bundle dependencies for storage abstraction in correct order [hudi]

2024-05-02 Thread via GitHub
hudi-bot commented on PR #11131: URL: https://github.com/apache/hudi/pull/11131#issuecomment-2090939013 ## CI report: * d1de8c5240cf8f3695303a6e118538a87dea82a8 UNKNOWN * 50b743df39f533e7824741d997f0981cb2f8b32c Azure:

  1   2   >