David-N-Perkins commented on code in PR #11727:
URL: https://github.com/apache/hudi/pull/11727#discussion_r1779498859
##
hudi-flink-datasource/hudi-flink1.18.x/src/main/java/org/apache/hudi/table/format/cow/ParquetSplitReaderUtil.java:
##
@@ -546,15 +615,30 @@ private static Wri
danny0405 commented on code in PR #11727:
URL: https://github.com/apache/hudi/pull/11727#discussion_r1779312862
##
hudi-flink-datasource/hudi-flink1.18.x/src/main/java/org/apache/hudi/table/format/cow/ParquetSplitReaderUtil.java:
##
@@ -282,12 +286,23 @@ private static ColumnVec
danny0405 commented on code in PR #11727:
URL: https://github.com/apache/hudi/pull/11727#discussion_r1779312050
##
hudi-flink-datasource/hudi-flink1.18.x/src/main/java/org/apache/hudi/table/format/cow/ParquetSplitReaderUtil.java:
##
@@ -546,15 +615,30 @@ private static WritableC
danny0405 commented on code in PR #11727:
URL: https://github.com/apache/hudi/pull/11727#discussion_r1779307568
##
hudi-client/hudi-flink-client/src/test/java/org/apache/hudi/io/storage/row/parquet/TestParquetSchemaConverter.java:
##
@@ -50,7 +50,7 @@ void testConvertComplexType
hudi-bot commented on PR #11727:
URL: https://github.com/apache/hudi/pull/11727#issuecomment-2378431494
## CI report:
* 53977f3241ead8f22c26372a5f88ab19bcce63fb Azure:
[SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=814)
hudi-bot commented on PR #11727:
URL: https://github.com/apache/hudi/pull/11727#issuecomment-2378375324
## CI report:
* b1242af2f8445058dbafe0747c3cc9c8ee9de6de Azure:
[FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=807)
hudi-bot commented on PR #11727:
URL: https://github.com/apache/hudi/pull/11727#issuecomment-2378374237
## CI report:
* b1242af2f8445058dbafe0747c3cc9c8ee9de6de Azure:
[FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=807)
hudi-bot commented on PR #11727:
URL: https://github.com/apache/hudi/pull/11727#issuecomment-2378294716
## CI report:
* b1242af2f8445058dbafe0747c3cc9c8ee9de6de Azure:
[FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=807)
hudi-bot commented on PR #11727:
URL: https://github.com/apache/hudi/pull/11727#issuecomment-2378225151
## CI report:
* b53a85428c17a226ba18c7baf1ca2a55a9f09cf8 Azure:
[SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=783)
hudi-bot commented on PR #11727:
URL: https://github.com/apache/hudi/pull/11727#issuecomment-2378224007
## CI report:
* b53a85428c17a226ba18c7baf1ca2a55a9f09cf8 Azure:
[SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=783)
hudi-bot commented on PR #11727:
URL: https://github.com/apache/hudi/pull/11727#issuecomment-2374315681
## CI report:
* b53a85428c17a226ba18c7baf1ca2a55a9f09cf8 Azure:
[SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=783)
hudi-bot commented on PR #11727:
URL: https://github.com/apache/hudi/pull/11727#issuecomment-2374113194
## CI report:
* ef78ab357ee9447de7a52a6b2904773e1645b106 Azure:
[SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=741)
hudi-bot commented on PR #11727:
URL: https://github.com/apache/hudi/pull/11727#issuecomment-2374109414
## CI report:
* ef78ab357ee9447de7a52a6b2904773e1645b106 Azure:
[SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=741)
hudi-bot commented on PR #11727:
URL: https://github.com/apache/hudi/pull/11727#issuecomment-2371376110
## CI report:
* ef78ab357ee9447de7a52a6b2904773e1645b106 Azure:
[SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=741)
hudi-bot commented on PR #11727:
URL: https://github.com/apache/hudi/pull/11727#issuecomment-2371195556
## CI report:
* 61ea65a8e70a59ee409f8fa2d80dc8be7893ae20 Azure:
[SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=724)
hudi-bot commented on PR #11727:
URL: https://github.com/apache/hudi/pull/11727#issuecomment-2371192263
## CI report:
* 61ea65a8e70a59ee409f8fa2d80dc8be7893ae20 Azure:
[SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=724)
danny0405 commented on PR #11727:
URL: https://github.com/apache/hudi/pull/11727#issuecomment-2369912416
Still there is compile error:
```java
Error:
src/main/java/org/apache/hudi/io/storage/row/parquet/ParquetSchemaConverter.java:[636,38]
(whitespace) ParenPad: '(' is followed b
hudi-bot commented on PR #11727:
URL: https://github.com/apache/hudi/pull/11727#issuecomment-2368304171
## CI report:
* 61ea65a8e70a59ee409f8fa2d80dc8be7893ae20 Azure:
[SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=724)
hudi-bot commented on PR #11727:
URL: https://github.com/apache/hudi/pull/11727#issuecomment-2368073332
## CI report:
* e08c6cfae2b9ea5d3f645edc11519d18f42557ff Azure:
[SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=693)
hudi-bot commented on PR #11727:
URL: https://github.com/apache/hudi/pull/11727#issuecomment-2368070009
## CI report:
* e08c6cfae2b9ea5d3f645edc11519d18f42557ff Azure:
[SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=693)
danny0405 commented on PR #11727:
URL: https://github.com/apache/hudi/pull/11727#issuecomment-2367104964
@David-N-Perkins I have no access to your focked repo, here is a patch to
fix the checkstyle error:
[Fix_checkstyle_errors.patch.zip](https://github.com/user-attachments/files/1709208
danny0405 commented on PR #11727:
URL: https://github.com/apache/hudi/pull/11727#issuecomment-2367078940
> Do I need to copy these changes to the other Flink versions?
yeah, we should but in separate PR, let's make this one solid first.
--
This is an automated message from the Apach
David-N-Perkins commented on PR #11727:
URL: https://github.com/apache/hudi/pull/11727#issuecomment-2367033160
Do I need to copy these changes to the other Flink versions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
hudi-bot commented on PR #11727:
URL: https://github.com/apache/hudi/pull/11727#issuecomment-2367003902
## CI report:
* e08c6cfae2b9ea5d3f645edc11519d18f42557ff Azure:
[SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=693)
hudi-bot commented on PR #11727:
URL: https://github.com/apache/hudi/pull/11727#issuecomment-2366983434
## CI report:
* a3f5fc8ad58d9c6e4b6e3736a9cf9b352213e837 Azure:
[CANCELED](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=691)
hudi-bot commented on PR #11727:
URL: https://github.com/apache/hudi/pull/11727#issuecomment-2366967462
## CI report:
* a3f5fc8ad58d9c6e4b6e3736a9cf9b352213e837 Azure:
[CANCELED](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=691)
hudi-bot commented on PR #11727:
URL: https://github.com/apache/hudi/pull/11727#issuecomment-2366967028
## CI report:
* d1fb6b57829bba0b45d4a609cab92a654b76ca96 Azure:
[FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=669)
David-N-Perkins commented on code in PR #11727:
URL: https://github.com/apache/hudi/pull/11727#discussion_r1770636387
##
hudi-flink-datasource/hudi-flink1.18.x/src/main/java/org/apache/hudi/table/format/cow/ParquetSplitReaderUtil.java:
##
@@ -546,15 +606,30 @@ private static Wri
David-N-Perkins commented on code in PR #11727:
URL: https://github.com/apache/hudi/pull/11727#discussion_r1770635705
##
hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/table/TestHoodieTableSource.java:
##
@@ -151,6 +159,91 @@ void testGetTableAvroSchema() {
hudi-bot commented on PR #11727:
URL: https://github.com/apache/hudi/pull/11727#issuecomment-2366963223
## CI report:
* d1fb6b57829bba0b45d4a609cab92a654b76ca96 Azure:
[FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=669)
hudi-bot commented on PR #11727:
URL: https://github.com/apache/hudi/pull/11727#issuecomment-2366962521
## CI report:
* d1fb6b57829bba0b45d4a609cab92a654b76ca96 Azure:
[FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=669)
danny0405 commented on PR #11727:
URL: https://github.com/apache/hudi/pull/11727#issuecomment-2365382994
Hmm, there is a test failure:
```java
TestParquetSchemaConverter.testConvertComplexTypes:72
Expected: is "message converted {\n optional group f_array (LIST) {\n
repeate
hudi-bot commented on PR #11727:
URL: https://github.com/apache/hudi/pull/11727#issuecomment-2365342330
## CI report:
* d1fb6b57829bba0b45d4a609cab92a654b76ca96 Azure:
[FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=669)
hudi-bot commented on PR #11727:
URL: https://github.com/apache/hudi/pull/11727#issuecomment-2365325196
## CI report:
* e9d0cf057174b8558d547af5268820d55af0e6ec Azure:
[SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=25
hudi-bot commented on PR #11727:
URL: https://github.com/apache/hudi/pull/11727#issuecomment-2365324817
## CI report:
* e9d0cf057174b8558d547af5268820d55af0e6ec Azure:
[SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=25
David-N-Perkins commented on PR #11727:
URL: https://github.com/apache/hudi/pull/11727#issuecomment-2343499063
I added unit tests to `ITTestHoodieDataSource` and uncovered an issue with
inconsistent Parquet schemas when performing an `insert` vs `upsert`. I spoke
with @danny0405 about this
yihua commented on PR #11727:
URL: https://github.com/apache/hudi/pull/11727#issuecomment-2342683619
@David-N-Perkins any updates on addressing the comments on the PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
danny0405 commented on code in PR #11727:
URL: https://github.com/apache/hudi/pull/11727#discussion_r1704798193
##
hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/utils/TestData.java:
##
@@ -413,6 +419,139 @@ public class TestData {
TimestampData.from
danny0405 commented on code in PR #11727:
URL: https://github.com/apache/hudi/pull/11727#discussion_r1704794304
##
hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/table/TestHoodieTableSource.java:
##
@@ -151,6 +159,91 @@ void testGetTableAvroSchema() {
assert
hudi-bot commented on PR #11727:
URL: https://github.com/apache/hudi/pull/11727#issuecomment-2269750622
## CI report:
* e9d0cf057174b8558d547af5268820d55af0e6ec Azure:
[SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=25
hudi-bot commented on PR #11727:
URL: https://github.com/apache/hudi/pull/11727#issuecomment-2269574107
## CI report:
* e9d0cf057174b8558d547af5268820d55af0e6ec Azure:
[PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=25
hudi-bot commented on PR #11727:
URL: https://github.com/apache/hudi/pull/11727#issuecomment-2269559482
## CI report:
* e9d0cf057174b8558d547af5268820d55af0e6ec UNKNOWN
Bot commands
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run th
David-N-Perkins opened a new pull request, #11727:
URL: https://github.com/apache/hudi/pull/11727
### Change Logs
Added support for Array of Rows and Maps with Row values in Flink. Only
supports nesting 1 level deep. The Row cannot contain another Array or Map.
I've only appli
43 matches
Mail list logo
