KnightChess commented on PR #11568:
URL: https://github.com/apache/hudi/pull/11568#issuecomment-2223061487
@codope if specified, look like work well.
https://github.com/apache/hudi/assets/20125927/9ab0f7b8-76d1-4281-b693-bc1de1e412cc";>
--
This is an automated message from the Apach
KnightChess commented on PR #11568:
URL: https://github.com/apache/hudi/pull/11568#issuecomment-2223023363
@codope got it o(￣▽￣)o
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
codope commented on PR #11568:
URL: https://github.com/apache/hudi/pull/11568#issuecomment-998105
@KnightChess Yes it is not due to this PR. I just tested by creating a
parquet table and it's still the same behavior. So, issue is something
unrelated to Hudi. You could try as well:
``
KnightChess commented on PR #11568:
URL: https://github.com/apache/hudi/pull/11568#issuecomment-856656
@codope hi, need specified like `insert into aaa (id, day, price, name,
hour) values (2, '01', 12.2, 'bbb', '02')` will trigger this logical, but you
case not specified columns, and I
codope commented on PR #11568:
URL: https://github.com/apache/hudi/pull/11568#issuecomment-779094
@KnightChess Looks like this PR does not handle partition spec? Can you
please check HUDI-7964?
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
danny0405 merged PR #11568:
URL: https://github.com/apache/hudi/pull/11568
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apac
leesf commented on PR #11568:
URL: https://github.com/apache/hudi/pull/11568#issuecomment-2212620852
LGTM, with minor comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
leesf commented on code in PR #11568:
URL: https://github.com/apache/hudi/pull/11568#discussion_r1667793800
##
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/dml/TestInsertTable.scala:
##
@@ -2826,4 +2826,163 @@ class TestInsertTable extends HoodieSpar
leesf commented on code in PR #11568:
URL: https://github.com/apache/hudi/pull/11568#discussion_r1667793749
##
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/dml/TestInsertTable.scala:
##
@@ -2826,4 +2826,163 @@ class TestInsertTable extends HoodieSpar
danny0405 commented on PR #11568:
URL: https://github.com/apache/hudi/pull/11568#issuecomment-2212278490
@leesf Do you have intreast to reivew this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
hudi-bot commented on PR #11568:
URL: https://github.com/apache/hudi/pull/11568#issuecomment-2211780369
## CI report:
* a0ee4874c79268370a765067614fbfa8797d0f0b Azure:
[SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24
hudi-bot commented on PR #11568:
URL: https://github.com/apache/hudi/pull/11568#issuecomment-2211756816
## CI report:
* 19a29026785304260e8c534e9e1edc80aa0c1e9b Azure:
[SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24
hudi-bot commented on PR #11568:
URL: https://github.com/apache/hudi/pull/11568#issuecomment-2211755305
## CI report:
* 19a29026785304260e8c534e9e1edc80aa0c1e9b Azure:
[SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24
KnightChess commented on code in PR #11568:
URL: https://github.com/apache/hudi/pull/11568#discussion_r1667357115
##
hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/analysis/HoodieAnalysis.scala:
##
@@ -408,12 +408,20 @@ case class ResolveImplementation
danny0405 commented on code in PR #11568:
URL: https://github.com/apache/hudi/pull/11568#discussion_r1667210894
##
hudi-spark-datasource/hudi-spark3.1.x/src/main/scala/org/apache/spark/sql/HoodieSpark31CatalystPlanUtils.scala:
##
@@ -83,4 +82,13 @@ object HoodieSpark31CatalystPl
danny0405 commented on code in PR #11568:
URL: https://github.com/apache/hudi/pull/11568#discussion_r1667210845
##
hudi-spark-datasource/hudi-spark3-common/src/main/scala/org/apache/spark/sql/HoodieSpark3CatalystPlanUtils.scala:
##
@@ -56,15 +57,6 @@ trait HoodieSpark3CatalystPl
danny0405 commented on code in PR #11568:
URL: https://github.com/apache/hudi/pull/11568#discussion_r1667210673
##
hudi-spark-datasource/hudi-spark2/src/main/scala/org/apache/spark/sql/HoodieSpark2CatalystPlanUtils.scala:
##
@@ -61,10 +61,10 @@ object HoodieSpark2CatalystPlanUti
danny0405 commented on code in PR #11568:
URL: https://github.com/apache/hudi/pull/11568#discussion_r1667210457
##
hudi-client/hudi-spark-client/src/main/scala/org/apache/spark/sql/HoodieCatalystPlansUtils.scala:
##
@@ -112,7 +113,7 @@ trait HoodieCatalystPlansUtils {
* Deco
danny0405 commented on code in PR #11568:
URL: https://github.com/apache/hudi/pull/11568#discussion_r1667210583
##
hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/analysis/HoodieAnalysis.scala:
##
@@ -408,12 +408,20 @@ case class ResolveImplementationsE
hudi-bot commented on PR #11568:
URL: https://github.com/apache/hudi/pull/11568#issuecomment-2209094499
## CI report:
* 19a29026785304260e8c534e9e1edc80aa0c1e9b Azure:
[SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24
hudi-bot commented on PR #11568:
URL: https://github.com/apache/hudi/pull/11568#issuecomment-2208847684
## CI report:
* 19a29026785304260e8c534e9e1edc80aa0c1e9b Azure:
[PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24
hudi-bot commented on PR #11568:
URL: https://github.com/apache/hudi/pull/11568#issuecomment-2208830193
## CI report:
* 19a29026785304260e8c534e9e1edc80aa0c1e9b UNKNOWN
Bot commands
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run th
KnightChess opened a new pull request, #11568:
URL: https://github.com/apache/hudi/pull/11568
as #11552 describe, hoodie insert not support column specified, support this
case:
- user can specified column order when insert into/overwrite
### Change Logs
only support spark ve
23 matches
Mail list logo
