Re: [PR] [HUDI-7958] Create partition stats index for all columns when no cols specified [hudi]

2024-07-25 Thread via GitHub
yihua commented on code in PR #11579: URL: https://github.com/apache/hudi/pull/11579#discussion_r1692356320 ## hudi-common/src/main/java/org/apache/hudi/common/config/HoodieMetadataConfig.java: ## @@ -332,7 +332,7 @@ public final class HoodieMetadataConfig extends HoodieConfig

Re: [PR] [HUDI-7958] Create partition stats index for all columns when no cols specified [hudi]

2024-07-25 Thread via GitHub
yihua commented on PR #11579: URL: https://github.com/apache/hudi/pull/11579#issuecomment-2251769299 > I really feel we should cut down on the no of cols we generate stats out of the box. I have encountered OSS users give col stats a try and since it takes lot of time to populate col stats

Re: [PR] [HUDI-7958] Create partition stats index for all columns when no cols specified [hudi]

2024-07-05 Thread via GitHub
hudi-bot commented on PR #11579: URL: https://github.com/apache/hudi/pull/11579#issuecomment-2211188134 ## CI report: * 25c6ae81e406de37846d79655e8949e49eef6806 Azure:

Re: [PR] [HUDI-7958] Create partition stats index for all columns when no cols specified [hudi]

2024-07-05 Thread via GitHub
hudi-bot commented on PR #11579: URL: https://github.com/apache/hudi/pull/11579#issuecomment-2211139635 ## CI report: * 25c6ae81e406de37846d79655e8949e49eef6806 Azure:

Re: [PR] [HUDI-7958] Create partition stats index for all columns when no cols specified [hudi]

2024-07-05 Thread via GitHub
hudi-bot commented on PR #11579: URL: https://github.com/apache/hudi/pull/11579#issuecomment-2211130646 ## CI report: * 25c6ae81e406de37846d79655e8949e49eef6806 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run

Re: [PR] [HUDI-7958] Create partition stats index for all columns when no cols specified [hudi]

2024-07-05 Thread via GitHub
nsivabalan commented on code in PR #11579: URL: https://github.com/apache/hudi/pull/11579#discussion_r1666960268 ## hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestPartitionStatsIndexWithSql.scala: ## @@ -261,41 +261,75 @@ class

Re: [PR] [HUDI-7958] Create partition stats index for all columns when no cols specified [hudi]

2024-07-05 Thread via GitHub
nsivabalan commented on code in PR #11579: URL: https://github.com/apache/hudi/pull/11579#discussion_r1666955280 ## hudi-common/src/main/java/org/apache/hudi/common/config/HoodieMetadataConfig.java: ## @@ -332,7 +332,7 @@ public final class HoodieMetadataConfig extends

Re: [PR] [HUDI-7958] Create partition stats index for all columns when no cols specified [hudi]

2024-07-05 Thread via GitHub
nsivabalan commented on PR #11579: URL: https://github.com/apache/hudi/pull/11579#issuecomment-2211095975 I really feel we should cut down on the no of cols we generate stats out of the box. I have encountered OSS users give col stats a try and since it takes lot of time to populate col

Re: [PR] [HUDI-7958] Create partition stats index for all columns when no cols specified [hudi]

2024-07-05 Thread via GitHub
codope commented on code in PR #11579: URL: https://github.com/apache/hudi/pull/11579#discussion_r1666935047 ## hudi-common/src/main/java/org/apache/hudi/common/config/HoodieMetadataConfig.java: ## @@ -332,7 +332,7 @@ public final class HoodieMetadataConfig extends

[PR] [HUDI-7958] Create partition stats index for all columns when no cols specified [hudi]

2024-07-05 Thread via GitHub
codope opened a new pull request, #11579: URL: https://github.com/apache/hudi/pull/11579 ### Change Logs Just like column stats index, we can create partition stats index for all column if no columns configured by the user. ### Impact Users don't necessarily have to