Re: [PR] [MINOR] Removing dead code in HiveAvroSerializer [hudi]

2024-07-07 Thread via GitHub
voonhous closed pull request #11577: [MINOR] Removing dead code in HiveAvroSerializer URL: https://github.com/apache/hudi/pull/11577 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] [MINOR] Removing dead code in HiveAvroSerializer [hudi]

2024-07-07 Thread via GitHub
voonhous commented on PR #11577: URL: https://github.com/apache/hudi/pull/11577#issuecomment-2213126024 Sure, will close this then. I'll revisit this again when i have time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [MINOR] Removing dead code in HiveAvroSerializer [hudi]

2024-07-07 Thread via GitHub
hudi-bot commented on PR #11577: URL: https://github.com/apache/hudi/pull/11577#issuecomment-2213055271 ## CI report: * fd1ddca4e5c2b2da638e2548a03de76019ba3988 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24

Re: [PR] [MINOR] Removing dead code in HiveAvroSerializer [hudi]

2024-07-07 Thread via GitHub
hudi-bot commented on PR #11577: URL: https://github.com/apache/hudi/pull/11577#issuecomment-2212998667 ## CI report: * 17c4b4993200ae1c91ca9fd4548c5313fc533a7c Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24

Re: [PR] [MINOR] Removing dead code in HiveAvroSerializer [hudi]

2024-07-07 Thread via GitHub
danny0405 commented on PR #11577: URL: https://github.com/apache/hudi/pull/11577#issuecomment-2212995870 > @danny0405 I checked the code and realised that the reason why the tests were failing because the `DATE` column is defined with an INT type in `org.apache.hudi.common.testutils.HoodieT

Re: [PR] [MINOR] Removing dead code in HiveAvroSerializer [hudi]

2024-07-07 Thread via GitHub
hudi-bot commented on PR #11577: URL: https://github.com/apache/hudi/pull/11577#issuecomment-2212932363 ## CI report: * 17c4b4993200ae1c91ca9fd4548c5313fc533a7c Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24

Re: [PR] [MINOR] Removing dead code in HiveAvroSerializer [hudi]

2024-07-07 Thread via GitHub
voonhous commented on PR #11577: URL: https://github.com/apache/hudi/pull/11577#issuecomment-2212920904 @danny0405 I checked the code and realised that the reason why the tests were failing because the `DATE` column is defined with an INT type in `org.apache.hudi.common.testutils.HoodieTest

Re: [PR] [MINOR] Removing dead code in HiveAvroSerializer [hudi]

2024-07-06 Thread via GitHub
voonhous commented on PR #11577: URL: https://github.com/apache/hudi/pull/11577#issuecomment-2211690471 Will check on it and ping you again. Seems like my initial claim of this section being no longer required is wrong, let me confirm this. -- This is an automated message from the Apache

Re: [PR] [MINOR] Removing dead code in HiveAvroSerializer [hudi]

2024-07-05 Thread via GitHub
danny0405 commented on PR #11577: URL: https://github.com/apache/hudi/pull/11577#issuecomment-2211530303 Thanks for the contribution, can you check the Azure CI failures? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] [MINOR] Removing dead code in HiveAvroSerializer [hudi]

2024-07-05 Thread via GitHub
hudi-bot commented on PR #11577: URL: https://github.com/apache/hudi/pull/11577#issuecomment-2210770009 ## CI report: * 17c4b4993200ae1c91ca9fd4548c5313fc533a7c Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24

Re: [PR] [MINOR] Removing dead code in HiveAvroSerializer [hudi]

2024-07-05 Thread via GitHub
hudi-bot commented on PR #11577: URL: https://github.com/apache/hudi/pull/11577#issuecomment-2210708630 ## CI report: * 17c4b4993200ae1c91ca9fd4548c5313fc533a7c Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=24

Re: [PR] [MINOR] Removing dead code in HiveAvroSerializer [hudi]

2024-07-05 Thread via GitHub
hudi-bot commented on PR #11577: URL: https://github.com/apache/hudi/pull/11577#issuecomment-2210698559 ## CI report: * 17c4b4993200ae1c91ca9fd4548c5313fc533a7c UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run th

[PR] [MINOR] Removing dead code in HiveAvroSerializer [hudi]

2024-07-05 Thread via GitHub
voonhous opened a new pull request, #11577: URL: https://github.com/apache/hudi/pull/11577 ### Change Logs Removing the case `INT` + **DATE** if - block as **DATE** types from the Hive related entrypoints will have a **DATE** `PrmitiveFieldObjectInspector` type. ![image](http