[
https://issues.apache.org/jira/browse/HUDI-781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17133539#comment-17133539
]
Vinoth Chandar commented on HUDI-781:
-
One thing to be careful about when deciding mocks vs functional
[
https://issues.apache.org/jira/browse/HUDI-781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17130049#comment-17130049
]
Nishith Agarwal commented on HUDI-781:
--
[~pwason] Can you help with #2 ? Like we talked about, mocks
[
https://issues.apache.org/jira/browse/HUDI-781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17129642#comment-17129642
]
Raymond Xu commented on HUDI-781:
-
[~vinoth] Make sense. I've paused #1 as it's targeting from a different
[
https://issues.apache.org/jira/browse/HUDI-781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17129248#comment-17129248
]
Vinoth Chandar commented on HUDI-781:
-
Sounds good overall.. I would suggest we get a head start in #5
[
https://issues.apache.org/jira/browse/HUDI-781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17128778#comment-17128778
]
Raymond Xu commented on HUDI-781:
-
[~yanghua] [~yanghua] [~nishith29] [~garyli1019]
Here is an execution
[
https://issues.apache.org/jira/browse/HUDI-781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17086739#comment-17086739
]
Raymond Xu commented on HUDI-781:
-
[~vinoth][~yanghua]Thank you for the feedbacks. Created
[
https://issues.apache.org/jira/browse/HUDI-781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083724#comment-17083724
]
vinoyang commented on HUDI-781:
---
+1 to distinguish the pure unit tests and engine-binding tests, this action
[
https://issues.apache.org/jira/browse/HUDI-781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083624#comment-17083624
]
Vinoth Chandar commented on HUDI-781:
-
+1 ... I would also add having the unit tests mirror the package
[
https://issues.apache.org/jira/browse/HUDI-781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083451#comment-17083451
]
Raymond Xu commented on HUDI-781:
-
[~vinothchandar] [~yanghua] Before we consider re-design some test
