(ignite-3) branch main updated: IGNITE-22268 Add checkstyle rule for package names (#3783)

[apkhmv]

This is an automated email from the ASF dual-hosted git repository.

apkhmv pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/ignite-3.git


The following commit(s) were added to refs/heads/main by this push:
     new 426b355d6c IGNITE-22268 Add checkstyle rule for package names (#3783)
426b355d6c is described below

commit 426b355d6ce841482c8022378bd8ef698f73e1e6
Author: Vadim Pakhnushev <8614891+valep...@users.noreply.github.com>
AuthorDate: Fri May 17 13:53:08 2024 +0300

    IGNITE-22268 Add checkstyle rule for package names (#3783)
---
 check-rules/checkstyle-rules.xml                         | 16 +++++++++-------
 .../ignite/internal/{ => hlc}/HybridClockTest.java       |  6 +-----
 .../ignite/internal/{ => hlc}/HybridClockTestUtils.java  |  0
 3 files changed, 10 insertions(+), 12 deletions(-)

diff --git a/check-rules/checkstyle-rules.xml b/check-rules/checkstyle-rules.xml
index 0699d220f8..8ca542715d 100644
--- a/check-rules/checkstyle-rules.xml
+++ b/check-rules/checkstyle-rules.xml
@@ -39,11 +39,11 @@
 
   <property name="fileExtensions" value="java, properties, xml"/>
   <!-- Excludes all 'module-info.java' files              -->
-  <!-- See https://checkstyle.org/config_filefilters.html -->
+  <!-- See 
https://checkstyle.org/filefilters/beforeexecutionexclusionfilefilter.html -->
   <module name="BeforeExecutionExclusionFileFilter">
     <property name="fileNamePattern" value="module\-info\.java$"/>
   </module>
-  <!-- https://checkstyle.org/config_filters.html#SuppressionFilter -->
+  <!-- https://checkstyle.org/filters/suppressionfilter.html -->
   <module name="SuppressionFilter">
     <property name="file" 
value="${org.checkstyle.google.suppressionfilter.config}"
            default="checkstyle-suppressions.xml" />
@@ -51,7 +51,7 @@
   </module>
 
   <!-- Checks for whitespace                               -->
-  <!-- See http://checkstyle.org/config_whitespace.html -->
+  <!-- https://checkstyle.org/checks/whitespace/filetabcharacter.html -->
   <module name="FileTabCharacter">
     <property name="eachLine" value="true"/>
   </module>
@@ -63,7 +63,7 @@
   </module>
 
   <module name="TreeWalker">
-    <!-- Import Checks. See: 
http://checkstyle.sourceforge.net/config_imports.html -->
+    <!-- Import Checks. See: 
https://checkstyle.org/checks/imports/unusedimports.html -->
     <module name="UnusedImports"/>
 
     <module name="OuterTypeFilename"/>
@@ -116,7 +116,7 @@
                     COMPACT_CTOR_DEF"/>
     </module>
     <module name="SuppressionXpathSingleFilter">
-      <!-- suppresion is required till 
https://github.com/checkstyle/checkstyle/issues/7541 -->
+      <!-- suppression is required till 
https://github.com/checkstyle/checkstyle/issues/7541 -->
       <property name="id" value="RightCurlyAlone"/>
       <property name="query" value="//RCURLY[parent::SLIST[count(./*)=1]
                                      or 
preceding-sibling::*[last()][self::LCURLY]]"/>
@@ -382,14 +382,16 @@
       <property name="format" 
value="^(?!CHECKSTYLE:ON)(?!noinspection)(?!---)(?!===)([^\s\/*])"/>
       <message key="todo.match" value="Comment text should start with space."/>
     </module>
-    <!-- https://checkstyle.org/config_filters.html#SuppressionXpathFilter -->
+    <!-- https://checkstyle.org/filters/suppressionxpathfilter.html -->
     <module name="SuppressionXpathFilter">
       <property name="file" 
value="${org.checkstyle.google.suppressionxpathfilter.config}"
              default="checkstyle-xpath-suppressions.xml" />
       <property name="optional" value="true"/>
     </module>
-    <!-- https://checkstyle.org/config_filters.html#SuppressionCommentFilter 
-->
+    <!-- https://checkstyle.org/filters/suppressioncommentfilter.html -->
     <module name="SuppressionCommentFilter"/>
+    <!-- https://checkstyle.org/checks/coding/packagedeclaration.html -->
+    <module name="PackageDeclaration"/>
   </module>
   <module name="Header">
     <property name="headerFile" value="${checkstyle.header.file}" 
default="LICENSE.txt"/>
diff --git 
a/modules/core/src/test/java/org/apache/ignite/internal/HybridClockTest.java 
b/modules/core/src/test/java/org/apache/ignite/internal/hlc/HybridClockTest.java
similarity index 95%
rename from 
modules/core/src/test/java/org/apache/ignite/internal/HybridClockTest.java
rename to 
modules/core/src/test/java/org/apache/ignite/internal/hlc/HybridClockTest.java
index a0ee0af6c6..b0ba0e4afe 100644
--- a/modules/core/src/test/java/org/apache/ignite/internal/HybridClockTest.java
+++ 
b/modules/core/src/test/java/org/apache/ignite/internal/hlc/HybridClockTest.java
@@ -15,7 +15,7 @@
  * limitations under the License.
  */
 
-package org.apache.ignite.internal;
+package org.apache.ignite.internal.hlc;
 
 import static 
org.apache.ignite.internal.hlc.HybridClockTestUtils.mockToEpochMilli;
 import static org.junit.jupiter.api.Assertions.assertEquals;
@@ -26,10 +26,6 @@ import static org.mockito.Mockito.verify;
 import java.time.Clock;
 import java.util.concurrent.TimeUnit;
 import java.util.function.Supplier;
-import org.apache.ignite.internal.hlc.ClockUpdateListener;
-import org.apache.ignite.internal.hlc.HybridClock;
-import org.apache.ignite.internal.hlc.HybridClockImpl;
-import org.apache.ignite.internal.hlc.HybridTimestamp;
 import org.apache.ignite.internal.testframework.BaseIgniteAbstractTest;
 import org.junit.jupiter.api.AfterEach;
 import org.junit.jupiter.api.Test;
diff --git 
a/modules/core/src/test/java/org/apache/ignite/internal/HybridClockTestUtils.java
 
b/modules/core/src/test/java/org/apache/ignite/internal/hlc/HybridClockTestUtils.java
similarity index 100%
rename from 
modules/core/src/test/java/org/apache/ignite/internal/HybridClockTestUtils.java
rename to 
modules/core/src/test/java/org/apache/ignite/internal/hlc/HybridClockTestUtils.java