Repository: knox Updated Branches: refs/heads/master fb0587976 -> 495369f98
KNOX-748 - Fix Resource Leak in X509CertificateUtil.writeCertificateToJKS (Sandeep More via lmccay) Project: http://git-wip-us.apache.org/repos/asf/knox/repo Commit: http://git-wip-us.apache.org/repos/asf/knox/commit/495369f9 Tree: http://git-wip-us.apache.org/repos/asf/knox/tree/495369f9 Diff: http://git-wip-us.apache.org/repos/asf/knox/diff/495369f9 Branch: refs/heads/master Commit: 495369f989e5b5d8307264b75411bb36ae6d45cb Parents: fb05879 Author: Larry McCay <lmc...@hortonworks.com> Authored: Tue Sep 6 07:19:06 2016 -0400 Committer: Larry McCay <lmc...@hortonworks.com> Committed: Tue Sep 6 07:19:06 2016 -0400 ---------------------------------------------------------------------- .../gateway/services/security/impl/X509CertificateUtil.java | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/knox/blob/495369f9/gateway-spi/src/main/java/org/apache/hadoop/gateway/services/security/impl/X509CertificateUtil.java ---------------------------------------------------------------------- diff --git a/gateway-spi/src/main/java/org/apache/hadoop/gateway/services/security/impl/X509CertificateUtil.java b/gateway-spi/src/main/java/org/apache/hadoop/gateway/services/security/impl/X509CertificateUtil.java index 9035b85..e31c7d8 100644 --- a/gateway-spi/src/main/java/org/apache/hadoop/gateway/services/security/impl/X509CertificateUtil.java +++ b/gateway-spi/src/main/java/org/apache/hadoop/gateway/services/security/impl/X509CertificateUtil.java @@ -294,10 +294,13 @@ public class X509CertificateUtil { char[] password = "changeme".toCharArray(); ks.load(null, password); ks.setCertificateEntry("gateway-identity", cert); - FileOutputStream fos = new FileOutputStream(file); - ks.store(fos, password); - fos.close(); + /* Coverity Scan CID 1361992 */ + try { + ks.store(fos, password); + } finally { + fos.close(); + } } }
