KYLIN-2213 minor code review
Project: http://git-wip-us.apache.org/repos/asf/kylin/repo Commit: http://git-wip-us.apache.org/repos/asf/kylin/commit/a2ecf18d Tree: http://git-wip-us.apache.org/repos/asf/kylin/tree/a2ecf18d Diff: http://git-wip-us.apache.org/repos/asf/kylin/diff/a2ecf18d Branch: refs/heads/master Commit: a2ecf18de8ceb73f6b2748cd3e1d7b43ac1ca8ac Parents: be7b5d1 Author: Li Yang <liy...@apache.org> Authored: Mon Nov 28 16:28:56 2016 +0800 Committer: Li Yang <liy...@apache.org> Committed: Mon Nov 28 16:28:56 2016 +0800 ---------------------------------------------------------------------- .../apache/kylin/dict/BuiltInFunctionTransformer.java | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/kylin/blob/a2ecf18d/core-dictionary/src/main/java/org/apache/kylin/dict/BuiltInFunctionTransformer.java ---------------------------------------------------------------------- diff --git a/core-dictionary/src/main/java/org/apache/kylin/dict/BuiltInFunctionTransformer.java b/core-dictionary/src/main/java/org/apache/kylin/dict/BuiltInFunctionTransformer.java index 0f8e895..f451c2c 100755 --- a/core-dictionary/src/main/java/org/apache/kylin/dict/BuiltInFunctionTransformer.java +++ b/core-dictionary/src/main/java/org/apache/kylin/dict/BuiltInFunctionTransformer.java @@ -89,12 +89,7 @@ public class BuiltInFunctionTransformer implements ITupleFilterTransformer { if (dict == null) return null; - CompareTupleFilter translated; - if (builtInFunctionTupleFilter.isReversed()) { - translated = new CompareTupleFilter(FilterOperatorEnum.NOTIN); - } else { - translated = new CompareTupleFilter(FilterOperatorEnum.IN); - } + CompareTupleFilter translated = new CompareTupleFilter(builtInFunctionTupleFilter.isReversed() ? FilterOperatorEnum.NOTIN : FilterOperatorEnum.IN); translated.addChild(new ColumnTupleFilter(columnRef)); try { @@ -126,12 +121,7 @@ public class BuiltInFunctionTransformer implements ITupleFilterTransformer { if (dict == null) return null; - CompareTupleFilter translated; - if (builtInFunctionTupleFilter.isReversed()) { - translated = new CompareTupleFilter(FilterOperatorEnum.NOTIN); - } else { - translated = new CompareTupleFilter(FilterOperatorEnum.IN); - } + CompareTupleFilter translated = new CompareTupleFilter(builtInFunctionTupleFilter.isReversed() ? FilterOperatorEnum.NOTIN : FilterOperatorEnum.IN); translated.addChild(new ColumnTupleFilter(columnRef)); try {
