Use try-with-resources.
Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/6fa48c56 Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/6fa48c56 Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/6fa48c56 Branch: refs/heads/LOG4J2-1161 Commit: 6fa48c56075c1f74b118a9166540fd570b45f0a5 Parents: 95e9bda Author: Matt Sicker <boa...@gmail.com> Authored: Wed Oct 21 01:08:05 2015 -0500 Committer: Matt Sicker <boa...@gmail.com> Committed: Wed Oct 21 01:08:05 2015 -0500 ---------------------------------------------------------------------- .../java/org/apache/logging/log4j/core/config/XIncludeTest.java | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/6fa48c56/log4j-core/src/test/java/org/apache/logging/log4j/core/config/XIncludeTest.java ---------------------------------------------------------------------- diff --git a/log4j-core/src/test/java/org/apache/logging/log4j/core/config/XIncludeTest.java b/log4j-core/src/test/java/org/apache/logging/log4j/core/config/XIncludeTest.java index 566081b..807e0cb 100644 --- a/log4j-core/src/test/java/org/apache/logging/log4j/core/config/XIncludeTest.java +++ b/log4j-core/src/test/java/org/apache/logging/log4j/core/config/XIncludeTest.java @@ -126,14 +126,11 @@ public class XIncludeTest { logger.debug("This is test message number {}", random); int count = 0; String line = Strings.EMPTY; - final BufferedReader in = new BufferedReader(new FileReader(this.logFileName)); - try { + try (BufferedReader in = new BufferedReader(new FileReader(this.logFileName))) { while (in.ready()) { ++count; line = in.readLine(); } - } finally { - in.close(); } assertThat(count, is(equalTo(1))); assertThat(line, endsWith(Long.toString(random)));