Use try-with-resources for JDBC resources. Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/b6ecddc5 Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/b6ecddc5 Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/b6ecddc5
Branch: refs/heads/LOG4J2-1553 Commit: b6ecddc584fc0339dad323b4da69d6fc76c50b33 Parents: c4962aa Author: Gary Gregory <ggreg...@apache.org> Authored: Sun Aug 28 13:33:35 2016 -0700 Committer: Gary Gregory <ggreg...@apache.org> Committed: Sun Aug 28 13:33:35 2016 -0700 ---------------------------------------------------------------------- .../core/appender/db/jpa/AbstractJpaAppenderTest.java | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/b6ecddc5/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/db/jpa/AbstractJpaAppenderTest.java ---------------------------------------------------------------------- diff --git a/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/db/jpa/AbstractJpaAppenderTest.java b/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/db/jpa/AbstractJpaAppenderTest.java index 8fb2aaa..b150f1e 100644 --- a/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/db/jpa/AbstractJpaAppenderTest.java +++ b/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/db/jpa/AbstractJpaAppenderTest.java @@ -68,18 +68,8 @@ public abstract class AbstractJpaAppenderTest { context.reconfigure(); StatusLogger.getLogger().reset(); - Statement statement = null; - try { - statement = this.connection.createStatement(); + try (Statement statement = this.connection.createStatement();) { statement.execute("SHUTDOWN"); - } finally { - try { - if (statement != null) { - statement.close(); - } - } catch (final SQLException ignore) { - /* */ - } } this.connection.close();
