This is an automated email from the ASF dual-hosted git repository.

khmarbaise pushed a commit to branch code-improvements
in repository https://gitbox.apache.org/repos/asf/maven-invoker-plugin.git

commit cb814ee9011b4c65f4e2ea3b6e38d43787b79d2d
Author: Karl Heinz Marbaise <khmarba...@apache.org>
AuthorDate: Sun Dec 31 16:02:41 2023 +0100

    Small code improvments.
---
 src/main/java/org/apache/maven/plugins/invoker/InvokerProperties.java | 4 ++--
 src/main/java/org/apache/maven/plugins/invoker/InvokerToolchain.java  | 2 +-
 src/main/java/org/apache/maven/plugins/invoker/JobExecutor.java       | 3 ++-
 3 files changed, 5 insertions(+), 4 deletions(-)

diff --git 
a/src/main/java/org/apache/maven/plugins/invoker/InvokerProperties.java 
b/src/main/java/org/apache/maven/plugins/invoker/InvokerProperties.java
index f4e510e..a315c55 100644
--- a/src/main/java/org/apache/maven/plugins/invoker/InvokerProperties.java
+++ b/src/main/java/org/apache/maven/plugins/invoker/InvokerProperties.java
@@ -88,7 +88,7 @@ class InvokerProperties {
     private enum SelectorProperty {
         JAVA_VERSION(".java.version"),
         MAVEN_VERSION(".maven.version"),
-        OS_FAMLY(".os.family");
+        OS_FAMILY(".os.family");
 
         private final String suffix;
 
@@ -281,7 +281,7 @@ class InvokerProperties {
      * @since 3.0.0
      */
     public String getOsFamily(int index) {
-        return this.properties.getProperty(SELECTOR_PREFIX + index + 
SelectorProperty.OS_FAMLY, getOsFamily());
+        return this.properties.getProperty(SELECTOR_PREFIX + index + 
SelectorProperty.OS_FAMILY, getOsFamily());
     }
 
     public Collection<InvokerToolchain> getToolchains() {
diff --git 
a/src/main/java/org/apache/maven/plugins/invoker/InvokerToolchain.java 
b/src/main/java/org/apache/maven/plugins/invoker/InvokerToolchain.java
index a2e879b..c132712 100644
--- a/src/main/java/org/apache/maven/plugins/invoker/InvokerToolchain.java
+++ b/src/main/java/org/apache/maven/plugins/invoker/InvokerToolchain.java
@@ -29,7 +29,7 @@ import java.util.Map;
 public class InvokerToolchain {
     private final String type;
 
-    private Map<String, String> provides = new HashMap<>();
+    private final Map<String, String> provides = new HashMap<>();
 
     public InvokerToolchain(String type) {
         this.type = type;
diff --git a/src/main/java/org/apache/maven/plugins/invoker/JobExecutor.java 
b/src/main/java/org/apache/maven/plugins/invoker/JobExecutor.java
index 3e2c374..704e214 100644
--- a/src/main/java/org/apache/maven/plugins/invoker/JobExecutor.java
+++ b/src/main/java/org/apache/maven/plugins/invoker/JobExecutor.java
@@ -18,6 +18,7 @@
  */
 package org.apache.maven.plugins.invoker;
 
+import java.util.Comparator;
 import java.util.LinkedHashMap;
 import java.util.List;
 import java.util.Map;
@@ -49,7 +50,7 @@ class JobExecutor {
     public void forEach(ThrowableJobConsumer jobConsumer) {
         // group and sort jobs by ordinal
         Map<Integer, List<BuildJob>> groupedJobs = jobs.stream()
-                .sorted((j1, j2) -> Integer.compare(j2.getOrdinal(), 
j1.getOrdinal()))
+                .sorted(Comparator.comparing(BuildJob::getOrdinal).reversed())
                 .collect(Collectors.groupingBy(BuildJob::getOrdinal, 
LinkedHashMap::new, Collectors.toList()));
 
         ExecutorService executorService = 
Executors.newFixedThreadPool(threadsCount);

Reply via email to