Author: brianf Date: Tue Oct 31 19:21:16 2006 New Revision: 469767 URL: http://svn.apache.org/viewvc?view=rev&rev=469767 Log: MPMD-46 - ability to fail check above certain priority and warn on the rest.
Added: maven/plugins/trunk/maven-pmd-plugin/src/test/resources/unit/default-configuration/def/configuration/App2.java maven/plugins/trunk/maven-pmd-plugin/src/test/resources/unit/default-configuration/pmd-check-failandwarnonpriority-plugin-config.xml (with props) maven/plugins/trunk/maven-pmd-plugin/src/test/resources/unit/default-configuration/pmd-check-failonpriority-plugin-config.xml (with props) Modified: maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/AbstractPmdReport.java maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/AbstractPmdViolationCheckMojo.java maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/CpdReport.java maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/CpdReportGenerator.java maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/CpdViolationCheckMojo.java maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/Locator.java maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/PmdReport.java maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/PmdReportListener.java maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/PmdViolationCheckMojo.java maven/plugins/trunk/maven-pmd-plugin/src/test/java/org/apache/maven/plugin/pmd/PmdViolationCheckMojoTest.java maven/plugins/trunk/maven-pmd-plugin/src/test/resources/unit/default-configuration/pmd-check-notfailonviolation-plugin-config.xml Modified: maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/AbstractPmdReport.java URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/AbstractPmdReport.java?view=diff&rev=469767&r1=469766&r2=469767 ============================================================================== --- maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/AbstractPmdReport.java (original) +++ maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/AbstractPmdReport.java Tue Oct 31 19:21:16 2006 @@ -16,20 +16,20 @@ * limitations under the License. */ +import java.io.File; +import java.io.IOException; +import java.util.Collections; +import java.util.Iterator; +import java.util.List; + import org.apache.maven.artifact.handler.ArtifactHandler; import org.apache.maven.model.ReportPlugin; import org.apache.maven.project.MavenProject; import org.apache.maven.reporting.AbstractMavenReport; import org.codehaus.doxia.site.renderer.SiteRenderer; +import org.codehaus.plexus.util.FileUtils; import org.codehaus.plexus.util.PathTool; import org.codehaus.plexus.util.StringUtils; -import org.codehaus.plexus.util.FileUtils; - -import java.io.File; -import java.io.IOException; -import java.util.Iterator; -import java.util.List; -import java.util.Collections; /** * Base class for the PMD reports. Modified: maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/AbstractPmdViolationCheckMojo.java URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/AbstractPmdViolationCheckMojo.java?view=diff&rev=469767&r1=469766&r2=469767 ============================================================================== --- maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/AbstractPmdViolationCheckMojo.java (original) +++ maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/AbstractPmdViolationCheckMojo.java Tue Oct 31 19:21:16 2006 @@ -20,6 +20,10 @@ import java.io.File; import java.io.FileReader; import java.io.IOException; +import java.util.ArrayList; +import java.util.HashMap; +import java.util.Iterator; +import java.util.List; import java.util.Map; import org.apache.maven.plugin.AbstractMojo; @@ -37,6 +41,10 @@ public abstract class AbstractPmdViolationCheckMojo extends AbstractMojo { + private final Boolean FAILURES_KEY = Boolean.TRUE; + + private final Boolean WARNINGS_KEY = Boolean.FALSE; + /** * The location of the XML report to check, as generated by the PMD report. * @@ -78,7 +86,7 @@ */ private boolean verbose; - protected void executeCheck( String filename, String tagName, String key ) + protected void executeCheck( String filename, String tagName, String key, int failurePriority ) throws MojoFailureException, MojoExecutionException { if ( "java".equals( language ) && sourceDirectory.exists() ) @@ -93,21 +101,27 @@ BufferedReader breader = new BufferedReader( freader ); xpp.setInput( breader ); - int violations = countViolations( xpp, tagName ); - if ( violations > 0 ) + Map violations = getViolations( xpp, tagName, failurePriority ); + + List failures = (List) violations.get( FAILURES_KEY ); + List warnings = (List) violations.get( WARNINGS_KEY ); + + if ( verbose ) { - String message = "You have " + violations + " " + key + ( violations > 1 ? "s" : "" ) - + " For more details see:" + outputFile.getAbsolutePath(); + printErrors( failures, warnings ); + } + + int failureCount = failures.size(); + int warningCount = warnings.size(); + + String message = getMessage( failureCount, warningCount, key, outputFile ); - if ( failOnViolation ) - { - throw new MojoFailureException( message ); - } - else - { - this.getLog().info( message ); - } + if ( failureCount > 0 && failOnViolation ) + { + throw new MojoFailureException( message ); } + + this.getLog().info( message ); } catch ( IOException e ) { @@ -130,7 +144,7 @@ } /** - * Method for counting the number of violations found by the PMD tool + * Method for collecting the violations found by the PMD tool * * @param xpp * the xml parser object @@ -140,30 +154,113 @@ * @throws XmlPullParserException * @throws IOException */ - private int countViolations( XmlPullParser xpp, String tagName ) + private Map getViolations( XmlPullParser xpp, String tagName, int failurePriority ) throws XmlPullParserException, IOException { - int count = 0; int eventType = xpp.getEventType(); + List failures = new ArrayList(); + List warnings = new ArrayList(); + while ( eventType != XmlPullParser.END_DOCUMENT ) { if ( eventType == XmlPullParser.START_TAG && tagName.equals( xpp.getName() ) ) { - count++; - - if ( verbose ) + Map details = getErrorDetails( xpp ); + try { - //separate methods setup to support 2 levels: warn and fail by priority - printError(getErrorDetails(xpp)); + int priority = Integer.parseInt( (String) details.get( "priority" ) ); + if ( priority <= failurePriority ) + { + failures.add( details ); + } + else + { + warnings.add( details ); + } + } + catch ( NumberFormatException e ) + { + // i don't know what priority this is. Treat it like a + // failure + failures.add( details ); + } + catch ( NullPointerException e ) + { + // i don't know what priority this is. Treat it like a + // failure + failures.add( details ); } + } eventType = xpp.next(); + } + HashMap map = new HashMap( 2 ); + map.put( FAILURES_KEY, failures ); + map.put( WARNINGS_KEY, warnings ); + return map; + } + + /** + * Prints the warnings and failures + * + * @param failures + * list of failures + * @param warnings + * list of warnings + */ + protected void printErrors( List failures, List warnings ) + { + Iterator iter = warnings.iterator(); + while ( iter.hasNext() ) + { + printError( (Map) iter.next(), "Warning" ); + } + + iter = failures.iterator(); + while ( iter.hasNext() ) + { + printError( (Map) iter.next(), "Failure" ); } + } + + /** + * Gets the output message + * + * @param failures + * @param warnings + * @param key + * @param outputFile + * @return + */ + private String getMessage( int failureCount, int warningCount, String key, File outputFile ) + { + StringBuffer message = new StringBuffer(); + if ( failureCount > 0 || warningCount > 0 ) + { + if ( failureCount > 0 ) + { + message.append( "You have " + failureCount + " " + key + ( failureCount > 1 ? "s" : "" ) ); + } + + if ( warningCount > 0 ) + { + if ( failureCount > 0 ) + { + message.append( " and " ); + } + else + { + message.append( "You have " ); + } + message.append( warningCount + " warning" + ( warningCount > 1 ? "s" : "" ) ); + } - return count; + message.append( ". For more details see:" + outputFile.getAbsolutePath() ); + } + return message.toString(); } /** @@ -171,7 +268,7 @@ * * @param item */ - abstract protected void printError( Map item ); + abstract protected void printError( Map item, String severity ); /** * Gets the attributes and text for the violation tag and puts them in a Modified: maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/CpdReport.java URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/CpdReport.java?view=diff&rev=469767&r1=469766&r2=469767 ============================================================================== --- maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/CpdReport.java (original) +++ maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/CpdReport.java Tue Oct 31 19:21:16 2006 @@ -20,7 +20,6 @@ import java.io.FileWriter; import java.io.IOException; import java.io.Writer; -import java.util.ArrayList; import java.util.List; import java.util.Locale; import java.util.ResourceBundle; @@ -32,7 +31,6 @@ import net.sourceforge.pmd.cpd.XMLRenderer; import org.apache.maven.reporting.MavenReportException; -import org.codehaus.plexus.util.DirectoryScanner; /** * Report for PMD's CPD tool. See <a href="http://pmd.sourceforge.net/cpd.html">http://pmd.sourceforge.net/cpd.html</a> Modified: maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/CpdReportGenerator.java URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/CpdReportGenerator.java?view=diff&rev=469767&r1=469766&r2=469767 ============================================================================== --- maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/CpdReportGenerator.java (original) +++ maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/CpdReportGenerator.java Tue Oct 31 19:21:16 2006 @@ -3,8 +3,8 @@ import java.util.Iterator; import java.util.ResourceBundle; -import net.sourceforge.pmd.cpd.Match; import net.sourceforge.pmd.PMD; +import net.sourceforge.pmd.cpd.Match; import org.codehaus.doxia.sink.Sink; import org.codehaus.plexus.util.StringUtils; Modified: maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/CpdViolationCheckMojo.java URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/CpdViolationCheckMojo.java?view=diff&rev=469767&r1=469766&r2=469767 ============================================================================== --- maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/CpdViolationCheckMojo.java (original) +++ maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/CpdViolationCheckMojo.java Tue Oct 31 19:21:16 2006 @@ -40,7 +40,7 @@ public void execute() throws MojoExecutionException, MojoFailureException { - executeCheck( "cpd.xml", "duplication", "CPD duplication" ); + executeCheck( "cpd.xml", "duplication", "CPD duplication",10 ); } /** @@ -48,7 +48,7 @@ * * @param item */ - protected void printError( Map item ) + protected void printError( Map item, String severity ) { // TODO Auto-generated method stub Modified: maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/Locator.java URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/Locator.java?view=diff&rev=469767&r1=469766&r2=469767 ============================================================================== --- maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/Locator.java (original) +++ maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/Locator.java Tue Oct 31 19:21:16 2006 @@ -16,15 +16,15 @@ * limitations under the License. */ -import org.apache.maven.plugin.logging.Log; -import org.apache.maven.plugin.logging.SystemStreamLog; -import org.codehaus.plexus.util.FileUtils; -import org.codehaus.plexus.util.StringUtils; - import java.io.File; import java.io.FileNotFoundException; import java.io.IOException; import java.net.URL; + +import org.apache.maven.plugin.logging.Log; +import org.apache.maven.plugin.logging.SystemStreamLog; +import org.codehaus.plexus.util.FileUtils; +import org.codehaus.plexus.util.StringUtils; /** * Performs Locator services for the <code>*Location</code> parameters in the Modified: maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/PmdReport.java URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/PmdReport.java?view=diff&rev=469767&r1=469766&r2=469767 ============================================================================== --- maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/PmdReport.java (original) +++ maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/PmdReport.java Tue Oct 31 19:21:16 2006 @@ -16,24 +16,6 @@ * limitations under the License. */ -import net.sourceforge.pmd.IRuleViolation; -import net.sourceforge.pmd.PMD; -import net.sourceforge.pmd.Report; -import net.sourceforge.pmd.Rule; -import net.sourceforge.pmd.RuleContext; -import net.sourceforge.pmd.RuleSet; -import net.sourceforge.pmd.RuleSetFactory; -import net.sourceforge.pmd.SourceType; -import net.sourceforge.pmd.renderers.CSVRenderer; -import net.sourceforge.pmd.renderers.HTMLRenderer; -import net.sourceforge.pmd.renderers.Renderer; -import net.sourceforge.pmd.renderers.TextRenderer; -import net.sourceforge.pmd.renderers.XMLRenderer; -import org.apache.maven.reporting.MavenReportException; -import org.codehaus.doxia.sink.Sink; -import org.codehaus.plexus.util.FileUtils; -import org.codehaus.plexus.util.StringUtils; - import java.io.File; import java.io.FileInputStream; import java.io.FileNotFoundException; @@ -45,11 +27,27 @@ import java.io.Reader; import java.io.UnsupportedEncodingException; import java.io.Writer; -import java.util.Collections; import java.util.Iterator; import java.util.List; import java.util.Locale; import java.util.ResourceBundle; + +import net.sourceforge.pmd.IRuleViolation; +import net.sourceforge.pmd.PMD; +import net.sourceforge.pmd.Report; +import net.sourceforge.pmd.Rule; +import net.sourceforge.pmd.RuleContext; +import net.sourceforge.pmd.RuleSet; +import net.sourceforge.pmd.RuleSetFactory; +import net.sourceforge.pmd.SourceType; +import net.sourceforge.pmd.renderers.CSVRenderer; +import net.sourceforge.pmd.renderers.HTMLRenderer; +import net.sourceforge.pmd.renderers.Renderer; +import net.sourceforge.pmd.renderers.TextRenderer; +import net.sourceforge.pmd.renderers.XMLRenderer; + +import org.apache.maven.reporting.MavenReportException; +import org.codehaus.doxia.sink.Sink; /** * Implement the PMD report. Modified: maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/PmdReportListener.java URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/PmdReportListener.java?view=diff&rev=469767&r1=469766&r2=469767 ============================================================================== --- maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/PmdReportListener.java (original) +++ maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/PmdReportListener.java Tue Oct 31 19:21:16 2006 @@ -25,8 +25,8 @@ import java.util.ResourceBundle; import net.sourceforge.pmd.IRuleViolation; -import net.sourceforge.pmd.ReportListener; import net.sourceforge.pmd.PMD; +import net.sourceforge.pmd.ReportListener; import net.sourceforge.pmd.stat.Metric; import org.codehaus.doxia.sink.Sink; Modified: maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/PmdViolationCheckMojo.java URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/PmdViolationCheckMojo.java?view=diff&rev=469767&r1=469766&r2=469767 ============================================================================== --- maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/PmdViolationCheckMojo.java (original) +++ maven/plugins/trunk/maven-pmd-plugin/src/main/java/org/apache/maven/plugin/pmd/PmdViolationCheckMojo.java Tue Oct 31 19:21:16 2006 @@ -36,24 +36,36 @@ extends AbstractPmdViolationCheckMojo { /** + * What priority level to fail the build on. Failures at or above this level + * will stop the build. Anything below will be warnings and will be + * displayed in the build output if verbose=true. Note: Minumum Priority = 5 + * Maximum Priority = 0 + * + * @parameter expression="${pmd.failurePriority}" default-value="5" + * @required + */ + private int failurePriority; + + /** * @see org.apache.maven.plugin.AbstractMojo#execute() */ public void execute() throws MojoExecutionException, MojoFailureException { - executeCheck( "pmd.xml", "violation", "PMD violation" ); + executeCheck( "pmd.xml", "violation", "PMD violation", failurePriority ); } /** * Formats the failure details and prints them as an INFO message * * @param item - * parsed details about error + * parsed details about error */ - protected void printError( Map item ) + protected void printError( Map item, String severity ) { - + StringBuffer buff = new StringBuffer( 100 ); + buff.append( "PMD " + severity + ": " ); buff.append( item.get( "package" ) ); buff.append( "." ).append( item.get( "class" ) ); buff.append( ":" ).append( item.get( "line" ) ); Modified: maven/plugins/trunk/maven-pmd-plugin/src/test/java/org/apache/maven/plugin/pmd/PmdViolationCheckMojoTest.java URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-pmd-plugin/src/test/java/org/apache/maven/plugin/pmd/PmdViolationCheckMojoTest.java?view=diff&rev=469767&r1=469766&r2=469767 ============================================================================== --- maven/plugins/trunk/maven-pmd-plugin/src/test/java/org/apache/maven/plugin/pmd/PmdViolationCheckMojoTest.java (original) +++ maven/plugins/trunk/maven-pmd-plugin/src/test/java/org/apache/maven/plugin/pmd/PmdViolationCheckMojoTest.java Tue Oct 31 19:21:16 2006 @@ -16,6 +16,8 @@ * limitations under the License. */ +import org.apache.maven.plugin.MojoExecutionException; +import org.apache.maven.plugin.MojoFailureException; import org.apache.maven.plugin.testing.AbstractMojoTestCase; import java.io.File; @@ -64,7 +66,32 @@ PmdViolationCheckMojo pmdViolationMojo = (PmdViolationCheckMojo) lookupMojo( "check", testPom ); pmdViolationMojo.execute(); - assertTrue( true ); + assertTrue( true ); + } + + public void testFailurePriority() + throws Exception + { + System.out.println("testFailurePriority"); + File testPom = new File( getBasedir(), + "src/test/resources/unit/default-configuration/pmd-check-failonpriority-plugin-config.xml" ); + PmdViolationCheckMojo pmdViolationMojo = (PmdViolationCheckMojo) lookupMojo( "check", testPom ); + pmdViolationMojo.execute(); + + System.out.println("testFailurePriority2"); + testPom = new File( getBasedir(), + "src/test/resources/unit/default-configuration/pmd-check-failandwarnonpriority-plugin-config.xml" ); + pmdViolationMojo = (PmdViolationCheckMojo) lookupMojo( "check", testPom ); + try + { + pmdViolationMojo.execute(); + fail( "Exeception Expected" ); + } + catch ( MojoFailureException e ) + { + System.out.println(e.getMessage());// expected + } + } public void testException() Added: maven/plugins/trunk/maven-pmd-plugin/src/test/resources/unit/default-configuration/def/configuration/App2.java URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-pmd-plugin/src/test/resources/unit/default-configuration/def/configuration/App2.java?view=auto&rev=469767 ============================================================================== --- maven/plugins/trunk/maven-pmd-plugin/src/test/resources/unit/default-configuration/def/configuration/App2.java (added) +++ maven/plugins/trunk/maven-pmd-plugin/src/test/resources/unit/default-configuration/def/configuration/App2.java Tue Oct 31 19:21:16 2006 @@ -0,0 +1,13 @@ +package def.configuration; +//trigger unused import +import java.io.File; +/** + * This is a sample class used for testing + * + * @author Maria Odea Ching + */ +public class App2 +{ + + +} Added: maven/plugins/trunk/maven-pmd-plugin/src/test/resources/unit/default-configuration/pmd-check-failandwarnonpriority-plugin-config.xml URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-pmd-plugin/src/test/resources/unit/default-configuration/pmd-check-failandwarnonpriority-plugin-config.xml?view=auto&rev=469767 ============================================================================== --- maven/plugins/trunk/maven-pmd-plugin/src/test/resources/unit/default-configuration/pmd-check-failandwarnonpriority-plugin-config.xml (added) +++ maven/plugins/trunk/maven-pmd-plugin/src/test/resources/unit/default-configuration/pmd-check-failandwarnonpriority-plugin-config.xml Tue Oct 31 19:21:16 2006 @@ -0,0 +1,35 @@ +<project> + <modelVersion>4.0.0</modelVersion> + <groupId>custom.configuration</groupId> + <artifactId>custom-configuration</artifactId> + <packaging>jar</packaging> + <version>1.0-SNAPSHOT</version> + <inceptionYear>2006</inceptionYear> + <name>Maven PMD Violation Check Custom Configuration Test</name> + <url>http://maven.apache.org</url> + <build> + <finalName>custom-configuration</finalName> + <plugins> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-pmd-plugin</artifactId> + <configuration> + <sourceDirectory>${basedir}/src/test/resources/unit/default-configuration</sourceDirectory> + <targetDirectory>${basedir}/target/test/unit/default-configuration/target</targetDirectory> + <failOnViolation>true</failOnViolation> + <failurePriority>3</failurePriority> + <verbose>true</verbose> + <language>java</language> + </configuration> + </plugin> + </plugins> + </build> + <reporting> + <plugins> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-jxr-plugin</artifactId> + </plugin> + </plugins> + </reporting> +</project> Propchange: maven/plugins/trunk/maven-pmd-plugin/src/test/resources/unit/default-configuration/pmd-check-failandwarnonpriority-plugin-config.xml ------------------------------------------------------------------------------ svn:mime-type = text/xml Added: maven/plugins/trunk/maven-pmd-plugin/src/test/resources/unit/default-configuration/pmd-check-failonpriority-plugin-config.xml URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-pmd-plugin/src/test/resources/unit/default-configuration/pmd-check-failonpriority-plugin-config.xml?view=auto&rev=469767 ============================================================================== --- maven/plugins/trunk/maven-pmd-plugin/src/test/resources/unit/default-configuration/pmd-check-failonpriority-plugin-config.xml (added) +++ maven/plugins/trunk/maven-pmd-plugin/src/test/resources/unit/default-configuration/pmd-check-failonpriority-plugin-config.xml Tue Oct 31 19:21:16 2006 @@ -0,0 +1,36 @@ +<project> + <modelVersion>4.0.0</modelVersion> + <groupId>custom.configuration</groupId> + <artifactId>custom-configuration</artifactId> + <packaging>jar</packaging> + <version>1.0-SNAPSHOT</version> + <inceptionYear>2006</inceptionYear> + <name>Maven PMD Violation Check Custom Configuration Test</name> + <url>http://maven.apache.org</url> + <build> + <finalName>custom-configuration</finalName> + <plugins> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-pmd-plugin</artifactId> + <configuration> + <!-- project implementation="org.apache.maven.plugin.pmd.stubs.DefaultConfigurationMavenProjectStub"/--> + <sourceDirectory>${basedir}/src/test/resources/unit/default-configuration</sourceDirectory> + <targetDirectory>${basedir}/target/test/unit/default-configuration/target</targetDirectory> + <failOnViolation>true</failOnViolation> + <failurePriority>1</failurePriority> + <verbose>false</verbose> + <language>java</language> + </configuration> + </plugin> + </plugins> + </build> + <reporting> + <plugins> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-jxr-plugin</artifactId> + </plugin> + </plugins> + </reporting> +</project> Propchange: maven/plugins/trunk/maven-pmd-plugin/src/test/resources/unit/default-configuration/pmd-check-failonpriority-plugin-config.xml ------------------------------------------------------------------------------ svn:mime-type = text/xml Modified: maven/plugins/trunk/maven-pmd-plugin/src/test/resources/unit/default-configuration/pmd-check-notfailonviolation-plugin-config.xml URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-pmd-plugin/src/test/resources/unit/default-configuration/pmd-check-notfailonviolation-plugin-config.xml?view=diff&rev=469767&r1=469766&r2=469767 ============================================================================== --- maven/plugins/trunk/maven-pmd-plugin/src/test/resources/unit/default-configuration/pmd-check-notfailonviolation-plugin-config.xml (original) +++ maven/plugins/trunk/maven-pmd-plugin/src/test/resources/unit/default-configuration/pmd-check-notfailonviolation-plugin-config.xml Tue Oct 31 19:21:16 2006 @@ -18,7 +18,7 @@ <sourceDirectory>${basedir}/src/test/resources/unit/default-configuration</sourceDirectory> <targetDirectory>${basedir}/target/test/unit/default-configuration/target</targetDirectory> <failOnViolation>false</failOnViolation> - <verbose>true</verbose> + <verbose>false</verbose> <language>java</language> </configuration> </plugin>