This is an automated email from the ASF dual-hosted git repository.
andschwa pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mesos.git
commit dafb03e4194624e3148200a7f919bfb150b6afb7
Author: Andrew Schwartzmeyer
AuthorDate: Fri Aug 17 13:54:45 2018 -0700
This is an automated email from the ASF dual-hosted git repository.
andschwa pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mesos.git
commit 269a9735031566ddda47ccb8398fd0609af3a826
Author: Andrew Schwartzmeyer
AuthorDate: Fri Aug 17 14:46:34 2018 -0700
This is an automated email from the ASF dual-hosted git repository.
andschwa pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mesos.git
commit 9658e8e0e05c8ec9332f40f0884914ccee8f3639
Author: Andrew Schwartzmeyer
AuthorDate: Thu Aug 16 16:10:30 2018 -0700
This is an automated email from the ASF dual-hosted git repository.
andschwa pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/mesos.git.
from ac766c8 Added --skip-verify flag to verify-reviews.py to skip
verification.
new 9658e8e Added /files API
This is an automated email from the ASF dual-hosted git repository.
andschwa pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mesos.git
The following commit(s) were added to refs/heads/master by this push:
new ac766c8 Added --skip-verify flag to verify
This is an automated email from the ASF dual-hosted git repository.
andschwa pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mesos.git
commit 1a2dc1522eba6aca8074d28272d151742dd3a532
Author: Andrew Schwartzmeyer
AuthorDate: Mon Aug 27 11:47:34 2018 -0700
This is an automated email from the ASF dual-hosted git repository.
andschwa pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mesos.git
commit 40e13ae62fff4776b8a27f93bcd4b435dcc848ff
Author: Andrew Schwartzmeyer
AuthorDate: Mon Aug 27 11:47:44 2018 -0700
This is an automated email from the ASF dual-hosted git repository.
andschwa pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mesos.git
commit e4bb564ff21976e8c21462a0c4730f85e80f3b19
Author: Andrew Schwartzmeyer
AuthorDate: Mon Aug 27 11:47:41 2018 -0700
This is an automated email from the ASF dual-hosted git repository.
andschwa pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mesos.git
commit 788a95845c308984643655194aeb352b6e2a3b01
Author: Andrew Schwartzmeyer
AuthorDate: Mon Aug 27 11:47:46 2018 -0700
This is an automated email from the ASF dual-hosted git repository.
andschwa pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/mesos.git.
from 1263683 Groomed the CHANGELOG.
new 1a2dc15 Windows: Added notes for permanently disabled tests.
new
This is an automated email from the ASF dual-hosted git repository.
andschwa pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mesos.git
commit 590a75d0c9d61b0b07f8a3807225c40eb8189a0b
Author: Dragos Schebesch
AuthorDate: Tue Aug 21 10:42:52 2018 -0700
This is an automated email from the ASF dual-hosted git repository.
andschwa pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/mesos.git.
from 6cac5ad Windows: Made `libwinio` the default option for Mesos.
new 21bddc3 Refactored ReviewBoard API
This is an automated email from the ASF dual-hosted git repository.
andschwa pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mesos.git
commit 21bddc30d756ae673a062c7cf23c0f064bafb275
Author: Dragos Schebesch
AuthorDate: Tue Aug 21 10:42:46 2018 -0700
This is an automated email from the ASF dual-hosted git repository.
andschwa pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mesos.git
commit 062b34eabb7f437b9d32b54544b51689a918c021
Author: Dragos Schebesch
AuthorDate: Tue Aug 21 10:42:48 2018 -0700
This is an automated email from the ASF dual-hosted git repository.
andschwa pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mesos.git
commit e80fa6f4d5d1c2feb62e6a83ee1d09befc2e251a
Author: Dragos Schebesch
AuthorDate: Tue Aug 21 10:42:50 2018 -0700
This is an automated email from the ASF dual-hosted git repository.
andschwa pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/mesos.git.
from dbcf3c6 Removed MESOS-4509 from the 1.7.0 CHANGELOG.
new db6a22b Windows: Made `libwinio` the default option
This is an automated email from the ASF dual-hosted git repository.
andschwa pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mesos.git
commit db6a22b481d32d1b83edf5fba6c021ebded9f9b1
Author: Andrew Schwartzmeyer
AuthorDate: Mon Aug 13 14:59:29 2018 -0700
This is an automated email from the ASF dual-hosted git repository.
andschwa pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mesos.git
The following commit(s) were added to refs/heads/master by this push:
new 0ac5af2 Fixed Windows build break.
0ac5af2
This is an automated email from the ASF dual-hosted git repository.
andschwa pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mesos.git
The following commit(s) were added to refs/heads/master by this push:
new 138bfbb Fixed gRPC compilation for non-SSL
This is an automated email from the ASF dual-hosted git repository.
andschwa pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mesos.git
The following commit(s) were added to refs/heads/master by this push:
new 3bb3108 Fixed `mesos-style.py` for Windows
Repository: mesos
Updated Branches:
refs/heads/master 3bd7711b1 -> a1052300f
Replaced `` with `` in stout.
The intent is that `os.hpp` includes the correct OS-specific header,
`windows/os.hpp` or `posix/os.hpp`, automatically. They should never
be included manually.
Review:
+ option(ENABLE_PORT_MAPPING_ISOLATOR
+"Whether to enable the port mapping isolator."
+FALSE)
+
+ if (ENABLE_PORT_MAPPING_ISOLATOR)
+# TODO(andschwa): Check for `libnl-3`.
+message(FATAL_ERROR
+ "The port mapping isolator is not yet supported, see MESOS-8993.&
ion of the Mesos CLI.
+#
+# TODO(andschwa): Remove this when fully deprecated.
+# This is not ported to Windows.
+if (NOT ENABLE_NEW_CLI AND NOT WIN32)
+ # NOTE: This can be built at the same time as the new CLI, except
+ # there is a name collis
t;Use jemalloc as memory allocator for the master and agent binaries."
FALSE)
+
+ option(ENABLE_XFS_DISK_ISOLATOR
+"Whether to enable the XFS disk isolator."
+FALSE)
+
+ if (ENABLE_XFS_DISK_ISOLATOR)
+# TODO(andschwa): Check for required headers and libraries.
+
Repository: mesos
Updated Branches:
refs/heads/master 62d4ff53b -> ad6e67f97
Patched Google Test with upstream bugfix.
Per MESOS-8990, our Google Test dependency needs a patch from
upstream, https://github.com/google/googletest/pull/1620, in order to
continue building with the next version of
Repository: mesos
Updated Branches:
refs/heads/master 0519403ec -> 9047fdccc
Enabled `TimeTest.Now` on Windows.
While the timer resolution on Windows does not support 10
microseconds, it does support 1000 microseconds, which is still fast
enough for a unit test.
Review:
Windows: Enabled `RemoteLink` tests.
This resolves MESOS-5941. Note that on Windows, `os::killtree()` is
only valid for processes specifically spawned in a group via a job
object, otherwise it will fail (and the failure is not being checked
here). Since the `linkee` process only ever spawns the
Windows: Ported remaining tests in the `HTTPTest` suite.
These were enabled by fixing the use of `Path()` in `process.cpp` to
explicitly use '/' as the separator, as it's being used to manipulate
URLs, not filesystem paths, and previously this failed due the Windows
path separator being '\'.
/tests/process_tests.cpp
index 8baf60d..8e4135a 100644
--- a/3rdparty/libprocess/src/tests/process_tests.cpp
+++ b/3rdparty/libprocess/src/tests/process_tests.cpp
@@ -783,9 +783,29 @@ protected:
EXPECT_CALL(coordinator, consume_(_))
.WillOnce(FutureArg<0>());
+// TODO(an
Added optional `path_separator` parameter to `Path` constructor.
This defaults to `os::PATH_SEPARATOR` and so by default retains the
previous behavior. However, now `Path` can be arbitrarily used with,
e.g., URLs on Windows by providing `/` as the separator.
Review:
Loop::initialize()
void EventLoop::delay(
const Duration& duration, const std::function& function)
{
+ if (!libwinio_loop) {
+// TODO(andschwa): Remove this check, see MESOS-9097.
+LOG(FATAL) << "Windows IOCP event loop is not initialized";
+ }
+
libwi
Windows: Enabled rest of `ProcessTest` suite.
Several of these worked as-is, and the two firewall tests were fixed
by replace `path::join` (which joined with `\`) with
`strings::join("/")`.
Review: https://reviews.apache.org/r/67980
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
// failure by hogging all available file descriptors.
+//
+// TODO(andschwa): Enable this test. The current logic will not work on Windows
+// as " The Microsoft Winsock provider limits the maximum number of sockets
+// supported only by available memory on the local computer." See
22a..2ec0d42 100644
--- a/3rdparty/libprocess/src/tests/benchmarks.cpp
+++ b/3rdparty/libprocess/src/tests/benchmarks.cpp
@@ -494,8 +494,6 @@ TEST(ProcessTest, Process_BENCHMARK_ThroughputPerformance)
}
-// TODO(andschwa): Turn this test back on when MESOS-8915 is solved.
-#ifndef __WINDOWS__
cl
Repository: mesos
Updated Branches:
refs/heads/master 14c68199c -> 01475ec28
Cleaned up whitespace in `site/doap.rdf`.
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/5076bab4
Tree:
Made Git normalize all line endings automatically.
Instead of relying on the user to `core.autocrlf = true` before
cloning, we now set this in `.gitattributes` for all files.
Only one file needed normalization via `git add --renormalize .`, it
was `site/doap.rdf`.
The Windows instructions were
Repository: mesos
Updated Branches:
refs/heads/master f0cb4d363 -> ac6952d68
Added note about `3RDPARTY_DEPENDENCIES` use on Windows.
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/ac6952d6
Tree:
Repository: mesos
Updated Branches:
refs/heads/master 9128994aa -> 964a63bc4
Updated Windows build documentation for `ENABLE_LIBWINIO`.
This is now the recommended way to build Mesos on Windows, instead of
using libevent, as it is buggy (and the latest enabled tests will fail
with libevent
Repository: mesos
Updated Branches:
refs/heads/master 7c9c72dad -> 40188e68e
Added MESOS-8668 to 1.7.0 CHANGELOG.
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/40188e68
Tree:
Organized POSIX and Windows libprocess implementations.
In preparation of the new Windows IOCP library, the POSIX and Windows
specific files in libprocess have been moved to their own directories
for better code organization.
Review: https://reviews.apache.org/r/67388/
Project:
Repository: mesos
Updated Branches:
refs/heads/master f6f35a88b -> 7c9c72dad
Windows: Ported `docker_containerizer_tests.cpp`.
With some Docker bug fixes and the IOCP backend, the remaining Docker
tests have been ported. The only remaining Docker tests that aren't
ported are either due to
Changed use of `os::nonblock` to `io::prepare_async`.
Due to the previous patch, instances that use `os::nonblock` before
sending the file descriptor to the async IO functions now need to use
`io::prepare_async`.
Review: https://reviews.apache.org/r/67387/
Project:
http://git-wip-us.apache.org/repos/asf/mesos/blob/78244b53/3rdparty/libprocess/src/poll_socket.cpp
--
diff --git a/3rdparty/libprocess/src/poll_socket.cpp
b/3rdparty/libprocess/src/poll_socket.cpp
deleted file mode 100644
index
Windows: Integrated libwinio with libprocess code.
The libprocess event loops are used to implement the `EventLoop`,
`SocketImpl`, and `io::read/write` interfaces. Thus, by providing
those implementations using libwinio, libprocess now supports the
libwinio backend.
Review:
Added Windows IOCP backend to libprocess's CMake build.
With the CMake option `ENABLE_LIBWINIO`, we can now conditionally turn
on the Windows IOCP backend for libprocess.
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit:
Windows: Added IOCP `HANDLE` to `WindowsFD`.
Users of `os::nonblock()` assume that it is idempotent. Unfortunately,
`CreateIoCompletionPort` is not idempotent, so we need to wrap the
function around our own code to make it so. We need to keep it inside
the `WindowsFD` class, because there isn't a
Added CMake `ENABLE_LIBWINIO` option for Windows IOCP backend.
This option will let us enable the new Windows IOCP backend for
libprocess. It can only be used on Windows, and it is mutually
exclusive with `ENABLE_LIBEVENT`. For now, it is disabled by default,
but this is expected to change,
Windows: Added `windows_to_unix_epoch` function.
There are a couple of places where we need to convert a Windows
absolute time (epoch at 01/01/1601) to a UNIX absolute time (epoch at
01/01/1970). So, a function has been added to handle it.
Review: https://reviews.apache.org/r/67685/
Project:
Windows: Implemented Windows IOCP async backend.
The Windows IOCP async backend, called libwinio, provides a single
threaded event loop implementation that allows for async IO and timer
events. This library wraps the native Win32 async functions using
libprocess's primitives, which makes it
Windows: Made `PipeLargeOutput` test work with IOCP backend.
The `PipeLargeOutput` test was calling `io::read`, which was returning
the wrong error since it operates at a higher level abstraction. The
test really just checks if a pipe EOF returns `ERROR_BROKEN_PIPE`, so
the test was changed to
Added `io::prepare_async` and `io::is_async` functions.
The `os::nonblock` and `os::isNonBlock` fucntions are stubs that only
do things for Windows sockets. For the IOCP implementation, we need to
associate the handles with the IOCP handel, which is created by
libprocess. Thus, we need these new
http://git-wip-us.apache.org/repos/asf/mesos/blob/78244b53/3rdparty/libprocess/src/posix/poll_socket.cpp
--
diff --git a/3rdparty/libprocess/src/posix/poll_socket.cpp
b/3rdparty/libprocess/src/posix/poll_socket.cpp
new file mode
Windows: Ported `io_tests.cpp`.
With the IOCP backened implemented, `io_tests.cpp` is now ported to
Windows. Since the tests require async pipe IO, the tests are only run
if libprocess is compiled with the IOCP backened.
Review: https://reviews.apache.org/r/67393/
Project:
Windows: Made socket `int_fd` castable to `HANDLE` type.
Many Win32 functions that take in `HANDLE` also work on `SOCKET`, such
as `ReadFile` or `CreateIoCompletionPort`. IOCP on Windows uses the
`HANDLE` type uniformly, so we need to be able to convert socket
`int_fd` to `HANDLE`.
Review:
Repository: mesos
Updated Branches:
refs/heads/master c0488797e -> 2e913d545
Added MESOS-3790 to 1.6.1 and 1.5.2 in CHANGELOG.
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/2e913d54
Tree:
Repository: mesos
Updated Branches:
refs/heads/1.6.x 0ba127368 -> 1d5f83d2b
Fixed ordering of CHANGELOG.
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/1d5f83d2
Tree:
Repository: mesos
Updated Branches:
refs/heads/1.5.x e770e842e -> 5a52aaa12
Fixed ordering of CHANGELOG.
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/5a52aaa1
Tree:
Repository: mesos
Updated Branches:
refs/heads/1.6.x b29abc389 -> 0ba127368
Moved MESOS-3790 to 1.6.1 release.
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/0ba12736
Tree:
Repository: mesos
Updated Branches:
refs/heads/1.6.x 87f0c2903 -> b29abc389
Updated ZooKeeper retry logic to retry on `ENOENT` too.
Per MESOS-3790, the call to `zookeeper_init` maps `EAI_NONAME` and
`EAI_NODATA` to an `errno` value of `ENOENT`, and all others except
`EAI_MEMORY` to `EINVAL`.
Added MESOS-3790 to 1.6.2 CHANGELOG.
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/b29abc38
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/b29abc38
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/b29abc38
Repository: mesos
Updated Branches:
refs/heads/1.5.x 42a2b15e4 -> e770e842e
Updated ZooKeeper retry logic to retry on `ENOENT` too.
Per MESOS-3790, the call to `zookeeper_init` maps `EAI_NONAME` and
`EAI_NODATA` to an `errno` value of `ENOENT`, and all others except
`EAI_MEMORY` to `EINVAL`.
Added MESOS-3790 to 1.5.2 CHANGELOG.
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/e770e842
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/e770e842
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/e770e842
Repository: mesos
Updated Branches:
refs/heads/master 335459297 -> c0488797e
Added a support script to check for files missing in CMake.
This compares the sources listed in the Autotools and CMake build
files, and emits the difference. We use this to check if the builds
have diverged, and how
Repository: mesos
Updated Branches:
refs/heads/master 4cdddf687 -> b648f6987
Renamed APR and SVN `find_package` implementations.
Upstream follows a convention of using ALL UPERCASE letters for
package names for implementations of `FindPACKAGE.cmake`. This patch
renames our `find_package`
Repository: mesos
Updated Branches:
refs/heads/master 3f60c9857 -> 004fb5fa2
Added two tests to the stout CMake build.
Review: https://reviews.apache.org/r/67709/
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/004fb5fa
Added `profiler_tests.cpp` to the libprocess CMake build.
Review: https://reviews.apache.org/r/67708/
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/22ddf54e
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/22ddf54e
Repository: mesos
Updated Branches:
refs/heads/master 22524ecdd -> 4ea9c7f96
Fixed Autotools `cd 3rdparty/stout && make tests` build.
Building `stout-tests` without having first built the default targets
was broken for two reasons: it was lacking the dependency required to
build the bundled
Repository: mesos
Updated Branches:
refs/heads/master bc3944c51 -> 22524ecdd
Updated ZooKeeper retry logic to retry on `ENOENT` too.
Per MESOS-3790, the call to `zookeeper_init` maps `EAI_NONAME` and
`EAI_NODATA` to an `errno` value of `ENOENT`, and all others except
`EAI_MEMORY` to `EINVAL`.
on-hook #'lsp-cquery-enable)
+ (setq cquery-executable "/path/to/cquery/build/cquery")
+ (setq cquery-extra-init-params '(:completion (:detailedLabel t
+```
+
+Being Emacs, feel free to customize to your liking. The author's
+configurations can be found [here](https://gi
Repository: mesos
Updated Branches:
refs/heads/master 57091affe -> 7b4d625f7
Windows: Fixed libarchive and zlib linkage warnings.
Our build of libarchive was erroneously linking in the shared version
of our build of zlib, and so defined `ZLIB_DLL`, which caused warnings
when the consumers of
Repository: mesos
Updated Branches:
refs/heads/master 85adb1e87 -> 62c5c3eee
Removed headers from `libprocess/src/CMakeList.txt`.
Header files are not necessary (and so are redundant) in CMake.
Review: https://reviews.apache.org/r/67554/
Project:
Repository: mesos
Updated Branches:
refs/heads/master b13ef3160 -> 85adb1e87
Fixed break of `port_mapping_tests.cpp`.
The last change applied to the file descriptor whitelist chain removed
the default value from the new argument, and this function was not
updated. The other change made was
Whitelist inheritable file descriptors in the containerizer.
This commit whitelists the read and write ends of the control pipe
that are intended to be inherited by the containerizer. This is
necessary because this pipe is passed to the child process
implicitly (through environment variables), so
Whitelist inheritable file descriptors in libprocess.
This commit plumbs the list of whitelisted file descriptors through
the libprocess APIs.
Review: https://reviews.apache.org/r/67287/
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit:
/shell.hpp
@@ -242,15 +242,18 @@ inline Try create_process(
const std::vector& argv,
const Option>& environment,
const bool create_suspended = false,
-const Option>& pipes = None())
+const Option>& pipes = None(),
+const std::vector& whitelist_fd
Repository: mesos
Updated Branches:
refs/heads/master e9b5e0300 -> 1b851877f
Fixed use of rbt command in `push-commits.py` for Windows.
Same logic as `post-reviews.py`.
Review: https://reviews.apache.org/r/67580/
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit:
Repository: mesos
Updated Branches:
refs/heads/master dff60a0b9 -> e9b5e0300
Fixed `push-commits.py` for Windows.
This script didn't work even before the port to Python 3, as
`os.path.join` cannot be used for joining URL components, as the
filesystem path separator on Windows is a backslash.
Removed superfluous guard around `signals.hpp`.
Review: https://reviews.apache.org/r/67533/
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/f1c0377a
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/f1c0377a
Diff:
Repository: mesos
Updated Branches:
refs/heads/master abef72521 -> f1c0377a9
Removed superfluous guard around `signals.hpp`.
This is a follow-up to commit e765f8fab where we made this header safe
to include, but a no-op on Windows.
Review: https://reviews.apache.org/r/67532/
Project:
Repository: mesos
Updated Branches:
refs/heads/master b1e88f73b -> abef72521
Ported `EnvTest.EraseEnv` to Windows, with added comments.
The difference between `os::unsetenv` and `os::eraseenv` is important,
but subtle. Now the reason for the existence of `os::eraseenv` is
documented in
so that the canonical integer
// file descriptors representing `stdin` (0), `stdout` (1), and
// `stderr` (2), and the invalid value of -1 can be used.
- //
- // TODO(andschwa): Consider constraining to the range [-1, 2].
WindowsFD(int crt) : WindowsFD(INVALID_HANDLE_VA
Repository: mesos
Updated Branches:
refs/heads/master c185752b7 -> 5e1d8627b
Windows: Fixed incorrect return code for `os:kill`.
`os::kill` was returning the opposite error code than expected. It
was returning `KILL_FAIL` on success and `KILL_PASS` on error.
Review:
Repository: mesos
Updated Branches:
refs/heads/master a17036065 -> e05342b94
Fixed `python3/mesos-style.py`.
The `cpplint.py` file was made to be single-source compatible with
both Python 2 and Python 3, but `mesos-style.py` was erroneously
changed to look for a copy of it under
Fixed type error when using `check_output` in Python 3 scripts.
Review: https://reviews.apache.org/r/67463/
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/d05c8cad
Tree:
Repository: mesos
Updated Branches:
refs/heads/master 52660fe6a -> 6ed9882a1
Fixed socket creation bug in `docker.cpp`.
On Windows, the statement `int_fd socket = ::socket(...);` would
implictly call the `WindowsFD(int crt)` constructor. Since that
contstructor only accepts values of {0, 1,
Added python3 to list of Pylint excluded files.
This change ensures that pylint will not try to lint the new Python 3
support scripts if it is not run with Python 3. Having such a situation
results in unexpected errors such as "Unnecessary parens after 'print'
keyword". This change will not be
Added warning to Python version checker script.
After the user has installed Python 3, if they use the Python 2
scripts, we want to alert them to start using (and therefore testing)
the ported Python 3 scripts.
Review: https://reviews.apache.org/r/67292/
Project:
Ported all support scripts to Python 3.
The scripts are in a temporary directory, support/python3.
The scripts have been ported using 2to3, the official tool to do so.
Many of these scripts require testing from the community before being
used by default.
The script building the virtual
http://git-wip-us.apache.org/repos/asf/mesos/blob/960df5c4/support/python3/push-commits.py
--
diff --git a/support/python3/push-commits.py b/support/python3/push-commits.py
new file mode 100755
index 000..82a7004
--- /dev/null
Updated support scripts to check for Python 3.
Review: https://reviews.apache.org/r/67099/
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/2820028e
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/2820028e
Diff:
Repository: mesos
Updated Branches:
refs/heads/master 05594d69d -> ae4e7956a
Added support script to check if Python >= 3.6 is available.
Review: https://reviews.apache.org/r/67247/
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit:
Repository: mesos
Updated Branches:
refs/heads/master cb8a30bbd -> 668030da1
Fixed `mesos-style` missing ending newline warning.
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/668030da
Tree:
Windows: Ported `sendfile_tests.cpp`.
The `os::sendfile` unit tests were using `socketpair`, but the rest of
the tests were cross-platform. By providing a Windows `socketpair`
implementation, the tests are now ported.
Review: https://reviews.apache.org/r/66961/
Project:
if (result.isError()) {
+return -1;
+ }
+
+ if (result.isSome()) {
+return result.get();
+ }
+
+ // IO is pending, so wait for the overlapped object.
DWORD bytes;
- // TODO(andschwa): Handle overlapped I/O.
- const BOOL result =
-::
Windows: Added tests for async I/O functions.
New asynchronous functions were introduced to the Windows stout `read`
and `write` implementations, so extra tests were added.
Review: https://reviews.apache.org/r/66962/
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit:
Windows: Fixed pipe inheritance in Mesos containerizer.
The Mesos containerizer needs an inheritable pipe that is not used for
stdio of the child process. It is used for signaling when the child
process should start running, so the pipe needs to be inheritable and
not overlapped.
Note this is
Windows: Added internal Windows file for overlapped helpers.
Added a helper file for handling overlapped objects, because
`os::read/write` need to work on overlapped files and the logic can be
shared.
Review: https://reviews.apache.org/r/66954/
Project:
diff --git a/3rdparty/stout/include/stout/os/windows/open.hpp
b/3rdparty/stout/include/stout/os/windows/open.hpp
index 701dcec..b2f033c 100644
--- a/3rdparty/stout/include/stout/os/windows/open.hpp
+++ b/3rdparty/stout/include/stout/os/windows/open.hpp
@@ -44,6 +4
Windows: Enabled creating overlapped pipes with `os::pipe`.
`os::pipe` was using `CreatePipe`, which does not support overlapped
I/O. Now, the implementation of `os::pipe` has been changed to use
`CreateNamedPipe`, which supports overlapped I/O. The named pipe is
created with an unique random
case WindowsFD::Type::HANDLE: {
DWORD bytes;
- // TODO(andschwa): Handle overlapped I/O.
- const BOOL result =
-::ReadFile(fd, data, static_cast(size), , nullptr);
- if (result == FALSE) {
-// The pipe "breaks" when the other pro
1 - 100 of 323 matches
Mail list logo
