Repository: mesos Updated Branches: refs/heads/master 0735c2d18 -> a94e3cd0f
MesosTidy: Added some `google-*` checks to the default set of checks. Review: https://reviews.apache.org/r/63565 Project: http://git-wip-us.apache.org/repos/asf/mesos/repo Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/6fd1399c Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/6fd1399c Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/6fd1399c Branch: refs/heads/master Commit: 6fd1399c2ed9999936681cf7b16951498c3b96eb Parents: 0735c2d Author: Michael Park <mp...@apache.org> Authored: Sat Nov 4 15:21:07 2017 -0700 Committer: Michael Park <mp...@apache.org> Committed: Mon Nov 6 13:56:56 2017 -0800 ---------------------------------------------------------------------- support/mesos-tidy.sh | 30 +++++++++++++++++++++++++++++- 1 file changed, 29 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/mesos/blob/6fd1399c/support/mesos-tidy.sh ---------------------------------------------------------------------- diff --git a/support/mesos-tidy.sh b/support/mesos-tidy.sh index 875108a..c33dfe0 100755 --- a/support/mesos-tidy.sh +++ b/support/mesos-tidy.sh @@ -21,10 +21,38 @@ set -o pipefail MESOS_DIR=$(git rev-parse --show-toplevel) +DEFAULT_CHECKS= + +DEFAULT_CHECKS=${DEFAULT_CHECKS},'clang-diagnostic-*' + +DEFAULT_CHECKS=${DEFAULT_CHECKS},'clang-analyzer-*' +DEFAULT_CHECKS=${DEFAULT_CHECKS},'-clang-analyzer-' +DEFAULT_CHECKS=${DEFAULT_CHECKS},'-clang-analyzer-core.CallAndMessage' +DEFAULT_CHECKS=${DEFAULT_CHECKS},'-clang-analyzer-core.NonNullParamChecker' +DEFAULT_CHECKS=${DEFAULT_CHECKS},'-clang-analyzer-core.NullDereference' +DEFAULT_CHECKS=${DEFAULT_CHECKS},'-clang-analyzer-cplusplus.NewDelete' +DEFAULT_CHECKS=${DEFAULT_CHECKS},'-clang-analyzer-optin.cplusplus.VirtualCall' + +DEFAULT_CHECKS=${DEFAULT_CHECKS},'google-*' +DEFAULT_CHECKS=${DEFAULT_CHECKS},'-google-build-using-namespace' +DEFAULT_CHECKS=${DEFAULT_CHECKS},'-google-default-arguments' +DEFAULT_CHECKS=${DEFAULT_CHECKS},'-google-explicit-constructor' +DEFAULT_CHECKS=${DEFAULT_CHECKS},'-google-global-names-in-headers' +DEFAULT_CHECKS=${DEFAULT_CHECKS},'-google-readability-namespace-comments' +DEFAULT_CHECKS=${DEFAULT_CHECKS},'-google-runtime-int' +DEFAULT_CHECKS=${DEFAULT_CHECKS},'-google-runtime-member-string-references' +DEFAULT_CHECKS=${DEFAULT_CHECKS},'-google-readability-casting' +DEFAULT_CHECKS=${DEFAULT_CHECKS},'-google-runtime-references' + +DEFAULT_CHECKS=${DEFAULT_CHECKS},'mesos-*' +DEFAULT_CHECKS=${DEFAULT_CHECKS},'-mesos-this-capture' + +DEFAULT_CHECKS=${DEFAULT_CHECKS},'readability-redundant-string-cstr' + # Configure how checks are run. These variables can be overridden by setting the # respective environment variables before invoking this script. # TODO(bbannier): Enable more upstream checks by default, e.g., from the Google set. -CHECKS=${CHECKS:-'-*,mesos-*,readability-redundant-string-cstr'} +CHECKS=${CHECKS:-${DEFAULT_CHECKS}} # Check for unstaged or uncommitted changes. if ! $(git diff-index --quiet HEAD --); then
