[GitHub] anirudhacharya commented on issue #13390: Onnx multi output

2018-11-23 Thread GitBox
anirudhacharya commented on issue #13390: Onnx multi output URL: https://github.com/apache/incubator-mxnet/pull/13390#issuecomment-441349615 Thanks for doing this. This is an automated message from the Apache Git Service. To r

[GitHub] anirudhacharya commented on a change in pull request #13390: Onnx multi output

2018-11-23 Thread GitBox
anirudhacharya commented on a change in pull request #13390: Onnx multi output URL: https://github.com/apache/incubator-mxnet/pull/13390#discussion_r236034041 ## File path: python/mxnet/contrib/onnx/mx2onnx/export_onnx.py ## @@ -242,6 +242,14 @@ def create_onnx_graph_proto(

[GitHub] anirudhacharya commented on a change in pull request #13390: Onnx multi output

2018-11-23 Thread GitBox
anirudhacharya commented on a change in pull request #13390: Onnx multi output URL: https://github.com/apache/incubator-mxnet/pull/13390#discussion_r236033976 ## File path: python/mxnet/contrib/onnx/mx2onnx/export_onnx.py ## @@ -294,7 +302,7 @@ def create_onnx_graph_proto(s

[GitHub] anirudhacharya commented on a change in pull request #13390: Onnx multi output

2018-11-23 Thread GitBox
anirudhacharya commented on a change in pull request #13390: Onnx multi output URL: https://github.com/apache/incubator-mxnet/pull/13390#discussion_r236033496 ## File path: tests/python/unittest/test_onnx.py ## @@ -0,0 +1,95 @@ +# Licensed to the Apache Software Foundation

[GitHub] anirudhacharya commented on a change in pull request #13390: Onnx multi output

2018-11-23 Thread GitBox
anirudhacharya commented on a change in pull request #13390: Onnx multi output URL: https://github.com/apache/incubator-mxnet/pull/13390#discussion_r236033889 ## File path: python/mxnet/contrib/onnx/mx2onnx/export_onnx.py ## @@ -242,6 +242,14 @@ def create_onnx_graph_proto(

[incubator-mxnet-site] branch asf-site updated: Bump the publish timestamp.

2018-11-23 Thread zhasheng
This is an automated email from the ASF dual-hosted git repository. zhasheng pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-mxnet-site.git The following commit(s) were added to refs/heads/asf-site by this push: new 4fd5423 Bump the publish ti

[GitHub] safrooze commented on issue #13390: Onnx multi output

2018-11-23 Thread GitBox
safrooze commented on issue #13390: Onnx multi output URL: https://github.com/apache/incubator-mxnet/pull/13390#issuecomment-441345151 @Roshrini Please review. This is an automated message from the Apache Git Service. To respo

[GitHub] safrooze opened a new pull request #13390: Onnx multi output

2018-11-23 Thread GitBox
safrooze opened a new pull request #13390: Onnx multi output URL: https://github.com/apache/incubator-mxnet/pull/13390 ## Description ## ONNX export does not create a correct graph when there are multiple outputs. This PR fixes this bug. ## Checklist ## ### Essentials ### Pl

[GitHub] chinakook commented on issue #13265: MXNet C++Interface reasoning leads to CPU memory leak

2018-11-23 Thread GitBox
chinakook commented on issue #13265: MXNet C++Interface reasoning leads to CPU memory leak URL: https://github.com/apache/incubator-mxnet/issues/13265#issuecomment-441343952 You can drop reshape to avoid this. This is an aut

[GitHub] KellenSunderland closed issue #13133: Manually compile MXNet1.3.0 release code, which is very inefficient after testing.

2018-11-23 Thread GitBox
KellenSunderland closed issue #13133: Manually compile MXNet1.3.0 release code, which is very inefficient after testing. URL: https://github.com/apache/incubator-mxnet/issues/13133 This is an automated message from the Apach

[GitHub] chenyujing1234 commented on issue #13133: Manually compile MXNet1.3.0 release code, which is very inefficient after testing.

2018-11-23 Thread GitBox
chenyujing1234 commented on issue #13133: Manually compile MXNet1.3.0 release code, which is very inefficient after testing. URL: https://github.com/apache/incubator-mxnet/issues/13133#issuecomment-441340238 This problem can be closed. Thank you. --

[GitHub] chenyujing1234 commented on issue #13133: Manually compile MXNet1.3.0 release code, which is very inefficient after testing.

2018-11-23 Thread GitBox
chenyujing1234 commented on issue #13133: Manually compile MXNet1.3.0 release code, which is very inefficient after testing. URL: https://github.com/apache/incubator-mxnet/issues/13133#issuecomment-441340224 It looks like it's openblash that causes me to use only one CPU -

[GitHub] chenyujing1234 commented on issue #13133: Manually compile MXNet1.3.0 release code, which is very inefficient after testing.

2018-11-23 Thread GitBox
chenyujing1234 commented on issue #13133: Manually compile MXNet1.3.0 release code, which is very inefficient after testing. URL: https://github.com/apache/incubator-mxnet/issues/13133#issuecomment-441340202 a solution was found. It's normal not to link openblash -

[GitHub] cyh-ustc opened a new issue #13389: how to carry out unit test on essential classes

2018-11-23 Thread GitBox
cyh-ustc opened a new issue #13389: how to carry out unit test on essential classes URL: https://github.com/apache/incubator-mxnet/issues/13389 Note: Providing complete information in the most concise form is the best way to get help. This issue template serves as the checklist for essenti

[incubator-mxnet-site] branch asf-site updated: Bump the publish timestamp.

2018-11-23 Thread zhasheng
This is an automated email from the ASF dual-hosted git repository. zhasheng pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-mxnet-site.git The following commit(s) were added to refs/heads/asf-site by this push: new acc9699 Bump the publish ti

[incubator-mxnet] branch master updated (aee0953 -> 388a5f4)

2018-11-23 Thread haibin
This is an automated email from the ASF dual-hosted git repository. haibin pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git. from aee0953 Add utility slave (#13383) add 388a5f4 A few operators on graphs stored as CSR (#13290) No n

[GitHub] eric-haibin-lin closed pull request #13290: A few operators on graphs stored as CSR

2018-11-23 Thread GitBox
eric-haibin-lin closed pull request #13290: A few operators on graphs stored as CSR URL: https://github.com/apache/incubator-mxnet/pull/13290 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As thi

[GitHub] KellenSunderland commented on a change in pull request #12922: Support Quantized Fully Connected by INT8 GEMM

2018-11-23 Thread GitBox
KellenSunderland commented on a change in pull request #12922: Support Quantized Fully Connected by INT8 GEMM URL: https://github.com/apache/incubator-mxnet/pull/12922#discussion_r236024098 ## File path: src/operator/quantization/quantized_fully_connected.cc ## @@ -79,6 +8

[GitHub] gaurav-gireesh commented on a change in pull request #13325: [MXNET-1210 ] Gluon Audio - Example

2018-11-23 Thread GitBox
gaurav-gireesh commented on a change in pull request #13325: [MXNET-1210 ] Gluon Audio - Example URL: https://github.com/apache/incubator-mxnet/pull/13325#discussion_r236024030 ## File path: example/gluon/urban_sounds/train.py ## @@ -0,0 +1,161 @@ +# Licensed to the Apache

[GitHub] marcoabreu commented on issue #13362: Add NHWC layout support to Pooling (cuDNN only)

2018-11-23 Thread GitBox
marcoabreu commented on issue #13362: Add NHWC layout support to Pooling (cuDNN only) URL: https://github.com/apache/incubator-mxnet/pull/13362#issuecomment-441320947 I took care of it :) I actually just wanted to show up as contributor of this PR :P Just kidding, I hope everything

[GitHub] marcoabreu commented on issue #13378: [DO NOT MERGE] Testing subrepo by branch

2018-11-23 Thread GitBox
marcoabreu commented on issue #13378: [DO NOT MERGE] Testing subrepo by branch URL: https://github.com/apache/incubator-mxnet/pull/13378#issuecomment-441320837 Gotcha, thanks for the explanation. I'm really curious :) This is

[GitHub] marcoabreu commented on issue #13378: [DO NOT MERGE] Testing subrepo by branch

2018-11-23 Thread GitBox
marcoabreu commented on issue #13378: [DO NOT MERGE] Testing subrepo by branch URL: https://github.com/apache/incubator-mxnet/pull/13378#issuecomment-441320791 Anton submitted a patch to make CI resilient against submodule problems. That should be fine now. But yeah it's a good point

[GitHub] KellenSunderland edited a comment on issue #13378: [DO NOT MERGE] Testing subrepo by branch

2018-11-23 Thread GitBox
KellenSunderland edited a comment on issue #13378: [DO NOT MERGE] Testing subrepo by branch URL: https://github.com/apache/incubator-mxnet/pull/13378#issuecomment-441320108 @marcoabreu Yeah it's a good question. It's actually explained really well in the main PR that prompted me to open t

[GitHub] KellenSunderland commented on issue #13378: [DO NOT MERGE] Testing subrepo by branch

2018-11-23 Thread GitBox
KellenSunderland commented on issue #13378: [DO NOT MERGE] Testing subrepo by branch URL: https://github.com/apache/incubator-mxnet/pull/13378#issuecomment-441320108 @marcoabreu Yeah it's a good question. It's actually explained really well in the main PR that prompted me to open this pr:

[GitHub] marcoabreu commented on issue #13378: [DO NOT MERGE] Testing subrepo by branch

2018-11-23 Thread GitBox
marcoabreu commented on issue #13378: [DO NOT MERGE] Testing subrepo by branch URL: https://github.com/apache/incubator-mxnet/pull/13378#issuecomment-441319894 I know you don't intend to merge this, but do you mind explaining why we rename the folders instead of just updating the repository

[incubator-mxnet] branch master updated: Add utility slave (#13383)

2018-11-23 Thread marcoabreu
This is an automated email from the ASF dual-hosted git repository. marcoabreu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git The following commit(s) were added to refs/heads/master by this push: new aee0953 Add utility slave (#13383)

[GitHub] marcoabreu closed pull request #13383: Add utility slave

2018-11-23 Thread GitBox
marcoabreu closed pull request #13383: Add utility slave URL: https://github.com/apache/incubator-mxnet/pull/13383 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request

[GitHub] marcoabreu commented on issue #13383: Add utility slave

2018-11-23 Thread GitBox
marcoabreu commented on issue #13383: Add utility slave URL: https://github.com/apache/incubator-mxnet/pull/13383#issuecomment-441319629 Thanks for your review! This is an automated message from the Apache Git Service. To resp

[GitHub] marcoabreu closed pull request #13379: DO NOT MERGE: Test performance of MKLDNN without Debug

2018-11-23 Thread GitBox
marcoabreu closed pull request #13379: DO NOT MERGE: Test performance of MKLDNN without Debug URL: https://github.com/apache/incubator-mxnet/pull/13379 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenanc

[GitHub] marcoabreu commented on issue #13383: Add utility slave

2018-11-23 Thread GitBox
marcoabreu commented on issue #13383: Add utility slave URL: https://github.com/apache/incubator-mxnet/pull/13383#issuecomment-441319579 Yes, this PR (and the Backend changes) have been tested on the dev account :) With patch I'm not talking about 1.3.1 or 1.4 but 1.4.1. we would have

[GitHub] KellenSunderland commented on issue #13383: Add utility slave

2018-11-23 Thread GitBox
KellenSunderland commented on issue #13383: Add utility slave URL: https://github.com/apache/incubator-mxnet/pull/13383#issuecomment-441318476 The intent of all software patching is to improve things in one dimension or another. Large changes at a critical time rarely achieve solely their

[GitHub] marcoabreu commented on issue #13383: Add utility slave

2018-11-23 Thread GitBox
marcoabreu commented on issue #13383: Add utility slave URL: https://github.com/apache/incubator-mxnet/pull/13383#issuecomment-441315178 This patch is exactly to improve the stability. We have to merge these changes before the release or we won't be able to support a patch release. ---

[GitHub] KellenSunderland commented on issue #13362: Add NHWC layout support to Pooling (cuDNN only)

2018-11-23 Thread GitBox
KellenSunderland commented on issue #13362: Add NHWC layout support to Pooling (cuDNN only) URL: https://github.com/apache/incubator-mxnet/pull/13362#issuecomment-441315151 Thanks for the contribution guys. FYI: I'm keeping an eye on this one and will do my best to get it past CI. We had

[GitHub] gigasquid opened a new issue #13388: [Clojure] - Add Clojure to the main website docs install

2018-11-23 Thread GitBox
gigasquid opened a new issue #13388: [Clojure] - Add Clojure to the main website docs install URL: https://github.com/apache/incubator-mxnet/issues/13388 Currently Clojure doesn't appear as an option on the main install page of MXNet https://mxnet.incubator.apache.org/install/index.html?

[GitHub] stu1130 commented on issue #13382: Java doc broken link fix and minor update

2018-11-23 Thread GitBox
stu1130 commented on issue #13382: Java doc broken link fix and minor update URL: https://github.com/apache/incubator-mxnet/pull/13382#issuecomment-441314687 @mxnet-label-bot add [pr-awaiting-review] This is an automated messa

[GitHub] KellenSunderland commented on a change in pull request #13378: [DO NOT MERGE] Testing subrepo by branch

2018-11-23 Thread GitBox
KellenSunderland commented on a change in pull request #13378: [DO NOT MERGE] Testing subrepo by branch URL: https://github.com/apache/incubator-mxnet/pull/13378#discussion_r236015665 ## File path: .gitmodules ## @@ -20,12 +20,13 @@ path = 3rdparty/mkldnn u

[GitHub] KellenSunderland commented on issue #13133: Manually compile MXNet1.3.0 release code, which is very inefficient after testing.

2018-11-23 Thread GitBox
KellenSunderland commented on issue #13133: Manually compile MXNet1.3.0 release code, which is very inefficient after testing. URL: https://github.com/apache/incubator-mxnet/issues/13133#issuecomment-441314093 Would you be able to run a simple test (in which you see a performance differen

[GitHub] KellenSunderland commented on issue #13133: Manually compile MXNet1.3.0 release code, which is very inefficient after testing.

2018-11-23 Thread GitBox
KellenSunderland commented on issue #13133: Manually compile MXNet1.3.0 release code, which is very inefficient after testing. URL: https://github.com/apache/incubator-mxnet/issues/13133#issuecomment-441313941 "Later, it was found that the libmxnet.so I compiled is a Debug version. How ca

[GitHub] KellenSunderland commented on issue #13133: Manually compile MXNet1.3.0 release code, which is very inefficient after testing.

2018-11-23 Thread GitBox
KellenSunderland commented on issue #13133: Manually compile MXNet1.3.0 release code, which is very inefficient after testing. URL: https://github.com/apache/incubator-mxnet/issues/13133#issuecomment-441313795 Today I found that tensorRT is not used in compile phase. Does it have any effe

[GitHub] KellenSunderland commented on issue #13133: Manually compile MXNet1.3.0 release code, which is very inefficient after testing.

2018-11-23 Thread GitBox
KellenSunderland commented on issue #13133: Manually compile MXNet1.3.0 release code, which is very inefficient after testing. URL: https://github.com/apache/incubator-mxnet/issues/13133#issuecomment-441313686 I found that the compiled libmxnet. so is only 295M, while the official release

[GitHub] KellenSunderland commented on issue #13337: Issues of running MXNET cu-80 with RTX2080, Nvidia-driver-410, CUDA-8.0, 9.0, 9.2

2018-11-23 Thread GitBox
KellenSunderland commented on issue #13337: Issues of running MXNET cu-80 with RTX2080, Nvidia-driver-410, CUDA-8.0, 9.0, 9.2 URL: https://github.com/apache/incubator-mxnet/issues/13337#issuecomment-441312847 It shouldn't crash if you use Turing, it should just use a possibly less than id

[GitHub] KellenSunderland commented on issue #13380: mxnet bind fails in nvidia jetson tx2 (jetpack 3.3, cuda 9.0)

2018-11-23 Thread GitBox
KellenSunderland commented on issue #13380: mxnet bind fails in nvidia jetson tx2 (jetpack 3.3, cuda 9.0) URL: https://github.com/apache/incubator-mxnet/issues/13380#issuecomment-441312112 Would you be able to share the model with us? Does it bind properly if you use the CPU as your cont

[GitHub] KellenSunderland commented on a change in pull request #13376: Fix incorrect delete in MXExecutorReshape exception handling

2018-11-23 Thread GitBox
KellenSunderland commented on a change in pull request #13376: Fix incorrect delete in MXExecutorReshape exception handling URL: https://github.com/apache/incubator-mxnet/pull/13376#discussion_r236013420 ## File path: src/c_api/c_api_executor.cc ## @@ -560,6 +560,7 @@ int

[GitHub] lanking520 commented on issue #13375: ..

2018-11-23 Thread GitBox
lanking520 commented on issue #13375: .. URL: https://github.com/apache/incubator-mxnet/issues/13375#issuecomment-441310615 @qilei123 close this issue due to lack of information. Please feel free to reopen if you complete the information in your issue. ---

[GitHub] lanking520 closed issue #13375: ..

2018-11-23 Thread GitBox
lanking520 closed issue #13375: .. URL: https://github.com/apache/incubator-mxnet/issues/13375 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above t

[GitHub] YutingZhang commented on a change in pull request #13318: Improving multi-processing reliability for gluon DataLoader

2018-11-23 Thread GitBox
YutingZhang commented on a change in pull request #13318: Improving multi-processing reliability for gluon DataLoader URL: https://github.com/apache/incubator-mxnet/pull/13318#discussion_r236008239 ## File path: python/mxnet/gluon/data/dataloader.py ## @@ -275,9 +284,24 @@

[GitHub] anujsrc opened a new pull request #13387: Fixes #13386 - Refer Warnings

2018-11-23 Thread GitBox
anujsrc opened a new pull request #13387: Fixes #13386 - Refer Warnings URL: https://github.com/apache/incubator-mxnet/pull/13387 ## Description ## Fixes refer warnings as suggested by @gigasquid in https://github.com/apache/incubator-mxnet/issues/13386 Test run no longer has ``re

[GitHub] larroy commented on issue #13364: [MXNET-1225] Always use config.mk in make install instructions

2018-11-23 Thread GitBox
larroy commented on issue #13364: [MXNET-1225] Always use config.mk in make install instructions URL: https://github.com/apache/incubator-mxnet/pull/13364#issuecomment-441292717 I'm not familiar with the compilation in the Scala package. And no CMake doesn't work with config.mk Just

[GitHub] andrewfayres commented on issue #13382: Java doc broken link fix and minor update

2018-11-23 Thread GitBox
andrewfayres commented on issue #13382: Java doc broken link fix and minor update URL: https://github.com/apache/incubator-mxnet/pull/13382#issuecomment-441285820 Changes look good. Thanks for the link fix. CI seems to of failed and needs to be restarted. -

[GitHub] larroy commented on issue #13333: Two C++ unit test failing ACTIVATION_PERF.ExecuteBidirectional ACTIVATION_PERF.TimingCPU

2018-11-23 Thread GitBox
larroy commented on issue #1: Two C++ unit test failing ACTIVATION_PERF.ExecuteBidirectional ACTIVATION_PERF.TimingCPU URL: https://github.com/apache/incubator-mxnet/issues/1#issuecomment-441277310 ElemwiseShape is asserting because the relu shape is 2, but hardcoded as 3 https://

[GitHub] gigasquid opened a new issue #13386: [Clojure] - Remove refer warning

2018-11-23 Thread GitBox
gigasquid opened a new issue #13386: [Clojure] - Remove refer warning URL: https://github.com/apache/incubator-mxnet/issues/13386 Currently on the master branch if you run the clojure package, you will see the warnings: ``` WARNING: ref already refers to: #'clojure.core/ref in nam

[GitHub] gigasquid opened a new issue #13385: [Clojure] - Turn examples into integration tests

2018-11-23 Thread GitBox
gigasquid opened a new issue #13385: [Clojure] - Turn examples into integration tests URL: https://github.com/apache/incubator-mxnet/issues/13385 Currently we have a good set of examples in the Clojure package but it would be nice to be able to run them as integration/ regression tests whe

[GitHub] chenyujing1234 commented on issue #13265: MXNet C++Interface reasoning leads to CPU memory leak

2018-11-23 Thread GitBox
chenyujing1234 commented on issue #13265: MXNet C++Interface reasoning leads to CPU memory leak URL: https://github.com/apache/incubator-mxnet/issues/13265#issuecomment-441266371 Now GPU reasoning will still have memory leaks, troubled for two weeks, now want to go online, but stuck here.

[GitHub] gigasquid opened a new issue #13384: [Clojure] - Port Scala Inference to Clojure Package

2018-11-23 Thread GitBox
gigasquid opened a new issue #13384: [Clojure] - Port Scala Inference to Clojure Package URL: https://github.com/apache/incubator-mxnet/issues/13384 The Scala package has a very nice inference package. It would be nice to port it to the Clojure API. Here is the scala code https://g

[GitHub] yangfly commented on issue #13351: Fix contrib.bipartite_matching malloc defect

2018-11-23 Thread GitBox
yangfly commented on issue #13351: Fix contrib.bipartite_matching malloc defect URL: https://github.com/apache/incubator-mxnet/pull/13351#issuecomment-441260103 This **op** is currently used in [GluonCV](https://github.com/dmlc/gluon-cv/blob/master/gluoncv/nn/matcher.py#L80) And cause me

[GitHub] marcoabreu opened a new pull request #13383: Add utility slave

2018-11-23 Thread GitBox
marcoabreu opened a new pull request #13383: Add utility slave URL: https://github.com/apache/incubator-mxnet/pull/13383 This PR adds utility slaves. The idea of utility slaves is to offload miscellaneous lifecycle-tasks that are not actually part of the task but rather involved to k

[incubator-mxnet-site] branch asf-site updated: Bump the publish timestamp.

2018-11-23 Thread zhasheng
This is an automated email from the ASF dual-hosted git repository. zhasheng pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-mxnet-site.git The following commit(s) were added to refs/heads/asf-site by this push: new 652a38a Bump the publish ti

[GitHub] marcoabreu commented on issue #13380: mxnet bind fails in nvidia jetson tx2 (jetpack 3.3, cuda 9.0)

2018-11-23 Thread GitBox
marcoabreu commented on issue #13380: mxnet bind fails in nvidia jetson tx2 (jetpack 3.3, cuda 9.0) URL: https://github.com/apache/incubator-mxnet/issues/13380#issuecomment-441229026 Hello, thanks for your issue. Could you elaborate how you run the example and could you paste it here?

[GitHub] lebeg commented on a change in pull request #13224: [WIP] Quantize/digitize operator

2018-11-23 Thread GitBox
lebeg commented on a change in pull request #13224: [WIP] Quantize/digitize operator URL: https://github.com/apache/incubator-mxnet/pull/13224#discussion_r235914290 ## File path: src/operator/tensor/digitize_op.h ## @@ -0,0 +1,184 @@ +/* + * Licensed to the Apache Software

[GitHub] lebeg commented on a change in pull request #13224: [WIP] Quantize/digitize operator

2018-11-23 Thread GitBox
lebeg commented on a change in pull request #13224: [WIP] Quantize/digitize operator URL: https://github.com/apache/incubator-mxnet/pull/13224#discussion_r235914956 ## File path: src/operator/tensor/digitize_op.h ## @@ -0,0 +1,184 @@ +/* + * Licensed to the Apache Software

[GitHub] lebeg commented on a change in pull request #13224: [WIP] Quantize/digitize operator

2018-11-23 Thread GitBox
lebeg commented on a change in pull request #13224: [WIP] Quantize/digitize operator URL: https://github.com/apache/incubator-mxnet/pull/13224#discussion_r235914821 ## File path: src/operator/tensor/digitize_op.cu ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software

[GitHub] lebeg commented on a change in pull request #13224: [WIP] Quantize/digitize operator

2018-11-23 Thread GitBox
lebeg commented on a change in pull request #13224: [WIP] Quantize/digitize operator URL: https://github.com/apache/incubator-mxnet/pull/13224#discussion_r235914129 ## File path: src/operator/tensor/digitize_op.h ## @@ -0,0 +1,184 @@ +/* + * Licensed to the Apache Software

[GitHub] taliesinb commented on issue #13376: Fix incorrect delete in MXExecutorReshape exception handling

2018-11-23 Thread GitBox
taliesinb commented on issue #13376: Fix incorrect delete in MXExecutorReshape exception handling URL: https://github.com/apache/incubator-mxnet/pull/13376#issuecomment-441213966 @KellenSunderland good point. I've moved the nullptr set up to just after API_BEGIN. -

[GitHub] lupesko commented on issue #13382: Java doc broken link fix and minor update

2018-11-23 Thread GitBox
lupesko commented on issue #13382: Java doc broken link fix and minor update URL: https://github.com/apache/incubator-mxnet/pull/13382#issuecomment-441213829 @lanking520 @andrewfayres please take a look. @mxnet-label-bot add [pr-awaiting-review] --

[GitHub] lupesko opened a new pull request #13382: Java doc broken link fix and minor update

2018-11-23 Thread GitBox
lupesko opened a new pull request #13382: Java doc broken link fix and minor update URL: https://github.com/apache/incubator-mxnet/pull/13382 ## Description ## The Java on IntelliJ doc has a broken link that this commit fixes, and a couple of minor text edits. ### Changes ###

[GitHub] lupesko commented on a change in pull request #13358: Java demo file-path fix

2018-11-23 Thread GitBox
lupesko commented on a change in pull request #13358: Java demo file-path fix URL: https://github.com/apache/incubator-mxnet/pull/13358#discussion_r235905242 ## File path: scala-package/mxnet-demo/java-demo/README.md ## @@ -2,7 +2,13 @@ This is an project created to use Ma

[GitHub] lupesko commented on a change in pull request #13358: Java demo file-path fix

2018-11-23 Thread GitBox
lupesko commented on a change in pull request #13358: Java demo file-path fix URL: https://github.com/apache/incubator-mxnet/pull/13358#discussion_r235903628 ## File path: scala-package/mxnet-demo/java-demo/README.md ## @@ -2,7 +2,13 @@ This is an project created to use Ma

[GitHub] lupesko commented on a change in pull request #13358: Java demo file-path fix

2018-11-23 Thread GitBox
lupesko commented on a change in pull request #13358: Java demo file-path fix URL: https://github.com/apache/incubator-mxnet/pull/13358#discussion_r235902073 ## File path: docs/tutorials/java/mxnet_java_on_intellij.md ## @@ -86,18 +86,18 @@ Set the project's location. The r

[GitHub] zerolxf opened a new issue #13381: [Feature Request] Support CSRNDArray in kv_store

2018-11-23 Thread GitBox
zerolxf opened a new issue #13381: [Feature Request] Support CSRNDArray in kv_store URL: https://github.com/apache/incubator-mxnet/issues/13381 ## Description In distributed training, communication takes up a lot of time. In order to compress the communication time, an optimization

[GitHub] lebeg commented on a change in pull request #12591: USE_MKLDNN=1 is default in make build (mkldnn must be explicitly turned off)

2018-11-23 Thread GitBox
lebeg commented on a change in pull request #12591: USE_MKLDNN=1 is default in make build (mkldnn must be explicitly turned off) URL: https://github.com/apache/incubator-mxnet/pull/12591#discussion_r235880592 ## File path: ci/docker/runtime_functions.sh ## @@ -170,6 +171,7

[GitHub] MaeThird commented on issue #13370: the official image-classification predict-cpp demo crashed if...

2018-11-23 Thread GitBox
MaeThird commented on issue #13370: the official image-classification predict-cpp demo crashed if... URL: https://github.com/apache/incubator-mxnet/issues/13370#issuecomment-441184017 ha ... the "always the same as the first forward's output" is my fault.Sorry about this.But the crash cau

[GitHub] stu1130 commented on a change in pull request #13062: Add header files required by horovod

2018-11-23 Thread GitBox
stu1130 commented on a change in pull request #13062: Add header files required by horovod URL: https://github.com/apache/incubator-mxnet/pull/13062#discussion_r235867467 ## File path: python/mxnet/libinfo.py ## @@ -77,5 +77,36 @@ def find_lib_path(): return lib_path

[GitHub] stu1130 commented on issue #12485: test_ImageRecordIter_seed_augmentation flaky test fix

2018-11-23 Thread GitBox
stu1130 commented on issue #12485: test_ImageRecordIter_seed_augmentation flaky test fix URL: https://github.com/apache/incubator-mxnet/pull/12485#issuecomment-441175410 @mxnet-label-bot update [pr-awaiting-review] This is an