[GitHub] lanking520 edited a comment on issue #13559: fix for opencv4

2019-01-23 Thread GitBox
lanking520 edited a comment on issue #13559: fix for opencv4 URL: https://github.com/apache/incubator-mxnet/pull/13559#issuecomment-456970202 Do we still have OpenCV 2 and 3 support if we switch the namespace? Since CI now are using CV2 and publish using CV3 If not, we should made th

[GitHub] HyperZealot closed pull request #13564: Enhancement of split op with indices option

2019-01-23 Thread GitBox
HyperZealot closed pull request #13564: Enhancement of split op with indices option URL: https://github.com/apache/incubator-mxnet/pull/13564 This is an automated message from the Apache Git Service. To respond to the messag

[incubator-mxnet] branch master updated: split_v2 (#13687)

2019-01-23 Thread zhasheng
This is an automated email from the ASF dual-hosted git repository. zhasheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git The following commit(s) were added to refs/heads/master by this push: new 45d1a1e split_v2 (#13687) 45d1a1e is

[GitHub] szha merged pull request #13687: split_v2 operator

2019-01-23 Thread GitBox
szha merged pull request #13687: split_v2 operator URL: https://github.com/apache/incubator-mxnet/pull/13687 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use th

[GitHub] leleamol commented on issue #13972: [MXNET-1301] Remove the unnecessary WaitAll statements from inception_inference example

2019-01-23 Thread GitBox
leleamol commented on issue #13972: [MXNET-1301] Remove the unnecessary WaitAll statements from inception_inference example URL: https://github.com/apache/incubator-mxnet/pull/13972#issuecomment-456965179 @ddavydenko @lupesko @sandeep-krishnamurthy

[GitHub] apeforest commented on issue #13667: [MXNET-1253] [WIP] Fix large array issue in topk operator

2019-01-23 Thread GitBox
apeforest commented on issue #13667: [MXNET-1253] [WIP] Fix large array issue in topk operator URL: https://github.com/apache/incubator-mxnet/pull/13667#issuecomment-456958535 Got fully occupied with another project. I will resume this PR when I get some slack next week. -

[incubator-mxnet-site] branch asf-site updated: Bump the publish timestamp.

2019-01-23 Thread zhasheng
This is an automated email from the ASF dual-hosted git repository. zhasheng pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-mxnet-site.git The following commit(s) were added to refs/heads/asf-site by this push: new 80bf1e3 Bump the publish ti

[GitHub] leontalbot edited a comment on issue #13971: clojure: cross-platform unique library dependency

2019-01-23 Thread GitBox
leontalbot edited a comment on issue #13971: clojure: cross-platform unique library dependency URL: https://github.com/apache/incubator-mxnet/issues/13971#issuecomment-456956403 Thank you for taking a look @gigasquid @lanking520 ! Was wondering, globally, would a single artefact take much

[GitHub] leontalbot commented on issue #13971: clojure: cross-platform unique library dependency

2019-01-23 Thread GitBox
leontalbot commented on issue #13971: clojure: cross-platform unique library dependency URL: https://github.com/apache/incubator-mxnet/issues/13971#issuecomment-456956403 Globally, would a single artefact take much more disk space then platform specific ones? Is that an issue? --

[GitHub] leleamol commented on a change in pull request #13680: [MXNET-1121] Example to demonstrate the inference workflow using RNN

2019-01-23 Thread GitBox
leleamol commented on a change in pull request #13680: [MXNET-1121] Example to demonstrate the inference workflow using RNN URL: https://github.com/apache/incubator-mxnet/pull/13680#discussion_r250358286 ## File path: cpp-package/example/inference/sentiment_analysis_rnn.cpp ###

[GitHub] leleamol commented on a change in pull request #13680: [MXNET-1121] Example to demonstrate the inference workflow using RNN

2019-01-23 Thread GitBox
leleamol commented on a change in pull request #13680: [MXNET-1121] Example to demonstrate the inference workflow using RNN URL: https://github.com/apache/incubator-mxnet/pull/13680#discussion_r250356977 ## File path: cpp-package/example/inference/README.md ## @@ -39,3 +39

[GitHub] hetong007 commented on issue #13952: Fix MXNet R package build

2019-01-23 Thread GitBox
hetong007 commented on issue #13952: Fix MXNet R package build URL: https://github.com/apache/incubator-mxnet/pull/13952#issuecomment-456941931 LGTM. @marcoabreu do you have any comments? This is an automated message from the

[GitHub] hetong007 commented on issue #13859: Newly updated Makefile generate path errors

2019-01-23 Thread GitBox
hetong007 commented on issue #13859: Newly updated Makefile generate path errors URL: https://github.com/apache/incubator-mxnet/issues/13859#issuecomment-456927914 @lichen11 instead of removing your `.libPaths()` , how about you install `roxygen2` in your Rstudio server too? -

[GitHub] zhreshold commented on issue #13928: MXNet 1.5.0 is slower than 1.3.0 when intputs are variant

2019-01-23 Thread GitBox
zhreshold commented on issue #13928: MXNet 1.5.0 is slower than 1.3.0 when intputs are variant URL: https://github.com/apache/incubator-mxnet/issues/13928#issuecomment-456927888 @wkcn THanks for the update, can be resolve this issue? ---

[GitHub] marcoabreu commented on a change in pull request #13624: Nightly Tests For Clojure

2019-01-23 Thread GitBox
marcoabreu commented on a change in pull request #13624: Nightly Tests For Clojure URL: https://github.com/apache/incubator-mxnet/pull/13624#discussion_r250330292 ## File path: ci/docker/runtime_functions.sh ## @@ -868,6 +868,14 @@ unittest_ubuntu_cpu_clojure() { ./co

[incubator-mxnet-site] branch asf-site updated: Bump the publish timestamp.

2019-01-23 Thread zhasheng
This is an automated email from the ASF dual-hosted git repository. zhasheng pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-mxnet-site.git The following commit(s) were added to refs/heads/asf-site by this push: new 513f754 Bump the publish ti

[GitHub] leleamol opened a new pull request #13972: [MXNET-1301] Remove the unnecessary WaitAll statements from inception_inference example

2019-01-23 Thread GitBox
leleamol opened a new pull request #13972: [MXNET-1301] Remove the unnecessary WaitAll statements from inception_inference example URL: https://github.com/apache/incubator-mxnet/pull/13972 ## Description ## Th example contains call to WaitAll() function that are not required in some pla

[GitHub] sandeep-krishnamurthy commented on a change in pull request #13680: [MXNET-1121] Example to demonstrate the inference workflow using RNN

2019-01-23 Thread GitBox
sandeep-krishnamurthy commented on a change in pull request #13680: [MXNET-1121] Example to demonstrate the inference workflow using RNN URL: https://github.com/apache/incubator-mxnet/pull/13680#discussion_r250323324 ## File path: cpp-package/example/inference/README.md ##

[GitHub] sandeep-krishnamurthy commented on a change in pull request #13680: [MXNET-1121] Example to demonstrate the inference workflow using RNN

2019-01-23 Thread GitBox
sandeep-krishnamurthy commented on a change in pull request #13680: [MXNET-1121] Example to demonstrate the inference workflow using RNN URL: https://github.com/apache/incubator-mxnet/pull/13680#discussion_r250322034 ## File path: cpp-package/example/inference/sentiment_analysis_rnn

[GitHub] sandeep-krishnamurthy commented on a change in pull request #13680: [MXNET-1121] Example to demonstrate the inference workflow using RNN

2019-01-23 Thread GitBox
sandeep-krishnamurthy commented on a change in pull request #13680: [MXNET-1121] Example to demonstrate the inference workflow using RNN URL: https://github.com/apache/incubator-mxnet/pull/13680#discussion_r250320751 ## File path: cpp-package/example/inference/README.md ##

[GitHub] edisongustavo commented on a change in pull request #13957: Always go through cmake/ChooseBlas.cmake, now we only execute this lo…

2019-01-23 Thread GitBox
edisongustavo commented on a change in pull request #13957: Always go through cmake/ChooseBlas.cmake, now we only execute this lo… URL: https://github.com/apache/incubator-mxnet/pull/13957#discussion_r250321515 ## File path: CMakeLists.txt ## @@ -294,8 +294,8 @@ else()

[GitHub] larroy commented on a change in pull request #13957: Always go through cmake/ChooseBlas.cmake, now we only execute this lo…

2019-01-23 Thread GitBox
larroy commented on a change in pull request #13957: Always go through cmake/ChooseBlas.cmake, now we only execute this lo… URL: https://github.com/apache/incubator-mxnet/pull/13957#discussion_r250313667 ## File path: CMakeLists.txt ## @@ -294,8 +294,8 @@ else() add_def

[GitHub] lanking520 commented on issue #13971: clojure: cross-platform unique library dependency

2019-01-23 Thread GitBox
lanking520 commented on issue #13971: clojure: cross-platform unique library dependency URL: https://github.com/apache/incubator-mxnet/issues/13971#issuecomment-456907017 @gigasquid There are three issues inside: - GPU and CPU are not compiled as the same types, GPU operators are compil

[GitHub] lanking520 commented on a change in pull request #13624: Nightly Tests For Clojure

2019-01-23 Thread GitBox
lanking520 commented on a change in pull request #13624: Nightly Tests For Clojure URL: https://github.com/apache/incubator-mxnet/pull/13624#discussion_r250303716 ## File path: ci/docker/runtime_functions.sh ## @@ -868,6 +868,14 @@ unittest_ubuntu_cpu_clojure() { ./co

[GitHub] frankfliu commented on issue #13969: Hybridization Feature Request (better dynamic shape inference)

2019-01-23 Thread GitBox
frankfliu commented on issue #13969: Hybridization Feature Request (better dynamic shape inference) URL: https://github.com/apache/incubator-mxnet/issues/13969#issuecomment-456899945 @mxnet-label-bot add [gluon] This is an a

[GitHub] frankfliu edited a comment on issue #13968: Hybridization SequenceLast Bug

2019-01-23 Thread GitBox
frankfliu edited a comment on issue #13968: Hybridization SequenceLast Bug URL: https://github.com/apache/incubator-mxnet/issues/13968#issuecomment-456898238 @mxnet-label-bot add [Gluon, operator] This is an automated message

[GitHub] frankfliu commented on issue #13968: Hybridization SequenceLast Bug

2019-01-23 Thread GitBox
frankfliu commented on issue #13968: Hybridization SequenceLast Bug URL: https://github.com/apache/incubator-mxnet/issues/13968#issuecomment-456898238 @mxnet-label-bot [Gluon, operator] This is an automated message from the A

[GitHub] MendelXu edited a comment on issue #13199: Namescope is None when hybridize in multi-threading environment. AttributeError: 'NoneType' object has no attribute '__exit__'

2019-01-23 Thread GitBox
MendelXu edited a comment on issue #13199: Namescope is None when hybridize in multi-threading environment. AttributeError: 'NoneType' object has no attribute '__exit__' URL: https://github.com/apache/incubator-mxnet/issues/13199#issuecomment-456897618 I'm facing the same problem. Has thi

[GitHub] frankfliu commented on issue #13967: Hybrid Variable Pass Through [Bug]

2019-01-23 Thread GitBox
frankfliu commented on issue #13967: Hybrid Variable Pass Through [Bug] URL: https://github.com/apache/incubator-mxnet/issues/13967#issuecomment-456897613 @mxnet-label-bot add [gluon] This is an automated message from the Apa

[GitHub] frankfliu commented on issue #13965: mxnet_coreml_converter unsupported type error

2019-01-23 Thread GitBox
frankfliu commented on issue #13965: mxnet_coreml_converter unsupported type error URL: https://github.com/apache/incubator-mxnet/issues/13965#issuecomment-456896441 @mxnet-label-bot add [Python] This is an automated message

[GitHub] stephenrawls commented on issue #13956: C API should *never* call abort()

2019-01-23 Thread GitBox
stephenrawls commented on issue #13956: C API should *never* call abort() URL: https://github.com/apache/incubator-mxnet/issues/13956#issuecomment-456895966 I can add a second issue if desired, but I'd like to point out that the C++ API has the same problem. https://github.com/apac

[GitHub] frankfliu commented on issue #13970: AttributeError: 'list' object has no attribute 'reshape'

2019-01-23 Thread GitBox
frankfliu commented on issue #13970: AttributeError: 'list' object has no attribute 'reshape' URL: https://github.com/apache/incubator-mxnet/issues/13970#issuecomment-456895556 @mxnet-label-bot add [Python] This is an automa

[GitHub] frankfliu commented on issue #13970: AttributeError: 'list' object has no attribute 'reshape'

2019-01-23 Thread GitBox
frankfliu commented on issue #13970: AttributeError: 'list' object has no attribute 'reshape' URL: https://github.com/apache/incubator-mxnet/issues/13970#issuecomment-456895406 @mxnet-label-bot add [question] This is an auto

[GitHub] codecov-io commented on issue #13966: upload example code for snail with gluon

2019-01-23 Thread GitBox
codecov-io commented on issue #13966: upload example code for snail with gluon URL: https://github.com/apache/incubator-mxnet/pull/13966#issuecomment-456860141 # [Codecov](https://codecov.io/gh/apache/incubator-mxnet/pull/13966?src=pr&el=h1) Report > Merging [#13966](https://codecov.io

[incubator-mxnet] branch ib/ci-jl-win deleted (was 6161e84)

2019-01-23 Thread iblis
This is an automated email from the ASF dual-hosted git repository. iblis pushed a change to branch ib/ci-jl-win in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git. was 6161e84 Julia: add windows-cpu build The revisions that were on this branch are still contained in ot

[incubator-mxnet] branch master updated: Julia: add windows-cpu build (#13937)

2019-01-23 Thread iblis
This is an automated email from the ASF dual-hosted git repository. iblis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git The following commit(s) were added to refs/heads/master by this push: new ce8b083 Julia: add windows-cpu build (#

[GitHub] iblis17 merged pull request #13937: Julia: add windows-cpu build

2019-01-23 Thread GitBox
iblis17 merged pull request #13937: Julia: add windows-cpu build URL: https://github.com/apache/incubator-mxnet/pull/13937 This is an automated message from the Apache Git Service. To respond to the message, please log on Git

[GitHub] lebeg commented on issue #13937: Julia: add windows-cpu build

2019-01-23 Thread GitBox
lebeg commented on issue #13937: Julia: add windows-cpu build URL: https://github.com/apache/incubator-mxnet/pull/13937#issuecomment-456827488 Looks good, only 4 and 5 minutes for the testing parts This is an automated message

[GitHub] soeque1 commented on a change in pull request #13647: Update lip reading example

2019-01-23 Thread GitBox
soeque1 commented on a change in pull request #13647: Update lip reading example URL: https://github.com/apache/incubator-mxnet/pull/13647#discussion_r250219354 ## File path: example/gluon/lipnet/trainer.py ## @@ -0,0 +1,152 @@ +# Licensed to the Apache Software Foundation

[GitHub] soeque1 commented on a change in pull request #13647: Update lip reading example

2019-01-23 Thread GitBox
soeque1 commented on a change in pull request #13647: Update lip reading example URL: https://github.com/apache/incubator-mxnet/pull/13647#discussion_r250219420 ## File path: example/gluon/lipnet/trainer.py ## @@ -0,0 +1,152 @@ +# Licensed to the Apache Software Foundation

[GitHub] soeque1 commented on a change in pull request #13647: Update lip reading example

2019-01-23 Thread GitBox
soeque1 commented on a change in pull request #13647: Update lip reading example URL: https://github.com/apache/incubator-mxnet/pull/13647#discussion_r250213129 ## File path: example/gluon/lipnet/BeamSearch.py ## @@ -0,0 +1,168 @@ +# Licensed to the Apache Software Foundati

[GitHub] gigasquid commented on issue #13971: clojure: cross-platform unique library dependency

2019-01-23 Thread GitBox
gigasquid commented on issue #13971: clojure: cross-platform unique library dependency URL: https://github.com/apache/incubator-mxnet/issues/13971#issuecomment-456815752 Thanks for reporting the issue @leontalbot 😸 @nswamy @lanking520 @andrewfayres @frankfliu I'm wondering

[GitHub] pengzhao-intel commented on issue #13952: Fix MXNet R package build

2019-01-23 Thread GitBox
pengzhao-intel commented on issue #13952: Fix MXNet R package build URL: https://github.com/apache/incubator-mxnet/pull/13952#issuecomment-456810576 @hetong007 could you help take a review? This is an automated message from th

[GitHub] suyz526 commented on issue #13955: adding the gluon implementation of deformable convolution

2019-01-23 Thread GitBox
suyz526 commented on issue #13955: adding the gluon implementation of deformable convolution URL: https://github.com/apache/incubator-mxnet/pull/13955#issuecomment-456808132 The output channels of the convolution for the offset is hardcoded because its size is described in the paper.

[incubator-mxnet] branch ib/ci-jl-win updated (71ac27e -> 6161e84)

2019-01-23 Thread iblis
This is an automated email from the ASF dual-hosted git repository. iblis pushed a change to branch ib/ci-jl-win in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git. discard 71ac27e fix unix-cpu julia build process discard a713aed add comments discard fa0bf5c Revert "try

[GitHub] seujung commented on a change in pull request #13647: Update lip reading example

2019-01-23 Thread GitBox
seujung commented on a change in pull request #13647: Update lip reading example URL: https://github.com/apache/incubator-mxnet/pull/13647#discussion_r250195745 ## File path: example/gluon/lipnet/trainer.py ## @@ -0,0 +1,152 @@ +# Licensed to the Apache Software Foundation

[GitHub] seujung commented on a change in pull request #13647: Update lip reading example

2019-01-23 Thread GitBox
seujung commented on a change in pull request #13647: Update lip reading example URL: https://github.com/apache/incubator-mxnet/pull/13647#discussion_r250195808 ## File path: example/gluon/lipnet/trainer.py ## @@ -0,0 +1,152 @@ +# Licensed to the Apache Software Foundation

[GitHub] seujung commented on a change in pull request #13647: Update lip reading example

2019-01-23 Thread GitBox
seujung commented on a change in pull request #13647: Update lip reading example URL: https://github.com/apache/incubator-mxnet/pull/13647#discussion_r250194621 ## File path: example/gluon/lipnet/data_loader.py ## @@ -0,0 +1,73 @@ +""" +Description : Set DataSet module for

[GitHub] seujung commented on a change in pull request #13647: Update lip reading example

2019-01-23 Thread GitBox
seujung commented on a change in pull request #13647: Update lip reading example URL: https://github.com/apache/incubator-mxnet/pull/13647#discussion_r250194549 ## File path: example/gluon/lipnet/data_loader.py ## @@ -0,0 +1,73 @@ +""" +Description : Set DataSet module for

[incubator-mxnet-site] branch asf-site updated: Bump the publish timestamp.

2019-01-23 Thread zhasheng
This is an automated email from the ASF dual-hosted git repository. zhasheng pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-mxnet-site.git The following commit(s) were added to refs/heads/asf-site by this push: new f9545dc Bump the publish ti

[GitHub] juliusshufan commented on a change in pull request #13895: Add a inference script providing both accuracy and benchmark result for original wide_n_deep example

2019-01-23 Thread GitBox
juliusshufan commented on a change in pull request #13895: Add a inference script providing both accuracy and benchmark result for original wide_n_deep example URL: https://github.com/apache/incubator-mxnet/pull/13895#discussion_r250185628 ## File path: example/sparse/wide_deep/inf

[GitHub] leontalbot opened a new issue #13971: clojure: cross-platform unique library dependency

2019-01-23 Thread GitBox
leontalbot opened a new issue #13971: clojure: cross-platform unique library dependency URL: https://github.com/apache/incubator-mxnet/issues/13971 I am building a clojure library. I'd like to use MxNet in it. I found these different dependencies I could use: [org.apache.mxnet.co

[GitHub] soeque1 edited a comment on issue #13647: Update lip reading example

2019-01-23 Thread GitBox
soeque1 edited a comment on issue #13647: Update lip reading example URL: https://github.com/apache/incubator-mxnet/pull/13647#issuecomment-456786166 @aaronmarkham I have been busy these days. I will update some of thomelane's comments soon.

[GitHub] soeque1 commented on issue #13647: Update lip reading example

2019-01-23 Thread GitBox
soeque1 commented on issue #13647: Update lip reading example URL: https://github.com/apache/incubator-mxnet/pull/13647#issuecomment-456786166 @aaronmarkham I have been busy these days. I will update some of them soon. This is

[GitHub] iblis17 opened a new pull request #13937: Julia: add windows-cpu build

2019-01-23 Thread GitBox
iblis17 opened a new pull request #13937: Julia: add windows-cpu build URL: https://github.com/apache/incubator-mxnet/pull/13937 - [x] Julia v0.7 - [x] Julia v1.0 This is an automated message from the Apache Git Service. To

[GitHub] iblis17 closed pull request #13937: Julia: add windows-cpu build

2019-01-23 Thread GitBox
iblis17 closed pull request #13937: Julia: add windows-cpu build URL: https://github.com/apache/incubator-mxnet/pull/13937 This is an automated message from the Apache Git Service. To respond to the message, please log on Git

[GitHub] larroy commented on a change in pull request #13549: Runtime feature detection

2019-01-23 Thread GitBox
larroy commented on a change in pull request #13549: Runtime feature detection URL: https://github.com/apache/incubator-mxnet/pull/13549#discussion_r250156486 ## File path: python/mxnet/mxfeatures.py ## @@ -0,0 +1,103 @@ +# Licensed to the Apache Software Foundation (ASF) u

[GitHub] larroy commented on a change in pull request #13964: Addresses comments in runtime feature discovery

2019-01-23 Thread GitBox
larroy commented on a change in pull request #13964: Addresses comments in runtime feature discovery URL: https://github.com/apache/incubator-mxnet/pull/13964#discussion_r250154027 ## File path: include/mxnet/c_api.h ## @@ -208,6 +208,24 @@ MXNET_DLL const char *MXGetLastE

[GitHub] larroy commented on a change in pull request #13964: Addresses comments in runtime feature discovery

2019-01-23 Thread GitBox
larroy commented on a change in pull request #13964: Addresses comments in runtime feature discovery URL: https://github.com/apache/incubator-mxnet/pull/13964#discussion_r250154162 ## File path: include/mxnet/mxruntime.h ## @@ -0,0 +1,194 @@ +/* + * Licensed to the

[GitHub] larroy commented on a change in pull request #13964: Addresses comments in runtime feature discovery

2019-01-23 Thread GitBox
larroy commented on a change in pull request #13964: Addresses comments in runtime feature discovery URL: https://github.com/apache/incubator-mxnet/pull/13964#discussion_r250153378 ## File path: include/mxnet/mxruntime.h ## @@ -0,0 +1,194 @@ +/* Review comment:

[GitHub] toufikoss opened a new issue #13970: AttributeError: 'list' object has no attribute 'reshape'

2019-01-23 Thread GitBox
toufikoss opened a new issue #13970: AttributeError: 'list' object has no attribute 'reshape' URL: https://github.com/apache/incubator-mxnet/issues/13970 i have a error in this line of my code python: AttributeError: 'list' object has no attribute 'reshape' the code is def fe

[GitHub] larroy commented on issue #13964: Addresses comments in runtime feature discovery

2019-01-23 Thread GitBox
larroy commented on issue #13964: Addresses comments in runtime feature discovery URL: https://github.com/apache/incubator-mxnet/pull/13964#issuecomment-456759770 Seems CI status is fully missing. This is an automated message

[GitHub] larroy commented on a change in pull request #13964: Addresses comments in runtime feature discovery

2019-01-23 Thread GitBox
larroy commented on a change in pull request #13964: Addresses comments in runtime feature discovery URL: https://github.com/apache/incubator-mxnet/pull/13964#discussion_r250146366 ## File path: python/mxnet/runtime.py ## @@ -0,0 +1,82 @@ +# Licensed to the Apache Software

[GitHub] larroy commented on a change in pull request #13964: Addresses comments in runtime feature discovery

2019-01-23 Thread GitBox
larroy commented on a change in pull request #13964: Addresses comments in runtime feature discovery URL: https://github.com/apache/incubator-mxnet/pull/13964#discussion_r250146123 ## File path: include/mxnet/c_api.h ## @@ -208,6 +208,24 @@ MXNET_DLL const char *MXGetLastE

[GitHub] larroy commented on a change in pull request #13964: Addresses comments in runtime feature discovery

2019-01-23 Thread GitBox
larroy commented on a change in pull request #13964: Addresses comments in runtime feature discovery URL: https://github.com/apache/incubator-mxnet/pull/13964#discussion_r250144412 ## File path: tests/cpp/misc/runtime_test.cc ## @@ -0,0 +1,32 @@ +/* + * Licensed to the Apa

[GitHub] larroy commented on a change in pull request #13964: Addresses comments in runtime feature discovery

2019-01-23 Thread GitBox
larroy commented on a change in pull request #13964: Addresses comments in runtime feature discovery URL: https://github.com/apache/incubator-mxnet/pull/13964#discussion_r250144278 ## File path: include/mxnet/mxruntime.h ## @@ -0,0 +1,194 @@ +/* + * Licensed to the

[GitHub] marcoabreu commented on issue #13955: adding the gluon implementation of deformable convolution

2019-01-23 Thread GitBox
marcoabreu commented on issue #13955: adding the gluon implementation of deformable convolution URL: https://github.com/apache/incubator-mxnet/pull/13955#issuecomment-456732260 https://github.com/apache/incubator-mxnet/blob/master/tests/python/unittest/test_gluon_contrib.py maybe?

[GitHub] dabraude commented on issue #13875: importing mxnet causing subprocess to crash

2019-01-23 Thread GitBox
dabraude commented on issue #13875: importing mxnet causing subprocess to crash URL: https://github.com/apache/incubator-mxnet/issues/13875#issuecomment-456728205 @TaoLv It didn't crash when running overnight so I assume it is working. --

[GitHub] suyz526 commented on issue #13955: adding the gluon implementation of deformable convolution

2019-01-23 Thread GitBox
suyz526 commented on issue #13955: adding the gluon implementation of deformable convolution URL: https://github.com/apache/incubator-mxnet/pull/13955#issuecomment-456712713 @marcoabreu Thanks for your reply! So now I need to add a file for the test cases. Where should I put the file

[GitHub] marcoabreu commented on issue #13966: upload example code for snail with gluon

2019-01-23 Thread GitBox
marcoabreu commented on issue #13966: upload example code for snail with gluon URL: https://github.com/apache/incubator-mxnet/pull/13966#issuecomment-456709401 Thanks a lot for your contribution, this looks great! This is an a

[GitHub] marcoabreu commented on a change in pull request #13966: upload example code for snail with gluon

2019-01-23 Thread GitBox
marcoabreu commented on a change in pull request #13966: upload example code for snail with gluon URL: https://github.com/apache/incubator-mxnet/pull/13966#discussion_r250089612 ## File path: example/gluon/snail/README.md ## @@ -0,0 +1,59 @@ +# SNAIL with Gluon + +--- + +G

[GitHub] marcoabreu edited a comment on issue #13955: adding the gluon implementation of deformable convolution

2019-01-23 Thread GitBox
marcoabreu edited a comment on issue #13955: adding the gluon implementation of deformable convolution URL: https://github.com/apache/incubator-mxnet/pull/13955#issuecomment-456708201 I see, thanks for elaborating :) You just added the new gluon implementation layer, so you don't have to v

[GitHub] marcoabreu commented on issue #13955: adding the gluon implementation of deformable convolution

2019-01-23 Thread GitBox
marcoabreu commented on issue #13955: adding the gluon implementation of deformable convolution URL: https://github.com/apache/incubator-mxnet/pull/13955#issuecomment-456708201 I see, thanks for elaborating :) You just added the new gluon implementation layer, so you don't have to verify t

[GitHub] szha commented on a change in pull request #13964: Addresses comments in runtime feature discovery

2019-01-23 Thread GitBox
szha commented on a change in pull request #13964: Addresses comments in runtime feature discovery URL: https://github.com/apache/incubator-mxnet/pull/13964#discussion_r250088287 ## File path: python/mxnet/runtime.py ## @@ -0,0 +1,82 @@ +# Licensed to the Apache Software F

[GitHub] szha commented on a change in pull request #13964: Addresses comments in runtime feature discovery

2019-01-23 Thread GitBox
szha commented on a change in pull request #13964: Addresses comments in runtime feature discovery URL: https://github.com/apache/incubator-mxnet/pull/13964#discussion_r250087797 ## File path: include/mxnet/c_api.h ## @@ -208,6 +208,24 @@ MXNET_DLL const char *MXGetLastErr

[GitHub] szha commented on a change in pull request #13964: Addresses comments in runtime feature discovery

2019-01-23 Thread GitBox
szha commented on a change in pull request #13964: Addresses comments in runtime feature discovery URL: https://github.com/apache/incubator-mxnet/pull/13964#discussion_r250087026 ## File path: include/mxnet/mxruntime.h ## @@ -0,0 +1,194 @@ +/* Review comment:

[GitHub] marcoabreu commented on a change in pull request #13964: Addresses comments in runtime feature discovery

2019-01-23 Thread GitBox
marcoabreu commented on a change in pull request #13964: Addresses comments in runtime feature discovery URL: https://github.com/apache/incubator-mxnet/pull/13964#discussion_r250086248 ## File path: tests/python/unittest/test_runtime.py ## @@ -0,0 +1,40 @@ +# Licensed to t

[GitHub] marcoabreu commented on a change in pull request #13964: Addresses comments in runtime feature discovery

2019-01-23 Thread GitBox
marcoabreu commented on a change in pull request #13964: Addresses comments in runtime feature discovery URL: https://github.com/apache/incubator-mxnet/pull/13964#discussion_r250086049 ## File path: tests/python/unittest/test_runtime.py ## @@ -0,0 +1,40 @@ +# Licensed to t

[GitHub] marcoabreu commented on a change in pull request #13964: Addresses comments in runtime feature discovery

2019-01-23 Thread GitBox
marcoabreu commented on a change in pull request #13964: Addresses comments in runtime feature discovery URL: https://github.com/apache/incubator-mxnet/pull/13964#discussion_r250086118 ## File path: tests/python/unittest/test_runtime.py ## @@ -0,0 +1,40 @@ +# Licensed to t

[GitHub] marcoabreu commented on a change in pull request #13964: Addresses comments in runtime feature discovery

2019-01-23 Thread GitBox
marcoabreu commented on a change in pull request #13964: Addresses comments in runtime feature discovery URL: https://github.com/apache/incubator-mxnet/pull/13964#discussion_r250086118 ## File path: tests/python/unittest/test_runtime.py ## @@ -0,0 +1,40 @@ +# Licensed to t

<    1   2