[GitHub] ciyongch commented on a change in pull request #14128: MKLDNN based Quantized FullyConnected Operator and its fusion

2019-03-01 Thread GitBox
ciyongch commented on a change in pull request #14128: MKLDNN based Quantized FullyConnected Operator and its fusion URL: https://github.com/apache/incubator-mxnet/pull/14128#discussion_r261482177 ## File path: src/operator/nn/mkldnn/mkldnn_fully_connected.cc ## @@

[GitHub] ciyongch commented on a change in pull request #14128: MKLDNN based Quantized FullyConnected Operator and its fusion

2019-03-01 Thread GitBox
ciyongch commented on a change in pull request #14128: MKLDNN based Quantized FullyConnected Operator and its fusion URL: https://github.com/apache/incubator-mxnet/pull/14128#discussion_r261482044 ## File path: src/operator/nn/mkldnn/mkldnn_fully_connected.cc ## @@

[GitHub] ashokei opened a new issue #14301: SoftmaxOutput crashes with normalization "valid"

2019-03-01 Thread GitBox
ashokei opened a new issue #14301: SoftmaxOutput crashes with normalization "valid" URL: https://github.com/apache/incubator-mxnet/issues/14301 ## Description ## Environment info (Required) ubuntu 16.04 default build and, run below script. ``` import numpy as np

[GitHub] mxnet-label-bot commented on issue #14301: SoftmaxOutput crashes with normalization "valid"

2019-03-01 Thread GitBox
mxnet-label-bot commented on issue #14301: SoftmaxOutput crashes with normalization "valid" URL: https://github.com/apache/incubator-mxnet/issues/14301#issuecomment-468896278 Hey, this is the MXNet Label Bot. Thank you for submitting the issue! I will try and suggest some labels so

[incubator-mxnet-site] branch asf-site updated: Bump the publish timestamp.

2019-03-01 Thread zhasheng
This is an automated email from the ASF dual-hosted git repository. zhasheng pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-mxnet-site.git The following commit(s) were added to refs/heads/asf-site by this push: new 68ce43c Bump the publish

[GitHub] yuxihu commented on issue #14300: Add MKLDNN header files in include dir

2019-03-01 Thread GitBox
yuxihu commented on issue #14300: Add MKLDNN header files in include dir URL: https://github.com/apache/incubator-mxnet/pull/14300#issuecomment-468890218 @mxnet-label-bot update [pr-awaiting-review] This is an automated

[GitHub] yuxihu commented on issue #14300: Add MKLDNN header files in include dir

2019-03-01 Thread GitBox
yuxihu commented on issue #14300: Add MKLDNN header files in include dir URL: https://github.com/apache/incubator-mxnet/pull/14300#issuecomment-468890205 @pengzhao-intel @wuxun-zhang @apeforest please help review This is an

[GitHub] yuxihu opened a new pull request #14300: Add MKLDNN header files in include dir

2019-03-01 Thread GitBox
yuxihu opened a new pull request #14300: Add MKLDNN header files in include dir URL: https://github.com/apache/incubator-mxnet/pull/14300 We are hitting segfault when using MKLDNN enabled MXNet library with Horovod. MKLDNN is enabled by default when we are building MXNet from source in

[GitHub] arcadiaphy commented on issue #14223: fix memory-related issues to enable ASAN tests

2019-03-01 Thread GitBox
arcadiaphy commented on issue #14223: fix memory-related issues to enable ASAN tests URL: https://github.com/apache/incubator-mxnet/pull/14223#issuecomment-46565 @szha Submodules are merged and pointed to new commits.

[GitHub] TaoLv commented on a change in pull request #13668: [WIP] Update MKL-DNN to v0.18 release (was: fix the Dense layer issue)

2019-03-01 Thread GitBox
TaoLv commented on a change in pull request #13668: [WIP] Update MKL-DNN to v0.18 release (was: fix the Dense layer issue) URL: https://github.com/apache/incubator-mxnet/pull/13668#discussion_r261813667 ## File path: cmake/DownloadMKLML.cmake ## @@ -19,15 +19,19 @@

[GitHub] zhreshold commented on issue #14290: Optimize NMS

2019-03-01 Thread GitBox
zhreshold commented on issue #14290: Optimize NMS URL: https://github.com/apache/incubator-mxnet/pull/14290#issuecomment-468885206 lgtm, I will leave it open for 24hr before merging this in case others have more comments

[GitHub] DickJC123 commented on a change in pull request #14200: Bulked op segments to allow Variable nodes

2019-03-01 Thread GitBox
DickJC123 commented on a change in pull request #14200: Bulked op segments to allow Variable nodes URL: https://github.com/apache/incubator-mxnet/pull/14200#discussion_r261811596 ## File path: src/executor/graph_executor.cc ## @@ -1211,63 +1212,53 @@ void

[GitHub] DickJC123 commented on a change in pull request #14200: Bulked op segments to allow Variable nodes

2019-03-01 Thread GitBox
DickJC123 commented on a change in pull request #14200: Bulked op segments to allow Variable nodes URL: https://github.com/apache/incubator-mxnet/pull/14200#discussion_r261811596 ## File path: src/executor/graph_executor.cc ## @@ -1211,63 +1212,53 @@ void

[GitHub] IvyBazan commented on issue #14297: 1.4 release

2019-03-01 Thread GitBox
IvyBazan commented on issue #14297: 1.4 release URL: https://github.com/apache/incubator-mxnet/pull/14297#issuecomment-468827823 @aaronmarkham This is an automated message from the Apache Git Service. To respond to the

[GitHub] IvyBazan opened a new pull request #14297: 1.4 release

2019-03-01 Thread GitBox
IvyBazan opened a new pull request #14297: 1.4 release URL: https://github.com/apache/incubator-mxnet/pull/14297 ## Description ## (Brief description on what this PR is about) ## Checklist ## ### Essentials ### Please feel free to remove inapplicable items for your PR. -

[GitHub] stsukrov edited a comment on issue #13846: Unit tests are broken on OSX with cmake build

2019-03-01 Thread GitBox
stsukrov edited a comment on issue #13846: Unit tests are broken on OSX with cmake build URL: https://github.com/apache/incubator-mxnet/issues/13846#issuecomment-468721215 Updated the issue so that impact is clear This is

[GitHub] stsukrov commented on issue #13846: Unit tests are broken on OSX with cmake build

2019-03-01 Thread GitBox
stsukrov commented on issue #13846: Unit tests are broken on OSX with cmake build URL: https://github.com/apache/incubator-mxnet/issues/13846#issuecomment-468817208 We were actually talking about c++ tests This is an

[GitHub] Chouffe commented on issue #14295: [clojure-package] fix docstrings in `normal.clj`

2019-03-01 Thread GitBox
Chouffe commented on issue #14295: [clojure-package] fix docstrings in `normal.clj` URL: https://github.com/apache/incubator-mxnet/pull/14295#issuecomment-468814947 The main issue was in the docstring for `normal` + some extra specs for `uniform` ``` `loc`: Mean (centre) of the

[GitHub] satyakrishnagorti commented on issue #14265: Bug in Optimizer's serializeState and deserializeState methods (Scala)

2019-03-01 Thread GitBox
satyakrishnagorti commented on issue #14265: Bug in Optimizer's serializeState and deserializeState methods (Scala) URL: https://github.com/apache/incubator-mxnet/issues/14265#issuecomment-468810623 Yeah, I will send a PR soon.

[GitHub] leleamol commented on issue #14282: inference using float16 is not faster than float32 for `rnn` model

2019-03-01 Thread GitBox
leleamol commented on issue #14282: inference using float16 is not faster than float32 for `rnn` model URL: https://github.com/apache/incubator-mxnet/issues/14282#issuecomment-468807841 @IvyGongoogle The predict-cpp example mentioned in the issue is designed from image recognition.

[GitHub] sl1pkn07 commented on issue #10951: [MXNET-545] Fix broken cython build

2019-03-01 Thread GitBox
sl1pkn07 commented on issue #10951: [MXNET-545] Fix broken cython build URL: https://github.com/apache/incubator-mxnet/pull/10951#issuecomment-468807144 anyone can rebase this pr? i can't apply it for this https://github.com/apache/incubator-mxnet/issues/10738

[GitHub] gigasquid commented on issue #14295: [clojure-package] fix docstrings in `normal.clj`

2019-03-01 Thread GitBox
gigasquid commented on issue #14295: [clojure-package] fix docstrings in `normal.clj` URL: https://github.com/apache/incubator-mxnet/pull/14295#issuecomment-468806748 It is good to go once the CI tests pass This is an

[GitHub] gigasquid commented on a change in pull request #14295: [clojure-package] fix docstrings in `normal.clj`

2019-03-01 Thread GitBox
gigasquid commented on a change in pull request #14295: [clojure-package] fix docstrings in `normal.clj` URL: https://github.com/apache/incubator-mxnet/pull/14295#discussion_r261752512 ## File path: contrib/clojure-package/src/org/apache/clojure_mxnet/random.clj ## @@

[GitHub] gigasquid commented on a change in pull request #14295: [clojure-package] fix docstrings in `normal.clj`

2019-03-01 Thread GitBox
gigasquid commented on a change in pull request #14295: [clojure-package] fix docstrings in `normal.clj` URL: https://github.com/apache/incubator-mxnet/pull/14295#discussion_r261752693 ## File path: contrib/clojure-package/src/org/apache/clojure_mxnet/random.clj ## @@

[GitHub] leleamol commented on issue #14294: Strange error when training resnet101_v2 with mixed precision

2019-03-01 Thread GitBox
leleamol commented on issue #14294: Strange error when training resnet101_v2 with mixed precision URL: https://github.com/apache/incubator-mxnet/issues/14294#issuecomment-468790037 Thank you for submitting the issue! I'm labeling it so the MXNet community members can help resolve it.

[GitHub] leleamol edited a comment on issue #14294: Strange error when training resnet101_v2 with mixed precision

2019-03-01 Thread GitBox
leleamol edited a comment on issue #14294: Strange error when training resnet101_v2 with mixed precision URL: https://github.com/apache/incubator-mxnet/issues/14294#issuecomment-468790037 Thank you for submitting the issue! I'm labeling it so the MXNet community members can help resolve

[GitHub] zachgk commented on issue #14265: Bug in Optimizer's serializeState and deserializeState methods (Scala)

2019-03-01 Thread GitBox
zachgk commented on issue #14265: Bug in Optimizer's serializeState and deserializeState methods (Scala) URL: https://github.com/apache/incubator-mxnet/issues/14265#issuecomment-468787411 Hey @satyakrishnagorti, it sounds like you have looked at this and know what to change. If you are

[incubator-mxnet-site] branch asf-site updated: Bump the publish timestamp.

2019-03-01 Thread zhasheng
This is an automated email from the ASF dual-hosted git repository. zhasheng pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-mxnet-site.git The following commit(s) were added to refs/heads/asf-site by this push: new ad86d28 Bump the publish

[GitHub] apeforest edited a comment on issue #13846: Unit tests are broken on OSX with cmake build

2019-03-01 Thread GitBox
apeforest edited a comment on issue #13846: Unit tests are broken on OSX with cmake build URL: https://github.com/apache/incubator-mxnet/issues/13846#issuecomment-468768478 Confirmed. I build with ``` cp make/osx.mk config.mk make -j8 nosetests -v tests/python/unittest

[GitHub] apeforest commented on issue #13846: Unit tests are broken on OSX with cmake build

2019-03-01 Thread GitBox
apeforest commented on issue #13846: Unit tests are broken on OSX with cmake build URL: https://github.com/apache/incubator-mxnet/issues/13846#issuecomment-468768478 Confirmed. I build with ``` cp make/osx.mk config.mk make -j8` nosetests -v tests/python/unittest ```

[GitHub] access2rohit opened a new pull request #14296: [WIP]: ensure when one dimension is zero the shape is inferred

2019-03-01 Thread GitBox
access2rohit opened a new pull request #14296: [WIP]: ensure when one dimension is zero the shape is inferred URL: https://github.com/apache/incubator-mxnet/pull/14296 ## Description ## (Brief description on what this PR is about) ## Checklist ## ### Essentials ### Please

[GitHub] lanking520 merged pull request #14000: MXNET-1302 Exclude commons-codec and commons-io from assembled JAR

2019-03-01 Thread GitBox
lanking520 merged pull request #14000: MXNET-1302 Exclude commons-codec and commons-io from assembled JAR URL: https://github.com/apache/incubator-mxnet/pull/14000 This is an automated message from the Apache Git Service.

[incubator-mxnet] branch master updated: MXNET-1302 Exclude commons-codec and commons-io from assembled JAR (#14000)

2019-03-01 Thread lanking
This is an automated email from the ASF dual-hosted git repository. lanking pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git The following commit(s) were added to refs/heads/master by this push: new c6b1fd5 MXNET-1302 Exclude

[GitHub] junrushao1994 commented on issue #14153: Fix shape inference pass

2019-03-01 Thread GitBox
junrushao1994 commented on issue #14153: Fix shape inference pass URL: https://github.com/apache/incubator-mxnet/pull/14153#issuecomment-468757321 @ptrendx Yes, please. I am so sorry for the inconvenience. This is an

[GitHub] ptrendx commented on issue #14153: Fix shape inference pass

2019-03-01 Thread GitBox
ptrendx commented on issue #14153: Fix shape inference pass URL: https://github.com/apache/incubator-mxnet/pull/14153#issuecomment-468756609 Ok, so I should move it back to InferShapeAttr and make my changes there then? This

[GitHub] gordon1992 commented on issue #14000: MXNET-1302 Exclude commons-codec and commons-io from assembled JAR

2019-03-01 Thread GitBox
gordon1992 commented on issue #14000: MXNET-1302 Exclude commons-codec and commons-io from assembled JAR URL: https://github.com/apache/incubator-mxnet/pull/14000#issuecomment-468754795 @mxnet-label-bot update [Maven, Scala, pr-awaiting-merge)

[GitHub] gordon1992 edited a comment on issue #14000: MXNET-1302 Exclude commons-codec and commons-io from assembled JAR

2019-03-01 Thread GitBox
gordon1992 edited a comment on issue #14000: MXNET-1302 Exclude commons-codec and commons-io from assembled JAR URL: https://github.com/apache/incubator-mxnet/pull/14000#issuecomment-468754795 @mxnet-label-bot update [Maven, Scala, pr-awaiting-merge]

[GitHub] junrushao1994 commented on issue #14153: Fix shape inference pass

2019-03-01 Thread GitBox
junrushao1994 commented on issue #14153: Fix shape inference pass URL: https://github.com/apache/incubator-mxnet/pull/14153#issuecomment-468740620 @ptrendx Sorry it is a mistake. I am actually working on two projects, dynamic shape and numpy operators. In dynamic shape, I should make infer

[GitHub] anirudhacharya commented on issue #14189: [Flaky Test] Python3: MKLDNN-GPU test_kvstore_gpu.test_rsp_push_pull

2019-03-01 Thread GitBox
anirudhacharya commented on issue #14189: [Flaky Test] Python3: MKLDNN-GPU test_kvstore_gpu.test_rsp_push_pull URL: https://github.com/apache/incubator-mxnet/issues/14189#issuecomment-468731704 @mxnet-label-bot add [Disabled test]

[GitHub] ptrendx commented on issue #14153: Fix shape inference pass

2019-03-01 Thread GitBox
ptrendx commented on issue #14153: Fix shape inference pass URL: https://github.com/apache/incubator-mxnet/pull/14153#issuecomment-468730232 @junrushao1994 I wanted to rebase this PR on top of the current master and I'm confused - in PR #14193 you made InferShapeAttr as a standalone

[GitHub] mahmoodn commented on issue #14233: seed_state must be int

2019-03-01 Thread GitBox
mahmoodn commented on issue #14233: seed_state must be int URL: https://github.com/apache/incubator-mxnet/issues/14233#issuecomment-468725015 Hi Is there any temporary workaround for that? This is an automated message

[GitHub] stsukrov commented on issue #13846: Unit tests are broken on OSX with cmake build

2019-03-01 Thread GitBox
stsukrov commented on issue #13846: Unit tests are broken on OSX with cmake build URL: https://github.com/apache/incubator-mxnet/issues/13846#issuecomment-468721215 Updated the issue so the impact of the issue is clear This

[GitHub] stsukrov edited a comment on issue #13846: Unit tests are broken on OSX

2019-03-01 Thread GitBox
stsukrov edited a comment on issue #13846: Unit tests are broken on OSX URL: https://github.com/apache/incubator-mxnet/issues/13846#issuecomment-468718437 Rebuild the test with make make test ./mxnet_unit_tests --gtest_filter=FULLY_CONNECTED* **Confirming to be

[GitHub] Chancebair closed pull request #14248: [WIP] Windows Path Changes for New AMIs

2019-03-01 Thread GitBox
Chancebair closed pull request #14248: [WIP] Windows Path Changes for New AMIs URL: https://github.com/apache/incubator-mxnet/pull/14248 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] stsukrov commented on issue #13846: Unit tests are broken on OSX

2019-03-01 Thread GitBox
stsukrov commented on issue #13846: Unit tests are broken on OSX URL: https://github.com/apache/incubator-mxnet/issues/13846#issuecomment-468718437 Rebuild the test with make make test ./mxnet_unit_tests --gtest_filter=FULLY_CONNECTED* **Confirming to be successfull

[GitHub] gigasquid commented on issue #14295: [clojure-package] fix docstrings in `normal.clj`

2019-03-01 Thread GitBox
gigasquid commented on issue #14295: [clojure-package] fix docstrings in `normal.clj` URL: https://github.com/apache/incubator-mxnet/pull/14295#issuecomment-468690247 Thanks for your contribution @Chouffe. I look forward to reviewing it shortly 

[GitHub] Chouffe opened a new pull request #14295: [clojure-package] fix docstrings in `normal.clj`

2019-03-01 Thread GitBox
Chouffe opened a new pull request #14295: [clojure-package] fix docstrings in `normal.clj` URL: https://github.com/apache/incubator-mxnet/pull/14295 ## Description ## * Added spec to catch `high` < `low` in `uniform` * Added spec to catch `scale` <= 0 in `normal` * Added unit

[incubator-mxnet-site] branch asf-site updated: Bump the publish timestamp.

2019-03-01 Thread zhasheng
This is an automated email from the ASF dual-hosted git repository. zhasheng pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-mxnet-site.git The following commit(s) were added to refs/heads/asf-site by this push: new 4b33e8f Bump the publish

[GitHub] Chancebair commented on issue #14190: [Flaky Test] Python3: MKLDNN-GPU test_kvstore_gpu.test_rsp_push_pull

2019-03-01 Thread GitBox
Chancebair commented on issue #14190: [Flaky Test] Python3: MKLDNN-GPU test_kvstore_gpu.test_rsp_push_pull URL: https://github.com/apache/incubator-mxnet/pull/14190#issuecomment-468606783 @anirudhacharya yes in the first comment

[GitHub] wkcn commented on issue #13559: fix for opencv4

2019-03-01 Thread GitBox
wkcn commented on issue #13559: fix for opencv4 URL: https://github.com/apache/incubator-mxnet/pull/13559#issuecomment-468602962 Thanks for your contribution! @daleydeng @szha @zhreshold @anirudh2290 Hi! Is it available to merge this PR? Thanks!

[GitHub] Jessespace commented on issue #14220: Qestion bout nd.waitall()

2019-03-01 Thread GitBox
Jessespace commented on issue #14220: Qestion bout nd.waitall() URL: https://github.com/apache/incubator-mxnet/issues/14220#issuecomment-468584777 > You'll want to start 'time_loadimage' after the load and context change has finished: remember that MXNet operations are asynchronous. And

[GitHub] junrushao1994 commented on issue #14289: [Flaky] test_operator_gpu.test_convolution_multiple_streams

2019-03-01 Thread GitBox
junrushao1994 commented on issue #14289: [Flaky] test_operator_gpu.test_convolution_multiple_streams URL: https://github.com/apache/incubator-mxnet/issues/14289#issuecomment-468583438 @mxnet-label-bot add [Test, Flaky] This

[GitHub] junrushao1994 commented on issue #14288: [Flaky] test_operator_gpu.test_dropout

2019-03-01 Thread GitBox
junrushao1994 commented on issue #14288: [Flaky] test_operator_gpu.test_dropout URL: https://github.com/apache/incubator-mxnet/issues/14288#issuecomment-468583523 @mxnet-label-bot add [Test, Flaky] This is an automated

[GitHub] junrushao1994 commented on issue #14292: [Flaky] test_operator_gpu.test_adamax

2019-03-01 Thread GitBox
junrushao1994 commented on issue #14292: [Flaky] test_operator_gpu.test_adamax URL: https://github.com/apache/incubator-mxnet/issues/14292#issuecomment-468583347 @mxnet-label-bot add [Test, Flaky] This is an automated

[GitHub] yangjin111 opened a new issue #14294: Strange error when training resnet101_v2 with mixed precision

2019-03-01 Thread GitBox
yangjin111 opened a new issue #14294: Strange error when training resnet101_v2 with mixed precision URL: https://github.com/apache/incubator-mxnet/issues/14294 ## Description Firstly,I trained inception_v3 with mixed precision,it work well and I got a good result.But when I train

[GitHub] stsukrov edited a comment on issue #13846: Unit tests are broken on OSX

2019-03-01 Thread GitBox
stsukrov edited a comment on issue #13846: Unit tests are broken on OSX URL: https://github.com/apache/incubator-mxnet/issues/13846#issuecomment-468576825 CLion uses CMake, so we cannot ignore it completely. I'm not even sure, that the default make makes tests. Last time, I found