[GitHub] [incubator-mxnet] seujung commented on issue #13735: update wavenet codes

2019-04-08 Thread GitBox
seujung commented on issue #13735: update wavenet codes URL: https://github.com/apache/incubator-mxnet/pull/13735#issuecomment-481105086 @piyushghai Yes. I solve the suggested issues @marcoabreu Could you check the job fail in sanity? Because, this pull request does not have any test

[GitHub] [incubator-mxnet] wkcn commented on issue #14610: [Feature Request] Disable lazy evaluation

2019-04-08 Thread GitBox
wkcn commented on issue #14610: [Feature Request] Disable lazy evaluation URL: https://github.com/apache/incubator-mxnet/issues/14610#issuecomment-481104183 @eric-haibin-lin Thank you! This is an automated message from the

[GitHub] [incubator-mxnet] eric-haibin-lin commented on issue #14610: [Feature Request] Disable lazy evaluation

2019-04-08 Thread GitBox
eric-haibin-lin commented on issue #14610: [Feature Request] Disable lazy evaluation URL: https://github.com/apache/incubator-mxnet/issues/14610#issuecomment-481098878 @wkcn I would rather say the operators are executed eagerly. The number of ops executed in parallel is controlled by

[GitHub] [incubator-mxnet] ciyongch commented on a change in pull request #14614: [MKLDNN] add quantized sum

2019-04-08 Thread GitBox
ciyongch commented on a change in pull request #14614: [MKLDNN] add quantized sum URL: https://github.com/apache/incubator-mxnet/pull/14614#discussion_r273321316 ## File path: src/operator/quantization/mkldnn/mkldnn_quantized_sum.cc ## @@ -0,0 +1,206 @@ +/* + * Licensed

[GitHub] [incubator-mxnet] ciyongch commented on a change in pull request #14614: [MKLDNN] add quantized sum

2019-04-08 Thread GitBox
ciyongch commented on a change in pull request #14614: [MKLDNN] add quantized sum URL: https://github.com/apache/incubator-mxnet/pull/14614#discussion_r273322248 ## File path: tests/python/quantization/test_quantization.py ## @@ -213,6 +213,71 @@ def

[GitHub] [incubator-mxnet] ifeherva commented on issue #13768: Skip CI pipelines unaffected by code changes. [WIP][Do not merge]

2019-04-08 Thread GitBox
ifeherva commented on issue #13768: Skip CI pipelines unaffected by code changes. [WIP][Do not merge] URL: https://github.com/apache/incubator-mxnet/pull/13768#issuecomment-481098855 @piyushghai sorry, not yet :( This is an

[GitHub] [incubator-mxnet] ciyongch commented on a change in pull request #14614: [MKLDNN] add quantized sum

2019-04-08 Thread GitBox
ciyongch commented on a change in pull request #14614: [MKLDNN] add quantized sum URL: https://github.com/apache/incubator-mxnet/pull/14614#discussion_r273321180 ## File path: src/operator/quantization/mkldnn/mkldnn_quantized_sum.cc ## @@ -0,0 +1,206 @@ +/* + * Licensed

[GitHub] [incubator-mxnet] ciyongch commented on a change in pull request #14614: [MKLDNN] add quantized sum

2019-04-08 Thread GitBox
ciyongch commented on a change in pull request #14614: [MKLDNN] add quantized sum URL: https://github.com/apache/incubator-mxnet/pull/14614#discussion_r273321821 ## File path: src/operator/quantization/quantized_sum.cc ## @@ -0,0 +1,143 @@ +/* + * Licensed to the Apache

[GitHub] [incubator-mxnet] ciyongch commented on a change in pull request #14614: [MKLDNN] add quantized sum

2019-04-08 Thread GitBox
ciyongch commented on a change in pull request #14614: [MKLDNN] add quantized sum URL: https://github.com/apache/incubator-mxnet/pull/14614#discussion_r273322080 ## File path: src/operator/subgraph/mkldnn/mkldnn_subgraph_property.cc ## @@ -21,7 +21,7 @@ #include

[GitHub] [incubator-mxnet] ciyongch commented on a change in pull request #14614: [MKLDNN] add quantized sum

2019-04-08 Thread GitBox
ciyongch commented on a change in pull request #14614: [MKLDNN] add quantized sum URL: https://github.com/apache/incubator-mxnet/pull/14614#discussion_r273320812 ## File path: src/operator/quantization/mkldnn/mkldnn_quantized_sum.cc ## @@ -0,0 +1,206 @@ +/* + * Licensed

[GitHub] [incubator-mxnet] haojin2 commented on issue #14606: Add nd.power and sym.pow

2019-04-08 Thread GitBox
haojin2 commented on issue #14606: Add nd.power and sym.pow URL: https://github.com/apache/incubator-mxnet/pull/14606#issuecomment-481098781 @eric-haibin-lin Done. This is an automated message from the Apache Git Service. To

[GitHub] [incubator-mxnet] eric-haibin-lin commented on issue #14606: Add nd.power and sym.pow

2019-04-08 Thread GitBox
eric-haibin-lin commented on issue #14606: Add nd.power and sym.pow URL: https://github.com/apache/incubator-mxnet/pull/14606#issuecomment-481098558 Can you rebase with master to skip the TRT flaky test? This is an automated

[GitHub] [incubator-mxnet] eric-haibin-lin commented on issue #14243: Fix commands to make doc consistent

2019-04-08 Thread GitBox
eric-haibin-lin commented on issue #14243: Fix commands to make doc consistent URL: https://github.com/apache/incubator-mxnet/pull/14243#issuecomment-481097022 I am suggesting that python specific examples should be added to

[GitHub] [incubator-mxnet] ciyongch commented on a change in pull request #14614: [MKLDNN] add quantized sum

2019-04-08 Thread GitBox
ciyongch commented on a change in pull request #14614: [MKLDNN] add quantized sum URL: https://github.com/apache/incubator-mxnet/pull/14614#discussion_r273320747 ## File path: src/operator/quantization/mkldnn/mkldnn_quantized_sum.cc ## @@ -0,0 +1,206 @@ +/* + * Licensed

[GitHub] [incubator-mxnet] ciyongch commented on a change in pull request #14614: [MKLDNN] add quantized sum

2019-04-08 Thread GitBox
ciyongch commented on a change in pull request #14614: [MKLDNN] add quantized sum URL: https://github.com/apache/incubator-mxnet/pull/14614#discussion_r273319588 ## File path: src/operator/quantization/mkldnn/mkldnn_quantized_sum-inl.h ## @@ -0,0 +1,58 @@ +/* + * Licensed

[GitHub] [incubator-mxnet] pengzhao-intel edited a comment on issue #14619: [Discussion] 1.5.0 Roadmap

2019-04-08 Thread GitBox
pengzhao-intel edited a comment on issue #14619: [Discussion] 1.5.0 Roadmap URL: https://github.com/apache/incubator-mxnet/issues/14619#issuecomment-480110642 MKLDNN Quantization PR Name | PR# -- | -- sum | #14614 relu | #14604 refactor requantize | #14608 improve

[GitHub] [incubator-mxnet] huangzhiyuan commented on a change in pull request #14604: [MKLDNN]Add quantized relu

2019-04-08 Thread GitBox
huangzhiyuan commented on a change in pull request #14604: [MKLDNN]Add quantized relu URL: https://github.com/apache/incubator-mxnet/pull/14604#discussion_r273303769 ## File path: tests/python/quantization/test_quantization.py ## @@ -414,6 +414,57 @@ def

[GitHub] [incubator-mxnet] rongzha1 commented on a change in pull request #14614: [MKLDNN] add quantized sum

2019-04-08 Thread GitBox
rongzha1 commented on a change in pull request #14614: [MKLDNN] add quantized sum URL: https://github.com/apache/incubator-mxnet/pull/14614#discussion_r273301352 ## File path: src/operator/quantization/mkldnn/mkldnn_quantized_sum.cc ## @@ -0,0 +1,203 @@ +/* + * Licensed

[GitHub] [incubator-mxnet] TaoLv commented on a change in pull request #14614: [MKLDNN] add quantized sum

2019-04-08 Thread GitBox
TaoLv commented on a change in pull request #14614: [MKLDNN] add quantized sum URL: https://github.com/apache/incubator-mxnet/pull/14614#discussion_r273300604 ## File path: src/operator/quantization/mkldnn/mkldnn_quantized_sum.cc ## @@ -0,0 +1,203 @@ +/* + * Licensed to

[GitHub] [incubator-mxnet] junrushao1994 commented on issue #14244: Feature request: share memory between numpy.array and mxnet.ndarray

2019-04-08 Thread GitBox
junrushao1994 commented on issue #14244: Feature request: share memory between numpy.array and mxnet.ndarray URL: https://github.com/apache/incubator-mxnet/issues/14244#issuecomment-481069471 @reminisce Sounds good. Will do!

[GitHub] [incubator-mxnet] huangzhiyuan commented on a change in pull request #14604: [MKLDNN]Add quantized relu

2019-04-08 Thread GitBox
huangzhiyuan commented on a change in pull request #14604: [MKLDNN]Add quantized relu URL: https://github.com/apache/incubator-mxnet/pull/14604#discussion_r273297037 ## File path: src/operator/quantization/mkldnn/mkldnn_quantized_act.cc ## @@ -0,0 +1,59 @@ +/* + *

[GitHub] [incubator-mxnet] huangzhiyuan commented on a change in pull request #14604: [MKLDNN]Add quantized relu

2019-04-08 Thread GitBox
huangzhiyuan commented on a change in pull request #14604: [MKLDNN]Add quantized relu URL: https://github.com/apache/incubator-mxnet/pull/14604#discussion_r273297058 ## File path: src/operator/quantization/quantized_activation.cc ## @@ -0,0 +1,138 @@ +/* + * Licensed to

[GitHub] [incubator-mxnet] huangzhiyuan commented on a change in pull request #14604: [MKLDNN]Add quantized relu

2019-04-08 Thread GitBox
huangzhiyuan commented on a change in pull request #14604: [MKLDNN]Add quantized relu URL: https://github.com/apache/incubator-mxnet/pull/14604#discussion_r273296980 ## File path: src/operator/quantization/mkldnn/mkldnn_quantized_act.cc ## @@ -0,0 +1,59 @@ +/* + *

[GitHub] [incubator-mxnet] huangzhiyuan commented on a change in pull request #14604: [MKLDNN]Add quantized relu

2019-04-08 Thread GitBox
huangzhiyuan commented on a change in pull request #14604: [MKLDNN]Add quantized relu URL: https://github.com/apache/incubator-mxnet/pull/14604#discussion_r273297010 ## File path: src/operator/quantization/mkldnn/mkldnn_quantized_act.cc ## @@ -0,0 +1,59 @@ +/* + *

[GitHub] [incubator-mxnet] szha commented on issue #14476: Change RNN OP to stateful

2019-04-08 Thread GitBox
szha commented on issue #14476: Change RNN OP to stateful URL: https://github.com/apache/incubator-mxnet/pull/14476#issuecomment-481065650 @lihaofd thanks for the fix. Could you rebase to the current master? The flaky tests might have been disabled on master already.

[GitHub] [incubator-mxnet] zachgk commented on issue #14647: Avoid secondary deployment of package to local

2019-04-08 Thread GitBox
zachgk commented on issue #14647: Avoid secondary deployment of package to local URL: https://github.com/apache/incubator-mxnet/pull/14647#issuecomment-481065006 @mxnet-label-bot add [Scala, Maven] This is an automated

[GitHub] [incubator-mxnet] zachgk opened a new pull request #14647: Avoid secondary deployment of package to local

2019-04-08 Thread GitBox
zachgk opened a new pull request #14647: Avoid secondary deployment of package to local URL: https://github.com/apache/incubator-mxnet/pull/14647 ## Description ## Avoid creating an org.apache.mxnet.mxnet-deployment artifact when doing a local deployment from Scala @lanking520

[incubator-mxnet-site] branch asf-site updated: Bump the publish timestamp.

2019-04-08 Thread zhasheng
This is an automated email from the ASF dual-hosted git repository. zhasheng pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-mxnet-site.git The following commit(s) were added to refs/heads/asf-site by this push: new cd9029f Bump the publish

[GitHub] [incubator-mxnet] eric-haibin-lin commented on a change in pull request #14627: Speed up SequenceReverse

2019-04-08 Thread GitBox
eric-haibin-lin commented on a change in pull request #14627: Speed up SequenceReverse URL: https://github.com/apache/incubator-mxnet/pull/14627#discussion_r273293692 ## File path: src/operator/sequence_reverse-inl.h ## @@ -118,9 +115,25 @@ class SequenceReverseOp :

[GitHub] [incubator-mxnet] ChaiBapchya commented on issue #14243: Fix commands to make doc consistent

2019-04-08 Thread GitBox
ChaiBapchya commented on issue #14243: Fix commands to make doc consistent URL: https://github.com/apache/incubator-mxnet/pull/14243#issuecomment-481062055 @piyushghai I am still waiting for conclusive next steps. I am not sure if consensus was reached on dev list or the discussion here.

[GitHub] [incubator-mxnet] piyushghai commented on issue #14534: [DOC] Update ubuntu install instructions from source

2019-04-08 Thread GitBox
piyushghai commented on issue #14534: [DOC] Update ubuntu install instructions from source URL: https://github.com/apache/incubator-mxnet/pull/14534#issuecomment-481060014 @larroy Is this PR good to merge now ? This is an

[GitHub] [incubator-mxnet] piyushghai commented on issue #13083: [MXNET-345] Hardmax operator

2019-04-08 Thread GitBox
piyushghai commented on issue #13083: [MXNET-345] Hardmax operator URL: https://github.com/apache/incubator-mxnet/pull/13083#issuecomment-481059834 @nswamy Can this PR be closed if it's not as per the spec ? This is an

[GitHub] [incubator-mxnet] piyushghai commented on issue #14053: in-place reshape ops

2019-04-08 Thread GitBox
piyushghai commented on issue #14053: in-place reshape ops URL: https://github.com/apache/incubator-mxnet/pull/14053#issuecomment-481059726 @szha Is this good to merge ? This is an automated message from the Apache Git

[GitHub] [incubator-mxnet] piyushghai commented on issue #14028: Cmake blas

2019-04-08 Thread GitBox
piyushghai commented on issue #14028: Cmake blas URL: https://github.com/apache/incubator-mxnet/pull/14028#issuecomment-481059599 @edisongustavo Gentle ping... This is an automated message from the Apache Git Service. To

[GitHub] [incubator-mxnet] xinyu-intel opened a new pull request #14646: Support SSD f32/int8 evaluation on COCO dataset

2019-04-08 Thread GitBox
xinyu-intel opened a new pull request #14646: Support SSD f32/int8 evaluation on COCO dataset URL: https://github.com/apache/incubator-mxnet/pull/14646 ## Description ## This PR enable ssd training and f32/int8 evaluation on coco2014 dataset. Changes: - enable int8

[GitHub] [incubator-mxnet] piyushghai commented on issue #13907: Fixes downloading of data in cpp-package/example/get_data.sh

2019-04-08 Thread GitBox
piyushghai commented on issue #13907: Fixes downloading of data in cpp-package/example/get_data.sh URL: https://github.com/apache/incubator-mxnet/pull/13907#issuecomment-481059479 @larroy Gentle ping... This is an automated

[GitHub] [incubator-mxnet] piyushghai commented on issue #14367: upload snail for gluon

2019-04-08 Thread GitBox
piyushghai commented on issue #14367: upload snail for gluon URL: https://github.com/apache/incubator-mxnet/pull/14367#issuecomment-481059404 @szha Ping for review :) This is an automated message from the Apache Git Service.

[GitHub] [incubator-mxnet] piyushghai commented on issue #14433: Prevent crashes for opencv exception and std::exception

2019-04-08 Thread GitBox
piyushghai commented on issue #14433: Prevent crashes for opencv exception and std::exception URL: https://github.com/apache/incubator-mxnet/pull/14433#issuecomment-481059348 @anirudh2290 Can you rebase with the master branch and resolve merge conflicts ?

[GitHub] [incubator-mxnet] piyushghai commented on issue #14491: Enable slice embedding concat split fuse

2019-04-08 Thread GitBox
piyushghai commented on issue #14491: Enable slice embedding concat split fuse URL: https://github.com/apache/incubator-mxnet/pull/14491#issuecomment-481059211 @apeforest Ping for review... This is an automated message from

[GitHub] [incubator-mxnet] piyushghai commented on issue #14470: Bug fixed: https://github.com/apache/incubator-mxnet/issues/13485

2019-04-08 Thread GitBox
piyushghai commented on issue #14470: Bug fixed: https://github.com/apache/incubator-mxnet/issues/13485 URL: https://github.com/apache/incubator-mxnet/pull/14470#issuecomment-481059273 @devymex Gentle ping This is an

[GitHub] [incubator-mxnet] piyushghai commented on issue #14560: min fix of 'storage_type' index mismatch

2019-04-08 Thread GitBox
piyushghai commented on issue #14560: min fix of 'storage_type' index mismatch URL: https://github.com/apache/incubator-mxnet/pull/14560#issuecomment-481059144 @gssplayer Can you look into the CI failures in order to take this PR forward ?

[GitHub] [incubator-mxnet] piyushghai commented on issue #13906: [MXNET-703] Update onnx-tensorrt for int8/fp16 support

2019-04-08 Thread GitBox
piyushghai commented on issue #13906: [MXNET-703] Update onnx-tensorrt for int8/fp16 support URL: https://github.com/apache/incubator-mxnet/pull/13906#issuecomment-481058939 @vandanavk @Roshrini Ping... This is an automated

[GitHub] [incubator-mxnet] piyushghai commented on issue #14568: NAG Optimizer with multi-precision support

2019-04-08 Thread GitBox
piyushghai commented on issue #14568: NAG Optimizer with multi-precision support URL: https://github.com/apache/incubator-mxnet/pull/14568#issuecomment-481058784 @anirudhacharya Can you look into the CI failures on this one. ?

[GitHub] [incubator-mxnet] piyushghai commented on issue #13886: Fixes for wine detection tutorial

2019-04-08 Thread GitBox
piyushghai commented on issue #13886: Fixes for wine detection tutorial URL: https://github.com/apache/incubator-mxnet/pull/13886#issuecomment-481058865 @larroy Gentle ping... This is an automated message from the Apache Git

[GitHub] [incubator-mxnet] piyushghai commented on issue #14071: [WIP][MXNET-1269] Scoverage

2019-04-08 Thread GitBox
piyushghai commented on issue #14071: [WIP][MXNET-1269] Scoverage URL: https://github.com/apache/incubator-mxnet/pull/14071#issuecomment-481058714 @zachgk Did you get a chance to revisit this PR ? This is an automated

[GitHub] [incubator-mxnet] piyushghai commented on issue #13143: [MXNET-1206] Support NDArray indexing with None and Ellipsis

2019-04-08 Thread GitBox
piyushghai commented on issue #13143: [MXNET-1206] Support NDArray indexing with None and Ellipsis URL: https://github.com/apache/incubator-mxnet/pull/13143#issuecomment-481058542 @kohr-h Did you get a chance to resolve the CI issues on this one ? :) This seems to be a super useful PR

[GitHub] [incubator-mxnet] piyushghai commented on issue #13401: [MXNET-1227] Adding CornerPooling operator

2019-04-08 Thread GitBox
piyushghai commented on issue #13401: [MXNET-1227] Adding CornerPooling operator URL: https://github.com/apache/incubator-mxnet/pull/13401#issuecomment-481058401 @BigDeviltjj Gentle ping... This is an automated message from

[GitHub] [incubator-mxnet] piyushghai commented on issue #14461: [MXNET-1359] Adds a multiclass-MCC metric derived from Pearson

2019-04-08 Thread GitBox
piyushghai commented on issue #14461: [MXNET-1359] Adds a multiclass-MCC metric derived from Pearson URL: https://github.com/apache/incubator-mxnet/pull/14461#issuecomment-481058335 @szha Can you help with the review of this PR ?

[GitHub] [incubator-mxnet] piyushghai commented on issue #14031: Fix transposed convolution in CPU w/o MKLDNN.

2019-04-08 Thread GitBox
piyushghai commented on issue #14031: Fix transposed convolution in CPU w/o MKLDNN. URL: https://github.com/apache/incubator-mxnet/pull/14031#issuecomment-481058161 @apeforest Gentle ping... This is an automated message from

[GitHub] [incubator-mxnet] piyushghai commented on issue #14452: [WIP] Fix the unit test for depthwise convolution

2019-04-08 Thread GitBox
piyushghai commented on issue #14452: [WIP] Fix the unit test for depthwise convolution URL: https://github.com/apache/incubator-mxnet/pull/14452#issuecomment-481057189 @TaoLv Were you able to figure out the test failures here ?

[GitHub] [incubator-mxnet] piyushghai commented on issue #12635: [WIP] initial commit for trace op feature

2019-04-08 Thread GitBox
piyushghai commented on issue #12635: [WIP] initial commit for trace op feature URL: https://github.com/apache/incubator-mxnet/pull/12635#issuecomment-481057255 @samskalicky Any update on this PR ? :) This is an automated

[GitHub] [incubator-mxnet] piyushghai commented on issue #14432: [WIP][Don't merge] Higher order grad support

2019-04-08 Thread GitBox
piyushghai commented on issue #14432: [WIP][Don't merge] Higher order grad support URL: https://github.com/apache/incubator-mxnet/pull/14432#issuecomment-481057071 @larroy Can you look into the CI failures here ? This is an

[GitHub] [incubator-mxnet] piyushghai commented on issue #14320: [WIP]Showing proper error message when quantization is used with CPU context

2019-04-08 Thread GitBox
piyushghai commented on issue #14320: [WIP]Showing proper error message when quantization is used with CPU context URL: https://github.com/apache/incubator-mxnet/pull/14320#issuecomment-481057014 @access2rohit Were you able to figure out the root cause ?

[GitHub] [incubator-mxnet] piyushghai commented on issue #14312: [MXNET-1332][WIP]predict on gpu

2019-04-08 Thread GitBox
piyushghai commented on issue #14312: [MXNET-1332][WIP]predict on gpu URL: https://github.com/apache/incubator-mxnet/pull/14312#issuecomment-481056931 @roywei Is this PR still a WIP ? This is an automated message from the

[GitHub] [incubator-mxnet] piyushghai commented on issue #14296: [WIP]: ensure when one dimension is zero the shape is inferred

2019-04-08 Thread GitBox
piyushghai commented on issue #14296: [WIP]: ensure when one dimension is zero the shape is inferred URL: https://github.com/apache/incubator-mxnet/pull/14296#issuecomment-481056871 @access2rohit Did you get a chance to revisit this PR ?

[GitHub] [incubator-mxnet] piyushghai commented on issue #14252: Allow releasing all gpu memory

2019-04-08 Thread GitBox
piyushghai commented on issue #14252: Allow releasing all gpu memory URL: https://github.com/apache/incubator-mxnet/pull/14252#issuecomment-481056815 @vladoovtcharov Gentle ping... This is an automated message from the Apache

[GitHub] [incubator-mxnet] piyushghai commented on issue #14243: Fix commands to make doc consistent

2019-04-08 Thread GitBox
piyushghai commented on issue #14243: Fix commands to make doc consistent URL: https://github.com/apache/incubator-mxnet/pull/14243#issuecomment-481056731 @ChaiBapchya Can you address the review comments and rebase with the latest master branch ?

[GitHub] [incubator-mxnet] piyushghai commented on issue #14251: [WIP] Fix unary operator ceil/floor/trunc when data type is integer

2019-04-08 Thread GitBox
piyushghai commented on issue #14251: [WIP] Fix unary operator ceil/floor/trunc when data type is integer URL: https://github.com/apache/incubator-mxnet/pull/14251#issuecomment-481056773 @apeforest Gentle ping... This is an

[GitHub] [incubator-mxnet] piyushghai commented on issue #14208: Add support for fast variable-length LSTM

2019-04-08 Thread GitBox
piyushghai commented on issue #14208: Add support for fast variable-length LSTM URL: https://github.com/apache/incubator-mxnet/pull/14208#issuecomment-481056609 @stephenrawls Can you rebase with the latest master to resolve the merge conflicts ?

[GitHub] [incubator-mxnet] piyushghai commented on issue #14042: [MXNET-891] Support tuple of scales in upsample operator

2019-04-08 Thread GitBox
piyushghai commented on issue #14042: [MXNET-891] Support tuple of scales in upsample operator URL: https://github.com/apache/incubator-mxnet/pull/14042#issuecomment-481056497 @vandanavk Gentle ping... This is an automated

[GitHub] [incubator-mxnet] piyushghai commented on issue #13917: [WIP] Enable image classification mem leak test

2019-04-08 Thread GitBox
piyushghai commented on issue #13917: [WIP] Enable image classification mem leak test URL: https://github.com/apache/incubator-mxnet/pull/13917#issuecomment-481056428 @KellenSunderland Gentle ping... This is an automated

[GitHub] [incubator-mxnet] piyushghai commented on issue #13768: Skip CI pipelines unaffected by code changes. [WIP][Do not merge]

2019-04-08 Thread GitBox
piyushghai commented on issue #13768: Skip CI pipelines unaffected by code changes. [WIP][Do not merge] URL: https://github.com/apache/incubator-mxnet/pull/13768#issuecomment-481056375 @ifeherva Were you able to revisit this PR ?

[GitHub] [incubator-mxnet] piyushghai commented on issue #13757: Set ImageNet data augmentation by default

2019-04-08 Thread GitBox
piyushghai commented on issue #13757: Set ImageNet data augmentation by default URL: https://github.com/apache/incubator-mxnet/pull/13757#issuecomment-481056325 @anirudhacharya Ping for review. @ymjiang Can you look into the CI failures ?

[GitHub] [incubator-mxnet] piyushghai commented on issue #13735: update wavenet codes

2019-04-08 Thread GitBox
piyushghai commented on issue #13735: update wavenet codes URL: https://github.com/apache/incubator-mxnet/pull/13735#issuecomment-481056215 @seujung Did you address all the PR feedback ? Also can you look into the failing CI ?

[GitHub] [incubator-mxnet] piyushghai commented on issue #13723: [Don't merge] Test ILP64

2019-04-08 Thread GitBox
piyushghai commented on issue #13723: [Don't merge] Test ILP64 URL: https://github.com/apache/incubator-mxnet/pull/13723#issuecomment-481056063 @TaoLv I see that you've opened up this PR again. Is it still a work in progress ?

[GitHub] [incubator-mxnet] piyushghai commented on issue #13667: [MXNET-1253] [WIP] Fix large array issue in topk operator

2019-04-08 Thread GitBox
piyushghai commented on issue #13667: [MXNET-1253] [WIP] Fix large array issue in topk operator URL: https://github.com/apache/incubator-mxnet/pull/13667#issuecomment-481055946 @apeforest Can you rebase with the current master branch and look into the CI failures ?

[GitHub] [incubator-mxnet] sandeep-krishnamurthy closed pull request #11658: Optimize cached op static memory allocation

2019-04-08 Thread GitBox
sandeep-krishnamurthy closed pull request #11658: Optimize cached op static memory allocation URL: https://github.com/apache/incubator-mxnet/pull/11658 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-mxnet] piyushghai commented on issue #13576: [MXNET-679] Improved CMakeLists.txt

2019-04-08 Thread GitBox
piyushghai commented on issue #13576: [MXNET-679] Improved CMakeLists.txt URL: https://github.com/apache/incubator-mxnet/pull/13576#issuecomment-481055781 @lebeg Can you rebase with the current master branch ? There seems to be a conflict. Is this PR good to go after that ?

[GitHub] [incubator-mxnet] piyushghai commented on issue #13627: [MXNET-895] ONNX import/export: TopK

2019-04-08 Thread GitBox
piyushghai commented on issue #13627: [MXNET-895] ONNX import/export: TopK URL: https://github.com/apache/incubator-mxnet/pull/13627#issuecomment-481055872 @vandanavk Gentle ping... This is an automated message from the

[GitHub] [incubator-mxnet] sandeep-krishnamurthy commented on issue #11658: Optimize cached op static memory allocation

2019-04-08 Thread GitBox
sandeep-krishnamurthy commented on issue #11658: Optimize cached op static memory allocation URL: https://github.com/apache/incubator-mxnet/pull/11658#issuecomment-481055891 To make sure we don't lose the work done in the PR, I have linked this PR in the issue about Gluon Memory

[GitHub] [incubator-mxnet] piyushghai commented on issue #13142: [WIP] cudnnFind** API does not return deterministic algorithms

2019-04-08 Thread GitBox
piyushghai commented on issue #13142: [WIP] cudnnFind** API does not return deterministic algorithms URL: https://github.com/apache/incubator-mxnet/pull/13142#issuecomment-481055653 @apeforest Pinging again for updating this PR.

[GitHub] [incubator-mxnet] sxjscience commented on issue #12821: [MXNET-1095] [WIP] Support higher order gradient for cos, sin, negative, mul

2019-04-08 Thread GitBox
sxjscience commented on issue #12821: [MXNET-1095] [WIP] Support higher order gradient for cos,sin,negative,mul URL: https://github.com/apache/incubator-mxnet/pull/12821#issuecomment-481055459 Yes, it can be closed. Get Outlook for iOS

[GitHub] [incubator-mxnet] piyushghai commented on issue #13132: enabled link checker and doc test during building the doc

2019-04-08 Thread GitBox
piyushghai commented on issue #13132: enabled link checker and doc test during building the doc URL: https://github.com/apache/incubator-mxnet/pull/13132#issuecomment-48106 @mli Ping... This is an automated message from

[GitHub] [incubator-mxnet] piyushghai commented on issue #12893: Dummy-data based benchmarking script for Gluon RNN-API

2019-04-08 Thread GitBox
piyushghai commented on issue #12893: Dummy-data based benchmarking script for Gluon RNN-API URL: https://github.com/apache/incubator-mxnet/pull/12893#issuecomment-481055431 @juliusshufan Were you able to complete this PR ?

[GitHub] [incubator-mxnet] lupesko commented on issue #5034: How to calculate floating-point operations(FLOPS) in mxnet?

2019-04-08 Thread GitBox
lupesko commented on issue #5034: How to calculate floating-point operations(FLOPS) in mxnet? URL: https://github.com/apache/incubator-mxnet/issues/5034#issuecomment-481055359 @mxnet-label-bot add [Feature request] This is

[GitHub] [incubator-mxnet] sandeep-krishnamurthy commented on issue #12226: Memory optimization in GLUON

2019-04-08 Thread GitBox
sandeep-krishnamurthy commented on issue #12226: Memory optimization in GLUON URL: https://github.com/apache/incubator-mxnet/issues/12226#issuecomment-481055511 This PR has a useful fix, however, it was not taken to completion and closed due to inactivity.

[GitHub] [incubator-mxnet] piyushghai commented on issue #12821: [MXNET-1095] [WIP] Support higher order gradient for cos, sin, negative, mul

2019-04-08 Thread GitBox
piyushghai commented on issue #12821: [MXNET-1095] [WIP] Support higher order gradient for cos,sin,negative,mul URL: https://github.com/apache/incubator-mxnet/pull/12821#issuecomment-481055288 @sxjscience Can this PR be closed if the work is being followed up in another PR by @apeforest

[GitHub] [incubator-mxnet] piyushghai commented on issue #12781: Fixed issue #12745

2019-04-08 Thread GitBox
piyushghai commented on issue #12781: Fixed issue #12745 URL: https://github.com/apache/incubator-mxnet/pull/12781#issuecomment-481055165 @LuckyPigeon Were you able to figure out the issue blocking this PR ? This is an

[GitHub] [incubator-mxnet] piyushghai commented on issue #12648: [WIP] Enable Codecov comment

2019-04-08 Thread GitBox
piyushghai commented on issue #12648: [WIP] Enable Codecov comment URL: https://github.com/apache/incubator-mxnet/pull/12648#issuecomment-481055064 @marcoabreu Ping again. Is this PR still a work in progress ? This is an

[GitHub] [incubator-mxnet] piyushghai commented on issue #12502: [NGRAPH] MXNet - nGraph initial integration

2019-04-08 Thread GitBox
piyushghai commented on issue #12502: [NGRAPH] MXNet - nGraph initial integration URL: https://github.com/apache/incubator-mxnet/pull/12502#issuecomment-481054895 @mbrookhart Pinging again. Can you rebase with master branch and address the review comments ?

[GitHub] [incubator-mxnet] lupesko commented on issue #12328: [WIP] [MXNET-857] Add initial NVTX profiler implementation

2019-04-08 Thread GitBox
lupesko commented on issue #12328: [WIP] [MXNET-857] Add initial NVTX profiler implementation URL: https://github.com/apache/incubator-mxnet/pull/12328#issuecomment-481054425 @KellenSunderland is this still WIP? name says it is, label says otherwise

[GitHub] [incubator-mxnet] piyushghai commented on issue #12328: [WIP] [MXNET-857] Add initial NVTX profiler implementation

2019-04-08 Thread GitBox
piyushghai commented on issue #12328: [WIP] [MXNET-857] Add initial NVTX profiler implementation URL: https://github.com/apache/incubator-mxnet/pull/12328#issuecomment-481054267 @anirudh2290 Ping again. This is an automated

[GitHub] [incubator-mxnet] lupesko commented on issue #11658: Optimize cached op static memory allocation

2019-04-08 Thread GitBox
lupesko commented on issue #11658: Optimize cached op static memory allocation URL: https://github.com/apache/incubator-mxnet/pull/11658#issuecomment-481053852 This PR has been open with no follow up for a long time, more than 6 months now. I suggest we close it, it can always be

[GitHub] [incubator-mxnet] gigasquid commented on issue #14195: [Clojure] Add methods based on NDArrayAPI/SymbolAPI

2019-04-08 Thread GitBox
gigasquid commented on issue #14195: [Clojure] Add methods based on NDArrayAPI/SymbolAPI URL: https://github.com/apache/incubator-mxnet/pull/14195#issuecomment-481047794 Oh @kedarbellare - one more thing... Would you mind marking the new api namespaces as `Experimental` ? That way users

[GitHub] [incubator-mxnet] wkcn commented on a change in pull request #14615: Add PushAsyncPtr and PushSyncPtr APIs in engine

2019-04-08 Thread GitBox
wkcn commented on a change in pull request #14615: Add PushAsyncPtr and PushSyncPtr APIs in engine URL: https://github.com/apache/incubator-mxnet/pull/14615#discussion_r272046544 ## File path: include/mxnet/engine.h ## @@ -206,6 +210,43 @@ class MXNET_API Engine {

[GitHub] [incubator-mxnet] reminisce commented on issue #14570: [WIP] use a compile flag to use int64 tensor size

2019-04-08 Thread GitBox
reminisce commented on issue #14570: [WIP] use a compile flag to use int64 tensor size URL: https://github.com/apache/incubator-mxnet/pull/14570#issuecomment-481046080 @larroy Tensors with `ndim=1` are not scalars, but 1D tensors, aka vectors.

[GitHub] [incubator-mxnet] nswamy edited a comment on issue #14629: [MXNET-1333] Estimator and Fit API

2019-04-08 Thread GitBox
nswamy edited a comment on issue #14629: [MXNET-1333] Estimator and Fit API URL: https://github.com/apache/incubator-mxnet/pull/14629#issuecomment-480440884 I am not sure I understand the concerns, What is the problem with 1) ? For 2), the user can create custom event Handler

[GitHub] [incubator-mxnet] reminisce commented on issue #14244: Feature request: share memory between numpy.array and mxnet.ndarray

2019-04-08 Thread GitBox
reminisce commented on issue #14244: Feature request: share memory between numpy.array and mxnet.ndarray URL: https://github.com/apache/incubator-mxnet/issues/14244#issuecomment-481045599 I think adding a parameter to the existing API may introduce certain level of ambiguity which is not

[GitHub] [incubator-mxnet] lanking520 commented on a change in pull request #14645: [MXNET-1383] Java new use of ParamObject

2019-04-08 Thread GitBox
lanking520 commented on a change in pull request #14645: [MXNET-1383] Java new use of ParamObject URL: https://github.com/apache/incubator-mxnet/pull/14645#discussion_r273275396 ## File path: scala-package/core/src/test/java/org/apache/mxnet/javaapi/NDArrayTest.java ##

[GitHub] [incubator-mxnet] zachgk commented on a change in pull request #14645: [MXNET-1383] Java new use of ParamObject

2019-04-08 Thread GitBox
zachgk commented on a change in pull request #14645: [MXNET-1383] Java new use of ParamObject URL: https://github.com/apache/incubator-mxnet/pull/14645#discussion_r273274760 ## File path: scala-package/macros/src/main/scala/org/apache/mxnet/APIDocGenerator.scala ## @@

[GitHub] [incubator-mxnet] zachgk commented on a change in pull request #14645: [MXNET-1383] Java new use of ParamObject

2019-04-08 Thread GitBox
zachgk commented on a change in pull request #14645: [MXNET-1383] Java new use of ParamObject URL: https://github.com/apache/incubator-mxnet/pull/14645#discussion_r273274433 ## File path: scala-package/core/src/test/java/org/apache/mxnet/javaapi/NDArrayTest.java ## @@

[GitHub] [incubator-mxnet] gigasquid commented on issue #14195: [Clojure] Add methods based on NDArrayAPI/SymbolAPI

2019-04-08 Thread GitBox
gigasquid commented on issue #14195: [Clojure] Add methods based on NDArrayAPI/SymbolAPI URL: https://github.com/apache/incubator-mxnet/pull/14195#issuecomment-481040481 I'm also not sure why the unix-gpu keeps failing from CI, might want to try to rebase on master and see if that helps

[GitHub] [incubator-mxnet] gigasquid commented on issue #14195: [Clojure] Add methods based on NDArrayAPI/SymbolAPI

2019-04-08 Thread GitBox
gigasquid commented on issue #14195: [Clojure] Add methods based on NDArrayAPI/SymbolAPI URL: https://github.com/apache/incubator-mxnet/pull/14195#issuecomment-481040277 @kedarbellare - I think the next step after this is to try to get

[GitHub] [incubator-mxnet] wkcn edited a comment on issue #14244: Feature request: share memory between numpy.array and mxnet.ndarray

2019-04-08 Thread GitBox
wkcn edited a comment on issue #14244: Feature request: share memory between numpy.array and mxnet.ndarray URL: https://github.com/apache/incubator-mxnet/issues/14244#issuecomment-481039905 I think it is suitable to add a new argument. # NDArray to NumPy a = mx.nd.array([1,2,3])

[GitHub] [incubator-mxnet] wkcn commented on issue #14244: Feature request: share memory between numpy.array and mxnet.ndarray

2019-04-08 Thread GitBox
wkcn commented on issue #14244: Feature request: share memory between numpy.array and mxnet.ndarray URL: https://github.com/apache/incubator-mxnet/issues/14244#issuecomment-481039905 I think adding a new argument may be better. # NDArray to NumPy a = mx.nd.array([1,2,3]) b =

[GitHub] [incubator-mxnet] gigasquid commented on a change in pull request #14195: [Clojure] Add methods based on NDArrayAPI/SymbolAPI

2019-04-08 Thread GitBox
gigasquid commented on a change in pull request #14195: [Clojure] Add methods based on NDArrayAPI/SymbolAPI URL: https://github.com/apache/incubator-mxnet/pull/14195#discussion_r273271220 ## File path: contrib/clojure-package/test/org/apache/clojure_mxnet/symbol_api_test.clj

[GitHub] [incubator-mxnet] larroy commented on issue #14570: [WIP] use a compile flag to use int64 tensor size

2019-04-08 Thread GitBox
larroy commented on issue #14570: [WIP] use a compile flag to use int64 tensor size URL: https://github.com/apache/incubator-mxnet/pull/14570#issuecomment-481035573 @reminisce why aren't we using ndim=1 for scalars? This is

[GitHub] [incubator-mxnet] yuxihu commented on issue #14615: Add PushAsyncPtr and PushSyncPtr APIs in engine

2019-04-08 Thread GitBox
yuxihu commented on issue #14615: Add PushAsyncPtr and PushSyncPtr APIs in engine URL: https://github.com/apache/incubator-mxnet/pull/14615#issuecomment-481034554 @wkcn Changed based on your suggestion. It worked. Please review again. @mxnet-label-bot add [pr-awaiting-review]

[GitHub] [incubator-mxnet] lanking520 opened a new pull request #14645: [MXNET-1383] Java new use of ParamObject

2019-04-08 Thread GitBox
lanking520 opened a new pull request #14645: [MXNET-1383] Java new use of ParamObject URL: https://github.com/apache/incubator-mxnet/pull/14645 ## Description ## Previously paramObj are created in a weird way. This is a fix to that: `NDArray.new paramObj` -> `new paramObj` The

[GitHub] [incubator-mxnet] junrushao1994 commented on issue #14244: Feature request: share memory between numpy.array and mxnet.ndarray

2019-04-08 Thread GitBox
junrushao1994 commented on issue #14244: Feature request: share memory between numpy.array and mxnet.ndarray URL: https://github.com/apache/incubator-mxnet/issues/14244#issuecomment-481012596 Being lazy for a while, and now I am thinking of adding an API to mxnet. @wkcn @szha @SunDoge

  1   2   3   >