[GitHub] [incubator-mxnet] gyshi commented on a change in pull request #15312: Numpy bitwise_xor operator

2019-07-14 Thread GitBox
gyshi commented on a change in pull request #15312: Numpy bitwise_xor operator URL: https://github.com/apache/incubator-mxnet/pull/15312#discussion_r303298676 ## File path: src/operator/numpy/np_elemwise_binary_op.cc ## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Softwa

[GitHub] [incubator-mxnet] gyshi commented on a change in pull request #15312: Numpy bitwise_xor operator

2019-07-14 Thread GitBox
gyshi commented on a change in pull request #15312: Numpy bitwise_xor operator URL: https://github.com/apache/incubator-mxnet/pull/15312#discussion_r303298696 ## File path: src/operator/numpy/np_elemwise_binary_op.cc ## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Softwa

[GitHub] [incubator-mxnet] gyshi opened a new pull request #15537: Numpy indices

2019-07-14 Thread GitBox
gyshi opened a new pull request #15537: Numpy indices URL: https://github.com/apache/incubator-mxnet/pull/15537 ## Description ## https://docs.scipy.org/doc/numpy/reference/generated/numpy.indices.html?highlight=indices#numpy.indices ## Checklist ## ### Essentials ### Pleas

[GitHub] [incubator-mxnet] kshitij12345 commented on a change in pull request #15531: [MXNET-978] Higher Order Gradient Support `arctan`, `arctanh`, `radians`.

2019-07-14 Thread GitBox
kshitij12345 commented on a change in pull request #15531: [MXNET-978] Higher Order Gradient Support `arctan`, `arctanh`, `radians`. URL: https://github.com/apache/incubator-mxnet/pull/15531#discussion_r303287020 ## File path: src/operator/tensor/util/node_op_util.h ## @@

[GitHub] [incubator-mxnet] gyshi commented on a change in pull request #15461: Numpy logspace

2019-07-14 Thread GitBox
gyshi commented on a change in pull request #15461: Numpy logspace URL: https://github.com/apache/incubator-mxnet/pull/15461#discussion_r303288974 ## File path: tests/python/unittest/test_numpy_op.py ## @@ -1162,6 +1162,70 @@ def test_np_broadcast_arrays(): pass +@

[GitHub] [incubator-mxnet] kshitij12345 commented on a change in pull request #15531: [MXNET-978] Higher Order Gradient Support `arctan`, `arctanh`, `radians`.

2019-07-14 Thread GitBox
kshitij12345 commented on a change in pull request #15531: [MXNET-978] Higher Order Gradient Support `arctan`, `arctanh`, `radians`. URL: https://github.com/apache/incubator-mxnet/pull/15531#discussion_r303287020 ## File path: src/operator/tensor/util/node_op_util.h ## @@

[incubator-mxnet] branch master updated (38a44db -> 6acf7e6)

2019-07-14 Thread wkcn
This is an automated email from the ASF dual-hosted git repository. wkcn pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git. from 38a44db update ratcheck for apache-rat 0.13 release (#15417) add 6acf7e6 Small typo fixes in batch_norm

[GitHub] [incubator-mxnet] wkcn commented on issue #15527: Small typo fixes in batch_norm-inl.h

2019-07-14 Thread GitBox
wkcn commented on issue #15527: Small typo fixes in batch_norm-inl.h URL: https://github.com/apache/incubator-mxnet/pull/15527#issuecomment-511262124 Merged. Thanks for your contribution! This is an automated message from the

[GitHub] [incubator-mxnet] wkcn merged pull request #15527: Small typo fixes in batch_norm-inl.h

2019-07-14 Thread GitBox
wkcn merged pull request #15527: Small typo fixes in batch_norm-inl.h URL: https://github.com/apache/incubator-mxnet/pull/15527 This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [incubator-mxnet] endvroy commented on a change in pull request #15468: Numpy compatible diagflat operator

2019-07-14 Thread GitBox
endvroy commented on a change in pull request #15468: Numpy compatible diagflat operator URL: https://github.com/apache/incubator-mxnet/pull/15468#discussion_r30328 ## File path: src/operator/numpy/np_diagflat_op.cu ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache So

[GitHub] [incubator-mxnet] endvroy commented on a change in pull request #15468: Numpy compatible diagflat operator

2019-07-14 Thread GitBox
endvroy commented on a change in pull request #15468: Numpy compatible diagflat operator URL: https://github.com/apache/incubator-mxnet/pull/15468#discussion_r30322 ## File path: tests/python/unittest/test_numpy_op.py ## @@ -28,6 +28,59 @@ import random +@with_see

[GitHub] [incubator-mxnet] endvroy commented on a change in pull request #15371: numpy compatible dsplit operator

2019-07-14 Thread GitBox
endvroy commented on a change in pull request #15371: numpy compatible dsplit operator URL: https://github.com/apache/incubator-mxnet/pull/15371#discussion_r303276905 ## File path: tests/python/unittest/test_numpy_op.py ## @@ -485,6 +485,55 @@ def hybrid_forward(self, F, a

[GitHub] [incubator-mxnet] endvroy commented on a change in pull request #15371: numpy compatible dsplit operator

2019-07-14 Thread GitBox
endvroy commented on a change in pull request #15371: numpy compatible dsplit operator URL: https://github.com/apache/incubator-mxnet/pull/15371#discussion_r303276891 ## File path: tests/python/unittest/test_numpy_op.py ## @@ -485,6 +485,55 @@ def hybrid_forward(self, F, a

[GitHub] [incubator-mxnet] hzfan commented on a change in pull request #15325: [Numpy] Numpy vstack

2019-07-14 Thread GitBox
hzfan commented on a change in pull request #15325: [Numpy] Numpy vstack URL: https://github.com/apache/incubator-mxnet/pull/15325#discussion_r303276266 ## File path: tests/python/unittest/test_numpy_op.py ## @@ -1162,6 +1162,63 @@ def test_np_broadcast_arrays(): pass

[GitHub] [incubator-mxnet] hzfan commented on a change in pull request #15434: [numpy] numpy copysign

2019-07-14 Thread GitBox
hzfan commented on a change in pull request #15434: [numpy] numpy copysign URL: https://github.com/apache/incubator-mxnet/pull/15434#discussion_r303275346 ## File path: src/operator/numpy/np_elemwise_broadcast_op.cc ## @@ -198,5 +218,25 @@ MXNET_OPERATOR_REGISTER_NP_BINARY

[incubator-mxnet] branch KellenSunderland-patch-2 updated (a572405 -> 2dacd26)

2019-07-14 Thread wkcn
This is an automated email from the ASF dual-hosted git repository. wkcn pushed a change to branch KellenSunderland-patch-2 in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git. from a572405 retrigger ci add 2dacd26 CI No new revisions were added by this update. Sum

[GitHub] [incubator-mxnet] braindotai commented on issue #15536: ONNX export using ONNX 1.5 throws up problem in BatchNorm operator

2019-07-14 Thread GitBox
braindotai commented on issue #15536: ONNX export using ONNX 1.5 throws up problem in BatchNorm operator URL: https://github.com/apache/incubator-mxnet/issues/15536#issuecomment-511216009 This [page](https://mxnet.incubator.apache.org/api/python/contrib/onnx.html) tells that only onnx ver

[GitHub] [incubator-mxnet] braindotai commented on issue #15535: mxnet.io.NDArrayIter does not properly function when len(data) * 2 < batch_size and last_batch_handle='pad'

2019-07-14 Thread GitBox
braindotai commented on issue #15535: mxnet.io.NDArrayIter does not properly function when len(data) * 2 < batch_size and last_batch_handle='pad' URL: https://github.com/apache/incubator-mxnet/issues/15535#issuecomment-511215625 Oh man!! Sorry, I forgot to see what's the default.

[GitHub] [incubator-mxnet] turtleizzy commented on issue #15535: mxnet.io.NDArrayIter does not properly function when len(data) * 2 < batch_size and last_batch_handle='pad'

2019-07-14 Thread GitBox
turtleizzy commented on issue #15535: mxnet.io.NDArrayIter does not properly function when len(data) * 2 < batch_size and last_batch_handle='pad' URL: https://github.com/apache/incubator-mxnet/issues/15535#issuecomment-511213685 > I was running your code, and it looks like `last_batch_hand

[GitHub] [incubator-mxnet] Mut1nyJD opened a new issue #15536: ONNX export using ONNX 1.5 throws up problem in BatchNorm operator

2019-07-14 Thread GitBox
Mut1nyJD opened a new issue #15536: ONNX export using ONNX 1.5 throws up problem in BatchNorm operator URL: https://github.com/apache/incubator-mxnet/issues/15536 ## Description I installed the latest ONNX version 1.5 and now trying to export a standard model (resnet18v2) from the gluon

[GitHub] [incubator-mxnet] mxnet-label-bot commented on issue #15536: ONNX export using ONNX 1.5 throws up problem in BatchNorm operator

2019-07-14 Thread GitBox
mxnet-label-bot commented on issue #15536: ONNX export using ONNX 1.5 throws up problem in BatchNorm operator URL: https://github.com/apache/incubator-mxnet/issues/15536#issuecomment-511211391 Hey, this is the MXNet Label Bot. Thank you for submitting the issue! I will try and suggest

[GitHub] [incubator-mxnet] CynthiaProtector closed issue #15509: Train models under the director '/mxnet/example/gluon/'

2019-07-14 Thread GitBox
CynthiaProtector closed issue #15509: Train models under the director '/mxnet/example/gluon/' URL: https://github.com/apache/incubator-mxnet/issues/15509 This is an automated message from the Apache Git Service. To respond t

[GitHub] [incubator-mxnet] gyshi commented on a change in pull request #15461: Numpy logspace

2019-07-14 Thread GitBox
gyshi commented on a change in pull request #15461: Numpy logspace URL: https://github.com/apache/incubator-mxnet/pull/15461#discussion_r303244073 ## File path: python/mxnet/ndarray/numpy/_op.py ## @@ -1691,3 +1692,101 @@ def arcsin(x, out=None, **kwargs): http://www.m

[incubator-mxnet] branch KellenSunderland-patch-2 updated (e7e9918 -> a572405)

2019-07-14 Thread wkcn
This is an automated email from the ASF dual-hosted git repository. wkcn pushed a change to branch KellenSunderland-patch-2 in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git. from e7e9918 ci add a572405 retrigger ci No new revisions were added by this update. Sum

[GitHub] [incubator-mxnet] braindotai edited a comment on issue #15535: mxnet.io.NDArrayIter does not properly function when len(data) * 2 < batch_size and last_batch_handle='pad'

2019-07-14 Thread GitBox
braindotai edited a comment on issue #15535: mxnet.io.NDArrayIter does not properly function when len(data) * 2 < batch_size and last_batch_handle='pad' URL: https://github.com/apache/incubator-mxnet/issues/15535#issuecomment-511202059 I was running your code, and it looks like `last_batch

[GitHub] [incubator-mxnet] braindotai edited a comment on issue #15535: mxnet.io.NDArrayIter does not properly function when len(data) * 2 < batch_size and last_batch_handle='pad'

2019-07-14 Thread GitBox
braindotai edited a comment on issue #15535: mxnet.io.NDArrayIter does not properly function when len(data) * 2 < batch_size and last_batch_handle='pad' URL: https://github.com/apache/incubator-mxnet/issues/15535#issuecomment-511202059 I was running your code, and it looks like `last_batch

[GitHub] [incubator-mxnet] braindotai commented on issue #15535: mxnet.io.NDArrayIter does not properly function when len(data) * 2 < batch_size and last_batch_handle='pad'

2019-07-14 Thread GitBox
braindotai commented on issue #15535: mxnet.io.NDArrayIter does not properly function when len(data) * 2 < batch_size and last_batch_handle='pad' URL: https://github.com/apache/incubator-mxnet/issues/15535#issuecomment-511202059 I was running your code, and it looks like `last_batch_handle

[GitHub] [incubator-mxnet] braindotai edited a comment on issue #15534: how to get get train-acc and validation-acc per epoch explicitly per epoch?

2019-07-14 Thread GitBox
braindotai edited a comment on issue #15534: how to get get train-acc and validation-acc per epoch explicitly per epoch? URL: https://github.com/apache/incubator-mxnet/issues/15534#issuecomment-511201098 You can pass eval_data(your validation data) and eval_metric(metric for your validati

[GitHub] [incubator-mxnet] braindotai commented on issue #15534: how to get get train-acc and validation-acc per epoch explicitly per epoch?

2019-07-14 Thread GitBox
braindotai commented on issue #15534: how to get get train-acc and validation-acc per epoch explicitly per epoch? URL: https://github.com/apache/incubator-mxnet/issues/15534#issuecomment-511201098 You can pass eval_data in the `.fit` call method as below: ```python # create a module

[GitHub] [incubator-mxnet] braindotai removed a comment on issue #15534: how to get get train-acc and validation-acc per epoch explicitly per epoch?

2019-07-14 Thread GitBox
braindotai removed a comment on issue #15534: how to get get train-acc and validation-acc per epoch explicitly per epoch? URL: https://github.com/apache/incubator-mxnet/issues/15534#issuecomment-511200504 You can pass evaluation data in .fit call as below: ```python # create a mo

[GitHub] [incubator-mxnet] braindotai commented on issue #15534: how to get get train-acc and validation-acc per epoch explicitly per epoch?

2019-07-14 Thread GitBox
braindotai commented on issue #15534: how to get get train-acc and validation-acc per epoch explicitly per epoch? URL: https://github.com/apache/incubator-mxnet/issues/15534#issuecomment-511200504 You can pass evaluation data in .fit call as below: ```python # create a module

[GitHub] [incubator-mxnet] tingying2020 commented on a change in pull request #15519: [Numpy] arctan2, a new branch for pr.

2019-07-14 Thread GitBox
tingying2020 commented on a change in pull request #15519: [Numpy] arctan2, a new branch for pr. URL: https://github.com/apache/incubator-mxnet/pull/15519#discussion_r303236599 ## File path: tests/python/gpu/test_operator_gpu.py ## @@ -2300,6 +2300,81 @@ def test_math():

[GitHub] [incubator-mxnet] tingying2020 commented on a change in pull request #15519: [Numpy] arctan2, a new branch for pr.

2019-07-14 Thread GitBox
tingying2020 commented on a change in pull request #15519: [Numpy] arctan2, a new branch for pr. URL: https://github.com/apache/incubator-mxnet/pull/15519#discussion_r303236584 ## File path: src/operator/numpy/np_elemwise_broadcast_op.cc ## @@ -198,5 +198,74 @@ MXNET_OPER

[GitHub] [incubator-mxnet] tingying2020 commented on a change in pull request #15519: [Numpy] arctan2, a new branch for pr.

2019-07-14 Thread GitBox
tingying2020 commented on a change in pull request #15519: [Numpy] arctan2, a new branch for pr. URL: https://github.com/apache/incubator-mxnet/pull/15519#discussion_r303236592 ## File path: src/operator/numpy/np_elemwise_broadcast_op.cc ## @@ -198,5 +198,74 @@ MXNET_OPER

[GitHub] [incubator-mxnet] tingying2020 commented on a change in pull request #15519: [Numpy] arctan2, a new branch for pr.

2019-07-14 Thread GitBox
tingying2020 commented on a change in pull request #15519: [Numpy] arctan2, a new branch for pr. URL: https://github.com/apache/incubator-mxnet/pull/15519#discussion_r303236607 ## File path: src/operator/numpy/np_elemwise_broadcast_op.cu ## @@ -42,6 +42,12 @@ NNVM_REGISTER

[GitHub] [incubator-mxnet] tingying2020 commented on a change in pull request #15519: [Numpy] arctan2, a new branch for pr.

2019-07-14 Thread GitBox
tingying2020 commented on a change in pull request #15519: [Numpy] arctan2, a new branch for pr. URL: https://github.com/apache/incubator-mxnet/pull/15519#discussion_r303236594 ## File path: tests/python/gpu/test_operator_gpu.py ## @@ -2300,6 +2300,81 @@ def test_math():

[GitHub] [incubator-mxnet] tingying2020 commented on a change in pull request #15519: [Numpy] arctan2, a new branch for pr.

2019-07-14 Thread GitBox
tingying2020 commented on a change in pull request #15519: [Numpy] arctan2, a new branch for pr. URL: https://github.com/apache/incubator-mxnet/pull/15519#discussion_r303236589 ## File path: src/operator/numpy/np_elemwise_broadcast_op.cc ## @@ -198,5 +198,74 @@ MXNET_OPER

[GitHub] [incubator-mxnet] tingying2020 commented on a change in pull request #15519: [Numpy] arctan2, a new branch for pr.

2019-07-14 Thread GitBox
tingying2020 commented on a change in pull request #15519: [Numpy] arctan2, a new branch for pr. URL: https://github.com/apache/incubator-mxnet/pull/15519#discussion_r303236597 ## File path: tests/python/gpu/test_operator_gpu.py ## @@ -2300,6 +2300,81 @@ def test_math():

[GitHub] [incubator-mxnet] tingying2020 commented on a change in pull request #15519: [Numpy] arctan2, a new branch for pr.

2019-07-14 Thread GitBox
tingying2020 commented on a change in pull request #15519: [Numpy] arctan2, a new branch for pr. URL: https://github.com/apache/incubator-mxnet/pull/15519#discussion_r303236578 ## File path: src/operator/numpy/np_elemwise_broadcast_op.cc ## @@ -198,5 +198,74 @@ MXNET_OPER

[GitHub] [incubator-mxnet] zixuanweeei commented on issue #15497: [MKLDNN] Independent gradients requests check with respect to weights and bias of convolution

2019-07-14 Thread GitBox
zixuanweeei commented on issue #15497: [MKLDNN] Independent gradients requests check with respect to weights and bias of convolution URL: https://github.com/apache/incubator-mxnet/pull/15497#issuecomment-511187153 I will take some tests to see whether a low bar works. -

[GitHub] [incubator-mxnet] pengzhao-intel edited a comment on issue #15497: [MKLDNN] Independent gradients requests check with respect to weights and bias of convolution

2019-07-14 Thread GitBox
pengzhao-intel edited a comment on issue #15497: [MKLDNN] Independent gradients requests check with respect to weights and bias of convolution URL: https://github.com/apache/incubator-mxnet/pull/15497#issuecomment-511184375 >the possible precision degradation resulted from the autotuned cud

[GitHub] [incubator-mxnet] pengzhao-intel commented on issue #15497: [MKLDNN] Independent gradients requests check with respect to weights and bias of convolution

2019-07-14 Thread GitBox
pengzhao-intel commented on issue #15497: [MKLDNN] Independent gradients requests check with respect to weights and bias of convolution URL: https://github.com/apache/incubator-mxnet/pull/15497#issuecomment-511184375 > he possible precision degradation resulted from the autotuned cudnn con

[GitHub] [incubator-mxnet] zixuanweeei commented on issue #15497: [MKLDNN] Independent gradients requests check with respect to weights and bias of convolution

2019-07-14 Thread GitBox
zixuanweeei commented on issue #15497: [MKLDNN] Independent gradients requests check with respect to weights and bias of convolution URL: https://github.com/apache/incubator-mxnet/pull/15497#issuecomment-511183395 @pengzhao-intel @TaoLv Please re-review on this PR. It should be noted that

[GitHub] [incubator-mxnet] kshitij12345 edited a comment on issue #15515: [MXNET-978] Higher Order Gradient Support `arcsin`, `arccos`.

2019-07-14 Thread GitBox
kshitij12345 edited a comment on issue #15515: [MXNET-978] Higher Order Gradient Support `arcsin`, `arccos`. URL: https://github.com/apache/incubator-mxnet/pull/15515#issuecomment-511179949 Thank You. Do note that, the other alternative is `2.*(array - np.min(array))/np.ptp(array)-1`, b

[GitHub] [incubator-mxnet] kshitij12345 commented on issue #15253: [MXNET-978] Add higher order gradient support `tan`, `tanh`

2019-07-14 Thread GitBox
kshitij12345 commented on issue #15253: [MXNET-978] Add higher order gradient support `tan`, `tanh` URL: https://github.com/apache/incubator-mxnet/pull/15253#issuecomment-511180019 It is actually confusing. Sure. Thank You. ---

[GitHub] [incubator-mxnet] kshitij12345 commented on issue #15515: [MXNET-978] Higher Order Gradient Support `arcsin`, `arccos`.

2019-07-14 Thread GitBox
kshitij12345 commented on issue #15515: [MXNET-978] Higher Order Gradient Support `arcsin`, `arccos`. URL: https://github.com/apache/incubator-mxnet/pull/15515#issuecomment-511179949 Do note that, the other alternative is `2.*(array - np.min(array))/np.ptp(array)-1`, but we will need to ha