[GitHub] [incubator-mxnet] eric-haibin-lin commented on a change in pull request #15545: Softmax fwd optimization for GPU

2019-07-16 Thread GitBox
eric-haibin-lin commented on a change in pull request #15545: Softmax fwd optimization for GPU URL: https://github.com/apache/incubator-mxnet/pull/15545#discussion_r304229449 ## File path: src/operator/nn/softmax-inl.h ## @@ -218,6 +219,157 @@ __global__ void

[GitHub] [incubator-mxnet] eric-haibin-lin commented on a change in pull request #15545: Softmax fwd optimization for GPU

2019-07-16 Thread GitBox
eric-haibin-lin commented on a change in pull request #15545: Softmax fwd optimization for GPU URL: https://github.com/apache/incubator-mxnet/pull/15545#discussion_r304229757 ## File path: src/operator/nn/softmax-inl.h ## @@ -218,6 +219,157 @@ __global__ void

[GitHub] [incubator-mxnet] kuonangzhe opened a new pull request #15566: Add CUDA ARCH for TX2 & Xavier

2019-07-16 Thread GitBox
kuonangzhe opened a new pull request #15566: Add CUDA ARCH for TX2 & Xavier URL: https://github.com/apache/incubator-mxnet/pull/15566 ## Description ## Add CUDA ARCH for TX2 & Xavier ## Checklist ## ### Essentials ### Please feel free to remove inapplicable items for your

[GitHub] [incubator-mxnet] ckt624 opened a new pull request #15565: Numpy Fix tensordot bug

2019-07-16 Thread GitBox
ckt624 opened a new pull request #15565: Numpy Fix tensordot bug URL: https://github.com/apache/incubator-mxnet/pull/15565 ## Description ## Fix issue #15563. ## Checklist ## ### Essentials ### Please feel free to remove inapplicable items for your PR. - [x] Changes are

[GitHub] [incubator-mxnet] reminisce opened a new pull request #15564: [DO NOT MERGE] Rebase numpy with master

2019-07-16 Thread GitBox
reminisce opened a new pull request #15564: [DO NOT MERGE] Rebase numpy with master URL: https://github.com/apache/incubator-mxnet/pull/15564 ## Description ## Will be closed after running CI. ## Checklist ## ### Essentials ### Please feel free to remove inapplicable items

[GitHub] [incubator-mxnet] pengzhao-intel commented on issue #15555: Bug or highly unintuitive and undocumented behaviour corrupting NDArray data(possibly race condition)[MKLDNN][C++]

2019-07-16 Thread GitBox
pengzhao-intel commented on issue #1: Bug or highly unintuitive and undocumented behaviour corrupting NDArray data(possibly race condition)[MKLDNN][C++] URL: https://github.com/apache/incubator-mxnet/issues/1#issuecomment-512102501 @ZhennanQin could you help take a look for this

[GitHub] [incubator-mxnet] cyrusbehr commented on issue #15327: Could not find OpenBlas - docker cross compile armv7

2019-07-16 Thread GitBox
cyrusbehr commented on issue #15327: Could not find OpenBlas - docker cross compile armv7 URL: https://github.com/apache/incubator-mxnet/issues/15327#issuecomment-512101678 I resolved the issue by adding the following steps. ``` # OpenBLAS RUN cd ~ && \ git clone

[GitHub] [incubator-mxnet] cyrusbehr closed issue #15327: Could not find OpenBlas - docker cross compile armv7

2019-07-16 Thread GitBox
cyrusbehr closed issue #15327: Could not find OpenBlas - docker cross compile armv7 URL: https://github.com/apache/incubator-mxnet/issues/15327 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-mxnet] KellenSunderland commented on issue #15551: Bypass cuda/cudnn checks if no driver.

2019-07-16 Thread GitBox
KellenSunderland commented on issue #15551: Bypass cuda/cudnn checks if no driver. URL: https://github.com/apache/incubator-mxnet/pull/15551#issuecomment-512097539 LGTM so far. There's a minor whitespace lint issue picked up by CI.

[GitHub] [incubator-mxnet] hzfan commented on issue #15563: [numpy] np.tensordot fails with 0-size tensor

2019-07-16 Thread GitBox
hzfan commented on issue #15563: [numpy] np.tensordot fails with 0-size tensor URL: https://github.com/apache/incubator-mxnet/issues/15563#issuecomment-512094188 @mxnet-label-bot add [bug] This is an automated message from

[GitHub] [incubator-mxnet] iblis17 commented on issue #15561: Julia path patch

2019-07-16 Thread GitBox
iblis17 commented on issue #15561: Julia path patch URL: https://github.com/apache/incubator-mxnet/pull/15561#issuecomment-512093668 Okay, I can make a patch for rename `MXNET_HOME` to `MXNET_ROOT`, then add a search candidate for `MXNET_LIBRARY_PATH`. In case of `LD_LIBRARY_PATH`,

[GitHub] [incubator-mxnet] hzfan opened a new issue #15563: [numpy] np.tensordot fails with 0-size tensor

2019-07-16 Thread GitBox
hzfan opened a new issue #15563: [numpy] np.tensordot fails with 0-size tensor URL: https://github.com/apache/incubator-mxnet/issues/15563 ## Description np.tensordot does not work with 0-size tensor ## Environment info python 3.7.3 ## Minimum reproducible example

[GitHub] [incubator-mxnet] mxnet-label-bot commented on issue #15563: [numpy] np.tensordot fails with 0-size tensor

2019-07-16 Thread GitBox
mxnet-label-bot commented on issue #15563: [numpy] np.tensordot fails with 0-size tensor URL: https://github.com/apache/incubator-mxnet/issues/15563#issuecomment-512093502 Hey, this is the MXNet Label Bot. Thank you for submitting the issue! I will try and suggest some labels so

[incubator-mxnet] branch numpy updated: Numpy Tensordot Operator (#15349)

2019-07-16 Thread reminisce
This is an automated email from the ASF dual-hosted git repository. reminisce pushed a commit to branch numpy in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git The following commit(s) were added to refs/heads/numpy by this push: new d8d6b3b Numpy Tensordot Operator

[GitHub] [incubator-mxnet] reminisce merged pull request #15349: Numpy Tensordot Operator

2019-07-16 Thread GitBox
reminisce merged pull request #15349: Numpy Tensordot Operator URL: https://github.com/apache/incubator-mxnet/pull/15349 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-mxnet] DickJC123 commented on a change in pull request #15551: Bypass cuda/cudnn checks if no driver.

2019-07-16 Thread GitBox
DickJC123 commented on a change in pull request #15551: Bypass cuda/cudnn checks if no driver. URL: https://github.com/apache/incubator-mxnet/pull/15551#discussion_r304199281 ## File path: src/common/cuda_utils.cc ## @@ -44,8 +44,15 @@ namespace cuda { // Dynamic init

[GitHub] [incubator-mxnet] yzhliu commented on issue #15550: Infra to use tvm write op kernels

2019-07-16 Thread GitBox
yzhliu commented on issue #15550: Infra to use tvm write op kernels URL: https://github.com/apache/incubator-mxnet/pull/15550#issuecomment-512077880 @marcoabreu cmake support added This is an automated message from the Apache

[GitHub] [incubator-mxnet] yzhliu commented on a change in pull request #15550: Infra to use tvm write op kernels

2019-07-16 Thread GitBox
yzhliu commented on a change in pull request #15550: Infra to use tvm write op kernels URL: https://github.com/apache/incubator-mxnet/pull/15550#discussion_r304198688 ## File path: Makefile ## @@ -589,6 +603,30 @@ $(DMLC_CORE)/libdmlc.a: DMLCCORE DMLCCORE: + cd

[GitHub] [incubator-mxnet] gyshi opened a new pull request #15562: Numpy mgrid and ogrid

2019-07-16 Thread GitBox
gyshi opened a new pull request #15562: Numpy mgrid and ogrid URL: https://github.com/apache/incubator-mxnet/pull/15562 ## Description ## [mgrid](https://docs.scipy.org/doc/numpy/reference/generated/numpy.mgrid.html#numpy.mgrid)

[GitHub] [incubator-mxnet] caocao1989 removed a comment on issue #9686: [Discussion] MXNet 2.0 Roadmap (was: APIs that might be a good idea to break in 2.0)

2019-07-16 Thread GitBox
caocao1989 removed a comment on issue #9686: [Discussion] MXNet 2.0 Roadmap (was: APIs that might be a good idea to break in 2.0) URL: https://github.com/apache/incubator-mxnet/issues/9686#issuecomment-491123842 2. Refactor of the C++ package I hope that the syntax of the C++ package

[GitHub] [incubator-mxnet] paulk-asert commented on issue #15544: remove mkl blas lincense

2019-07-16 Thread GitBox
paulk-asert commented on issue #15544: remove mkl blas lincense URL: https://github.com/apache/incubator-mxnet/issues/15544#issuecomment-512050383 I should also note that while removing the section from the source LICENSE file fixes the source tarball, you still seem to have issues with

[GitHub] [incubator-mxnet] sandeep-krishnamurthy commented on issue #15522: [Opperf] Add optimizer update operator benchmarks to opperf

2019-07-16 Thread GitBox
sandeep-krishnamurthy commented on issue #15522: [Opperf] Add optimizer update operator benchmarks to opperf URL: https://github.com/apache/incubator-mxnet/pull/15522#issuecomment-512037632 Thanks for the contribution. I don't see params such as grad, momentum etc. in this PR, how are

[GitHub] [incubator-mxnet] ChaiBapchya commented on a change in pull request #15541: [Opperf] Add normal, uniform ops to random_sampling_operators

2019-07-16 Thread GitBox
ChaiBapchya commented on a change in pull request #15541: [Opperf] Add normal, uniform ops to random_sampling_operators URL: https://github.com/apache/incubator-mxnet/pull/15541#discussion_r304163553 ## File path: benchmark/opperf/utils/op_registry_utils.py ## @@ -212,10

[GitHub] [incubator-mxnet] aaronmarkham opened a new pull request #15561: Julia path patch

2019-07-16 Thread GitBox
aaronmarkham opened a new pull request #15561: Julia path patch URL: https://github.com/apache/incubator-mxnet/pull/15561 ## Description ## Another followup PR to fix the Julia site build and unblock website publishing... Since the website builds so many versions, it does so in their

[GitHub] [incubator-mxnet] karan6181 commented on issue #15560: Add fp16 support for topk

2019-07-16 Thread GitBox
karan6181 commented on issue #15560: Add fp16 support for topk URL: https://github.com/apache/incubator-mxnet/pull/15560#issuecomment-512035771 @mxnet-label-bot add [FP16, Operator, pr-awaiting-review] This is an automated

[GitHub] [incubator-mxnet] karan6181 commented on issue #15559: [MXNET-1294] Add PushPull API

2019-07-16 Thread GitBox
karan6181 commented on issue #15559: [MXNET-1294] Add PushPull API URL: https://github.com/apache/incubator-mxnet/pull/15559#issuecomment-512035526 @mxnet-label-bot add [KVStore, C API, pr-work-in-progress] This is an

[GitHub] [incubator-mxnet] karan6181 commented on issue #15558: WIP: handle fix-gamma in TRT and ONNX conversion

2019-07-16 Thread GitBox
karan6181 commented on issue #15558: WIP: handle fix-gamma in TRT and ONNX conversion URL: https://github.com/apache/incubator-mxnet/pull/15558#issuecomment-512035230 @mxnet-label-bot add [Operator, ONNX, pr-work-in-progress]

[GitHub] [incubator-mxnet] karan6181 commented on issue #15552: Add Deformable V2

2019-07-16 Thread GitBox
karan6181 commented on issue #15552: Add Deformable V2 URL: https://github.com/apache/incubator-mxnet/pull/15552#issuecomment-512035037 @mxnet-label-bot add [Operator, pr-awaiting-response] This is an automated message from

[GitHub] [incubator-mxnet] bloatybo commented on issue #14875: MXNet to ONNX export bug

2019-07-16 Thread GitBox
bloatybo commented on issue #14875: MXNet to ONNX export bug URL: https://github.com/apache/incubator-mxnet/issues/14875#issuecomment-512034878 @ehsanmok I met the same problem with you. I saw the issue has been around for 3 months. Did you solve it?

[GitHub] [incubator-mxnet] karan6181 commented on issue #15551: Bypass cuda/cudnn checks if no driver.

2019-07-16 Thread GitBox
karan6181 commented on issue #15551: Bypass cuda/cudnn checks if no driver. URL: https://github.com/apache/incubator-mxnet/pull/15551#issuecomment-512034741 @mxnet-label-bot add [CUDA, pr-awaiting-response] This is an

[GitHub] [incubator-mxnet] karan6181 commented on issue #15549: [Doc] add squeeze to Array change shape

2019-07-16 Thread GitBox
karan6181 commented on issue #15549: [Doc] add squeeze to Array change shape URL: https://github.com/apache/incubator-mxnet/pull/15549#issuecomment-512033829 @mxnet-label-bot add [Doc, pr-awaiting-review] This is an automated

[GitHub] [incubator-mxnet] Zha0q1 edited a comment on issue #15490: Utility to help developers debug operators: Tensor Inspector

2019-07-16 Thread GitBox
Zha0q1 edited a comment on issue #15490: Utility to help developers debug operators: Tensor Inspector URL: https://github.com/apache/incubator-mxnet/pull/15490#issuecomment-512033689 > retrigger the build ... there is some julia error. Probably not because of your code changes. Also add

[GitHub] [incubator-mxnet] Zha0q1 commented on issue #15490: Utility to help developers debug operators: Tensor Inspector

2019-07-16 Thread GitBox
Zha0q1 commented on issue #15490: Utility to help developers debug operators: Tensor Inspector URL: https://github.com/apache/incubator-mxnet/pull/15490#issuecomment-512033689 > retrigger the build ... there is some julia error. Probably not because of your code changes. Also add link to

[GitHub] [incubator-mxnet] karan6181 commented on issue #15545: Softmax fwd optimization for GPU

2019-07-16 Thread GitBox
karan6181 commented on issue #15545: Softmax fwd optimization for GPU URL: https://github.com/apache/incubator-mxnet/pull/15545#issuecomment-512033691 @mxnet-label-bot add [Operator, pr-awaiting-review] This is an automated

[GitHub] [incubator-mxnet] access2rohit commented on issue #15490: Utility to help developers debug operators: Tensor Inspector

2019-07-16 Thread GitBox
access2rohit commented on issue #15490: Utility to help developers debug operators: Tensor Inspector URL: https://github.com/apache/incubator-mxnet/pull/15490#issuecomment-512033461 retrigger the build ... there is some julia error. Probably not because of your code changes. Also add link

[GitHub] [incubator-mxnet] karan6181 commented on issue #15515: [MXNET-978] Higher Order Gradient Support `arcsin`, `arccos`.

2019-07-16 Thread GitBox
karan6181 commented on issue #15515: [MXNET-978] Higher Order Gradient Support `arcsin`, `arccos`. URL: https://github.com/apache/incubator-mxnet/pull/15515#issuecomment-512033452 @mxnet-label-bot add [Operator, pr-awaiting-review]

[GitHub] [incubator-mxnet] sandeep-krishnamurthy commented on a change in pull request #15541: [Opperf] Add normal, uniform ops to random_sampling_operators

2019-07-16 Thread GitBox
sandeep-krishnamurthy commented on a change in pull request #15541: [Opperf] Add normal, uniform ops to random_sampling_operators URL: https://github.com/apache/incubator-mxnet/pull/15541#discussion_r304160063 ## File path: benchmark/opperf/utils/op_registry_utils.py ##

[incubator-mxnet] branch master updated (300cb69 -> 4d07d78)

2019-07-16 Thread skm
This is an automated email from the ASF dual-hosted git repository. skm pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git. from 300cb69 some minor typos/clarifications (#15538) add 4d07d78 broadcast axis is alias to broadcast axes;

[GitHub] [incubator-mxnet] sandeep-krishnamurthy merged pull request #15546: [Doc] broadcast axis is alias to broadcast axes

2019-07-16 Thread GitBox
sandeep-krishnamurthy merged pull request #15546: [Doc] broadcast axis is alias to broadcast axes URL: https://github.com/apache/incubator-mxnet/pull/15546 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-mxnet] Zha0q1 edited a comment on issue #15517: [WIP]Tensor Inspector Tutorial

2019-07-16 Thread GitBox
Zha0q1 edited a comment on issue #15517: [WIP]Tensor Inspector Tutorial URL: https://github.com/apache/incubator-mxnet/pull/15517#issuecomment-51202 @access2rohit @sandeep-krishnamurthy The tutorial is ready for review. After applying your suggestions I will replace the image url to

[GitHub] [incubator-mxnet] Zha0q1 commented on issue #15517: [WIP]Tensor Inspector Tutorial

2019-07-16 Thread GitBox
Zha0q1 commented on issue #15517: [WIP]Tensor Inspector Tutorial URL: https://github.com/apache/incubator-mxnet/pull/15517#issuecomment-51202 @access2rohit @sandeep-krishnamurthy The tutorial is ready for review. After applying your suggestions I will replace the image url to the ones

[GitHub] [incubator-mxnet] zhreshold commented on a change in pull request #15552: Add Deformable V2

2019-07-16 Thread GitBox
zhreshold commented on a change in pull request #15552: Add Deformable V2 URL: https://github.com/apache/incubator-mxnet/pull/15552#discussion_r304150734 ## File path: src/operator/contrib/modulated_deformable_convolution-inl.h ## @@ -0,0 +1,547 @@ +/*! Review comment:

[GitHub] [incubator-mxnet] zhreshold commented on issue #15552: Add Deformable V2

2019-07-16 Thread GitBox
zhreshold commented on issue #15552: Add Deformable V2 URL: https://github.com/apache/incubator-mxnet/pull/15552#issuecomment-512013369 @bryanyzhu This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-mxnet] anirudhacharya opened a new pull request #15560: Add fp16 support for topk

2019-07-16 Thread GitBox
anirudhacharya opened a new pull request #15560: Add fp16 support for topk URL: https://github.com/apache/incubator-mxnet/pull/15560 ## Description ## Add fp16 and fp64 support for topk operator. Required for certain machine translation tasks( and other NLP related tasks). ##

[GitHub] [incubator-mxnet] anirudhacharya closed pull request #14912: Add fp16 and fp64 support for topk

2019-07-16 Thread GitBox
anirudhacharya closed pull request #14912: Add fp16 and fp64 support for topk URL: https://github.com/apache/incubator-mxnet/pull/14912 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-mxnet] larroy commented on a change in pull request #15253: [MXNET-978] Add higher order gradient support `tan`, `tanh`

2019-07-16 Thread GitBox
larroy commented on a change in pull request #15253: [MXNET-978] Add higher order gradient support `tan`, `tanh` URL: https://github.com/apache/incubator-mxnet/pull/15253#discussion_r304140357 ## File path: src/operator/tensor/elemwise_unary_op_trig.cc ## @@ -139,7

[GitHub] [incubator-mxnet] ZhennanQin commented on a change in pull request #15550: Infra to use tvm write op kernels

2019-07-16 Thread GitBox
ZhennanQin commented on a change in pull request #15550: Infra to use tvm write op kernels URL: https://github.com/apache/incubator-mxnet/pull/15550#discussion_r304129924 ## File path: src/operator/contrib/tvmop/ufunc.cc ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache

[GitHub] [incubator-mxnet] roywei edited a comment on issue #15353: [MXNET-1358]Fit api tutorial

2019-07-16 Thread GitBox
roywei edited a comment on issue #15353: [MXNET-1358]Fit api tutorial URL: https://github.com/apache/incubator-mxnet/pull/15353#issuecomment-511995713 @aaronmarkham I have addressed your comments, could you take another look? thanks! Another problem is the estimator API doc is not

[GitHub] [incubator-mxnet] ZhennanQin commented on a change in pull request #15550: Infra to use tvm write op kernels

2019-07-16 Thread GitBox
ZhennanQin commented on a change in pull request #15550: Infra to use tvm write op kernels URL: https://github.com/apache/incubator-mxnet/pull/15550#discussion_r304128188 ## File path: src/operator/tvmop/op_module.cc ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache

[GitHub] [incubator-mxnet] roywei commented on issue #15353: [MXNET-1358]Fit api tutorial

2019-07-16 Thread GitBox
roywei commented on issue #15353: [MXNET-1358]Fit api tutorial URL: https://github.com/apache/incubator-mxnet/pull/15353#issuecomment-511995713 @aaronmarkham I have addressed your comments, could you take another look? thanks! Another problem is the estimator API doc is not showing up

[GitHub] [incubator-mxnet] roywei commented on a change in pull request #15353: [MXNET-1358]Fit api tutorial

2019-07-16 Thread GitBox
roywei commented on a change in pull request #15353: [MXNET-1358]Fit api tutorial URL: https://github.com/apache/incubator-mxnet/pull/15353#discussion_r304127389 ## File path: docs/tutorials/gluon/fit_api_tutorial.md ## @@ -0,0 +1,265 @@ + + + + + + + + + + + + + + + + +

[GitHub] [incubator-mxnet] roywei commented on a change in pull request #15353: [MXNET-1358]Fit api tutorial

2019-07-16 Thread GitBox
roywei commented on a change in pull request #15353: [MXNET-1358]Fit api tutorial URL: https://github.com/apache/incubator-mxnet/pull/15353#discussion_r304127276 ## File path: docs/tutorials/gluon/fit_api_tutorial.md ## @@ -0,0 +1,265 @@ + + + + + + + + + + + + + + + + +

[GitHub] [incubator-mxnet] roywei commented on a change in pull request #15353: [MXNET-1358]Fit api tutorial

2019-07-16 Thread GitBox
roywei commented on a change in pull request #15353: [MXNET-1358]Fit api tutorial URL: https://github.com/apache/incubator-mxnet/pull/15353#discussion_r304126729 ## File path: docs/tutorials/gluon/fit_api_tutorial.md ## @@ -0,0 +1,265 @@ + + + + + + + + + + + + + + + + +

[GitHub] [incubator-mxnet] roywei commented on a change in pull request #15353: [MXNET-1358]Fit api tutorial

2019-07-16 Thread GitBox
roywei commented on a change in pull request #15353: [MXNET-1358]Fit api tutorial URL: https://github.com/apache/incubator-mxnet/pull/15353#discussion_r304126854 ## File path: docs/tutorials/gluon/fit_api_tutorial.md ## @@ -0,0 +1,265 @@ + + + + + + + + + + + + + + + + +

[GitHub] [incubator-mxnet] ZhennanQin commented on a change in pull request #15550: Infra to use tvm write op kernels

2019-07-16 Thread GitBox
ZhennanQin commented on a change in pull request #15550: Infra to use tvm write op kernels URL: https://github.com/apache/incubator-mxnet/pull/15550#discussion_r304126544 ## File path: src/operator/contrib/tvmop/ufunc.cc ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache

[GitHub] [incubator-mxnet] larroy commented on issue #14979: [BUG] Using a package with MKL and GPU versions, using python to open a new process will cause an error

2019-07-16 Thread GitBox
larroy commented on issue #14979: [BUG] Using a package with MKL and GPU versions, using python to open a new process will cause an error URL: https://github.com/apache/incubator-mxnet/issues/14979#issuecomment-511990381 ping

[GitHub] [incubator-mxnet] access2rohit commented on issue #15490: Utility to help developers debug operators: Tensor Inspector

2019-07-16 Thread GitBox
access2rohit commented on issue #15490: Utility to help developers debug operators: Tensor Inspector URL: https://github.com/apache/incubator-mxnet/pull/15490#issuecomment-511986827 LGTM just address my last comment and no need to split this PR into 2 now since you have already addressed

[GitHub] [incubator-mxnet] Zha0q1 commented on a change in pull request #15490: Utility to help developers debug operators: Tensor Inspector

2019-07-16 Thread GitBox
Zha0q1 commented on a change in pull request #15490: Utility to help developers debug operators: Tensor Inspector URL: https://github.com/apache/incubator-mxnet/pull/15490#discussion_r304117413 ## File path: src/common/tensor_inspector.h ## @@ -0,0 +1,800 @@ +/* + *

[GitHub] [incubator-mxnet] access2rohit commented on a change in pull request #15490: Utility to help developers debug operators: Tensor Inspector

2019-07-16 Thread GitBox
access2rohit commented on a change in pull request #15490: Utility to help developers debug operators: Tensor Inspector URL: https://github.com/apache/incubator-mxnet/pull/15490#discussion_r304116187 ## File path: src/common/tensor_inspector.h ## @@ -0,0 +1,800 @@ +/* + *

[GitHub] [incubator-mxnet] sandeep-krishnamurthy commented on a change in pull request #15475: Add transpose_conv, sorting and searching operator benchmarks to Opperf

2019-07-16 Thread GitBox
sandeep-krishnamurthy commented on a change in pull request #15475: Add transpose_conv, sorting and searching operator benchmarks to Opperf URL: https://github.com/apache/incubator-mxnet/pull/15475#discussion_r304115757 ## File path:

[GitHub] [incubator-mxnet] sandeep-krishnamurthy commented on a change in pull request #15475: Add transpose_conv, sorting and searching operator benchmarks to Opperf

2019-07-16 Thread GitBox
sandeep-krishnamurthy commented on a change in pull request #15475: Add transpose_conv, sorting and searching operator benchmarks to Opperf URL: https://github.com/apache/incubator-mxnet/pull/15475#discussion_r304115134 ## File path:

[GitHub] [incubator-mxnet] larroy commented on a change in pull request #15331: [fix] missing input log higher order.

2019-07-16 Thread GitBox
larroy commented on a change in pull request #15331: [fix] missing input log higher order. URL: https://github.com/apache/incubator-mxnet/pull/15331#discussion_r304114906 ## File path: src/operator/tensor/elemwise_unary_op_basic.cc ## @@ -1117,15 +1117,15 @@

[GitHub] [incubator-mxnet] sandeep-krishnamurthy commented on a change in pull request #15475: Add transpose_conv, sorting and searching operator benchmarks to Opperf

2019-07-16 Thread GitBox
sandeep-krishnamurthy commented on a change in pull request #15475: Add transpose_conv, sorting and searching operator benchmarks to Opperf URL: https://github.com/apache/incubator-mxnet/pull/15475#discussion_r304113829 ## File path: benchmark/opperf/utils/op_registry_utils.py

[GitHub] [incubator-mxnet] larroy commented on a change in pull request #15530: [MXNET-978] Higher Order Gradient Support `arcsinh`, `arccosh`.

2019-07-16 Thread GitBox
larroy commented on a change in pull request #15530: [MXNET-978] Higher Order Gradient Support `arcsinh`, `arccosh`. URL: https://github.com/apache/incubator-mxnet/pull/15530#discussion_r304112629 ## File path: src/operator/tensor/elemwise_unary_op_trig.cc ## @@ -307,7

[GitHub] [incubator-mxnet] larroy commented on a change in pull request #15331: [fix] missing input log higher order.

2019-07-16 Thread GitBox
larroy commented on a change in pull request #15331: [fix] missing input log higher order. URL: https://github.com/apache/incubator-mxnet/pull/15331#discussion_r304112067 ## File path: src/operator/tensor/elemwise_unary_op_basic.cc ## @@ -1117,15 +1117,15 @@

[GitHub] [incubator-mxnet] larroy commented on issue #15331: [fix] missing input log higher order.

2019-07-16 Thread GitBox
larroy commented on issue #15331: [fix] missing input log higher order. URL: https://github.com/apache/incubator-mxnet/pull/15331#issuecomment-511978900 I think ograd[0] is dL/dx_grad About the number of inputs, you are right that we could check. If it's more than one or two

[GitHub] [incubator-mxnet] larroy commented on issue #15531: [MXNET-978] Higher Order Gradient Support `arctan`, `arctanh`, `radians`.

2019-07-16 Thread GitBox
larroy commented on issue #15531: [MXNET-978] Higher Order Gradient Support `arctan`, `arctanh`, `radians`. URL: https://github.com/apache/incubator-mxnet/pull/15531#issuecomment-511977409 Shall we rename grad_x to x_grad for consistency with other operators and PRs? What do you think?

[GitHub] [incubator-mxnet] vrakesh commented on issue #15557: mxnet.profiler.dump creates invalid json files

2019-07-16 Thread GitBox
vrakesh commented on issue #15557: mxnet.profiler.dump creates invalid json files URL: https://github.com/apache/incubator-mxnet/issues/15557#issuecomment-511974991 @mxnet-label-bot add [Profiler] This is an automated

[GitHub] [incubator-mxnet] larroy commented on a change in pull request #15531: [MXNET-978] Higher Order Gradient Support `arctan`, `arctanh`, `radians`.

2019-07-16 Thread GitBox
larroy commented on a change in pull request #15531: [MXNET-978] Higher Order Gradient Support `arctan`, `arctanh`, `radians`. URL: https://github.com/apache/incubator-mxnet/pull/15531#discussion_r304106230 ## File path: src/operator/tensor/util/node_op_util.h ## @@ -0,0

[GitHub] [incubator-mxnet] vrakesh commented on issue #15556: mxnet profiler.dump error: MXNetError(py_str(_LIB.MXGetLastError()))

2019-07-16 Thread GitBox
vrakesh commented on issue #15556: mxnet profiler.dump error: MXNetError(py_str(_LIB.MXGetLastError())) URL: https://github.com/apache/incubator-mxnet/issues/15556#issuecomment-511974685 @avivna Thanks for reporting this issue @mxnet-label-bot add [Profiler, Bug]

[GitHub] [incubator-mxnet] larroy commented on a change in pull request #15531: [MXNET-978] Higher Order Gradient Support `arctan`, `arctanh`, `radians`.

2019-07-16 Thread GitBox
larroy commented on a change in pull request #15531: [MXNET-978] Higher Order Gradient Support `arctan`, `arctanh`, `radians`. URL: https://github.com/apache/incubator-mxnet/pull/15531#discussion_r304106230 ## File path: src/operator/tensor/util/node_op_util.h ## @@ -0,0

[GitHub] [incubator-mxnet] larroy commented on issue #15465: [RFC] Integrate TVM into Apache MXNet

2019-07-16 Thread GitBox
larroy commented on issue #15465: [RFC] Integrate TVM into Apache MXNet URL: https://github.com/apache/incubator-mxnet/issues/15465#issuecomment-511972963 Would it be possible to keep it decoupled, say the infrastructure to load the tvm operator is included in MXNet but we don't need to

[GitHub] [incubator-mxnet] larroy commented on issue #14836: Refactor AGInfo and Imperative

2019-07-16 Thread GitBox
larroy commented on issue #14836: Refactor AGInfo and Imperative URL: https://github.com/apache/incubator-mxnet/pull/14836#issuecomment-511970285 Anything else needed for merge? This is an automated message from the Apache

[incubator-mxnet] branch master updated (9777717 -> 300cb69)

2019-07-16 Thread lanking
This is an automated email from the ASF dual-hosted git repository. lanking pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git. from 917 website build for julia: fix path to be static (#15554) add 300cb69 some minor

[GitHub] [incubator-mxnet] lanking520 merged pull request #15538: some minor typos/clarifications

2019-07-16 Thread GitBox
lanking520 merged pull request #15538: some minor typos/clarifications URL: https://github.com/apache/incubator-mxnet/pull/15538 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-mxnet] darlaker commented on a change in pull request #15524: refine Nano setup directions

2019-07-16 Thread GitBox
darlaker commented on a change in pull request #15524: refine Nano setup directions URL: https://github.com/apache/incubator-mxnet/pull/15524#discussion_r304063493 ## File path: docs/install/install-jetson.md ## @@ -60,49 +59,54 @@ sudo pip install \ ``` If you plan

[GitHub] [incubator-mxnet] darlaker commented on a change in pull request #15524: refine Nano setup directions

2019-07-16 Thread GitBox
darlaker commented on a change in pull request #15524: refine Nano setup directions URL: https://github.com/apache/incubator-mxnet/pull/15524#discussion_r304061657 ## File path: docs/install/install-jetson.md ## @@ -128,12 +130,13 @@ To use this with the MXNet Python

[GitHub] [incubator-mxnet] darlaker commented on a change in pull request #15524: refine Nano setup directions

2019-07-16 Thread GitBox
darlaker commented on a change in pull request #15524: refine Nano setup directions URL: https://github.com/apache/incubator-mxnet/pull/15524#discussion_r304063162 ## File path: docs/install/install-jetson.md ## @@ -60,49 +59,54 @@ sudo pip install \ ``` If you plan

[GitHub] [incubator-mxnet] nuslq commented on issue #15424: fixed config.mk and Makefile bugs for installing mkl

2019-07-16 Thread GitBox
nuslq commented on issue #15424: fixed config.mk and Makefile bugs for installing mkl URL: https://github.com/apache/incubator-mxnet/pull/15424#issuecomment-511940273 > @yugoren Can you double check? I can statically link MKL BLAS library by adding USE_BLAS=mkl to the make command line.

[GitHub] [incubator-mxnet] Zha0q1 commented on a change in pull request #15490: Utility to help developers debug operators: Tensor Inspector

2019-07-16 Thread GitBox
Zha0q1 commented on a change in pull request #15490: Utility to help developers debug operators: Tensor Inspector URL: https://github.com/apache/incubator-mxnet/pull/15490#discussion_r304064753 ## File path: src/common/tensor_inspector.h ## @@ -0,0 +1,799 @@ +/* + *

[GitHub] [incubator-mxnet] Zha0q1 commented on a change in pull request #15490: Utility to help developers debug operators: Tensor Inspector

2019-07-16 Thread GitBox
Zha0q1 commented on a change in pull request #15490: Utility to help developers debug operators: Tensor Inspector URL: https://github.com/apache/incubator-mxnet/pull/15490#discussion_r304064853 ## File path: src/common/tensor_inspector.h ## @@ -0,0 +1,799 @@ +/* + *

[GitHub] [incubator-mxnet] Zha0q1 commented on a change in pull request #15490: Utility to help developers debug operators: Tensor Inspector

2019-07-16 Thread GitBox
Zha0q1 commented on a change in pull request #15490: Utility to help developers debug operators: Tensor Inspector URL: https://github.com/apache/incubator-mxnet/pull/15490#discussion_r304064793 ## File path: src/common/tensor_inspector.h ## @@ -0,0 +1,799 @@ +/* + *

[GitHub] [incubator-mxnet] yzhliu commented on a change in pull request #15550: Infra to use tvm write op kernels

2019-07-16 Thread GitBox
yzhliu commented on a change in pull request #15550: Infra to use tvm write op kernels URL: https://github.com/apache/incubator-mxnet/pull/15550#discussion_r304059818 ## File path: Makefile ## @@ -589,6 +603,30 @@ $(DMLC_CORE)/libdmlc.a: DMLCCORE DMLCCORE: + cd

[GitHub] [incubator-mxnet] yzhliu commented on a change in pull request #15550: Infra to use tvm write op kernels

2019-07-16 Thread GitBox
yzhliu commented on a change in pull request #15550: Infra to use tvm write op kernels URL: https://github.com/apache/incubator-mxnet/pull/15550#discussion_r304060508 ## File path: python/mxnet/base.py ## @@ -734,3 +734,8 @@ def write_all_str(module_file,

[GitHub] [incubator-mxnet] yzhliu commented on a change in pull request #15550: Infra to use tvm write op kernels

2019-07-16 Thread GitBox
yzhliu commented on a change in pull request #15550: Infra to use tvm write op kernels URL: https://github.com/apache/incubator-mxnet/pull/15550#discussion_r304059818 ## File path: Makefile ## @@ -589,6 +603,30 @@ $(DMLC_CORE)/libdmlc.a: DMLCCORE DMLCCORE: + cd

[GitHub] [incubator-mxnet] Zha0q1 commented on a change in pull request #15490: Utility to help developers debug operators: Tensor Inspector

2019-07-16 Thread GitBox
Zha0q1 commented on a change in pull request #15490: Utility to help developers debug operators: Tensor Inspector URL: https://github.com/apache/incubator-mxnet/pull/15490#discussion_r304058801 ## File path: src/common/tensor_inspector.h ## @@ -0,0 +1,800 @@ +/* + *

[GitHub] [incubator-mxnet] access2rohit commented on a change in pull request #15490: Utility to help developers debug operators: Tensor Inspector

2019-07-16 Thread GitBox
access2rohit commented on a change in pull request #15490: Utility to help developers debug operators: Tensor Inspector URL: https://github.com/apache/incubator-mxnet/pull/15490#discussion_r304056788 ## File path: src/common/tensor_inspector.h ## @@ -0,0 +1,800 @@ +/* + *

[GitHub] [incubator-mxnet] yzhliu commented on a change in pull request #15550: Infra to use tvm write op kernels

2019-07-16 Thread GitBox
yzhliu commented on a change in pull request #15550: Infra to use tvm write op kernels URL: https://github.com/apache/incubator-mxnet/pull/15550#discussion_r304056021 ## File path: src/operator/contrib/tvmop/ufunc.cc ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache

[GitHub] [incubator-mxnet] anandj91 commented on issue #15124: [MXNET-1294] Priority-based parameter propagation for improved data parallel training throughput

2019-07-16 Thread GitBox
anandj91 commented on issue #15124: [MXNET-1294] Priority-based parameter propagation for improved data parallel training throughput URL: https://github.com/apache/incubator-mxnet/pull/15124#issuecomment-511931055 This PR is waiting on https://github.com/apache/incubator-mxnet/pull/15559

[GitHub] [incubator-mxnet] yzhliu commented on a change in pull request #15550: Infra to use tvm write op kernels

2019-07-16 Thread GitBox
yzhliu commented on a change in pull request #15550: Infra to use tvm write op kernels URL: https://github.com/apache/incubator-mxnet/pull/15550#discussion_r304054931 ## File path: src/operator/tvmop/op_module.cc ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache

[GitHub] [incubator-mxnet] Zha0q1 commented on a change in pull request #15490: Utility to help developers debug operators: Tensor Inspector

2019-07-16 Thread GitBox
Zha0q1 commented on a change in pull request #15490: Utility to help developers debug operators: Tensor Inspector URL: https://github.com/apache/incubator-mxnet/pull/15490#discussion_r304054436 ## File path: src/common/tensor_inspector.h ## @@ -0,0 +1,800 @@ +/* + *

[GitHub] [incubator-mxnet] Zha0q1 commented on a change in pull request #15490: Utility to help developers debug operators: Tensor Inspector

2019-07-16 Thread GitBox
Zha0q1 commented on a change in pull request #15490: Utility to help developers debug operators: Tensor Inspector URL: https://github.com/apache/incubator-mxnet/pull/15490#discussion_r304054184 ## File path: src/common/tensor_inspector.h ## @@ -0,0 +1,800 @@ +/* + *

[GitHub] [incubator-mxnet] anandj91 commented on issue #15559: [MXNET-1294] Add PushPull API

2019-07-16 Thread GitBox
anandj91 commented on issue #15559: [MXNET-1294] Add PushPull API URL: https://github.com/apache/incubator-mxnet/pull/15559#issuecomment-511929811 This is PR is work in progress and is raised to get the API definition reviewed. This PR is part of the

[GitHub] [incubator-mxnet] Zha0q1 commented on a change in pull request #15490: Utility to help developers debug operators: Tensor Inspector

2019-07-16 Thread GitBox
Zha0q1 commented on a change in pull request #15490: Utility to help developers debug operators: Tensor Inspector URL: https://github.com/apache/incubator-mxnet/pull/15490#discussion_r304053928 ## File path: src/common/tensor_inspector.h ## @@ -0,0 +1,800 @@ +/* + *

[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #15490: Utility to help developers debug operators: Tensor Inspector

2019-07-16 Thread GitBox
apeforest commented on a change in pull request #15490: Utility to help developers debug operators: Tensor Inspector URL: https://github.com/apache/incubator-mxnet/pull/15490#discussion_r304054217 ## File path: src/common/tensor_inspector.h ## @@ -0,0 +1,800 @@ +/* + *

[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #15490: Utility to help developers debug operators: Tensor Inspector

2019-07-16 Thread GitBox
apeforest commented on a change in pull request #15490: Utility to help developers debug operators: Tensor Inspector URL: https://github.com/apache/incubator-mxnet/pull/15490#discussion_r304053715 ## File path: src/common/tensor_inspector.h ## @@ -0,0 +1,800 @@ +/* + *

[GitHub] [incubator-mxnet] Zha0q1 commented on a change in pull request #15490: Utility to help developers debug operators: Tensor Inspector

2019-07-16 Thread GitBox
Zha0q1 commented on a change in pull request #15490: Utility to help developers debug operators: Tensor Inspector URL: https://github.com/apache/incubator-mxnet/pull/15490#discussion_r304053479 ## File path: src/common/tensor_inspector.h ## @@ -0,0 +1,800 @@ +/* + *

[GitHub] [incubator-mxnet] yzhliu commented on a change in pull request #15550: Infra to use tvm write op kernels

2019-07-16 Thread GitBox
yzhliu commented on a change in pull request #15550: Infra to use tvm write op kernels URL: https://github.com/apache/incubator-mxnet/pull/15550#discussion_r304053400 ## File path: src/operator/contrib/tvmop/ufunc.cc ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache

[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #15490: Utility to help developers debug operators: Tensor Inspector

2019-07-16 Thread GitBox
apeforest commented on a change in pull request #15490: Utility to help developers debug operators: Tensor Inspector URL: https://github.com/apache/incubator-mxnet/pull/15490#discussion_r304053402 ## File path: src/common/tensor_inspector.h ## @@ -0,0 +1,800 @@ +/* + *

[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #15490: Utility to help developers debug operators: Tensor Inspector

2019-07-16 Thread GitBox
apeforest commented on a change in pull request #15490: Utility to help developers debug operators: Tensor Inspector URL: https://github.com/apache/incubator-mxnet/pull/15490#discussion_r304053319 ## File path: src/common/tensor_inspector.h ## @@ -0,0 +1,800 @@ +/* + *

  1   2   >