[GitHub] [incubator-mxnet] ChaiBapchya commented on issue #17343: CMake: Attempt using ccache by default if available

2020-01-16 Thread GitBox
ChaiBapchya commented on issue #17343: CMake: Attempt using ccache by default if available URL: https://github.com/apache/incubator-mxnet/pull/17343#issuecomment-575513974 Thanks! Usability +1 This is an automated message fro

[GitHub] [incubator-mxnet] ChaiBapchya removed a comment on issue #17343: CMake: Attempt using ccache by default if available

2020-01-16 Thread GitBox
ChaiBapchya removed a comment on issue #17343: CMake: Attempt using ccache by default if available URL: https://github.com/apache/incubator-mxnet/pull/17343#issuecomment-575513974 Thanks! Usability +1 This is an automated mes

[GitHub] [incubator-mxnet] Yiyan66 commented on a change in pull request #17302: [numpy]add op random.logistic, random.gumbel

2020-01-16 Thread GitBox
Yiyan66 commented on a change in pull request #17302: [numpy]add op random.logistic, random.gumbel URL: https://github.com/apache/incubator-mxnet/pull/17302#discussion_r367800505 ## File path: src/operator/numpy/random/np_location_scale_op.h ## @@ -0,0 +1,510 @@ +/* + * Li

[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #17302: [numpy]add op random.logistic, random.gumbel

2020-01-16 Thread GitBox
haojin2 commented on a change in pull request #17302: [numpy]add op random.logistic, random.gumbel URL: https://github.com/apache/incubator-mxnet/pull/17302#discussion_r367799853 ## File path: src/operator/numpy/random/np_location_scale_op.h ## @@ -0,0 +1,510 @@ +/* + * Li

[GitHub] [incubator-mxnet] xidulu commented on a change in pull request #17302: [numpy]add op random.logistic, random.gumbel

2020-01-16 Thread GitBox
xidulu commented on a change in pull request #17302: [numpy]add op random.logistic, random.gumbel URL: https://github.com/apache/incubator-mxnet/pull/17302#discussion_r367798667 ## File path: src/operator/numpy/random/np_location_scale_op.h ## @@ -0,0 +1,510 @@ +/* + * Lic

[GitHub] [incubator-mxnet] szhengac commented on issue #17358: np.broadcast_to extension

2020-01-16 Thread GitBox
szhengac commented on issue #17358: np.broadcast_to extension URL: https://github.com/apache/incubator-mxnet/pull/17358#issuecomment-575507918 Great! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-mxnet] haojin2 opened a new pull request #17358: np.broadcast_to extension

2020-01-16 Thread GitBox
haojin2 opened a new pull request #17358: np.broadcast_to extension URL: https://github.com/apache/incubator-mxnet/pull/17358 ## Description ## Extending `broadcast_to` to infer shape from input tensor, useful under symbolic mode. ## Checklist ## ### Essentials ### Please fe

[GitHub] [incubator-mxnet] xidulu commented on a change in pull request #17302: [numpy]add op random.logistic, random.gumbel

2020-01-16 Thread GitBox
xidulu commented on a change in pull request #17302: [numpy]add op random.logistic, random.gumbel URL: https://github.com/apache/incubator-mxnet/pull/17302#discussion_r367796729 ## File path: python/mxnet/numpy/random.py ## @@ -200,6 +200,192 @@ def normal(loc=0.0, scale=1

[GitHub] [incubator-mxnet] xidulu commented on a change in pull request #17302: [numpy]add op random.logistic, random.gumbel

2020-01-16 Thread GitBox
xidulu commented on a change in pull request #17302: [numpy]add op random.logistic, random.gumbel URL: https://github.com/apache/incubator-mxnet/pull/17302#discussion_r367796564 ## File path: python/mxnet/numpy/random.py ## @@ -200,6 +200,192 @@ def normal(loc=0.0, scale=1

[GitHub] [incubator-mxnet] kohillyang opened a new issue #17357: lr_scheduler does not work as expect when training from checkpoint.(Not sure it is a bug.)

2020-01-16 Thread GitBox
kohillyang opened a new issue #17357: lr_scheduler does not work as expect when training from checkpoint.(Not sure it is a bug.) URL: https://github.com/apache/incubator-mxnet/issues/17357 ## Description As I know, the optimizer decides the num_update according to its _index_update_coun

[GitHub] [incubator-mxnet] szha commented on a change in pull request #17348: Fix Horovod build error due to missing exported symbols

2020-01-16 Thread GitBox
szha commented on a change in pull request #17348: Fix Horovod build error due to missing exported symbols URL: https://github.com/apache/incubator-mxnet/pull/17348#discussion_r367790272 ## File path: make/config/libmxnet.sym ## @@ -12,4 +12,4 @@ Java_org_apache_mxnet* *S

[incubator-mxnet-site] branch asf-site updated: Bump the publish timestamp.

2020-01-16 Thread aaronmarkham
This is an automated email from the ASF dual-hosted git repository. aaronmarkham pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-mxnet-site.git The following commit(s) were added to refs/heads/asf-site by this push: new 84774a3 Bump the publis

[GitHub] [incubator-mxnet] TaoLv commented on issue #17356: cmake: check USE_OPENMP for proper MKL-DNN build flag

2020-01-16 Thread GitBox
TaoLv commented on issue #17356: cmake: check USE_OPENMP for proper MKL-DNN build flag URL: https://github.com/apache/incubator-mxnet/pull/17356#issuecomment-575481956 @leezu @cyrusbehr @pengzhao-intel Please review~ This is

[GitHub] [incubator-mxnet] TaoLv opened a new pull request #17356: cmake: check USE_OPENMP for proper MKL-DNN build flag

2020-01-16 Thread GitBox
TaoLv opened a new pull request #17356: cmake: check USE_OPENMP for proper MKL-DNN build flag URL: https://github.com/apache/incubator-mxnet/pull/17356 ## Description ## Fix https://github.com/apache/incubator-mxnet/issues/17338 If `USE_OPENMP=OFF`, build MKL-DNN with `MKLDNN_CPU_

[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #17349: Fix links and highlights in ubuntu_setup.md page

2020-01-16 Thread GitBox
apeforest commented on a change in pull request #17349: Fix links and highlights in ubuntu_setup.md page URL: https://github.com/apache/incubator-mxnet/pull/17349#discussion_r367775903 ## File path: docs/static_site/src/pages/get_started/ubuntu_setup.md ## @@ -181,7 +181,6

[GitHub] [incubator-mxnet] TaoLv commented on issue #17352: Error in mkldnn unit test

2020-01-16 Thread GitBox
TaoLv commented on issue #17352: Error in mkldnn unit test URL: https://github.com/apache/incubator-mxnet/issues/17352#issuecomment-575466455 @juliusshufan This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-mxnet] TaoLv commented on issue #17352: Error in mkldnn unit test

2020-01-16 Thread GitBox
TaoLv commented on issue #17352: Error in mkldnn unit test URL: https://github.com/apache/incubator-mxnet/issues/17352#issuecomment-575466220 Yes, we're aware of this problem as in our local validation system, python tests are split into single run for each test. We didn't dive into the pr

[GitHub] [incubator-mxnet] TaoLv opened a new pull request #17355: [Scripts] Update MKL to 2020.0

2020-01-16 Thread GitBox
TaoLv opened a new pull request #17355: [Scripts] Update MKL to 2020.0 URL: https://github.com/apache/incubator-mxnet/pull/17355 ## Description ## This PR updates the MKL installation script to 2020.0. ## Checklist ## ### Essentials ### Please feel free to remove inapplicable

[GitHub] [incubator-mxnet] vandanavk edited a comment on issue #15993: Add a contrib operator for Constant

2020-01-16 Thread GitBox
vandanavk edited a comment on issue #15993: Add a contrib operator for Constant URL: https://github.com/apache/incubator-mxnet/pull/15993#issuecomment-575426224 > I mean, If we did some constant folding optimization in the graph, and generate a new tensor which is not filled with same value

[GitHub] [incubator-mxnet] vandanavk commented on issue #15993: Add a contrib operator for Constant

2020-01-16 Thread GitBox
vandanavk commented on issue #15993: Add a contrib operator for Constant URL: https://github.com/apache/incubator-mxnet/pull/15993#issuecomment-575426224 > I mean, If we did some constant folding optimization in the graph, and generate a new tensor which is not filled with same values. For

[GitHub] [incubator-mxnet] vandanavk commented on a change in pull request #15993: Add a contrib operator for Constant

2020-01-16 Thread GitBox
vandanavk commented on a change in pull request #15993: Add a contrib operator for Constant URL: https://github.com/apache/incubator-mxnet/pull/15993#discussion_r367733454 ## File path: src/operator/contrib/constant.cc ## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Sof

[GitHub] [incubator-mxnet] moneypi opened a new pull request #17354: fix error "TypeError: 'zip' object is not subscriptable" in deepspeec…

2020-01-16 Thread GitBox
moneypi opened a new pull request #17354: fix error "TypeError: 'zip' object is not subscriptable" in deepspeec… URL: https://github.com/apache/incubator-mxnet/pull/17354 …h.cfg training ## Description ## When traing speech_recognition by command `python main.py --configfile deep

[GitHub] [incubator-mxnet] rondogency commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support

2020-01-16 Thread GitBox
rondogency commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support URL: https://github.com/apache/incubator-mxnet/pull/17270#discussion_r367731357 ## File path: include/mxnet/lib_api.h ## @@ -833,20 +891,26 @@ extern "C" { #else void #e

[GitHub] [incubator-mxnet] rondogency commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support

2020-01-16 Thread GitBox
rondogency commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support URL: https://github.com/apache/incubator-mxnet/pull/17270#discussion_r367731063 ## File path: include/mxnet/lib_api.h ## @@ -763,9 +818,9 @@ typedef int (*opCallInferType_t)(

[GitHub] [incubator-mxnet] rondogency commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support

2020-01-16 Thread GitBox
rondogency commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support URL: https://github.com/apache/incubator-mxnet/pull/17270#discussion_r367730959 ## File path: src/c_api/c_api.cc ## @@ -635,11 +698,20 @@ int MXLoadLib(const char *path) {

[GitHub] [incubator-mxnet] rondogency commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support

2020-01-16 Thread GitBox
rondogency commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support URL: https://github.com/apache/incubator-mxnet/pull/17270#discussion_r367731019 ## File path: src/c_api/c_api.cc ## @@ -685,28 +757,26 @@ int MXLoadLib(const char *path) {

[GitHub] [incubator-mxnet] rondogency commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support

2020-01-16 Thread GitBox
rondogency commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support URL: https://github.com/apache/incubator-mxnet/pull/17270#discussion_r367730719 ## File path: include/mxnet/lib_api.h ## @@ -982,17 +1045,22 @@ extern "C" { // create a

[GitHub] [incubator-mxnet] rondogency commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support

2020-01-16 Thread GitBox
rondogency commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support URL: https://github.com/apache/incubator-mxnet/pull/17270#discussion_r367730787 ## File path: src/c_api/c_api.cc ## @@ -450,32 +480,59 @@ int MXLoadLib(const char *path) {

[GitHub] [incubator-mxnet] rondogency commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support

2020-01-16 Thread GitBox
rondogency commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support URL: https://github.com/apache/incubator-mxnet/pull/17270#discussion_r367730749 ## File path: src/c_api/c_api.cc ## @@ -97,9 +97,31 @@ inline int MXAPIGetFunctionRegInfo(cons

[GitHub] [incubator-mxnet] rondogency commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support

2020-01-16 Thread GitBox
rondogency commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support URL: https://github.com/apache/incubator-mxnet/pull/17270#discussion_r367730693 ## File path: include/mxnet/lib_api.h ## @@ -602,12 +649,18 @@ class CustomOp { isSGop =

[GitHub] [incubator-mxnet] rondogency commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support

2020-01-16 Thread GitBox
rondogency commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support URL: https://github.com/apache/incubator-mxnet/pull/17270#discussion_r367730326 ## File path: include/mxnet/lib_api.h ## @@ -215,25 +225,43 @@ struct MXTensor { MXTensor()

[GitHub] [incubator-mxnet] rondogency commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support

2020-01-16 Thread GitBox
rondogency commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support URL: https://github.com/apache/incubator-mxnet/pull/17270#discussion_r367730341 ## File path: include/mxnet/lib_api.h ## @@ -566,16 +609,20 @@ typedef MXReturnValue (*create

[GitHub] [incubator-mxnet] ChaokunChang commented on issue #17299: Error when building mxnet with USE_DIST_KVSTORE

2020-01-16 Thread GitBox
ChaokunChang commented on issue #17299: Error when building mxnet with USE_DIST_KVSTORE URL: https://github.com/apache/incubator-mxnet/issues/17299#issuecomment-575419361 close in mistake, reopen This is an automated message

[GitHub] [incubator-mxnet] ChaokunChang opened a new issue #17299: Error when building mxnet with USE_DIST_KVSTORE

2020-01-16 Thread GitBox
ChaokunChang opened a new issue #17299: Error when building mxnet with USE_DIST_KVSTORE URL: https://github.com/apache/incubator-mxnet/issues/17299 ## Description (A clear and concise description of what the bug is.) I am building MxNet from source code, following the steps: 1. git

[incubator-mxnet-site] branch asf-site updated: Bump the publish timestamp.

2020-01-16 Thread aaronmarkham
This is an automated email from the ASF dual-hosted git repository. aaronmarkham pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-mxnet-site.git The following commit(s) were added to refs/heads/asf-site by this push: new 87e8d3a Bump the publis

[GitHub] [incubator-mxnet] vandanavk commented on a change in pull request #15872: Add a contrib operator for dynamic reshape

2020-01-16 Thread GitBox
vandanavk commented on a change in pull request #15872: Add a contrib operator for dynamic reshape URL: https://github.com/apache/incubator-mxnet/pull/15872#discussion_r367719590 ## File path: src/operator/contrib/dynamic_shape_ops.cc ## @@ -0,0 +1,109 @@ +/* + * Licensed

[GitHub] [incubator-mxnet] eric-haibin-lin opened a new issue #17353: Tutorial does not render correctly

2020-01-16 Thread GitBox
eric-haibin-lin opened a new issue #17353: Tutorial does not render correctly URL: https://github.com/apache/incubator-mxnet/issues/17353 The links are not rendered properly: https://mxnet.apache.org/api/python/docs/tutorials/packages/ndarray/sparse/train_gluon.html ![Screen Sho

[GitHub] [incubator-mxnet] leezu commented on a change in pull request #17297: Fix NCCL Cmake autodetect issue

2020-01-16 Thread GitBox
leezu commented on a change in pull request #17297: Fix NCCL Cmake autodetect issue URL: https://github.com/apache/incubator-mxnet/pull/17297#discussion_r367715337 ## File path: cmake/Modules/FindNCCL.cmake ## @@ -33,6 +33,23 @@ set(NCCL_ROOT_DIR "" CACHE PATH "Folder c

[GitHub] [incubator-mxnet] apeforest commented on issue #17352: Error in mkldnn unit test

2020-01-16 Thread GitBox
apeforest commented on issue #17352: Error in mkldnn unit test URL: https://github.com/apache/incubator-mxnet/issues/17352#issuecomment-575407880 @PatricZhao @TaoLv Did you encounter this before? Thanks This is an automated m

[GitHub] [incubator-mxnet] samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support

2020-01-16 Thread GitBox
samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support URL: https://github.com/apache/incubator-mxnet/pull/17270#discussion_r367714197 ## File path: src/c_api/c_api.cc ## @@ -450,32 +480,59 @@ int MXLoadLib(const char *path) {

[GitHub] [incubator-mxnet] apeforest opened a new issue #17352: Error in mkl test

2020-01-16 Thread GitBox
apeforest opened a new issue #17352: Error in mkl test URL: https://github.com/apache/incubator-mxnet/issues/17352 ## Description When I ran nosetests -v tests/python/mkl/test_mkldnn.py, all the tests passed. If I ran nosetests -v tests/python/mkl/test_mkldnn.py:test_mkldnn_engine_t

[GitHub] [incubator-mxnet] samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support

2020-01-16 Thread GitBox
samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support URL: https://github.com/apache/incubator-mxnet/pull/17270#discussion_r367713381 ## File path: include/mxnet/lib_api.h ## @@ -833,20 +891,26 @@ extern "C" { #else void #

[GitHub] [incubator-mxnet] samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support

2020-01-16 Thread GitBox
samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support URL: https://github.com/apache/incubator-mxnet/pull/17270#discussion_r367713125 ## File path: include/mxnet/lib_api.h ## @@ -833,20 +891,26 @@ extern "C" { #else void #

[GitHub] [incubator-mxnet] anjishnu commented on issue #17298: [MXNET-1438] Adding SDML loss function

2020-01-16 Thread GitBox
anjishnu commented on issue #17298: [MXNET-1438] Adding SDML loss function URL: https://github.com/apache/incubator-mxnet/pull/17298#issuecomment-575405571 @haojin2 With the original confirguration I was getting around 1 in 100 or 1 in 200 failures, which is not acceptable for a unit te

[GitHub] [incubator-mxnet] samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support

2020-01-16 Thread GitBox
samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support URL: https://github.com/apache/incubator-mxnet/pull/17270#discussion_r367711041 ## File path: include/mxnet/lib_api.h ## @@ -763,9 +818,9 @@ typedef int (*opCallInferType_t)

[GitHub] [incubator-mxnet] eric-haibin-lin opened a new pull request #17351: [LICENSE] Update ps-lite LICENSE

2020-01-16 Thread GitBox
eric-haibin-lin opened a new pull request #17351: [LICENSE] Update ps-lite LICENSE URL: https://github.com/apache/incubator-mxnet/pull/17351 ## Description ## A new file was added to ps-lite by ByteDance. I'm including the copyright in LICENSE. Is this the right way to fix it? @leezu @r

[GitHub] [incubator-mxnet] samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support

2020-01-16 Thread GitBox
samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support URL: https://github.com/apache/incubator-mxnet/pull/17270#discussion_r367703387 ## File path: src/c_api/c_api.cc ## @@ -685,28 +757,26 @@ int MXLoadLib(const char *path) {

[GitHub] [incubator-mxnet] samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support

2020-01-16 Thread GitBox
samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support URL: https://github.com/apache/incubator-mxnet/pull/17270#discussion_r367703437 ## File path: src/c_api/c_api.cc ## @@ -685,28 +757,26 @@ int MXLoadLib(const char *path) {

[GitHub] [incubator-mxnet] samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support

2020-01-16 Thread GitBox
samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support URL: https://github.com/apache/incubator-mxnet/pull/17270#discussion_r367703072 ## File path: src/c_api/c_api.cc ## @@ -450,32 +480,59 @@ int MXLoadLib(const char *path) {

[GitHub] [incubator-mxnet] samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support

2020-01-16 Thread GitBox
samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support URL: https://github.com/apache/incubator-mxnet/pull/17270#discussion_r367702747 ## File path: src/c_api/c_api.cc ## @@ -635,11 +698,20 @@ int MXLoadLib(const char *path) {

[GitHub] [incubator-mxnet] samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support

2020-01-16 Thread GitBox
samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support URL: https://github.com/apache/incubator-mxnet/pull/17270#discussion_r367701262 ## File path: src/c_api/c_api.cc ## @@ -450,32 +480,59 @@ int MXLoadLib(const char *path) {

[GitHub] [incubator-mxnet] ChaiBapchya commented on a change in pull request #17297: Fix NCCL Cmake autodetect issue

2020-01-16 Thread GitBox
ChaiBapchya commented on a change in pull request #17297: Fix NCCL Cmake autodetect issue URL: https://github.com/apache/incubator-mxnet/pull/17297#discussion_r367701531 ## File path: cmake/Modules/FindNCCL.cmake ## @@ -33,6 +33,23 @@ set(NCCL_ROOT_DIR "" CACHE PATH "Fo

[GitHub] [incubator-mxnet] samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support

2020-01-16 Thread GitBox
samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support URL: https://github.com/apache/incubator-mxnet/pull/17270#discussion_r367700687 ## File path: src/c_api/c_api.cc ## @@ -97,9 +97,31 @@ inline int MXAPIGetFunctionRegInfo(con

[GitHub] [incubator-mxnet] leezu opened a new issue #17350: Website: Link-checker as part of build?

2020-01-16 Thread GitBox
leezu opened a new issue #17350: Website: Link-checker as part of build? URL: https://github.com/apache/incubator-mxnet/issues/17350 ## Description The consistency of all links should be asserted as part of the CI. Otherwise PR's can easily break internal links. For example, the

[GitHub] [incubator-mxnet] leezu opened a new pull request #17349: Fix links and highlights in ubuntu_setup.md page

2020-01-16 Thread GitBox
leezu opened a new pull request #17349: Fix links and highlights in ubuntu_setup.md page URL: https://github.com/apache/incubator-mxnet/pull/17349 ## Description ## Fix links and highlights in ubuntu_setup.md page This

[GitHub] [incubator-mxnet] samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support

2020-01-16 Thread GitBox
samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support URL: https://github.com/apache/incubator-mxnet/pull/17270#discussion_r367700150 ## File path: include/mxnet/lib_api.h ## @@ -982,17 +1045,22 @@ extern "C" { // create a

[GitHub] [incubator-mxnet] leezu edited a comment on issue #17347: Static build script error out

2020-01-16 Thread GitBox
leezu edited a comment on issue #17347: Static build script error out URL: https://github.com/apache/incubator-mxnet/issues/17347#issuecomment-575392966 This is not related to our CMake build. We're not yet using cmake for the staticbuild. -

[GitHub] [incubator-mxnet] leezu commented on issue #17347: Static build script error out

2020-01-16 Thread GitBox
leezu commented on issue #17347: Static build script error out URL: https://github.com/apache/incubator-mxnet/issues/17347#issuecomment-575392966 This is not related to our CMake build. This is an automated message from the A

[GitHub] [incubator-mxnet] samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support

2020-01-16 Thread GitBox
samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support URL: https://github.com/apache/incubator-mxnet/pull/17270#discussion_r367698887 ## File path: include/mxnet/lib_api.h ## @@ -602,12 +649,18 @@ class CustomOp { isSGop =

[GitHub] [incubator-mxnet] samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support

2020-01-16 Thread GitBox
samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support URL: https://github.com/apache/incubator-mxnet/pull/17270#discussion_r367697443 ## File path: include/mxnet/lib_api.h ## @@ -566,16 +609,20 @@ typedef MXReturnValue (*creat

[GitHub] [incubator-mxnet] samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support

2020-01-16 Thread GitBox
samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support URL: https://github.com/apache/incubator-mxnet/pull/17270#discussion_r367697443 ## File path: include/mxnet/lib_api.h ## @@ -566,16 +609,20 @@ typedef MXReturnValue (*creat

[GitHub] [incubator-mxnet] samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support

2020-01-16 Thread GitBox
samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support URL: https://github.com/apache/incubator-mxnet/pull/17270#discussion_r367696078 ## File path: include/mxnet/lib_api.h ## @@ -215,25 +225,43 @@ struct MXTensor { MXTensor(

[GitHub] [incubator-mxnet] samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support

2020-01-16 Thread GitBox
samskalicky commented on a change in pull request #17270: [WIP] Dynamic custom operator GPU support URL: https://github.com/apache/incubator-mxnet/pull/17270#discussion_r367696078 ## File path: include/mxnet/lib_api.h ## @@ -215,25 +225,43 @@ struct MXTensor { MXTensor(

[incubator-mxnet] branch master updated (a63390d -> d9291e5)

2020-01-16 Thread lausen
This is an automated email from the ASF dual-hosted git repository. lausen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git. from a63390d Add RandomApply in gluon's transforms (#17242) add d9291e5 CMake: Use ccache by default if av

[incubator-mxnet] branch master updated (a63390d -> d9291e5)

2020-01-16 Thread lausen
This is an automated email from the ASF dual-hosted git repository. lausen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git. from a63390d Add RandomApply in gluon's transforms (#17242) add d9291e5 CMake: Use ccache by default if av

[GitHub] [incubator-mxnet] leezu merged pull request #17343: CMake: Attempt using ccache by default if available

2020-01-16 Thread GitBox
leezu merged pull request #17343: CMake: Attempt using ccache by default if available URL: https://github.com/apache/incubator-mxnet/pull/17343 This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [incubator-mxnet] stu1130 commented on issue #17347: Static build script error out

2020-01-16 Thread GitBox
stu1130 commented on issue #17347: Static build script error out URL: https://github.com/apache/incubator-mxnet/issues/17347#issuecomment-575379534 you need the ``` sudo apt-get install -y git \ cmake \ libcurl4-openssl-dev \ unzip \ gcc-4.8 \ g++-4

[GitHub] [incubator-mxnet] apeforest commented on issue #17347: Static build script error out

2020-01-16 Thread GitBox
apeforest commented on issue #17347: Static build script error out URL: https://github.com/apache/incubator-mxnet/issues/17347#issuecomment-575379305 @stu1130 Are you aware of this error? Thanks This is an automated message f

[GitHub] [incubator-mxnet] apeforest opened a new pull request #17348: Fix Horovod build error due to missing exported symbols

2020-01-16 Thread GitBox
apeforest opened a new pull request #17348: Fix Horovod build error due to missing exported symbols URL: https://github.com/apache/incubator-mxnet/pull/17348 ## Description ## Export MXAPIHandle symbol and fixes https://github.com/apache/incubator-mxnet/issues/17292 ## Comments #

[GitHub] [incubator-mxnet] ChaiBapchya commented on a change in pull request #17297: Fix NCCL Cmake autodetect issue

2020-01-16 Thread GitBox
ChaiBapchya commented on a change in pull request #17297: Fix NCCL Cmake autodetect issue URL: https://github.com/apache/incubator-mxnet/pull/17297#discussion_r367682940 ## File path: cmake/Modules/FindNCCL.cmake ## @@ -33,6 +33,23 @@ set(NCCL_ROOT_DIR "" CACHE PATH "Fo

[GitHub] [incubator-mxnet] apeforest opened a new issue #17347: Static build script error out

2020-01-16 Thread GitBox
apeforest opened a new issue #17347: Static build script error out URL: https://github.com/apache/incubator-mxnet/issues/17347 ## Description If I want to build a wheel locally, the script tools/staticbuild/build.sh no longer works. ### Error Message ``` CMake Error at simd/

[incubator-mxnet] branch master updated (57b98de -> a63390d)

2020-01-16 Thread apeforest
This is an automated email from the ASF dual-hosted git repository. apeforest pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git. from 57b98de Build.py improvement (#16976) add a63390d Add RandomApply in gluon's transforms (#17242)

[incubator-mxnet] branch master updated (57b98de -> a63390d)

2020-01-16 Thread apeforest
This is an automated email from the ASF dual-hosted git repository. apeforest pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git. from 57b98de Build.py improvement (#16976) add a63390d Add RandomApply in gluon's transforms (#17242)

[incubator-mxnet] branch master updated (57b98de -> a63390d)

2020-01-16 Thread apeforest
This is an automated email from the ASF dual-hosted git repository. apeforest pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git. from 57b98de Build.py improvement (#16976) add a63390d Add RandomApply in gluon's transforms (#17242)

[GitHub] [incubator-mxnet] apeforest merged pull request #17242: add RandomApply in gluon's transforms

2020-01-16 Thread GitBox
apeforest merged pull request #17242: add RandomApply in gluon's transforms URL: https://github.com/apache/incubator-mxnet/pull/17242 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-mxnet] apeforest closed issue #17085: Suggest to add RandomApply in gluon's transforms

2020-01-16 Thread GitBox
apeforest closed issue #17085: Suggest to add RandomApply in gluon's transforms URL: https://github.com/apache/incubator-mxnet/issues/17085 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-mxnet] ChaiBapchya commented on a change in pull request #17346: Fix reshape interoperability test (#17155)

2020-01-16 Thread GitBox
ChaiBapchya commented on a change in pull request #17346: Fix reshape interoperability test (#17155) URL: https://github.com/apache/incubator-mxnet/pull/17346#discussion_r367676509 ## File path: ci/docker/install/docs_requirements ## @@ -26,11 +26,11 @@ h5py==2.8.0rc1 moc

[GitHub] [incubator-mxnet] reminisce commented on a change in pull request #17346: Fix reshape interoperability test (#17155)

2020-01-16 Thread GitBox
reminisce commented on a change in pull request #17346: Fix reshape interoperability test (#17155) URL: https://github.com/apache/incubator-mxnet/pull/17346#discussion_r367672217 ## File path: ci/docker/install/docs_requirements ## @@ -26,11 +26,11 @@ h5py==2.8.0rc1 mock=

[GitHub] [incubator-mxnet] haojin2 commented on issue #17342: [bug] Incorrect Indexed Assignment

2020-01-16 Thread GitBox
haojin2 commented on issue #17342: [bug] Incorrect Indexed Assignment URL: https://github.com/apache/incubator-mxnet/issues/17342#issuecomment-575365086 @kshitij12345 This has been addressed in the new `np` module: ```python from mxnet import np, npx npx.set_np() import numpy as

[GitHub] [incubator-mxnet] ChaiBapchya opened a new pull request #17346: Fix reshape interoperability test (#17155)

2020-01-16 Thread GitBox
ChaiBapchya opened a new pull request #17346: Fix reshape interoperability test (#17155) URL: https://github.com/apache/incubator-mxnet/pull/17346 * fix reshape interoperability test * fix for scipy import ## Description ## To fix the numpy.decorator issue in https://githu

[GitHub] [incubator-mxnet] leezu commented on issue #17293: [Build] Add a reasonable default for CMAKE_CUDA_COMPILER in *nix

2020-01-16 Thread GitBox
leezu commented on issue #17293: [Build] Add a reasonable default for CMAKE_CUDA_COMPILER in *nix URL: https://github.com/apache/incubator-mxnet/pull/17293#issuecomment-575355873 LD_LIBRARY_PATH will not cause issues in this case, but it's a related problem source. It will cause problems i

[GitHub] [incubator-mxnet] haojin2 commented on issue #17298: [MXNET-1438] Adding SDML loss function

2020-01-16 Thread GitBox
haojin2 commented on issue #17298: [MXNET-1438] Adding SDML loss function URL: https://github.com/apache/incubator-mxnet/pull/17298#issuecomment-575348787 @anjishnu I'm only concerned about if there's any flakiness in such a test, to verify, please try `MXNET_TEST_COUNT=500 nosetests te

[GitHub] [incubator-mxnet] anjishnu commented on issue #17298: [MXNET-1438] Adding SDML loss function

2020-01-16 Thread GitBox
anjishnu commented on issue #17298: [MXNET-1438] Adding SDML loss function URL: https://github.com/apache/incubator-mxnet/pull/17298#issuecomment-575347534 @haojin2 Are there any serious concerns with the new unit test? This i

[GitHub] [incubator-mxnet] larroy commented on issue #17293: [Build] Add a reasonable default for CMAKE_CUDA_COMPILER in *nix

2020-01-16 Thread GitBox
larroy commented on issue #17293: [Build] Add a reasonable default for CMAKE_CUDA_COMPILER in *nix URL: https://github.com/apache/incubator-mxnet/pull/17293#issuecomment-575346572 Thanks for the clarifications, make sense. I don't think LD_LIBRARY_PATH will be an issue in this case. As th

[GitHub] [incubator-mxnet] ChaiBapchya commented on issue #17200: [WIP] loosen numpy version requirement

2020-01-16 Thread GitBox
ChaiBapchya commented on issue #17200: [WIP] loosen numpy version requirement URL: https://github.com/apache/incubator-mxnet/pull/17200#issuecomment-575342644 Any idea which PR should be merged to get 1.5.x into working? I tried cherry-picking https://github.com/apache/incubator-mxnet/p

[incubator-mxnet] branch master updated (a296dad -> 57b98de)

2020-01-16 Thread apeforest
This is an automated email from the ASF dual-hosted git repository. apeforest pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git. from a296dad Fix flakey test_ndarray.py:test_reduce (#17312) add 57b98de Build.py improvement (#16976)

[incubator-mxnet] branch master updated (a296dad -> 57b98de)

2020-01-16 Thread apeforest
This is an automated email from the ASF dual-hosted git repository. apeforest pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git. from a296dad Fix flakey test_ndarray.py:test_reduce (#17312) add 57b98de Build.py improvement (#16976)

[GitHub] [incubator-mxnet] apeforest merged pull request #16976: Build.py improvement

2020-01-16 Thread GitBox
apeforest merged pull request #16976: Build.py improvement URL: https://github.com/apache/incubator-mxnet/pull/16976 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-mxnet] larroy commented on issue #16976: Build.py improvement

2020-01-16 Thread GitBox
larroy commented on issue #16976: Build.py improvement URL: https://github.com/apache/incubator-mxnet/pull/16976#issuecomment-575340365 @mxnet-label-bot add [pr-awaiting-merge] This is an automated message from the Apache Git

[GitHub] [incubator-mxnet] apeforest edited a comment on issue #17292: Can't run horovod with latest nightly wheel

2020-01-16 Thread GitBox
apeforest edited a comment on issue #17292: Can't run horovod with latest nightly wheel URL: https://github.com/apache/incubator-mxnet/issues/17292#issuecomment-574848779 Thanks @stephenrawls for the analysis. Here are the causes of the problem: 1) Horovod uses MX_API_BEGIN() an

[GitHub] [incubator-mxnet] apeforest edited a comment on issue #17292: Can't run horovod with latest nightly wheel

2020-01-16 Thread GitBox
apeforest edited a comment on issue #17292: Can't run horovod with latest nightly wheel URL: https://github.com/apache/incubator-mxnet/issues/17292#issuecomment-574848779 Thanks @stephenrawls for the analysis. Here are the causes of the problem: 1) Horovod uses MX_API_BEGIN() an

[GitHub] [incubator-mxnet] leezu edited a comment on issue #17293: [Build] Add a reasonable default for CMAKE_CUDA_COMPILER in *nix

2020-01-16 Thread GitBox
leezu edited a comment on issue #17293: [Build] Add a reasonable default for CMAKE_CUDA_COMPILER in *nix URL: https://github.com/apache/incubator-mxnet/pull/17293#issuecomment-575337042 @larroy, yes it's required to check the environment variables (both `CUDACXX` and `PATH`) first before "

[GitHub] [incubator-mxnet] leezu edited a comment on issue #17293: [Build] Add a reasonable default for CMAKE_CUDA_COMPILER in *nix

2020-01-16 Thread GitBox
leezu edited a comment on issue #17293: [Build] Add a reasonable default for CMAKE_CUDA_COMPILER in *nix URL: https://github.com/apache/incubator-mxnet/pull/17293#issuecomment-575337042 @larroy, yes it's required to check the environment variables (both `CUDACXX` and `PATH`) first before "

[GitHub] [incubator-mxnet] leezu edited a comment on issue #17293: [Build] Add a reasonable default for CMAKE_CUDA_COMPILER in *nix

2020-01-16 Thread GitBox
leezu edited a comment on issue #17293: [Build] Add a reasonable default for CMAKE_CUDA_COMPILER in *nix URL: https://github.com/apache/incubator-mxnet/pull/17293#issuecomment-575337042 @larroy, yes it's required to check the environment variables (both `CUDACXX` and `PATH`) first before "

[GitHub] [incubator-mxnet] leezu edited a comment on issue #17293: [Build] Add a reasonable default for CMAKE_CUDA_COMPILER in *nix

2020-01-16 Thread GitBox
leezu edited a comment on issue #17293: [Build] Add a reasonable default for CMAKE_CUDA_COMPILER in *nix URL: https://github.com/apache/incubator-mxnet/pull/17293#issuecomment-575337042 @larroy, yes it's required to check the environment variables (both `CUDACXX` and `PATH`) first before "

[GitHub] [incubator-mxnet] leezu edited a comment on issue #17293: [Build] Add a reasonable default for CMAKE_CUDA_COMPILER in *nix

2020-01-16 Thread GitBox
leezu edited a comment on issue #17293: [Build] Add a reasonable default for CMAKE_CUDA_COMPILER in *nix URL: https://github.com/apache/incubator-mxnet/pull/17293#issuecomment-575337042 @larroy, yes it's required to check the environment variables (both `CUDACXX` and `PATH`) first before "

[GitHub] [incubator-mxnet] leezu commented on issue #17293: [Build] Add a reasonable default for CMAKE_CUDA_COMPILER in *nix

2020-01-16 Thread GitBox
leezu commented on issue #17293: [Build] Add a reasonable default for CMAKE_CUDA_COMPILER in *nix URL: https://github.com/apache/incubator-mxnet/pull/17293#issuecomment-575337042 @larroy, yes it's required to check the environment variables (both `CUDACXX` and `PATH` first before "falling

[GitHub] [incubator-mxnet] marcoabreu commented on issue #16794: Random rotation

2020-01-16 Thread GitBox
marcoabreu commented on issue #16794: Random rotation URL: https://github.com/apache/incubator-mxnet/pull/16794#issuecomment-575334331 This is a very useful feature, thanks! @reminisce @eric-haibin-lin @apeforest could you review please? --

[GitHub] [incubator-mxnet] marcoabreu commented on a change in pull request #13456: Improve CCache handling

2020-01-16 Thread GitBox
marcoabreu commented on a change in pull request #13456: Improve CCache handling URL: https://github.com/apache/incubator-mxnet/pull/13456#discussion_r367634124 ## File path: ci/docker/runtime_functions.sh ## @@ -637,9 +685,11 @@ build_ubuntu_gpu_cmake_mkldnn() { build_ubu

[GitHub] [incubator-mxnet] larroy commented on a change in pull request #13456: Improve CCache handling

2020-01-16 Thread GitBox
larroy commented on a change in pull request #13456: Improve CCache handling URL: https://github.com/apache/incubator-mxnet/pull/13456#discussion_r367631941 ## File path: ci/docker/runtime_functions.sh ## @@ -637,9 +685,11 @@ build_ubuntu_gpu_cmake_mkldnn() { build_ubuntu_

  1   2   >