[incubator-mxnet-site] branch asf-site updated: Bump the publish timestamp.

2020-05-21 Thread aaronmarkham
This is an automated email from the ASF dual-hosted git repository. aaronmarkham pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-mxnet-site.git The following commit(s) were added to refs/heads/asf-site by this push: new daf91e7 Bump the publis

[GitHub] [incubator-mxnet] mseth10 closed pull request #18347: Fix nightly CD pipeline for python docker images

2020-05-21 Thread GitBox
mseth10 closed pull request #18347: URL: https://github.com/apache/incubator-mxnet/pull/18347 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-mxnet] mseth10 commented on pull request #18347: Fix nightly CD pipeline for python docker images

2020-05-21 Thread GitBox
mseth10 commented on pull request #18347: URL: https://github.com/apache/incubator-mxnet/pull/18347#issuecomment-632503203 Closing in favor of #18356 This is an automated message from the Apache Git Service. To respond to th

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18387: fix the error of resnet output weight sharing

2020-05-21 Thread GitBox
mxnet-bot commented on pull request #18387: URL: https://github.com/apache/incubator-mxnet/pull/18387#issuecomment-632501900 Hey @liuzh91 , Thanks for submitting the PR All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following co

[GitHub] [incubator-mxnet] liuzh91 opened a new pull request #18387: fix the error of resnet output weight sharing

2020-05-21 Thread GitBox
liuzh91 opened a new pull request #18387: URL: https://github.com/apache/incubator-mxnet/pull/18387 ## Description ## Fix the output weight sharing in test_gluon_estimator script. Fix #18372 ## Checklist ## ### Essentials ### Please feel free to remove inapplicable items

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18277: Fix binary scalar dtype and add bool support

2020-05-21 Thread GitBox
mxnet-bot commented on pull request #18277: URL: https://github.com/apache/incubator-mxnet/pull/18277#issuecomment-632500574 Jenkins CI successfully triggered : [windows-gpu] This is an automated message from the Apache Git S

[GitHub] [incubator-mxnet] Tommliu commented on pull request #18277: Fix binary scalar dtype and add bool support

2020-05-21 Thread GitBox
Tommliu commented on pull request #18277: URL: https://github.com/apache/incubator-mxnet/pull/18277#issuecomment-632500542 @mxnet-bot run ci [windows-gpu] This is an automated message from the Apache Git Service. To respond t

[GitHub] [incubator-mxnet] sxjscience commented on pull request #18089: Add npx op 'index_add'

2020-05-21 Thread GitBox
sxjscience commented on pull request #18089: URL: https://github.com/apache/incubator-mxnet/pull/18089#issuecomment-632499329 LGTM overall. Needs to fix the CudaMalloc + cudaFree. This is an automated message from the Apache

[GitHub] [incubator-mxnet] sxjscience commented on a change in pull request #18089: Add npx op 'index_add'

2020-05-21 Thread GitBox
sxjscience commented on a change in pull request #18089: URL: https://github.com/apache/incubator-mxnet/pull/18089#discussion_r429055166 ## File path: src/operator/tensor/index_add_backward.cu ## @@ -0,0 +1,119 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [incubator-mxnet] sxjscience commented on a change in pull request #18089: Add npx op 'index_add'

2020-05-21 Thread GitBox
sxjscience commented on a change in pull request #18089: URL: https://github.com/apache/incubator-mxnet/pull/18089#discussion_r429054854 ## File path: src/operator/tensor/index_add_backward.cu ## @@ -0,0 +1,119 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [incubator-mxnet] TriLoo closed issue #18386: the metric.py is missed in the latest master branch

2020-05-21 Thread GitBox
TriLoo closed issue #18386: URL: https://github.com/apache/incubator-mxnet/issues/18386 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [incubator-mxnet] TriLoo commented on issue #18386: the metric.py is missed in the latest master branch

2020-05-21 Thread GitBox
TriLoo commented on issue #18386: URL: https://github.com/apache/incubator-mxnet/issues/18386#issuecomment-632493182 It was indeed moved to `mx.gluon.metrix` ... This is an automated message from the Apache Git Service. To r

[GitHub] [incubator-mxnet] TriLoo opened a new issue #18386: the metric.py is missed in the latest master branch

2020-05-21 Thread GitBox
TriLoo opened a new issue #18386: URL: https://github.com/apache/incubator-mxnet/issues/18386 mxnet installed using latest source code from master branch complains: `AttributeError: module 'mxnet' has no attribute 'metric'` looks like the `metric.py` is missed or moved to another pac

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18371: [numpy] fix op repeat with list input

2020-05-21 Thread GitBox
mxnet-bot commented on pull request #18371: URL: https://github.com/apache/incubator-mxnet/pull/18371#issuecomment-632486123 Jenkins CI successfully triggered : [windows-gpu] This is an automated message from the Apache Git S

[GitHub] [incubator-mxnet] Yiyan66 commented on pull request #18371: [numpy] fix op repeat with list input

2020-05-21 Thread GitBox
Yiyan66 commented on pull request #18371: URL: https://github.com/apache/incubator-mxnet/pull/18371#issuecomment-632486091 @mxnet-bot run ci [windows-gpu] This is an automated message from the Apache Git Service. To respond t

[incubator-mxnet] branch master updated (b0315f8 -> 2cb6153)

2020-05-21 Thread zhasheng
This is an automated email from the ASF dual-hosted git repository. zhasheng pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git. from b0315f8 [R] Fix incorrect website title for Symbol API in R (#18326) add 2cb6153 Fix test_subgraph

[GitHub] [incubator-mxnet] szha merged pull request #18361: Fix test_subgraph skipif

2020-05-21 Thread GitBox
szha merged pull request #18361: URL: https://github.com/apache/incubator-mxnet/pull/18361 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-mxnet] mseth10 commented on pull request #18361: Fix test_subgraph skipif

2020-05-21 Thread GitBox
mseth10 commented on pull request #18361: URL: https://github.com/apache/incubator-mxnet/pull/18361#issuecomment-632479856 @leezu can we merge this? This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18385: Safe accumulation for computing gradient in Embedding & Take

2020-05-21 Thread GitBox
mxnet-bot commented on pull request #18385: URL: https://github.com/apache/incubator-mxnet/pull/18385#issuecomment-632476192 Hey @MoisesHer , Thanks for submitting the PR All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following

[GitHub] [incubator-mxnet] MoisesHer opened a new pull request #18385: Safe accumulation for computing gradient in Embedding & Take

2020-05-21 Thread GitBox
MoisesHer opened a new pull request #18385: URL: https://github.com/apache/incubator-mxnet/pull/18385 ## Description ## This PR adds the option to compute gradient of Embedding and Take with safe accumulation, i.e. when dtype is FP16, accumulation will be done in FP32. It fixes the

[GitHub] [incubator-mxnet] liuzh91 commented on issue #18372: Question about testing weight sharing of two resnets in test_gluon_estimator.py

2020-05-21 Thread GitBox
liuzh91 commented on issue #18372: URL: https://github.com/apache/incubator-mxnet/issues/18372#issuecomment-632473275 > @liuzh91 these appear to be two separate parameters, as their prefixes differ: **resnetv10**_weight vs **dense0**_weight It should be `val_net.output = gluon.nn.De

[GitHub] [incubator-mxnet] leezu commented on issue #18372: Question about testing weight sharing of two resnets in test_gluon_estimator.py

2020-05-21 Thread GitBox
leezu commented on issue #18372: URL: https://github.com/apache/incubator-mxnet/issues/18372#issuecomment-632470583 @liuzh91 these appear to be two separate parameters, as their prefixes differ: **resnetv10**_weight vs **dense0**_weight ---

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18384: Move nightly tests to PR tests

2020-05-21 Thread GitBox
mxnet-bot commented on pull request #18384: URL: https://github.com/apache/incubator-mxnet/pull/18384#issuecomment-632469994 Hey @leezu , Thanks for submitting the PR All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following comm

[GitHub] [incubator-mxnet] leezu opened a new pull request #18384: Move nightly tests to PR tests

2020-05-21 Thread GitBox
leezu opened a new pull request #18384: URL: https://github.com/apache/incubator-mxnet/pull/18384 Nightly tests are frequently broken and not fixed. Based on the staggered build pipeline it should be acceptable to run them on every PR. -

[incubator-mxnet] branch leezu-patch-2 created (now 1a7d8c3)

2020-05-21 Thread lausen
This is an automated email from the ASF dual-hosted git repository. lausen pushed a change to branch leezu-patch-2 in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git. at 1a7d8c3 Disable test_composite_embedding_with_one_embedding No new revisions were added by this upd

[incubator-mxnet] branch leezu-patch-2 created (now 1a7d8c3)

2020-05-21 Thread lausen
This is an automated email from the ASF dual-hosted git repository. lausen pushed a change to branch leezu-patch-2 in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git. at 1a7d8c3 Disable test_composite_embedding_with_one_embedding This branch includes the following new

[GitHub] [incubator-mxnet] leezu opened a new pull request #18383: Disable test_composite_embedding_with_one_embedding

2020-05-21 Thread GitBox
leezu opened a new pull request #18383: URL: https://github.com/apache/incubator-mxnet/pull/18383 https://github.com/apache/incubator-mxnet/issues/18282 This is an automated message from the Apache Git Service. To respond to

[incubator-mxnet] 01/01: Disable test_composite_embedding_with_one_embedding

2020-05-21 Thread lausen
This is an automated email from the ASF dual-hosted git repository. lausen pushed a commit to branch leezu-patch-2 in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git commit 1a7d8c36a1ed1077156cefa91013c3d0f4e2e7e1 Author: Leonard Lausen AuthorDate: Thu May 21 21:14:42 2020 -07

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18383: Disable test_composite_embedding_with_one_embedding

2020-05-21 Thread GitBox
mxnet-bot commented on pull request #18383: URL: https://github.com/apache/incubator-mxnet/pull/18383#issuecomment-632469356 Hey @leezu , Thanks for submitting the PR All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following comm

[GitHub] [incubator-mxnet] leezu commented on issue #18282: test_composite_embedding_with_one_embedding

2020-05-21 Thread GitBox
leezu commented on issue #18282: URL: https://github.com/apache/incubator-mxnet/issues/18282#issuecomment-632469389 http://jenkins.mxnet-ci.amazon-ml.com/blue/rest/organizations/jenkins/pipelines/mxnet-validation/pipelines/windows-gpu/branches/PR-18365/runs/10/nodes/109/steps/155/log/?star

[GitHub] [incubator-mxnet] liuzh91 commented on issue #18372: Question about testing weight sharing of two resnets in test_gluon_estimator.py

2020-05-21 Thread GitBox
liuzh91 commented on issue #18372: URL: https://github.com/apache/incubator-mxnet/issues/18372#issuecomment-632467681 I think as of the time of testing, you have not initialized network weights. Would you mind testing `net.output.weight.data==val_net.output.weight.data` after both `net` a

[GitHub] [incubator-mxnet] yajiedesign commented on pull request #18379: change _Pragma to #pragma

2020-05-21 Thread GitBox
yajiedesign commented on pull request #18379: URL: https://github.com/apache/incubator-mxnet/pull/18379#issuecomment-632461418 Cannot be resolved by upgrade vs. This is an automated message from the Apache Git Service. To res

[GitHub] [incubator-mxnet] Alicia1529 commented on pull request #18351: Back port the PR #17672:boolean indexing to branch v1.x

2020-05-21 Thread GitBox
Alicia1529 commented on pull request #18351: URL: https://github.com/apache/incubator-mxnet/pull/18351#issuecomment-632455492 @mxnet-bot run ci [edge] This is an automated message from the Apache Git Service. To respond to th

[GitHub] [incubator-mxnet] Alicia1529 commented on pull request #18352: Back port the PR #17672:boolean indexing to branch v1.7.x

2020-05-21 Thread GitBox
Alicia1529 commented on pull request #18352: URL: https://github.com/apache/incubator-mxnet/pull/18352#issuecomment-632455459 @mxnet-bot run ci [edge] This is an automated message from the Apache Git Service. To respond to th

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18352: Back port the PR #17672:boolean indexing to branch v1.7.x

2020-05-21 Thread GitBox
mxnet-bot commented on pull request #18352: URL: https://github.com/apache/incubator-mxnet/pull/18352#issuecomment-632455496 Jenkins CI successfully triggered : [edge] This is an automated message from the Apache Git Service.

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18351: Back port the PR #17672:boolean indexing to branch v1.x

2020-05-21 Thread GitBox
mxnet-bot commented on pull request #18351: URL: https://github.com/apache/incubator-mxnet/pull/18351#issuecomment-632455510 Jenkins CI successfully triggered : [edge] This is an automated message from the Apache Git Service.

[GitHub] [incubator-mxnet] acphile commented on issue #18372: Question about testing weight sharing of two resnets in test_gluon_estimator.py

2020-05-21 Thread GitBox
acphile commented on issue #18372: URL: https://github.com/apache/incubator-mxnet/issues/18372#issuecomment-63245 So is Line 420-423 meant to share the same parameters between net.output and val_net.output (other parts are different)? If so, actually Line 420-423 fails to share parame

[GitHub] [incubator-mxnet] leezu opened a new issue #18382: test_CSVIter

2020-05-21 Thread GitBox
leezu opened a new issue #18382: URL: https://github.com/apache/incubator-mxnet/issues/18382 ``` [2020-05-22T01:08:46.081Z] _ test_CSVIter _ [2020-05-22T01:08:46.081Z] [gw0] linux -- Python 3.6.9 /usr/bin/python3

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18351: Back port the PR #17672:boolean indexing to branch v1.x

2020-05-21 Thread GitBox
mxnet-bot commented on pull request #18351: URL: https://github.com/apache/incubator-mxnet/pull/18351#issuecomment-632445595 Jenkins CI successfully triggered : [edge] This is an automated message from the Apache Git Service.

[GitHub] [incubator-mxnet] Alicia1529 commented on pull request #18351: Back port the PR #17672:boolean indexing to branch v1.x

2020-05-21 Thread GitBox
Alicia1529 commented on pull request #18351: URL: https://github.com/apache/incubator-mxnet/pull/18351#issuecomment-632445584 @mxnet-bot run ci [edge] This is an automated message from the Apache Git Service. To respond to th

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18352: Back port the PR #17672:boolean indexing to branch v1.7.x

2020-05-21 Thread GitBox
mxnet-bot commented on pull request #18352: URL: https://github.com/apache/incubator-mxnet/pull/18352#issuecomment-632445504 Jenkins CI successfully triggered : [edge] This is an automated message from the Apache Git Service.

[GitHub] [incubator-mxnet] Alicia1529 commented on pull request #18352: Back port the PR #17672:boolean indexing to branch v1.7.x

2020-05-21 Thread GitBox
Alicia1529 commented on pull request #18352: URL: https://github.com/apache/incubator-mxnet/pull/18352#issuecomment-632445478 @mxnet-bot run ci [edge] This is an automated message from the Apache Git Service. To respond to th

[GitHub] [incubator-mxnet] yajiedesign commented on pull request #18379: change _Pragma to #pragma

2020-05-21 Thread GitBox
yajiedesign commented on pull request #18379: URL: https://github.com/apache/incubator-mxnet/pull/18379#issuecomment-632430692 I'll try upgrading vs This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-mxnet] wkcn commented on a change in pull request #18379: change _Pragma to #pragma

2020-05-21 Thread GitBox
wkcn commented on a change in pull request #18379: URL: https://github.com/apache/incubator-mxnet/pull/18379#discussion_r428988397 ## File path: src/io/batchify.cc ## @@ -150,7 +150,7 @@ class StackBatchify : public BatchifyFunction { } int sbs = static_cast(b

[incubator-mxnet-site] branch asf-site updated: Bump the publish timestamp.

2020-05-21 Thread aaronmarkham
This is an automated email from the ASF dual-hosted git repository. aaronmarkham pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-mxnet-site.git The following commit(s) were added to refs/heads/asf-site by this push: new d322d20 Bump the publis

[GitHub] [incubator-mxnet] wkcn commented on a change in pull request #17975: [Bug Fix] Fix the wrong result of `mx.np.mean` and `mx.np.sum` when the input contains np.inf

2020-05-21 Thread GitBox
wkcn commented on a change in pull request #17975: URL: https://github.com/apache/incubator-mxnet/pull/17975#discussion_r428987267 ## File path: tests/python/unittest/test_numpy_op.py ## @@ -9557,3 +9557,67 @@ def hybrid_forward(self, F, a): elif grad_req == 'a

[GitHub] [incubator-mxnet] wkcn commented on pull request #17975: [Bug Fix] Fix the wrong result of `mx.np.mean` and `mx.np.sum` when the input contains np.inf

2020-05-21 Thread GitBox
wkcn commented on pull request #17975: URL: https://github.com/apache/incubator-mxnet/pull/17975#issuecomment-632415615 Hi @sxjscience , could you please help take a review? Thank you! This is an automated message from the Ap

[GitHub] [incubator-mxnet] leezu commented on pull request #18365: Consider BUILD_SHARED_LIBS flag

2020-05-21 Thread GitBox
leezu commented on pull request #18365: URL: https://github.com/apache/incubator-mxnet/pull/18365#issuecomment-632403523 Adopting the standard `BUILD_SHARED_LIBS` may take additional work to make sure all dependencies + the CI logic correctly handle the result. It would however result into

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18277: Fix binary scalar dtype and add bool support

2020-05-21 Thread GitBox
mxnet-bot commented on pull request #18277: URL: https://github.com/apache/incubator-mxnet/pull/18277#issuecomment-632399069 Jenkins CI successfully triggered : [centos-cpu] This is an automated message from the Apache Git Se

[GitHub] [incubator-mxnet] Tommliu commented on pull request #18277: Fix binary scalar dtype and add bool support

2020-05-21 Thread GitBox
Tommliu commented on pull request #18277: URL: https://github.com/apache/incubator-mxnet/pull/18277#issuecomment-632399039 @mxnet-bot run ci [centos-cpu] This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-mxnet-ci] mseth10 commented on pull request #26: Update latest build selection and log when one build fails

2020-05-21 Thread GitBox
mseth10 commented on pull request #26: URL: https://github.com/apache/incubator-mxnet-ci/pull/26#issuecomment-632395929 > When the initial 2 stages of the mxnet-release-cd pipeline fail, it doesn't trigger the subsequent 2 stages ['mxnet_lib/static', 'python/pypi'] @ChaiBapchya M

[GitHub] [incubator-mxnet-ci] mseth10 commented on a change in pull request #26: Update latest build selection and log when one build fails

2020-05-21 Thread GitBox
mseth10 commented on a change in pull request #26: URL: https://github.com/apache/incubator-mxnet-ci/pull/26#discussion_r428961116 ## File path: services/jenkins-pipeline-monitor/handler.py ## @@ -87,11 +95,21 @@ def filter_by_desired_release_job_type(latest_day_builds, desire

[GitHub] [incubator-mxnet-ci] mseth10 commented on a change in pull request #26: Update latest build selection and log when one build fails

2020-05-21 Thread GitBox
mseth10 commented on a change in pull request #26: URL: https://github.com/apache/incubator-mxnet-ci/pull/26#discussion_r428941459 ## File path: services/jenkins-pipeline-monitor/handler.py ## @@ -123,8 +141,6 @@ def jenkins_pipeline_monitor(): latest_day_builds = get_late

[GitHub] [incubator-mxnet] leezu edited a comment on pull request #18365: Consider CMAKE_BUILD_SHARED flag

2020-05-21 Thread GitBox
leezu edited a comment on pull request #18365: URL: https://github.com/apache/incubator-mxnet/pull/18365#issuecomment-632276816 @szha sure. In that case just set BUILD_SHARED_LIBS=0. This is only about simplifying the cmake file to follow standard practice, reducing the amount of cod

[GitHub] [incubator-mxnet] leezu opened a new issue #18381: gelu_test disabled and flaky upon enabling

2020-05-21 Thread GitBox
leezu opened a new issue #18381: URL: https://github.com/apache/incubator-mxnet/issues/18381 ## Description https://github.com/apache/incubator-mxnet/blob/0210ce2c136afaa0f57666e5e1c659cab353f5f3/tests/python/unittest/test_gluon.py#L1423-L1434 is actually a no-op by mistake. Upon

[GitHub] [incubator-mxnet] cbalint13 commented on pull request #18365: Consider CMAKE_BUILD_SHARED flag

2020-05-21 Thread GitBox
cbalint13 commented on pull request #18365: URL: https://github.com/apache/incubator-mxnet/pull/18365#issuecomment-632297892 @leezu , * Proposed leap is big, someone need to adjust CI (out of my scope). * I can re-propose PR it in earlier form (agree not elegant) and see that sing

[GitHub] [incubator-mxnet] leezu edited a comment on pull request #18365: Consider CMAKE_BUILD_SHARED flag

2020-05-21 Thread GitBox
leezu edited a comment on pull request #18365: URL: https://github.com/apache/incubator-mxnet/pull/18365#issuecomment-632276816 @szha sure. In that case just set CMAKE_BUILD_SHARED=0. This is only about simplifying the cmake file to follow standard practice, reducing the amount of co

[incubator-mxnet-site] branch asf-site updated: Bump the publish timestamp.

2020-05-21 Thread aaronmarkham
This is an automated email from the ASF dual-hosted git repository. aaronmarkham pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-mxnet-site.git The following commit(s) were added to refs/heads/asf-site by this push: new 852dbaf Bump the publis

[GitHub] [incubator-mxnet] cbalint13 commented on pull request #18365: Consider CMAKE_BUILD_SHARED flag

2020-05-21 Thread GitBox
cbalint13 commented on pull request #18365: URL: https://github.com/apache/incubator-mxnet/pull/18365#issuecomment-632278035 > @leezu static object should be useful in building standalone C++ inference programs. If the size of test is a problem, we can strip the binary after compilation.

[GitHub] [incubator-mxnet] szha commented on a change in pull request #18376: Fix reference leak in Block._children and enable reference leak tests universally

2020-05-21 Thread GitBox
szha commented on a change in pull request #18376: URL: https://github.com/apache/incubator-mxnet/pull/18376#discussion_r428843534 ## File path: pytest.ini ## @@ -23,6 +23,7 @@ markers = gpu: mark a test that requires GPU. integration: mark an integration test on

[GitHub] [incubator-mxnet] leezu commented on pull request #18365: Consider CMAKE_BUILD_SHARED flag

2020-05-21 Thread GitBox
leezu commented on pull request #18365: URL: https://github.com/apache/incubator-mxnet/pull/18365#issuecomment-632276816 @szha sure. In that case just set CMAKE_BUILD_SHARED=0 This is an automated message from the Apache Git

[GitHub] [incubator-mxnet] szha commented on pull request #18365: Consider CMAKE_BUILD_SHARED flag

2020-05-21 Thread GitBox
szha commented on pull request #18365: URL: https://github.com/apache/incubator-mxnet/pull/18365#issuecomment-632276050 @leezu static object should be useful in building standalone C++ inference programs. If the size of test is a problem, we can strip the binary after compilation. --

[GitHub] [incubator-mxnet] zhreshold commented on a change in pull request #18379: change _Pragma to #pragma

2020-05-21 Thread GitBox
zhreshold commented on a change in pull request #18379: URL: https://github.com/apache/incubator-mxnet/pull/18379#discussion_r428841505 ## File path: src/io/batchify.cc ## @@ -150,7 +150,7 @@ class StackBatchify : public BatchifyFunction { } int sbs = static_c

[GitHub] [incubator-mxnet] zhreshold commented on pull request #18379: change _Pragma to #pragma

2020-05-21 Thread GitBox
zhreshold commented on pull request #18379: URL: https://github.com/apache/incubator-mxnet/pull/18379#issuecomment-632274216 `#pragma` won't work in a macro, what's the version of msvc? At least 2019 supports `_Pragma` This

[GitHub] [incubator-mxnet] leezu opened a new issue #18380: Various issues on Python 3.8

2020-05-21 Thread GitBox
leezu opened a new issue #18380: URL: https://github.com/apache/incubator-mxnet/issues/18380 CI doesn't test Python 3.8 and in fact some things are broken. What I noticed: - Use of `time.clock()` which is deprecated since Python 3.3 and not available in 3.8 in some files breaks thos

[incubator-mxnet] branch master updated (4827de8 -> b0315f8)

2020-05-21 Thread lausen
This is an automated email from the ASF dual-hosted git repository. lausen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git. from 4827de8 Improve the backward mirroring implementation (#18228) add b0315f8 [R] Fix incorrect website

[incubator-mxnet] branch master updated (4827de8 -> b0315f8)

2020-05-21 Thread lausen
This is an automated email from the ASF dual-hosted git repository. lausen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git. from 4827de8 Improve the backward mirroring implementation (#18228) add b0315f8 [R] Fix incorrect website

[incubator-mxnet] branch master updated (4827de8 -> b0315f8)

2020-05-21 Thread lausen
This is an automated email from the ASF dual-hosted git repository. lausen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git. from 4827de8 Improve the backward mirroring implementation (#18228) add b0315f8 [R] Fix incorrect website

[incubator-mxnet] branch master updated (4827de8 -> b0315f8)

2020-05-21 Thread lausen
This is an automated email from the ASF dual-hosted git repository. lausen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git. from 4827de8 Improve the backward mirroring implementation (#18228) add b0315f8 [R] Fix incorrect website

[GitHub] [incubator-mxnet] leezu commented on pull request #17749: Fix races in block scope

2020-05-21 Thread GitBox
leezu commented on pull request #17749: URL: https://github.com/apache/incubator-mxnet/pull/17749#issuecomment-632262724 @chinakook gluoncv does not support MXNet 2 development version at this point. You can use MXNet 1 This

[GitHub] [incubator-mxnet] leezu merged pull request #18326: [R] Fix incorrect website title for Symbol API in R

2020-05-21 Thread GitBox
leezu merged pull request #18326: URL: https://github.com/apache/incubator-mxnet/pull/18326 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [incubator-mxnet] ChaiBapchya commented on pull request #18326: [R] Fix incorrect website title for Symbol API in R

2020-05-21 Thread GitBox
ChaiBapchya commented on pull request #18326: URL: https://github.com/apache/incubator-mxnet/pull/18326#issuecomment-632259139 @mxnet-label-bot update [pr-awaiting-merge] This is an automated message from the Apache Git Servi

[GitHub] [incubator-mxnet] leezu commented on pull request #18365: Consider CMAKE_BUILD_SHARED flag

2020-05-21 Thread GitBox
leezu commented on pull request #18365: URL: https://github.com/apache/incubator-mxnet/pull/18365#issuecomment-632252702 > It seems, had the impression that all test units links libmxnet.a That's part of the problem. It comes with huge link, disk space and CI network traffic overhead

[GitHub] [incubator-mxnet] leezu commented on a change in pull request #18365: Consider CMAKE_BUILD_SHARED flag

2020-05-21 Thread GitBox
leezu commented on a change in pull request #18365: URL: https://github.com/apache/incubator-mxnet/pull/18365#discussion_r428813870 ## File path: CMakeLists.txt ## @@ -663,29 +663,46 @@ if(UNIX) # Create dummy file since we want an empty shared library before linking set(

[GitHub] [incubator-mxnet] leezu commented on a change in pull request #18365: Consider CMAKE_BUILD_SHARED flag

2020-05-21 Thread GitBox
leezu commented on a change in pull request #18365: URL: https://github.com/apache/incubator-mxnet/pull/18365#discussion_r428813539 ## File path: example/image-classification/predict-cpp/CMakeLists.txt ## @@ -5,11 +5,11 @@ OpenCV version >= 3 should be enabled and found to buil

[GitHub] [incubator-mxnet] leezu commented on a change in pull request #18365: Consider CMAKE_BUILD_SHARED flag

2020-05-21 Thread GitBox
leezu commented on a change in pull request #18365: URL: https://github.com/apache/incubator-mxnet/pull/18365#discussion_r428813091 ## File path: tests/CMakeLists.txt ## @@ -16,7 +16,7 @@ if(NOT GTEST_ROOT) endif() endif() -if(NOT MSVC) +if(NOT MSVC AND NOT CMAKE_BUILD_SH

[GitHub] [incubator-mxnet] leezu commented on a change in pull request #18365: Consider CMAKE_BUILD_SHARED flag

2020-05-21 Thread GitBox
leezu commented on a change in pull request #18365: URL: https://github.com/apache/incubator-mxnet/pull/18365#discussion_r428812794 ## File path: CMakeLists.txt ## @@ -663,29 +663,46 @@ if(UNIX) # Create dummy file since we want an empty shared library before linking set(

[GitHub] [incubator-mxnet] samskalicky commented on pull request #18236: [1.7] Pass args fix2 + Fix pylint with unpinned astroid causing CI issues

2020-05-21 Thread GitBox
samskalicky commented on pull request #18236: URL: https://github.com/apache/incubator-mxnet/pull/18236#issuecomment-632239843 @ciyongch thanks for the reminder, I merged This is an automated message from the Apache Git Servi

[GitHub] [incubator-mxnet] D-Roberts commented on pull request #18197: [Numpy] Add qr backward part 2 for wide matrices with m < n

2020-05-21 Thread GitBox
D-Roberts commented on pull request #18197: URL: https://github.com/apache/incubator-mxnet/pull/18197#issuecomment-632237899 Hi @yzhliu - is there anything else you'd like me to do on this? tnx This is an automated message fr

[GitHub] [incubator-mxnet] sxjscience commented on pull request #18228: [MXNET-1450] Improve the backward mirroring implementation

2020-05-21 Thread GitBox
sxjscience commented on pull request #18228: URL: https://github.com/apache/incubator-mxnet/pull/18228#issuecomment-632219485 Is there a way to use it for Gluon? This is an automated message from the Apache Git Service. To re

[incubator-mxnet] branch master updated (5343aef -> 4827de8)

2020-05-21 Thread haibin
This is an automated email from the ASF dual-hosted git repository. haibin pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git. from 5343aef [Numpy] Fix gluon activations (#18370) add 4827de8 Improve the backward mirroring implementat

[incubator-mxnet] branch master updated (67b5d31 -> 5343aef)

2020-05-21 Thread sxjscience
This is an automated email from the ASF dual-hosted git repository. sxjscience pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git. from 67b5d31 Fix race condition in unittest by pytest temp_dir fixtures (#18323) add 5343aef [Numpy]

[GitHub] [incubator-mxnet] eric-haibin-lin merged pull request #18228: [MXNET-1450] Improve the backward mirroring implementation

2020-05-21 Thread GitBox
eric-haibin-lin merged pull request #18228: URL: https://github.com/apache/incubator-mxnet/pull/18228 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[incubator-mxnet] branch master updated (67b5d31 -> 5343aef)

2020-05-21 Thread sxjscience
This is an automated email from the ASF dual-hosted git repository. sxjscience pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git. from 67b5d31 Fix race condition in unittest by pytest temp_dir fixtures (#18323) add 5343aef [Numpy]

[incubator-mxnet] branch master updated (67b5d31 -> 5343aef)

2020-05-21 Thread sxjscience
This is an automated email from the ASF dual-hosted git repository. sxjscience pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git. from 67b5d31 Fix race condition in unittest by pytest temp_dir fixtures (#18323) add 5343aef [Numpy]

[GitHub] [incubator-mxnet] yajiedesign commented on pull request #18379: change _Pragma to #pragma

2020-05-21 Thread GitBox
yajiedesign commented on pull request #18379: URL: https://github.com/apache/incubator-mxnet/pull/18379#issuecomment-632181662 https://github.com/apache/incubator-mxnet/issues/18374 This is an automated message from the Apach

[GitHub] [incubator-mxnet] yajiedesign opened a new pull request #18379: change _Pragma to #pragma

2020-05-21 Thread GitBox
yajiedesign opened a new pull request #18379: URL: https://github.com/apache/incubator-mxnet/pull/18379 ## Description ## change _Pragma to #pragma _Pragma not work with msvc ## Checklist ## ### Essentials ### - [x] Changes are complete (i.e. I finished coding on this PR)

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18379: change _Pragma to #pragma

2020-05-21 Thread GitBox
mxnet-bot commented on pull request #18379: URL: https://github.com/apache/incubator-mxnet/pull/18379#issuecomment-632181495 Hey @yajiedesign , Thanks for submitting the PR All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the followin

[incubator-mxnet] branch master updated (67b5d31 -> 5343aef)

2020-05-21 Thread sxjscience
This is an automated email from the ASF dual-hosted git repository. sxjscience pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git. from 67b5d31 Fix race condition in unittest by pytest temp_dir fixtures (#18323) add 5343aef [Numpy]

[GitHub] [incubator-mxnet] sxjscience merged pull request #18370: [Numpy] Fix gluon activations

2020-05-21 Thread GitBox
sxjscience merged pull request #18370: URL: https://github.com/apache/incubator-mxnet/pull/18370 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [incubator-mxnet] yajiedesign commented on issue #18374: Windows nightly builds broken

2020-05-21 Thread GitBox
yajiedesign commented on issue #18374: URL: https://github.com/apache/incubator-mxnet/issues/18374#issuecomment-632174279 I already know. Now there are some compilation errors. This is an automated message from the Apache Gi

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18352: Back port the PR #17672:boolean indexing to branch v1.7.x

2020-05-21 Thread GitBox
mxnet-bot commented on pull request #18352: URL: https://github.com/apache/incubator-mxnet/pull/18352#issuecomment-632107674 Jenkins CI successfully triggered : [edge] This is an automated message from the Apache Git Service.

[GitHub] [incubator-mxnet] Alicia1529 commented on pull request #18351: Back port the PR #17672:boolean indexing to branch v1.x

2020-05-21 Thread GitBox
Alicia1529 commented on pull request #18351: URL: https://github.com/apache/incubator-mxnet/pull/18351#issuecomment-632107730 @mxnet-bot run ci [edge] This is an automated message from the Apache Git Service. To respond to th

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18351: Back port the PR #17672:boolean indexing to branch v1.x

2020-05-21 Thread GitBox
mxnet-bot commented on pull request #18351: URL: https://github.com/apache/incubator-mxnet/pull/18351#issuecomment-632107782 Jenkins CI successfully triggered : [edge] This is an automated message from the Apache Git Service.

[GitHub] [incubator-mxnet] Alicia1529 commented on pull request #18352: Back port the PR #17672:boolean indexing to branch v1.7.x

2020-05-21 Thread GitBox
Alicia1529 commented on pull request #18352: URL: https://github.com/apache/incubator-mxnet/pull/18352#issuecomment-632107625 @mxnet-bot run ci [edge] This is an automated message from the Apache Git Service. To respond to th

[GitHub] [incubator-mxnet] bgawrych commented on issue #18244: unix-cpu MKL/MKL-DNN Test Time

2020-05-21 Thread GitBox
bgawrych commented on issue #18244: URL: https://github.com/apache/incubator-mxnet/issues/18244#issuecomment-632106623 @szha I've done some testing in docker for parallel tests and have some overview. For testing I've used about 35 long tests. pytest -n 4 spawns much more threads for MK

[incubator-mxnet-site] branch asf-site updated: Bump the publish timestamp.

2020-05-21 Thread aaronmarkham
This is an automated email from the ASF dual-hosted git repository. aaronmarkham pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-mxnet-site.git The following commit(s) were added to refs/heads/asf-site by this push: new b7795cc Bump the publis

[GitHub] [incubator-mxnet] chinakook commented on pull request #17749: Fix races in block scope

2020-05-21 Thread GitBox
chinakook commented on pull request #17749: URL: https://github.com/apache/incubator-mxnet/pull/17749#issuecomment-632050382 This commit may cause rcnn/mask-rcnn cannot be trained. https://github.com/dmlc/gluon-cv/blob/3c4150a964c776e4f7da0eb30b55ab05b7554c8d/gluoncv/data/transforms/pres

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18378: Add backward Type inference to main NN operators

2020-05-21 Thread GitBox
mxnet-bot commented on pull request #18378: URL: https://github.com/apache/incubator-mxnet/pull/18378#issuecomment-632031459 Hey @Kh4L , Thanks for submitting the PR All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following comma

[GitHub] [incubator-mxnet] Kh4L opened a new pull request #18378: Add backward Type inference to main NN operators

2020-05-21 Thread GitBox
Kh4L opened a new pull request #18378: URL: https://github.com/apache/incubator-mxnet/pull/18378 ## Description ## As described in #16757 , a list of operators have their FInferType functions were throwing an exception if the input type is not defined (dtype=-1). This was preventi

  1   2   >