ArmageddonKnight opened a new pull request #18704:
URL: https://github.com/apache/incubator-mxnet/pull/18704


   ## Description ##
   
   This PR is supposed to fix the issue described in #18564 
   
   ## Checklist ##
   ### Essentials ###
   Please feel free to remove inapplicable items for your PR.
   - [x] Changes are complete (i.e. I finished coding on this PR)
   - [x] All changes have test coverage:
   - Unit tests are added for small changes to verify correctness (e.g. adding 
a new operator)
   - Nightly tests are added for complicated/long-running ones (e.g. changing 
distributed kvstore)
   - Build tests will be added for build configuration changes (e.g. adding a 
new build option with NCCL)
   - [x] To the best of my knowledge, examples are either not affected by this 
change, or have been fixed to be compatible with this change
   
   ### Changes ###
   - [x] Removed the setting of `continuous_dump` when setting the profiler 
config.
   
   ## Comments ##
   This PR is for fixing the issue described in #18564 . Specifically, the 
reason why the error happens is because the profiler config has the flag 
`continuous_dump` set, which would further propagate to the core function 
`Profiler::SetContinuousProfileDump` (shown below) and give an error on line 
268.
   
   
https://github.com/apache/incubator-mxnet/blob/9d623926d4857a2cfa32515b58cd1398371f97f3/src/profiler/profiler.cc#L258-L268
   
   FYI, @szha 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to