ChaiBapchya commented on a change in pull request #18625:
URL: https://github.com/apache/incubator-mxnet/pull/18625#discussion_r448685082
##########
File path: ci/docker/runtime_functions.sh
##########
@@ -411,8 +413,9 @@ build_ubuntu_cpu_mkl() {
-DUSE_MKLDNN=OFF \
-DUSE_CUDA=OFF \
-DUSE_TVM_OP=ON \
- -DUSE_MKL_IF_AVAILABLE=ON \
+ -DUSE_MKL_IF_AVAILABLE=OFF \
Review comment:
why are we switching this off? This test is specifically for MKL as BLAS
engine. Removing this would cause all the subsequent PRs to not check for MKL
as BLAS engine.
##########
File path: src/operator/numpy/np_polynomial_op.cc
##########
@@ -53,7 +53,8 @@ struct polyval_backward_p {
DType igrad_p = 0;
index_t j = x_size - 1;
while (j >= 0) {
- igrad_p += pow(x_dptr[j], p_size - i - 1) * ograd_dptr[j];
+ igrad_p += pow(x_dptr[j], static_cast<DType>(p_size) -
Review comment:
just to confirm, there is a unittest coverage for this change?
##########
File path: config/distribution/linux_native.cmake
##########
@@ -29,3 +29,4 @@ set(USE_TVM_OP OFF CACHE BOOL "Enable use of TVM operator
build system.")
set(USE_SSE ON CACHE BOOL "Build with x86 SSE instruction support")
set(USE_F16C OFF CACHE BOOL "Build with x86 F16C instruction support")
set(USE_LIBJPEG_TURBO ON CACHE BOOL "Build with libjpeg-turbo")
+set(USE_INT64_TENSOR_SIZE ON CACHE BOOL "Use int64_t to represent the total
number of elements in a tensor")
Review comment:
nit pick end of the page
##########
File path: config/distribution/linux_cpu.cmake
##########
@@ -29,3 +29,4 @@ set(USE_TVM_OP OFF CACHE BOOL "Enable use of TVM operator
build system.")
set(USE_SSE ON CACHE BOOL "Build with x86 SSE instruction support")
set(USE_F16C OFF CACHE BOOL "Build with x86 F16C instruction support")
set(USE_LIBJPEG_TURBO ON CACHE BOOL "Build with libjpeg-turbo")
+set(USE_INT64_TENSOR_SIZE ON CACHE BOOL "Use int64_t to represent the total
number of elements in a tensor")
Review comment:
nitpick end of the page
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
