[GitHub] [incubator-mxnet] ChaiBapchya commented on issue #10227: Flaky test: test_operator.test_layer_norm

2019-10-02 Thread GitBox
ChaiBapchya commented on issue #10227: Flaky test: test_operator.test_layer_norm URL: https://github.com/apache/incubator-mxnet/issues/10227#issuecomment-537611017 Fixing the seed isn't a good practice is it? Removing finite difference will make this test loose right?

[GitHub] [incubator-mxnet] ChaiBapchya commented on issue #10227: Flaky test: test_operator.test_layer_norm

2019-10-02 Thread GitBox
ChaiBapchya commented on issue #10227: Flaky test: test_operator.test_layer_norm URL: https://github.com/apache/incubator-mxnet/issues/10227#issuecomment-537600327 Um.. 1E-1, 1E-2, now 1E-3.. it has to stop somewhere.. but anyway.. for temporary fix I will push that as PR then

[GitHub] [incubator-mxnet] ChaiBapchya commented on issue #10227: Flaky test: test_operator.test_layer_norm

2019-10-02 Thread GitBox
ChaiBapchya commented on issue #10227: Flaky test: test_operator.test_layer_norm URL: https://github.com/apache/incubator-mxnet/issues/10227#issuecomment-537596535 Happened again: #16336 (unrelated PR)