KellenSunderland commented on issue #14591: Reference engine from chunk via
weak pointer
URL: https://github.com/apache/incubator-mxnet/pull/14591#issuecomment-483904042
@anirudh2290 Moved the test into its own fixture, should be ready for
another look.
---
KellenSunderland commented on issue #14591: Reference engine from chunk via
weak pointer
URL: https://github.com/apache/incubator-mxnet/pull/14591#issuecomment-483520820
@anirudh2290 Good point. Took me a while to think of how we can test this.
Reproducing the issue is only possible when
KellenSunderland commented on issue #14591: Reference engine from chunk via
weak pointer
URL: https://github.com/apache/incubator-mxnet/pull/14591#issuecomment-479666131
@anirudhacharya @eric-haibin-lin
Could one of you guys do a quick review (it's a pretty small change).
-
KellenSunderland commented on issue #14591: Reference engine from chunk via
weak pointer
URL: https://github.com/apache/incubator-mxnet/pull/14591#issuecomment-479130992
@piyushghai Gotcha! Thanks for the quick responses on the PR.
-
KellenSunderland commented on issue #14591: Reference engine from chunk via
weak pointer
URL: https://github.com/apache/incubator-mxnet/pull/14591#issuecomment-479128434
Thanks @piyushghai. Not immediately clear to me why the numpy label is
attached. Does this PR have a Numpy related asp