[GitHub] [incubator-mxnet] ZhennanQin commented on a change in pull request #16141: [mkldnn-v1.0] Add MKL-DNN Convolution

2019-09-17 Thread GitBox
ZhennanQin commented on a change in pull request #16141: [mkldnn-v1.0] Add MKL-DNN Convolution URL: https://github.com/apache/incubator-mxnet/pull/16141#discussion_r325458549 ## File path: src/operator/nn/convolution.cc ## @@ -60,8 +60,12 @@ static void ConvolutionComputeE

[GitHub] [incubator-mxnet] ZhennanQin commented on a change in pull request #16141: [mkldnn-v1.0] Add MKL-DNN Convolution

2019-09-17 Thread GitBox
ZhennanQin commented on a change in pull request #16141: [mkldnn-v1.0] Add MKL-DNN Convolution URL: https://github.com/apache/incubator-mxnet/pull/16141#discussion_r325458549 ## File path: src/operator/nn/convolution.cc ## @@ -60,8 +60,12 @@ static void ConvolutionComputeE

[GitHub] [incubator-mxnet] ZhennanQin commented on a change in pull request #16141: [mkldnn-v1.0] Add MKL-DNN Convolution

2019-09-16 Thread GitBox
ZhennanQin commented on a change in pull request #16141: [mkldnn-v1.0] Add MKL-DNN Convolution URL: https://github.com/apache/incubator-mxnet/pull/16141#discussion_r324945190 ## File path: src/operator/nn/mkldnn/mkldnn_base-inl.h ## @@ -277,6 +277,19 @@ inline static mkldn

[GitHub] [incubator-mxnet] ZhennanQin commented on a change in pull request #16141: [mkldnn-v1.0] Add MKL-DNN Convolution

2019-09-16 Thread GitBox
ZhennanQin commented on a change in pull request #16141: [mkldnn-v1.0] Add MKL-DNN Convolution URL: https://github.com/apache/incubator-mxnet/pull/16141#discussion_r324945129 ## File path: src/operator/nn/mkldnn/mkldnn_convolution-inl.h ## @@ -79,54 +79,63 @@ struct MKLDNN

[GitHub] [incubator-mxnet] ZhennanQin commented on a change in pull request #16141: [mkldnn-v1.0] Add MKL-DNN Convolution

2019-09-16 Thread GitBox
ZhennanQin commented on a change in pull request #16141: [mkldnn-v1.0] Add MKL-DNN Convolution URL: https://github.com/apache/incubator-mxnet/pull/16141#discussion_r324944841 ## File path: src/operator/operator_common.h ## @@ -526,17 +526,46 @@ class OpSignature { * an

[GitHub] [incubator-mxnet] ZhennanQin commented on a change in pull request #16141: [mkldnn-v1.0] Add MKL-DNN Convolution

2019-09-15 Thread GitBox
ZhennanQin commented on a change in pull request #16141: [mkldnn-v1.0] Add MKL-DNN Convolution URL: https://github.com/apache/incubator-mxnet/pull/16141#discussion_r324521626 ## File path: src/operator/operator_common.h ## @@ -526,17 +526,46 @@ class OpSignature { * an

[GitHub] [incubator-mxnet] ZhennanQin commented on a change in pull request #16141: [mkldnn-v1.0] Add MKL-DNN Convolution

2019-09-15 Thread GitBox
ZhennanQin commented on a change in pull request #16141: [mkldnn-v1.0] Add MKL-DNN Convolution URL: https://github.com/apache/incubator-mxnet/pull/16141#discussion_r324520273 ## File path: src/common/exec_utils.h ## @@ -59,15 +59,15 @@ inline bool SetupDefaultBlobsIn(const