[GitHub] [incubator-mxnet] ZhennanQin commented on issue #15298: Fix Cached_op with static_shape=true

2019-06-26 Thread GitBox
ZhennanQin commented on issue #15298: Fix Cached_op with static_shape=true URL: https://github.com/apache/incubator-mxnet/pull/15298#issuecomment-506134064 @PatricZhao Tested symbolic & gluon inference speed and bert, seems everything works fine.

[GitHub] [incubator-mxnet] ZhennanQin commented on issue #15298: Fix Cached_op with static_shape=true

2019-06-26 Thread GitBox
ZhennanQin commented on issue #15298: Fix Cached_op with static_shape=true URL: https://github.com/apache/incubator-mxnet/pull/15298#issuecomment-505782542 @roywei On my side, sockeye has only 2 failures after this fix: test/unit/test_data_io.py::test_parallel_sample_iter FAILED

[GitHub] [incubator-mxnet] ZhennanQin commented on issue #15298: Fix Cached_op with static_shape=true

2019-06-25 Thread GitBox
ZhennanQin commented on issue #15298: Fix Cached_op with static_shape=true URL: https://github.com/apache/incubator-mxnet/pull/15298#issuecomment-505300321 https://github.com/apache/incubator-mxnet/issues/15297 should be fixed with this PR.