[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #14480: Tidy up storage allocation and deallocation

2019-03-26 Thread GitBox
apeforest commented on a change in pull request #14480: Tidy up storage allocation and deallocation URL: https://github.com/apache/incubator-mxnet/pull/14480#discussion_r269393152 ## File path: tests/cpp/include/test_util.h ## @@ -70,11 +70,9 @@ class BlobMemory { ret

[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #14480: Tidy up storage allocation and deallocation

2019-03-26 Thread GitBox
apeforest commented on a change in pull request #14480: Tidy up storage allocation and deallocation URL: https://github.com/apache/incubator-mxnet/pull/14480#discussion_r269296754 ## File path: src/storage/pinned_memory_storage.h ## @@ -38,32 +38,36 @@ class PinnedMemorySt

[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #14480: Tidy up storage allocation and deallocation

2019-03-26 Thread GitBox
apeforest commented on a change in pull request #14480: Tidy up storage allocation and deallocation URL: https://github.com/apache/incubator-mxnet/pull/14480#discussion_r269293120 ## File path: src/storage/gpu_device_storage.h ## @@ -43,20 +43,24 @@ class GPUDeviceStorage