cjolivier01 commented on issue #15375: Memory leak in Naive engine when 
profiling
URL: 
https://github.com/apache/incubator-mxnet/issues/15375#issuecomment-506577210
 
 
   I agree with Anirudh.
   
   I didn’t write the object pool code, but the reason it was done that way was 
to
   avoid a new/delete operation in-line to the profiling, thus causing 
profiling to introduce possibly extra locks (and associated heap code), 
depending on the allocation library used, causing the “Observer Effect”, which 
is not desired in profiling, of all things. Ideally, the naive engine would use 
the same mechanism (a better change, imho), but since it’s not used as much for 
production workloads, I suppose they didn’t think it was worth it to code it. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to