[GitHub] [incubator-mxnet] eric-haibin-lin commented on a change in pull request #16398: Aggregated adamw update

2019-10-11 Thread GitBox
eric-haibin-lin commented on a change in pull request #16398: Aggregated adamw update URL: https://github.com/apache/incubator-mxnet/pull/16398#discussion_r334121888 ## File path: python/mxnet/ndarray/contrib.py ## @@ -548,15 +548,15 @@ def isnan(data): """ retur

[GitHub] [incubator-mxnet] eric-haibin-lin commented on a change in pull request #16398: Aggregated adamw update

2019-10-10 Thread GitBox
eric-haibin-lin commented on a change in pull request #16398: Aggregated adamw update URL: https://github.com/apache/incubator-mxnet/pull/16398#discussion_r333825333 ## File path: python/mxnet/ndarray/contrib.py ## @@ -542,14 +546,17 @@ def isnan(data): [1. 0.]