haojin2 commented on a change in pull request #15468: Numpy compatible diagflat
operator
URL: https://github.com/apache/incubator-mxnet/pull/15468#discussion_r302922300
##
File path: src/operator/numpy/np_diagflat_op.cu
##
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache So
haojin2 commented on a change in pull request #15468: Numpy compatible diagflat
operator
URL: https://github.com/apache/incubator-mxnet/pull/15468#discussion_r302921968
##
File path: tests/python/unittest/test_numpy_op.py
##
@@ -28,6 +28,59 @@
import random
+@with_see
haojin2 commented on a change in pull request #15468: Numpy compatible diagflat
operator
URL: https://github.com/apache/incubator-mxnet/pull/15468#discussion_r302921755
##
File path: src/operator/numpy/np_diagflat_op-inl.h
##
@@ -0,0 +1,201 @@
+/*
Review comment:
See
haojin2 commented on a change in pull request #15468: Numpy compatible diagflat
operator
URL: https://github.com/apache/incubator-mxnet/pull/15468#discussion_r302921428
##
File path: src/operator/numpy/np_diagflat_op-inl.h
##
@@ -0,0 +1,201 @@
+/*
Review comment:
Bet