haojin2 commented on a change in pull request #17921: [Numpy] allow mix integer
dtypes for power/add/multiply
URL: https://github.com/apache/incubator-mxnet/pull/17921#discussion_r400579543
##########
File path: src/operator/numpy/np_elemwise_broadcast_op.h
##########
@@ -51,6 +51,11 @@ inline void PrintErrorMessage(const std::string& op_name,
const int dtype1, cons
<< " yet...";
}
+inline bool is_integer(const int dtype) {
Review comment:
no need for this extra function, you could use `common::is_float(const int
dtype)` instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
