larroy commented on issue #14940: Fix warnings
URL: https://github.com/apache/incubator-mxnet/pull/14940#issuecomment-513413494
Fixed the whitespace, let me know if there's something else.
This is an automated message from the
larroy commented on issue #14940: Fix warnings
URL: https://github.com/apache/incubator-mxnet/pull/14940#issuecomment-514741982
@haojin2 can you please review again?
This is an automated message from the Apache Git Service.
To
larroy commented on issue #14940: Fix warnings
URL: https://github.com/apache/incubator-mxnet/pull/14940#issuecomment-516212747
@szha this has been opened forever, could you help with this PR? thanks.
This is an automated mess
larroy commented on issue #14940: Fix warnings
URL: https://github.com/apache/incubator-mxnet/pull/14940#issuecomment-521899079
So the request for changes is basically for two additional blank lines
(which by the way are allowed by Google style guide and Pep8) this has a CI
cost which I d
larroy commented on issue #14940: Fix warnings
URL: https://github.com/apache/incubator-mxnet/pull/14940#issuecomment-521899781
I don't find this way to review code is conductive to contributing to this
project.
This is an au
larroy commented on issue #14940: Fix warnings
URL: https://github.com/apache/incubator-mxnet/pull/14940#issuecomment-522106028
@marcoabreu why this doesn't apply to huge PRs like this?
https://github.com/apache/incubator-mxnet/pull/15581/files instead is used as
nitpicking for small PRs f
larroy commented on issue #14940: Fix warnings and improve inline abuse
URL: https://github.com/apache/incubator-mxnet/pull/14940#issuecomment-492822950
@mxnet-label-bot add [pr-awaiting-review, Backend]
This is an automated m
larroy commented on issue #14940: Fix warnings and improve inline abuse
URL: https://github.com/apache/incubator-mxnet/pull/14940#issuecomment-494556561
@apeforest @anirudh2290 @haojin2
This is an automated message from the A
larroy commented on issue #14940: Fix warnings and improve inline abuse
URL: https://github.com/apache/incubator-mxnet/pull/14940#issuecomment-494581070
@apeforest I think everybody agreed with that. But somebody has to do it,
and I think I'm one of the few moving towards zero warnings. I h
