larroy commented on issue #15285: Graph dumper
URL: https://github.com/apache/incubator-mxnet/pull/15285#issuecomment-509777153
@ptrendx I didn't see code that dumps directly to dot, but to Json as
discussed above. If you guys have such a problem with introducing a graph class
which has un
larroy commented on issue #15285: Graph dumper
URL: https://github.com/apache/incubator-mxnet/pull/15285#issuecomment-509815270
@ptrendx not getting defensive, that was not my intention, let's not read
between the lines. Feedback should be concrete an actionable for efficient use
of everyb
larroy commented on issue #15285: Graph dumper
URL: https://github.com/apache/incubator-mxnet/pull/15285#issuecomment-509858209
@ptrendx Thanks
This is an automated message from the Apache Git Service.
To respond to the messag
larroy commented on issue #15285: Graph dumper
URL: https://github.com/apache/incubator-mxnet/pull/15285#issuecomment-515257152
It's ironic, the amount of questionable code that has gone in the repo, and
having a single header data structure with tests is a big issue. No worries, I
will re
larroy commented on issue #15285: Graph dumper
URL: https://github.com/apache/incubator-mxnet/pull/15285#issuecomment-515269966
Just curious, am I the only one who sees the design problems of the indexed
graph class?
This is
larroy commented on issue #15285: Graph dumper
URL: https://github.com/apache/incubator-mxnet/pull/15285#issuecomment-515280608
@anirudh2290 @ptrendx @szha please review again, I removed the offending
code.
This is an automat
larroy commented on issue #15285: Graph dumper
URL: https://github.com/apache/incubator-mxnet/pull/15285#issuecomment-515353265
@apeforest I'm confused by your latest review, have you read the comments
above? there's sample output, and samples from the graph, please scroll.
About Log
larroy commented on issue #15285: Graph dumper
URL: https://github.com/apache/incubator-mxnet/pull/15285#issuecomment-522161736
Question, is there interest to get this merged if I address @ptrendx
comments? The action points that I have in mind are just deduplicating node
names. I have lim
larroy commented on issue #15285: Graph dumper
URL: https://github.com/apache/incubator-mxnet/pull/15285#issuecomment-529167549
There doesn't seem to be interest to get this in. I will keep it as a
private tool. Thanks for the reviews.
--
