[GitHub] [incubator-mxnet] leezu commented on a change in pull request #18083: Changes to mxnet.metric

2020-05-08 Thread GitBox
leezu commented on a change in pull request #18083: URL: https://github.com/apache/incubator-mxnet/pull/18083#discussion_r422279290 ## File path: tests/python/train/test_mlp.py ## @@ -37,8 +37,9 @@ def test_mlp(tmpdir): def accuracy(label, pred): py = np.argmax(

[GitHub] [incubator-mxnet] leezu commented on a change in pull request #18083: Changes to mxnet.metric

2020-05-07 Thread GitBox
leezu commented on a change in pull request #18083: URL: https://github.com/apache/incubator-mxnet/pull/18083#discussion_r421715173 ## File path: tests/python/tensorrt/test_cvnets.py ## @@ -29,7 +28,12 @@ def get_classif_model(model_name, use_tensorrt, ctx=mx.gpu(0), batch_siz

[GitHub] [incubator-mxnet] leezu commented on a change in pull request #18083: Changes to mxnet.metric

2020-05-07 Thread GitBox
leezu commented on a change in pull request #18083: URL: https://github.com/apache/incubator-mxnet/pull/18083#discussion_r421715173 ## File path: tests/python/tensorrt/test_cvnets.py ## @@ -29,7 +28,12 @@ def get_classif_model(model_name, use_tensorrt, ctx=mx.gpu(0), batch_siz

[GitHub] [incubator-mxnet] leezu commented on a change in pull request #18083: Changes to mxnet.metric

2020-04-24 Thread GitBox
leezu commented on a change in pull request #18083: URL: https://github.com/apache/incubator-mxnet/pull/18083#discussion_r414924090 ## File path: python/mxnet/gluon/metric.py ## @@ -617,92 +585,102 @@ def update_binary_stats(self, label, pred): pred : `NDArray`

[GitHub] [incubator-mxnet] leezu commented on a change in pull request #18083: Changes to mxnet.metric

2020-04-24 Thread GitBox
leezu commented on a change in pull request #18083: URL: https://github.com/apache/incubator-mxnet/pull/18083#discussion_r414921455 ## File path: python/mxnet/gluon/metric.py ## @@ -617,92 +585,102 @@ def update_binary_stats(self, label, pred): pred : `NDArray`

[GitHub] [incubator-mxnet] leezu commented on a change in pull request #18083: Changes to mxnet.metric

2020-04-21 Thread GitBox
leezu commented on a change in pull request #18083: URL: https://github.com/apache/incubator-mxnet/pull/18083#discussion_r412625767 ## File path: python/mxnet/gluon/metric.py ## @@ -619,90 +583,100 @@ def update_binary_stats(self, label, pred): """ pred = pred

[GitHub] [incubator-mxnet] leezu commented on a change in pull request #18083: Changes to mxnet.metric

2020-04-21 Thread GitBox
leezu commented on a change in pull request #18083: URL: https://github.com/apache/incubator-mxnet/pull/18083#discussion_r412613930 ## File path: python/mxnet/gluon/metric.py ## @@ -24,9 +24,9 @@ import numpy Review comment: Instead of using numpy, we can use `mxnet.

[GitHub] [incubator-mxnet] leezu commented on a change in pull request #18083: Changes to mxnet.metric

2020-04-21 Thread GitBox
leezu commented on a change in pull request #18083: URL: https://github.com/apache/incubator-mxnet/pull/18083#discussion_r412605078 ## File path: python/mxnet/gluon/metric.py ## @@ -619,90 +583,100 @@ def update_binary_stats(self, label, pred): """ pred = pred