[GitHub] [incubator-mxnet] leezu commented on a change in pull request #18413: Simplifying mxnet.gluon.block APIs

2020-06-17 Thread GitBox
leezu commented on a change in pull request #18413: URL: https://github.com/apache/incubator-mxnet/pull/18413#discussion_r441043985 ## File path: python/mxnet/gluon/block.py ## @@ -57,57 +57,39 @@ def __init__(self, block): self._local._name_scope = None @static

[GitHub] [incubator-mxnet] leezu commented on a change in pull request #18413: Simplifying mxnet.gluon.block APIs

2020-06-12 Thread GitBox
leezu commented on a change in pull request #18413: URL: https://github.com/apache/incubator-mxnet/pull/18413#discussion_r439575123 ## File path: python/mxnet/gluon/block.py ## @@ -542,61 +460,60 @@ def load_parameters(self, filename, ctx=None, allow_missing=False,

[GitHub] [incubator-mxnet] leezu commented on a change in pull request #18413: Simplifying mxnet.gluon.block APIs

2020-06-05 Thread GitBox
leezu commented on a change in pull request #18413: URL: https://github.com/apache/incubator-mxnet/pull/18413#discussion_r436162599 ## File path: python/mxnet/gluon/parameter.py ## @@ -664,6 +677,40 @@ def cast(self, dtype): self._grad = [i.astype(dtype) for i in s