[GitHub] [incubator-mxnet] leezu commented on issue #17047: Add build flag for x86 arch

2019-12-12 Thread GitBox
leezu commented on issue #17047: Add build flag for x86 arch URL: https://github.com/apache/incubator-mxnet/pull/17047#issuecomment-565274798 On ARM there's also `mcpu` This is an automated message from the Apache Git Service

[GitHub] [incubator-mxnet] leezu commented on issue #17047: Add build flag for x86 arch

2019-12-12 Thread GitBox
leezu commented on issue #17047: Add build flag for x86 arch URL: https://github.com/apache/incubator-mxnet/pull/17047#issuecomment-564907560 @TaoLv From the wording alone I'd agree with you. But it seems that the wording is not precise: Quoting https://lemire.me/blog/2018/07/25/it-

[GitHub] [incubator-mxnet] leezu commented on issue #17047: Add build flag for x86 arch

2019-12-11 Thread GitBox
leezu commented on issue #17047: Add build flag for x86 arch URL: https://github.com/apache/incubator-mxnet/pull/17047#issuecomment-564891476 @larroy besides `march` there is `mtune`. But on ARM it's `mcpu` instead of `mtune`. We also need to handle such discrepancy ---

[GitHub] [incubator-mxnet] leezu commented on issue #17047: Add build flag for x86 arch

2019-12-11 Thread GitBox
leezu commented on issue #17047: Add build flag for x86 arch URL: https://github.com/apache/incubator-mxnet/pull/17047#issuecomment-564856392 We need to set `-march` and `-mtune` reasonably when building releases for other users (such as nightly build). But there's no problem to do that on

[GitHub] [incubator-mxnet] leezu commented on issue #17047: Add build flag for x86 arch

2019-12-11 Thread GitBox
leezu commented on issue #17047: Add build flag for x86 arch URL: https://github.com/apache/incubator-mxnet/pull/17047#issuecomment-564830820 > Yes, there is no need to set -msse3 explicitly if -march has a more advanced arch. But I keep -msse3 here as a gate keeper since we won't want to