[GitHub] [incubator-mxnet] leezu edited a comment on pull request #18204: Disable -DUSE_TVM_OP on GPU builds

2020-06-12 Thread GitBox
leezu edited a comment on pull request #18204: URL: https://github.com/apache/incubator-mxnet/pull/18204#issuecomment-643546626 Thank you @jinboci for fixing the issue! Reverting this PR will indeed re-enable the previous test setup, but there may be some conflicts during the revert due to

[GitHub] [incubator-mxnet] leezu edited a comment on pull request #18204: Disable -DUSE_TVM_OP on GPU builds

2020-04-30 Thread GitBox
leezu edited a comment on pull request #18204: URL: https://github.com/apache/incubator-mxnet/pull/18204#issuecomment-622025431 > So how did CI pass if it was broken? thinking Those features were not tested by CI. For some other tests that do rely on the broken feature, they are disa

[GitHub] [incubator-mxnet] leezu edited a comment on pull request #18204: Disable -DUSE_TVM_OP on GPU builds

2020-04-30 Thread GitBox
leezu edited a comment on pull request #18204: URL: https://github.com/apache/incubator-mxnet/pull/18204#issuecomment-622025431 > So how did CI pass if it was broken? thinking Those features were not tested by CI. For some other tests that do rely on the broken feature, they are disa

[GitHub] [incubator-mxnet] leezu edited a comment on pull request #18204: Disable -DUSE_TVM_OP on GPU builds

2020-04-30 Thread GitBox
leezu edited a comment on pull request #18204: URL: https://github.com/apache/incubator-mxnet/pull/18204#issuecomment-622023034 I think this has been broken since it was introduced. It's unclear why it triggers non-deterministic failure in some cases, but deterministic failures in other.