[GitHub] [incubator-mxnet] lihaofd commented on a change in pull request #14476: Change RNN OP to stateful

2019-04-11 Thread GitBox
lihaofd commented on a change in pull request #14476: Change RNN OP to stateful URL: https://github.com/apache/incubator-mxnet/pull/14476#discussion_r274766414 ## File path: src/operator/rnn-inl.h ## @@ -438,385 +572,891 @@ class RNNOp : public Operator{ } DType*

[GitHub] [incubator-mxnet] lihaofd commented on a change in pull request #14476: Change RNN OP to stateful

2019-04-10 Thread GitBox
lihaofd commented on a change in pull request #14476: Change RNN OP to stateful URL: https://github.com/apache/incubator-mxnet/pull/14476#discussion_r274253672 ## File path: src/operator/rnn-inl.h ## @@ -438,385 +565,891 @@ class RNNOp : public Operator{ } DType*

[GitHub] [incubator-mxnet] lihaofd commented on a change in pull request #14476: Change RNN OP to stateful

2019-04-10 Thread GitBox
lihaofd commented on a change in pull request #14476: Change RNN OP to stateful URL: https://github.com/apache/incubator-mxnet/pull/14476#discussion_r274253655 ## File path: src/operator/rnn.cc ## @@ -97,13 +215,69 @@ The definition of GRU here is slightly different from p

[GitHub] [incubator-mxnet] lihaofd commented on a change in pull request #14476: Change RNN OP to stateful

2019-04-08 Thread GitBox
lihaofd commented on a change in pull request #14476: Change RNN OP to stateful URL: https://github.com/apache/incubator-mxnet/pull/14476#discussion_r272925800 ## File path: src/operator/rnn-inl.h ## @@ -438,385 +565,893 @@ class RNNOp : public Operator{ } DType*

[GitHub] [incubator-mxnet] lihaofd commented on a change in pull request #14476: Change RNN OP to stateful

2019-04-08 Thread GitBox
lihaofd commented on a change in pull request #14476: Change RNN OP to stateful URL: https://github.com/apache/incubator-mxnet/pull/14476#discussion_r272888983 ## File path: src/operator/rnn-inl.h ## @@ -438,385 +565,893 @@ class RNNOp : public Operator{ } DType*

[GitHub] [incubator-mxnet] lihaofd commented on a change in pull request #14476: Change RNN OP to stateful

2019-04-07 Thread GitBox
lihaofd commented on a change in pull request #14476: Change RNN OP to stateful URL: https://github.com/apache/incubator-mxnet/pull/14476#discussion_r272888983 ## File path: src/operator/rnn-inl.h ## @@ -438,385 +565,893 @@ class RNNOp : public Operator{ } DType*

[GitHub] [incubator-mxnet] lihaofd commented on a change in pull request #14476: Change RNN OP to stateful

2019-04-07 Thread GitBox
lihaofd commented on a change in pull request #14476: Change RNN OP to stateful URL: https://github.com/apache/incubator-mxnet/pull/14476#discussion_r272868060 ## File path: src/operator/rnn-inl.h ## @@ -436,387 +563,901 @@ class RNNOp : public Operator{ if (param_.sta

[GitHub] [incubator-mxnet] lihaofd commented on a change in pull request #14476: Change RNN OP to stateful

2019-04-07 Thread GitBox
lihaofd commented on a change in pull request #14476: Change RNN OP to stateful URL: https://github.com/apache/incubator-mxnet/pull/14476#discussion_r272868052 ## File path: src/operator/rnn-inl.h ## @@ -436,387 +563,901 @@ class RNNOp : public Operator{ if (param_.sta

[GitHub] [incubator-mxnet] lihaofd commented on a change in pull request #14476: Change RNN OP to stateful

2019-04-07 Thread GitBox
lihaofd commented on a change in pull request #14476: Change RNN OP to stateful URL: https://github.com/apache/incubator-mxnet/pull/14476#discussion_r272868041 ## File path: src/operator/rnn-inl.h ## @@ -436,387 +563,901 @@ class RNNOp : public Operator{ if (param_.sta

[GitHub] [incubator-mxnet] lihaofd commented on a change in pull request #14476: Change RNN OP to stateful

2019-04-07 Thread GitBox
lihaofd commented on a change in pull request #14476: Change RNN OP to stateful URL: https://github.com/apache/incubator-mxnet/pull/14476#discussion_r272866427 ## File path: src/operator/rnn-inl.h ## @@ -436,387 +563,901 @@ class RNNOp : public Operator{ if (param_.sta

[GitHub] [incubator-mxnet] lihaofd commented on a change in pull request #14476: Change RNN OP to stateful

2019-03-26 Thread GitBox
lihaofd commented on a change in pull request #14476: Change RNN OP to stateful URL: https://github.com/apache/incubator-mxnet/pull/14476#discussion_r269112331 ## File path: src/operator/rnn-inl.h ## @@ -436,387 +566,897 @@ class RNNOp : public Operator{ if (param_.sta

[GitHub] [incubator-mxnet] lihaofd commented on a change in pull request #14476: Change RNN OP to stateful

2019-03-26 Thread GitBox
lihaofd commented on a change in pull request #14476: Change RNN OP to stateful URL: https://github.com/apache/incubator-mxnet/pull/14476#discussion_r269112331 ## File path: src/operator/rnn-inl.h ## @@ -436,387 +566,897 @@ class RNNOp : public Operator{ if (param_.sta